| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c79e20ae-7b90-5818-e0b2-6e4b860fc2d4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8172:1A5E8A:2194425:2AC09CD:6991AA5C |
| html-safe-nonce | 721c52ab94c84ff38d80136b32a3a08e7c730d3cb5391333983ad4cfc87e624f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTcyOjFBNUU4QToyMTk0NDI1OjJBQzA5Q0Q6Njk5MUFBNUMiLCJ2aXNpdG9yX2lkIjoiMzU2MzUzNTA3MDM5NzUwNzQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7d61507779c5fc7c072ed1e291203fb16823d5a5cdb4bfb30496fab2f881c074 |
| hovercard-subject-tag | pull_request:150926441 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16843/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bf480eb6bdd9adc462056b4daec38d544ed519b56147bfc6905bf8d3319a7f3a/nodejs/node/pull/16843 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bf480eb6bdd9adc462056b4daec38d544ed519b56147bfc6905bf8d3319a7f3a/nodejs/node/pull/16843 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
test |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | markmcnelis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16843#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16843 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16843 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16843 |
| Reload | https://github.com/nodejs/node/pull/16843 |
| Reload | https://github.com/nodejs/node/pull/16843 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
712
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| markmcnelis | https://github.com/markmcnelis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| markmcnelis:node-contribution | https://github.com/markmcnelis/node/tree/node-contribution |
| Conversation | https://github.com/nodejs/node/pull/16843 |
| Commits4 (4) | https://github.com/nodejs/node/pull/16843/commits |
| Checks | https://github.com/nodejs/node/pull/16843/checks |
| Files changed | https://github.com/nodejs/node/pull/16843/files |
| test: change assert message arg from literal to template literal | https://github.com/nodejs/node/pull/16843#top |
| markmcnelis | https://github.com/markmcnelis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| markmcnelis:node-contribution | https://github.com/markmcnelis/node/tree/node-contribution |
|
| https://github.com/markmcnelis |
| markmcnelis | https://github.com/markmcnelis |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#issue-271576089 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
| markmcnelis | https://github.com/markmcnelis |
| November 6, 2017 18:22 | https://github.com/nodejs/node/pull/16843#commits-pushed-1c6fd40 |
|
| https://github.com/markmcnelis |
| test: change assert message arg from literal to template literal | https://github.com/nodejs/node/pull/16843/commits/1c6fd40686dc9d3601c7ea9e67b621c7510519ef |
| 1c6fd40 | https://github.com/nodejs/node/pull/16843/commits/1c6fd40686dc9d3601c7ea9e67b621c7510519ef |
|
| https://github.com/markmcnelis |
| test: change assert message arg from literal to template literal | https://github.com/nodejs/node/pull/16843/commits/fafd4a185fa87d44fcc455c73c354d6b510e3201 |
| fafd4a1 | https://github.com/nodejs/node/pull/16843/commits/fafd4a185fa87d44fcc455c73c354d6b510e3201 |
|
| https://github.com/markmcnelis |
| Merge remote-tracking branch 'origin/node-contribution' into node-con… | https://github.com/nodejs/node/pull/16843/commits/26294a6095beeb8d5905cac0212485044566c5e2 |
| 26294a6 | https://github.com/nodejs/node/pull/16843/commits/26294a6095beeb8d5905cac0212485044566c5e2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#event-1328187905 |
| https://github.com/markmcnelis |
| markmcnelis | https://github.com/markmcnelis |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#event-1328188238 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
|
vm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#event-1328239356 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 6, 2017
| https://github.com/nodejs/node/pull/16843#pullrequestreview-74595405 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16843/files/26294a6095beeb8d5905cac0212485044566c5e2 |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/16843#pullrequestreview-74595405 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @markmcnelis | https://github.com/markmcnelis |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
| test/parallel/test-global.js | https://github.com/nodejs/node/pull/16843/files/26294a6095beeb8d5905cac0212485044566c5e2#diff-eae0715dc598f0763bb0fd1bcda7d3693f3483ea65dcb90f0e3290439c70e6e2 |
| Trott | https://github.com/Trott |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#discussion_r149232592 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
| test/parallel/test-global.js | https://github.com/nodejs/node/pull/16843/files/26294a6095beeb8d5905cac0212485044566c5e2#diff-eae0715dc598f0763bb0fd1bcda7d3693f3483ea65dcb90f0e3290439c70e6e2 |
| Trott | https://github.com/Trott |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#discussion_r149233040 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#event-1328671788 |
|
| https://github.com/markmcnelis |
| test: refactoring message based on feedback | https://github.com/nodejs/node/pull/16843/commits/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
| 45f4e6f | https://github.com/nodejs/node/pull/16843/commits/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
| https://github.com/markmcnelis |
| markmcnelis | https://github.com/markmcnelis |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16843#issuecomment-342328056 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 7, 2017
| https://github.com/nodejs/node/pull/16843#pullrequestreview-74637289 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16843/files/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 7, 2017
| https://github.com/nodejs/node/pull/16843#pullrequestreview-74661531 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16843/files/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 7, 2017 | https://github.com/nodejs/node/pull/16843#issuecomment-342447382 |
| @Trott | https://github.com/Trott |
| https://ci.nodejs.org/job/node-test-pull-request/11265/ | https://ci.nodejs.org/job/node-test-pull-request/11265/ |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| stale review | https://github.com/nodejs/node/pull/16843#pullrequestreview-74595405 |
| November 7, 2017 13:36 | https://github.com/nodejs/node/pull/16843#event-1329688625 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 7, 2017
| https://github.com/nodejs/node/pull/16843#pullrequestreview-74774411 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16843/files/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
| Trott | https://github.com/Trott |
|
Nov 7, 2017
| https://github.com/nodejs/node/pull/16843#ref-commit-9468108 |
|
| https://github.com/markmcnelis |
|
| https://github.com/Trott |
| test: improve assert messages in test-global | https://github.com/Trott/io.js/commit/9468108ebd4b014cd6e82acaa0b0ae56f74d53de |
| 9468108 | https://github.com/Trott/io.js/commit/9468108ebd4b014cd6e82acaa0b0ae56f74d53de |
| nodejs#16843 | https://github.com/nodejs/node/pull/16843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 7, 2017 | https://github.com/nodejs/node/pull/16843#issuecomment-342524356 |
| 9468108 | https://github.com/nodejs/node/commit/9468108ebd4b014cd6e82acaa0b0ae56f74d53de |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 7, 2017 | https://github.com/nodejs/node/pull/16843#event-1329970546 |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16843#ref-commit-adcaddf |
|
| https://github.com/markmcnelis |
|
| https://github.com/evanlucas |
| test: improve assert messages in test-global | https://github.com/nodejs/node/commit/adcaddfce88aa37e7b9a351677189455f1461dce |
| adcaddf | https://github.com/nodejs/node/commit/adcaddfce88aa37e7b9a351677189455f1461dce |
| #16843 | https://github.com/nodejs/node/pull/16843 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16843#ref-pullrequest-273462029 |
|
v9.2.0 proposal
#16992
| https://github.com/nodejs/node/pull/16992 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2017
| https://github.com/nodejs/node/pull/16843#ref-commit-71c11d6 |
|
| https://github.com/markmcnelis |
|
| https://github.com/MylesBorins |
| test: improve assert messages in test-global | https://github.com/nodejs/node/commit/71c11d67f44d225e274efd7e09109353ae31a971 |
| 71c11d6 | https://github.com/nodejs/node/commit/71c11d67f44d225e274efd7e09109353ae31a971 |
| #16843 | https://github.com/nodejs/node/pull/16843 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16843#event-1347321905 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16843#ref-pullrequest-275888281 |
|
v8.9.2 proposal
#17204
| https://github.com/nodejs/node/pull/17204 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16843 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/16843/files/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/16843/files/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/16843/files/45f4e6f72ebe3310bbbbb3c9127679ce3e9d1d89 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
|
vm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm |
| Please reload this page | https://github.com/nodejs/node/pull/16843 |
|
| https://github.com/markmcnelis |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |