René's URL Explorer Experiment


Title: added template for better error explanation to assert.ok error message by chrbergert · Pull Request #16829 · nodejs/node · GitHub

Open Graph Title: added template for better error explanation to assert.ok error message by chrbergert · Pull Request #16829 · nodejs/node

X Title: added template for better error explanation to assert.ok error message by chrbergert · Pull Request #16829 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...

Opengraph URL: https://github.com/nodejs/node/pull/16829

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9ae7929d-1a47-d63b-1ea7-ec148b7b7696
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9866:18E7C7:1DF0F6:26BCD1:6991D341
html-safe-nonce1d8b432b9ec250e7f59ad9cd5c6a4c1b7a7b348a89a2886e3b7d42f58b1744c6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODY2OjE4RTdDNzoxREYwRjY6MjZCQ0QxOjY5OTFEMzQxIiwidmlzaXRvcl9pZCI6IjQ1ODI4NzQ0NjkwNDM5MTc2MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccc3220573f336bd83587044408727b9daf72f6fe1ebb75c9092286783804eb35
hovercard-subject-tagpull_request:150893515
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16829/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b42d62ca881b19f605e31eaa0c4498ff90ddfa87d44da30b8433ea49467b337d/nodejs/node/pull/16829
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b42d62ca881b19f605e31eaa0c4498ff90ddfa87d44da30b8433ea49467b337d/nodejs/node/pull/16829
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechrbergert
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16829#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16829
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16829
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16829
Reloadhttps://github.com/nodejs/node/pull/16829
Reloadhttps://github.com/nodejs/node/pull/16829
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16829
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
chrbergerthttps://github.com/chrbergert
nodejs:masterhttps://github.com/nodejs/node/tree/master
chrbergert:masterhttps://github.com/chrbergert/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/16829
Commits5 (5)https://github.com/nodejs/node/pull/16829/commits
Checkshttps://github.com/nodejs/node/pull/16829/checks
Files changedhttps://github.com/nodejs/node/pull/16829/files
added template for better error explanation to assert.ok error messagehttps://github.com/nodejs/node/pull/16829#top
chrbergerthttps://github.com/chrbergert
nodejs:masterhttps://github.com/nodejs/node/tree/master
chrbergert:masterhttps://github.com/chrbergert/node/tree/master
https://github.com/chrbergert
chrbergerthttps://github.com/chrbergert
Nov 6, 2017https://github.com/nodejs/node/pull/16829#issue-271531126
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/chrbergert
added template for better error explanation to assert.ok error messagehttps://github.com/nodejs/node/pull/16829/commits/534c3ec52b224932f7ae152164e8cbaee6fa05c0
534c3echttps://github.com/nodejs/node/pull/16829/commits/534c3ec52b224932f7ae152164e8cbaee6fa05c0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 6, 2017https://github.com/nodejs/node/pull/16829#event-1327910259
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 6, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-74474625
View reviewed changes https://github.com/nodejs/node/pull/16829/files/534c3ec52b224932f7ae152164e8cbaee6fa05c0
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Nov 6, 2017https://github.com/nodejs/node/pull/16829#event-1327940476
https://github.com/mscdex
mscdexhttps://github.com/mscdex
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Nov 6, 2017https://github.com/nodejs/node/pull/16829#event-1328122774
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-74671910
View reviewed changes https://github.com/nodejs/node/pull/16829/files/534c3ec52b224932f7ae152164e8cbaee6fa05c0
test/parallel/test-child-process-spawnsync-maxbuf.jshttps://github.com/nodejs/node/pull/16829/files/534c3ec52b224932f7ae152164e8cbaee6fa05c0#diff-84cc2b08b07fdbcb9b7188ec4162d720db9b7be805f8a694ebe9ee718a42520e
joyeecheunghttps://github.com/joyeecheung
Nov 7, 2017https://github.com/nodejs/node/pull/16829#discussion_r149301593
Please reload this pagehttps://github.com/nodejs/node/pull/16829
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16829
chrbergerthttps://github.com/chrbergert
Nov 7, 2017https://github.com/nodejs/node/pull/16829#discussion_r149315611
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/chrbergert
changed error message to a more speaking information about what happe…https://github.com/nodejs/node/pull/16829/commits/41586a20c886aeffa89c5811cc09ad42eafa6043
41586a2https://github.com/nodejs/node/pull/16829/commits/41586a20c886aeffa89c5811cc09ad42eafa6043
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 7, 2017https://github.com/nodejs/node/pull/16829#issuecomment-342445059
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/job/node-test-pull-request/11263/https://ci.nodejs.org/job/node-test-pull-request/11263/
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/chrbergert
fixing linting issuehttps://github.com/nodejs/node/pull/16829/commits/ed558f324c6fb2c7f926e3d987907393d1ac6efc
ed558f3https://github.com/nodejs/node/pull/16829/commits/ed558f324c6fb2c7f926e3d987907393d1ac6efc
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 7, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-74712957
View reviewed changes https://github.com/nodejs/node/pull/16829/files/ed558f324c6fb2c7f926e3d987907393d1ac6efc
test/parallel/test-child-process-spawnsync-maxbuf.jshttps://github.com/nodejs/node/pull/16829/files/ed558f324c6fb2c7f926e3d987907393d1ac6efc#diff-84cc2b08b07fdbcb9b7188ec4162d720db9b7be805f8a694ebe9ee718a42520e
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 7, 2017https://github.com/nodejs/node/pull/16829#discussion_r149337473
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16829
chrbergerthttps://github.com/chrbergert
Nov 7, 2017https://github.com/nodejs/node/pull/16829#discussion_r149339902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/chrbergert
changed line break to a more standard wayhttps://github.com/nodejs/node/pull/16829/commits/7d056442d544261743604f96391899c19d45b979
7d05644https://github.com/nodejs/node/pull/16829/commits/7d056442d544261743604f96391899c19d45b979
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 7, 2017https://github.com/nodejs/node/pull/16829#issuecomment-342461635
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 7, 2017https://github.com/nodejs/node/pull/16829#issuecomment-342466264
@chrbergerthttps://github.com/chrbergert
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 7, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-74728432
View reviewed changes https://github.com/nodejs/node/pull/16829/files/7d056442d544261743604f96391899c19d45b979
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/16829#pullrequestreview-74728432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/chrbergert
- removed initial change for error messagehttps://github.com/nodejs/node/pull/16829/commits/9d58db532018c4f6bbd041b6a2d9265871e71b96
9d58db5https://github.com/nodejs/node/pull/16829/commits/9d58db532018c4f6bbd041b6a2d9265871e71b96
https://github.com/chrbergert
chrbergerthttps://github.com/chrbergert
Nov 7, 2017https://github.com/nodejs/node/pull/16829#issuecomment-342611959
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 8, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-75053563
View reviewed changes https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 8, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-75121892
View reviewed changes https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-75964244
View reviewed changes https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/16829#pullrequestreview-75964244
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2017https://github.com/nodejs/node/pull/16829#issuecomment-343749707
https://ci.nodejs.org/job/node-test-pull-request/11378/https://ci.nodejs.org/job/node-test-pull-request/11378/
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 13, 2017https://github.com/nodejs/node/pull/16829#issuecomment-344027776
https://ci.nodejs.org/job/node-test-commit-arm-fanned/12541/https://ci.nodejs.org/job/node-test-commit-arm-fanned/12541/
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 13, 2017 https://github.com/nodejs/node/pull/16829#pullrequestreview-76220642
View reviewed changes https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 13, 2017https://github.com/nodejs/node/pull/16829#issuecomment-344088774
21a7459https://github.com/nodejs/node/commit/21a7459d490d832d5d547833d527083e460999e1
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 13, 2017https://github.com/nodejs/node/pull/16829#event-1339787252
Trotthttps://github.com/Trott
Nov 13, 2017 https://github.com/nodejs/node/pull/16829#ref-commit-21a7459
https://github.com/chrbergert
https://github.com/Trott
test: refactor comments in test-child-process-spawnsync-maxbufhttps://github.com/Trott/io.js/commit/21a7459d490d832d5d547833d527083e460999e1
21a7459https://github.com/Trott/io.js/commit/21a7459d490d832d5d547833d527083e460999e1
nodejs#16829https://github.com/nodejs/node/pull/16829
evanlucashttps://github.com/evanlucas
Nov 14, 2017 https://github.com/nodejs/node/pull/16829#ref-commit-8658f26
https://github.com/chrbergert
https://github.com/evanlucas
test: refactor comments in test-child-process-spawnsync-maxbufhttps://github.com/nodejs/node/commit/8658f267b2d626639409a4433042004fdd730b59
8658f26https://github.com/nodejs/node/commit/8658f267b2d626639409a4433042004fdd730b59
#16829https://github.com/nodejs/node/pull/16829
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017 https://github.com/nodejs/node/pull/16829#ref-commit-6ab706d
https://github.com/chrbergert
https://github.com/MylesBorins
test: refactor comments in test-child-process-spawnsync-maxbufhttps://github.com/nodejs/node/commit/6ab706d7f0df2b45cb8daee996099c828d43322c
6ab706dhttps://github.com/nodejs/node/commit/6ab706d7f0df2b45cb8daee996099c828d43322c
#16829https://github.com/nodejs/node/pull/16829
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017 https://github.com/nodejs/node/pull/16829#ref-commit-2c7ad2f
https://github.com/chrbergert
https://github.com/MylesBorins
test: refactor comments in test-child-process-spawnsync-maxbufhttps://github.com/nodejs/node/commit/2c7ad2fa0239b8421f54a897568a1fcb49960a3c
2c7ad2fhttps://github.com/nodejs/node/commit/2c7ad2fa0239b8421f54a897568a1fcb49960a3c
#16829https://github.com/nodejs/node/pull/16829
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16829#event-1347470810
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Nov 21, 2017 https://github.com/nodejs/node/pull/16829#ref-pullrequest-275888281
v8.9.2 proposal #17204 https://github.com/nodejs/node/pull/17204
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/16829#ref-pullrequest-275653593
v6.12.1 proposal #17180 https://github.com/nodejs/node/pull/17180
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/16829#ref-commit-3ef7880
https://github.com/chrbergert
https://github.com/MylesBorins
test: refactor comments in test-child-process-spawnsync-maxbufhttps://github.com/nodejs/node/commit/3ef7880582542ab42b78310af53efc38c588cdda
3ef7880https://github.com/nodejs/node/commit/3ef7880582542ab42b78310af53efc38c588cdda
#16829https://github.com/nodejs/node/pull/16829
MylesBorinshttps://github.com/MylesBorins
Nov 28, 2017 https://github.com/nodejs/node/pull/16829#ref-commit-4752fc4
https://github.com/chrbergert
https://github.com/MylesBorins
test: refactor comments in test-child-process-spawnsync-maxbufhttps://github.com/nodejs/node/commit/4752fc4336fcc1bc202d2ae65828aa3d467eafb9
4752fc4https://github.com/nodejs/node/commit/4752fc4336fcc1bc202d2ae65828aa3d467eafb9
#16829https://github.com/nodejs/node/pull/16829
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16829
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/16829/files/ed558f324c6fb2c7f926e3d987907393d1ac6efc
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/16829/files/9d58db532018c4f6bbd041b6a2d9265871e71b96
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/16829
https://github.com/chrbergert
https://github.com/gireeshpunathil
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com/joyeecheung
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.