| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:75a83524-37af-783e-a77b-e99eb8f76a5e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E49C:24B6F8:187E82F:1F34DAD:69918AE4 |
| html-safe-nonce | db70f91017b1f11546cc0cf3872370aab93da170fb629d11b8c9fdfa73e1802c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDlDOjI0QjZGODoxODdFODJGOjFGMzREQUQ6Njk5MThBRTQiLCJ2aXNpdG9yX2lkIjoiMzg3MjE1Mzc0NzczNzExOTQ2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ccb1cc6da481f94fa66652aceef0d272ebe5f0314974fa7362a7bda43d8bfdac |
| hovercard-subject-tag | pull_request:150879550 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16813/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bdcbbc3943c44ab6082e647238067968f3adf04ba89a4e01484908e52e0701a9/nodejs/node/pull/16813 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bdcbbc3943c44ab6082e647238067968f3adf04ba89a4e01484908e52e0701a9/nodejs/node/pull/16813 |
| og:image:alt | I required common/fixtures module and swapped the location of fixturesDir
from common to fixtures module.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follow... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kkogovsek |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16813#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16813 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16813 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16813 |
| Reload | https://github.com/nodejs/node/pull/16813 |
| Reload | https://github.com/nodejs/node/pull/16813 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| kkogovsek | https://github.com/kkogovsek |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| kkogovsek:master | https://github.com/kkogovsek/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/16813 |
| Commits1 (1) | https://github.com/nodejs/node/pull/16813/commits |
| Checks | https://github.com/nodejs/node/pull/16813/checks |
| Files changed | https://github.com/nodejs/node/pull/16813/files |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/pull/16813#top |
| kkogovsek | https://github.com/kkogovsek |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| kkogovsek:master | https://github.com/kkogovsek/node/tree/master |
|
| https://github.com/kkogovsek |
| kkogovsek | https://github.com/kkogovsek |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16813#issue-271512285 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16813#event-1327795848 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16813#event-1327852068 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-342196397 |
| @kkogovsek | https://github.com/kkogovsek |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16813#event-1327895495 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 6, 2017
| https://github.com/nodejs/node/pull/16813#pullrequestreview-74467437 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16813/files |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 6, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-342224816 |
| @kkogovsek | https://github.com/kkogovsek |
| https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| https://github.com/kkogovsek |
| kkogovsek | https://github.com/kkogovsek |
| force-pushed | https://github.com/nodejs/node/compare/774834b8e9bdc83775f847081382585f4776226a..a340fd4f12d82ff75bcb27b56200c78183662f44 |
| 774834b | https://github.com/nodejs/node/commit/774834b8e9bdc83775f847081382585f4776226a |
| a340fd4 | https://github.com/nodejs/node/commit/a340fd4f12d82ff75bcb27b56200c78183662f44 |
|
Compare
| https://github.com/nodejs/node/compare/774834b8e9bdc83775f847081382585f4776226a..a340fd4f12d82ff75bcb27b56200c78183662f44 |
| November 7, 2017 09:02 | https://github.com/nodejs/node/pull/16813#event-1329242085 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 7, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-342440673 |
| https://ci.nodejs.org/job/node-test-pull-request/11261/ | https://ci.nodejs.org/job/node-test-pull-request/11261/ |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 7, 2017
| https://github.com/nodejs/node/pull/16813#pullrequestreview-74719507 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16813/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 7, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-342458130 |
| https://ci.nodejs.org/job/node-test-linter/13348/ | https://ci.nodejs.org/job/node-test-linter/13348/ |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
|
| https://github.com/Trott |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/pull/16813/commits/1eb03a8562a03f03a6fdcae8a9b9abae4e095c90 |
| 1eb03a8 | https://github.com/nodejs/node/pull/16813/commits/1eb03a8562a03f03a6fdcae8a9b9abae4e095c90 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/a340fd4f12d82ff75bcb27b56200c78183662f44..1eb03a8562a03f03a6fdcae8a9b9abae4e095c90 |
| a340fd4 | https://github.com/nodejs/node/commit/a340fd4f12d82ff75bcb27b56200c78183662f44 |
| 1eb03a8 | https://github.com/nodejs/node/commit/1eb03a8562a03f03a6fdcae8a9b9abae4e095c90 |
|
Compare
| https://github.com/nodejs/node/compare/a340fd4f12d82ff75bcb27b56200c78183662f44..1eb03a8562a03f03a6fdcae8a9b9abae4e095c90 |
| November 8, 2017 10:19 | https://github.com/nodejs/node/pull/16813#event-1331532107 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 8, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-342773730 |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 8, 2017
| https://github.com/nodejs/node/pull/16813#pullrequestreview-75049192 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16813/files/1eb03a8562a03f03a6fdcae8a9b9abae4e095c90 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 8, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-342782836 |
| https://ci.nodejs.org/job/node-test-pull-request/11298/ | https://ci.nodejs.org/job/node-test-pull-request/11298/ |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 13, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-343820504 |
| https://ci.nodejs.org/job/node-test-pull-request/11388/ | https://ci.nodejs.org/job/node-test-pull-request/11388/ |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16813#ref-commit-1601a3c |
|
| https://github.com/gireeshpunathil |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/commit/1601a3c2a9d82c0c235bc37c5ecbb365a4ceb47c |
| 1601a3c | https://github.com/nodejs/node/commit/1601a3c2a9d82c0c235bc37c5ecbb365a4ceb47c |
| #16813 | https://github.com/nodejs/node/pull/16813 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 13, 2017 | https://github.com/nodejs/node/pull/16813#issuecomment-343906179 |
| 1601a3c | https://github.com/nodejs/node/commit/1601a3c2a9d82c0c235bc37c5ecbb365a4ceb47c |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 13, 2017 | https://github.com/nodejs/node/pull/16813#event-1338602554 |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16813#ref-commit-ad02676 |
|
| https://github.com/evanlucas |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/commit/ad02676816d4067dda4a41ebc113a8bade345e79 |
| ad02676 | https://github.com/nodejs/node/commit/ad02676816d4067dda4a41ebc113a8bade345e79 |
| #16813 | https://github.com/nodejs/node/pull/16813 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16813#ref-pullrequest-273462029 |
|
v9.2.0 proposal
#16992
| https://github.com/nodejs/node/pull/16992 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2017
| https://github.com/nodejs/node/pull/16813#ref-commit-b60ac4f |
|
| https://github.com/MylesBorins |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/commit/b60ac4fe992634bf7fd4933c96b76a5dcd729a2b |
| b60ac4f | https://github.com/nodejs/node/commit/b60ac4fe992634bf7fd4933c96b76a5dcd729a2b |
| #16813 | https://github.com/nodejs/node/pull/16813 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 17, 2017
| https://github.com/nodejs/node/pull/16813#ref-commit-315fba8 |
|
| https://github.com/MylesBorins |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/commit/315fba8bfdcd69fbb173fc1e079111bea533c7f0 |
| 315fba8 | https://github.com/nodejs/node/commit/315fba8bfdcd69fbb173fc1e079111bea533c7f0 |
| #16813 | https://github.com/nodejs/node/pull/16813 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16813#event-1347465443 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16813#ref-pullrequest-275888281 |
|
v8.9.2 proposal
#17204
| https://github.com/nodejs/node/pull/17204 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16813#ref-pullrequest-275653593 |
|
v6.12.1 proposal
#17180
| https://github.com/nodejs/node/pull/17180 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16813#ref-commit-02838a5 |
|
| https://github.com/MylesBorins |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/commit/02838a596fa0e73e1b40f2f5846415778c380b54 |
| 02838a5 | https://github.com/nodejs/node/commit/02838a596fa0e73e1b40f2f5846415778c380b54 |
| #16813 | https://github.com/nodejs/node/pull/16813 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 28, 2017
| https://github.com/nodejs/node/pull/16813#ref-commit-f226ca6 |
|
| https://github.com/MylesBorins |
| test: used fixturesDir from fixtures modules | https://github.com/nodejs/node/commit/f226ca6b1222a0e70da65ebb89b79b09f69a6eb2 |
| f226ca6 | https://github.com/nodejs/node/commit/f226ca6b1222a0e70da65ebb89b79b09f69a6eb2 |
| #16813 | https://github.com/nodejs/node/pull/16813 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16813 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/16813/files/1eb03a8562a03f03a6fdcae8a9b9abae4e095c90 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/16813/files/a340fd4f12d82ff75bcb27b56200c78183662f44 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/16813/files/cdcce29b4ff2b6957642f3c254935de2c967285f |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/16813 |
|
| https://github.com/kkogovsek |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |