René's URL Explorer Experiment


Title: lib: fix version check in tick processor by bnoordhuis · Pull Request #16769 · nodejs/node · GitHub

Open Graph Title: lib: fix version check in tick processor by bnoordhuis · Pull Request #16769 · nodejs/node

X Title: lib: fix version check in tick processor by bnoordhuis · Pull Request #16769 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #16736 CI: https://ci.nodejs.org/job/node-test-pull-request/11198/

X Description: Fixes: #16736 CI: https://ci.nodejs.org/job/node-test-pull-request/11198/

Opengraph URL: https://github.com/nodejs/node/pull/16769

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e9f8b168-eb24-0c9a-8d63-aa1358f4e8f4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9746:325E01:78F75:A29D2:6AED3284
html-safe-nonce507e11f4721747ebf87ad94a68cfd3cef307eebc472f847f4053cdc4be22b7ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzQ2OjMyNUUwMTo3OEY3NTpBMjlEMjo2QUVEMzI4NCIsInZpc2l0b3JfaWQiOiI4MjUyNDcyNTQwODMxNDk0Nzg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc818edefaaf95c89dad8966940e03cb4bf97911f1d82853cac99fc54c9c8e507
hovercard-subject-tagpull_request:150718325
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16769/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/08434f668cdb74119fc26e0c5a78ea3ce2fc6194e06d9142b2ea7b4cb2951506/nodejs/node/pull/16769
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/08434f668cdb74119fc26e0c5a78ea3ce2fc6194e06d9142b2ea7b4cb2951506/nodejs/node/pull/16769
og:image:altFixes: #16736 CI: https://ci.nodejs.org/job/node-test-pull-request/11198/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16769#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16769
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16769
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16769
Reloadhttps://github.com/nodejs/node/pull/16769
Reloadhttps://github.com/nodejs/node/pull/16769
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix16736https://github.com/bnoordhuis/io.js/tree/fix16736
Conversationhttps://github.com/nodejs/node/pull/16769
Commits3 (3)https://github.com/nodejs/node/pull/16769/commits
Checkshttps://github.com/nodejs/node/pull/16769/checks
Files changedhttps://github.com/nodejs/node/pull/16769/files
lib: fix version check in tick processorhttps://github.com/nodejs/node/pull/16769#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix16736https://github.com/bnoordhuis/io.js/tree/fix16736
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 5, 2017https://github.com/nodejs/node/pull/16769#issue-271269684
Please reload this pagehttps://github.com/nodejs/node/pull/16769
#16736https://github.com/nodejs/node/issues/16736
https://ci.nodejs.org/job/node-test-pull-request/11198/https://ci.nodejs.org/job/node-test-pull-request/11198/
Please reload this pagehttps://github.com/nodejs/node/pull/16769
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Nov 5, 2017https://github.com/nodejs/node/pull/16769#event-1326440019
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 5, 2017 https://github.com/nodejs/node/pull/16769#ref-issue-271161458
Warning/Notice when processing V8 profiler output from same binary #16736 https://github.com/nodejs/node/issues/16736
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 5, 2017 https://github.com/nodejs/node/pull/16769#pullrequestreview-74283071
View reviewed changes https://github.com/nodejs/node/pull/16769/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 6, 2017 https://github.com/nodejs/node/pull/16769#pullrequestreview-74397491
View reviewed changes https://github.com/nodejs/node/pull/16769/files
bnoordhuishttps://github.com/bnoordhuis
November 7, 2017 12:15https://github.com/nodejs/node/pull/16769#commits-pushed-421316d
https://github.com/bnoordhuis
lib: fix version check in tick processorhttps://github.com/nodejs/node/pull/16769/commits/421316dca17d72919a928f414af8d03e2f3a2476
421316dhttps://github.com/nodejs/node/pull/16769/commits/421316dca17d72919a928f414af8d03e2f3a2476
70832bchttps://github.com/bnoordhuis/io.js/commit/70832bc3538d8b4e1c67ce8c49617c6e06fe3187
nodejs#16736https://github.com/nodejs/node/issues/16736
nodejs#16769https://github.com/nodejs/node/pull/16769
https://github.com/bnoordhuis
lib: shuffle v8_prof_polyfill.js for unit testinghttps://github.com/nodejs/node/pull/16769/commits/09d22ddab5eded7790b68059d91186117c43f3b7
09d22ddhttps://github.com/nodejs/node/pull/16769/commits/09d22ddab5eded7790b68059d91186117c43f3b7
nodejs#16769https://github.com/nodejs/node/pull/16769
https://github.com/bnoordhuis
test: tick processor version check regression testhttps://github.com/nodejs/node/pull/16769/commits/698bb96383e46017d68b44c680f328f7bdf18c45
698bb96https://github.com/nodejs/node/pull/16769/commits/698bb96383e46017d68b44c680f328f7bdf18c45
nodejs#16736https://github.com/nodejs/node/issues/16736
nodejs#16769https://github.com/nodejs/node/pull/16769
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/babc014ce4a5a408c11fed70428d8e14511b8436..698bb96383e46017d68b44c680f328f7bdf18c45
babc014https://github.com/nodejs/node/commit/babc014ce4a5a408c11fed70428d8e14511b8436
698bb96https://github.com/nodejs/node/commit/698bb96383e46017d68b44c680f328f7bdf18c45
Compare https://github.com/nodejs/node/compare/babc014ce4a5a408c11fed70428d8e14511b8436..698bb96383e46017d68b44c680f328f7bdf18c45
November 7, 2017 11:17https://github.com/nodejs/node/pull/16769#event-1329474678
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 7, 2017https://github.com/nodejs/node/pull/16769#event-1329474897
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
November 7, 2017 11:17https://github.com/nodejs/node/pull/16769#event-1329474899
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
698bb96https://github.com/nodejs/node/commit/698bb96383e46017d68b44c680f328f7bdf18c45
Nov 7, 2017https://github.com/nodejs/node/pull/16769#event-1329475669
cjihrighttps://github.com/cjihrig
Nov 7, 2017 https://github.com/nodejs/node/pull/16769#ref-commit-c14030e
https://github.com/bnoordhuis
https://github.com/cjihrig
lib: fix version check in tick processorhttps://github.com/cjihrig/node/commit/c14030ec7a4e5f0cfe693c694fe50c5a1303f577
c14030ehttps://github.com/cjihrig/node/commit/c14030ec7a4e5f0cfe693c694fe50c5a1303f577
70832bchttps://github.com/cjihrig/node/commit/70832bc3538d8b4e1c67ce8c49617c6e06fe3187
nodejs#16736https://github.com/nodejs/node/issues/16736
nodejs#16769https://github.com/nodejs/node/pull/16769
cjihrighttps://github.com/cjihrig
Nov 7, 2017 https://github.com/nodejs/node/pull/16769#ref-commit-e0c7b3d
https://github.com/bnoordhuis
https://github.com/cjihrig
lib: shuffle v8_prof_polyfill.js for unit testinghttps://github.com/cjihrig/node/commit/e0c7b3d13ffa660e9aa21aa82fc1ca5e61533e80
e0c7b3dhttps://github.com/cjihrig/node/commit/e0c7b3d13ffa660e9aa21aa82fc1ca5e61533e80
nodejs#16769https://github.com/nodejs/node/pull/16769
cjihrighttps://github.com/cjihrig
Nov 7, 2017 https://github.com/nodejs/node/pull/16769#ref-commit-2294ba4
https://github.com/bnoordhuis
https://github.com/cjihrig
test: tick processor version check regression testhttps://github.com/cjihrig/node/commit/2294ba49be01590b4ee3cc0d101c541d21d958dc
2294ba4https://github.com/cjihrig/node/commit/2294ba49be01590b4ee3cc0d101c541d21d958dc
nodejs#16736https://github.com/nodejs/node/issues/16736
nodejs#16769https://github.com/nodejs/node/pull/16769
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 7, 2017 https://github.com/nodejs/node/pull/16769#ref-pullrequest-271654245
v9.1.0 proposal #16851 https://github.com/nodejs/node/pull/16851
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 16, 2017https://github.com/nodejs/node/pull/16769#issuecomment-345094894
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/16769
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Nov 16, 2017https://github.com/nodejs/node/pull/16769#event-1346197966
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 17, 2017https://github.com/nodejs/node/pull/16769#issuecomment-345103451
#15785https://github.com/nodejs/node/pull/15785
Please reload this pagehttps://github.com/nodejs/node/pull/16769
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16769#event-1346250547
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16769
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16769/files/babc014ce4a5a408c11fed70428d8e14511b8436
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16769/files/babc014ce4a5a408c11fed70428d8e14511b8436
Please reload this pagehttps://github.com/nodejs/node/pull/16769
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/16769
https://github.com/bnoordhuis
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.