René's URL Explorer Experiment


Title: doc: update subprocess.killed by cjihrig · Pull Request #16748 · nodejs/node · GitHub

Open Graph Title: doc: update subprocess.killed by cjihrig · Pull Request #16748 · nodejs/node

X Title: doc: update subprocess.killed by cjihrig · Pull Request #16748 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit changes the wording of subprocess.killed to reflect that a child process was successfully signaled, and not necessarily terminated. Fixes: #16747 Checklist make -j4 test (UNIX), or v...

X Description: This commit changes the wording of subprocess.killed to reflect that a child process was successfully signaled, and not necessarily terminated. Fixes: #16747 Checklist make -j4 test (UNIX), or v...

Opengraph URL: https://github.com/nodejs/node/pull/16748

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:363cc2ac-1a3a-6ad3-9147-9c3a5fd60430
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8BC:15B152:DAC100:11778BD:69918B05
html-safe-nonce045d5f08187c21c6357aa5e923041c80b03a7d06e3ccec126fae65564d8d8b92
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEJDOjE1QjE1MjpEQUMxMDA6MTE3NzhCRDo2OTkxOEIwNSIsInZpc2l0b3JfaWQiOiI4MzUzNjcwMjAzNzU0Nzc3MzUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5d590082fb6311e14fde1ad049f815d23e27580b325e6144a3d2cc1f6f8dbd90
hovercard-subject-tagpull_request:150679127
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16748/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/81a52389b193703b4440c7fe1a72039d838e69b39ff8d070709635d428a714b9/nodejs/node/pull/16748
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/81a52389b193703b4440c7fe1a72039d838e69b39ff8d070709635d428a714b9/nodejs/node/pull/16748
og:image:altThis commit changes the wording of subprocess.killed to reflect that a child process was successfully signaled, and not necessarily terminated. Fixes: #16747 Checklist make -j4 test (UNIX), or v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16748#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16748
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16748
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16748
Reloadhttps://github.com/nodejs/node/pull/16748
Reloadhttps://github.com/nodejs/node/pull/16748
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16748
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:kill-docshttps://github.com/cjihrig/node/tree/kill-docs
Conversationhttps://github.com/nodejs/node/pull/16748
Commits1 (1)https://github.com/nodejs/node/pull/16748/commits
Checkshttps://github.com/nodejs/node/pull/16748/checks
Files changedhttps://github.com/nodejs/node/pull/16748/files
doc: update subprocess.killedhttps://github.com/nodejs/node/pull/16748#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:kill-docshttps://github.com/cjihrig/node/tree/kill-docs
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 4, 2017https://github.com/nodejs/node/pull/16748#issue-271196735
#16747https://github.com/nodejs/node/issues/16747
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16748
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Nov 4, 2017https://github.com/nodejs/node/pull/16748#event-1326080893
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 4, 2017 https://github.com/nodejs/node/pull/16748#ref-issue-271195717
Improve ChildProcess::killed property behaviour. Or update documentation. #16747 https://github.com/nodejs/node/issues/16747
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 4, 2017 https://github.com/nodejs/node/pull/16748#pullrequestreview-74258381
View reviewed changes https://github.com/nodejs/node/pull/16748/files
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 4, 2017 https://github.com/nodejs/node/pull/16748#pullrequestreview-74268080
View reviewed changes https://github.com/nodejs/node/pull/16748/files
doc/api/child_process.mdhttps://github.com/nodejs/node/pull/16748/files#diff-fb4d08d898bf0f72e95ea3627f5838fdf1c4b5adc303cd7c8f526da13e57faf5
Trotthttps://github.com/Trott
Nov 4, 2017https://github.com/nodejs/node/pull/16748#discussion_r148943776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16748
WoZhttps://github.com/WoZ
Nov 5, 2017https://github.com/nodejs/node/pull/16748#discussion_r148957389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/16748
doc/api/child_process.mdhttps://github.com/nodejs/node/pull/16748/files#diff-fb4d08d898bf0f72e95ea3627f5838fdf1c4b5adc303cd7c8f526da13e57faf5
Trotthttps://github.com/Trott
Nov 4, 2017https://github.com/nodejs/node/pull/16748#discussion_r148943783
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16748
https://github.com/eduardbme
eduardbmehttps://github.com/eduardbme
Nov 5, 2017https://github.com/nodejs/node/pull/16748#issuecomment-341970530
Please reload this pagehttps://github.com/nodejs/node/pull/16748
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 6, 2017 https://github.com/nodejs/node/pull/16748#pullrequestreview-74397593
View reviewed changes https://github.com/nodejs/node/pull/16748/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/f5ec3d4003deb886e03e4b3d6777d5e4a90ab446..8db8c2cea637767046e0605ff4b0fc084bf9f452
f5ec3d4https://github.com/nodejs/node/commit/f5ec3d4003deb886e03e4b3d6777d5e4a90ab446
8db8c2chttps://github.com/nodejs/node/commit/8db8c2cea637767046e0605ff4b0fc084bf9f452
Compare https://github.com/nodejs/node/compare/f5ec3d4003deb886e03e4b3d6777d5e4a90ab446..8db8c2cea637767046e0605ff4b0fc084bf9f452
November 7, 2017 18:44https://github.com/nodejs/node/pull/16748#event-1330343999
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 7, 2017https://github.com/nodejs/node/pull/16748#issuecomment-342581823
https://ci.nodejs.org/job/node-test-pull-request/11278/https://ci.nodejs.org/job/node-test-pull-request/11278/
Please reload this pagehttps://github.com/nodejs/node/pull/16748
https://github.com/cjihrig
doc: update subprocess.killedhttps://github.com/nodejs/node/pull/16748/commits/2fdb606daccde863c9bdc426947d0a3c76caf542
2fdb606https://github.com/nodejs/node/pull/16748/commits/2fdb606daccde863c9bdc426947d0a3c76caf542
nodejs#16747https://github.com/nodejs/node/issues/16747
nodejs#16748https://github.com/nodejs/node/pull/16748
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/8db8c2cea637767046e0605ff4b0fc084bf9f452..2fdb606daccde863c9bdc426947d0a3c76caf542
8db8c2chttps://github.com/nodejs/node/commit/8db8c2cea637767046e0605ff4b0fc084bf9f452
2fdb606https://github.com/nodejs/node/commit/2fdb606daccde863c9bdc426947d0a3c76caf542
Compare https://github.com/nodejs/node/compare/8db8c2cea637767046e0605ff4b0fc084bf9f452..2fdb606daccde863c9bdc426947d0a3c76caf542
November 7, 2017 20:36https://github.com/nodejs/node/pull/16748#event-1330549179
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
2fdb606https://github.com/nodejs/node/commit/2fdb606daccde863c9bdc426947d0a3c76caf542
Nov 7, 2017https://github.com/nodejs/node/pull/16748#event-1330551382
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
November 7, 2017 20:38https://github.com/nodejs/node/pull/16748#event-1330551832
evanlucashttps://github.com/evanlucas
Nov 13, 2017 https://github.com/nodejs/node/pull/16748#ref-commit-a184dbc
https://github.com/cjihrig
https://github.com/evanlucas
doc: update subprocess.killedhttps://github.com/nodejs/node/commit/a184dbcb2c689f22c8c2c616ab5734818a8f25aa
a184dbchttps://github.com/nodejs/node/commit/a184dbcb2c689f22c8c2c616ab5734818a8f25aa
#16747https://github.com/nodejs/node/issues/16747
#16748https://github.com/nodejs/node/pull/16748
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 13, 2017 https://github.com/nodejs/node/pull/16748#ref-pullrequest-273462029
v9.2.0 proposal #16992 https://github.com/nodejs/node/pull/16992
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017 https://github.com/nodejs/node/pull/16748#ref-commit-e2b8012
https://github.com/cjihrig
https://github.com/MylesBorins
doc: update subprocess.killedhttps://github.com/nodejs/node/commit/e2b80129cab745469ab63a5e3fcacf8b450acce4
e2b8012https://github.com/nodejs/node/commit/e2b80129cab745469ab63a5e3fcacf8b450acce4
#16747https://github.com/nodejs/node/issues/16747
#16748https://github.com/nodejs/node/pull/16748
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2017 https://github.com/nodejs/node/pull/16748#ref-commit-c4634bf
https://github.com/cjihrig
https://github.com/MylesBorins
doc: update subprocess.killedhttps://github.com/nodejs/node/commit/c4634bf5067c7fcda336a8fa68a8174ba4be6a18
c4634bfhttps://github.com/nodejs/node/commit/c4634bf5067c7fcda336a8fa68a8174ba4be6a18
#16747https://github.com/nodejs/node/issues/16747
#16748https://github.com/nodejs/node/pull/16748
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Nov 17, 2017https://github.com/nodejs/node/pull/16748#event-1347346351
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Nov 21, 2017 https://github.com/nodejs/node/pull/16748#ref-pullrequest-275888281
v8.9.2 proposal #17204 https://github.com/nodejs/node/pull/17204
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/16748#ref-pullrequest-275653593
v6.12.1 proposal #17180 https://github.com/nodejs/node/pull/17180
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/16748#ref-commit-f1e0ea2
https://github.com/cjihrig
https://github.com/MylesBorins
doc: update subprocess.killedhttps://github.com/nodejs/node/commit/f1e0ea2cabcdf70bd8e81a547f5bd54a381c2ea8
f1e0ea2https://github.com/nodejs/node/commit/f1e0ea2cabcdf70bd8e81a547f5bd54a381c2ea8
#16747https://github.com/nodejs/node/issues/16747
#16748https://github.com/nodejs/node/pull/16748
MylesBorinshttps://github.com/MylesBorins
Nov 28, 2017 https://github.com/nodejs/node/pull/16748#ref-commit-727a0fe
https://github.com/cjihrig
https://github.com/MylesBorins
doc: update subprocess.killedhttps://github.com/nodejs/node/commit/727a0fe6419b7756a16defcca968a923d5ad45e3
727a0fehttps://github.com/nodejs/node/commit/727a0fe6419b7756a16defcca968a923d5ad45e3
#16747https://github.com/nodejs/node/issues/16747
#16748https://github.com/nodejs/node/pull/16748
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16748
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16748/files/774b5d829ffbe252920444e17eac2fa679f5a65e
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/16748/files/774b5d829ffbe252920444e17eac2fa679f5a65e
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/16748/files/774b5d829ffbe252920444e17eac2fa679f5a65e
https://github.com/WoZ
WoZ https://github.com/WoZ
https://github.com/nodejs/node/pull/16748/files/774b5d829ffbe252920444e17eac2fa679f5a65e
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Please reload this pagehttps://github.com/nodejs/node/pull/16748
https://github.com/cjihrig
https://github.com/eduardbme
https://github.com/WoZ
https://github.com/jasnell
https://github.com/Trott
https://github.com/lpinca
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.