| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:056aceee-8fa6-acc4-0ea0-c7fc44ec5bfa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D08A:1E8EEE:462A52:5931D9:699216E2 |
| html-safe-nonce | 8893025025aac4ea1e6bd99dccedcc4d668e405cadf58852f4a958b2ff11320b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDhBOjFFOEVFRTo0NjJBNTI6NTkzMUQ5OjY5OTIxNkUyIiwidmlzaXRvcl9pZCI6IjI4OTYzMTcwODE5MzM5NzczMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bf4195f84cc0363b9f97aa4fb468a3d35c18aa78f4a4e88eaecea284ba3d5a31 |
| hovercard-subject-tag | pull_request:150470871 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16709/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6d244a1374016f77cf7c1dbd06f0a293af4fc980164cf4e1ad6c56b7d5a92dd0/nodejs/node/pull/16709 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6d244a1374016f77cf7c1dbd06f0a293af4fc980164cf4e1ad6c56b7d5a92dd0/nodejs/node/pull/16709 |
| og:image:alt | #16495 broke the Windows build, accounting for \r\n newlines should fix it.
Ref: #16495
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16709#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16709 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16709 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16709 |
| Reload | https://github.com/nodejs/node/pull/16709 |
| Reload | https://github.com/nodejs/node/pull/16709 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:stl-windows | https://github.com/addaleax/node/tree/stl-windows |
| Conversation | https://github.com/nodejs/node/pull/16709 |
| Commits1 (1) | https://github.com/nodejs/node/pull/16709/commits |
| Checks | https://github.com/nodejs/node/pull/16709/checks |
| Files changed | https://github.com/nodejs/node/pull/16709/files |
| test: fix test-cli-node-options on Windows | https://github.com/nodejs/node/pull/16709#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:stl-windows | https://github.com/addaleax/node/tree/stl-windows |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#issue-270901249 |
| #16495 | https://github.com/nodejs/node/pull/16495 |
| #16495 | https://github.com/nodejs/node/pull/16495 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
|
| https://github.com/addaleax |
| test: fix test-cli-node-options on Windows | https://github.com/nodejs/node/pull/16709/commits/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
| d762fc3 | https://github.com/nodejs/node/pull/16709/commits/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
| nodejs#16495 | https://github.com/nodejs/node/pull/16495 |
| nodejs#16495 | https://github.com/nodejs/node/pull/16495 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
cli
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#event-1324419487 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#issuecomment-341640620 |
| https://ci.nodejs.org/job/node-test-pull-request/11167/ | https://ci.nodejs.org/job/node-test-pull-request/11167/ |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 3, 2017
| https://github.com/nodejs/node/pull/16709#pullrequestreview-74011616 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 3, 2017
| https://github.com/nodejs/node/pull/16709#pullrequestreview-74025604 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Nov 3, 2017
| https://github.com/nodejs/node/pull/16709#pullrequestreview-74033103 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
| test/parallel/test-cli-node-options.js | https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701#diff-92036e8e1bc1f6cf849fcd5498840ba1dbbc53ba4d6335b81ea4f84426d30081 |
| gibfahn | https://github.com/gibfahn |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#discussion_r148743177 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#discussion_r148745129 |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| addaleax | https://github.com/addaleax |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#discussion_r148751062 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| gibfahn | https://github.com/gibfahn |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#discussion_r148760522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#issuecomment-341670900 |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| 3d4d5e0 | https://github.com/nodejs/node/commit/3d4d5e0c60f00693947c940b09249f3952bb0cdc |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 3, 2017 | https://github.com/nodejs/node/pull/16709#event-1324628221 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| November 3, 2017 10:47 | https://github.com/nodejs/node/pull/16709#event-1324629000 |
| addaleax | https://github.com/addaleax |
|
Nov 3, 2017
| https://github.com/nodejs/node/pull/16709#ref-commit-3d4d5e0 |
|
| https://github.com/addaleax |
| test: fix test-cli-node-options on Windows | https://github.com/nodejs/node/commit/3d4d5e0c60f00693947c940b09249f3952bb0cdc |
| 3d4d5e0 | https://github.com/nodejs/node/commit/3d4d5e0c60f00693947c940b09249f3952bb0cdc |
| #16495 | https://github.com/nodejs/node/pull/16495 |
| #16495 | https://github.com/nodejs/node/pull/16495 |
| #16709 | https://github.com/nodejs/node/pull/16709 |
| cjihrig | https://github.com/cjihrig |
|
Nov 6, 2017
| https://github.com/nodejs/node/pull/16709#ref-commit-26f1a1d |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
| test: fix test-cli-node-options on Windows | https://github.com/cjihrig/node/commit/26f1a1d9e95b91d29387f71b19ba76059b62e9f8 |
| 26f1a1d | https://github.com/cjihrig/node/commit/26f1a1d9e95b91d29387f71b19ba76059b62e9f8 |
| nodejs#16495 | https://github.com/nodejs/node/pull/16495 |
| nodejs#16495 | https://github.com/nodejs/node/pull/16495 |
| nodejs#16709 | https://github.com/nodejs/node/pull/16709 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Nov 6, 2017
| https://github.com/nodejs/node/pull/16709#ref-pullrequest-271654245 |
|
v9.1.0 proposal
#16851
| https://github.com/nodejs/node/pull/16851 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/16709#issuecomment-344336272 |
| #16495 | https://github.com/nodejs/node/pull/16495 |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/16709#event-1341378973 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
baking-for-lts
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/16709#event-1341381281 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/16709#ref-pullrequest-268491006 |
|
cli: add --stack-trace-limit to NODE_OPTIONS
#16495
| https://github.com/nodejs/node/pull/16495 |
| https://github.com/AndreasMadsen |
| AndreasMadsen | https://github.com/AndreasMadsen |
|
Jan 16, 2018
| https://github.com/nodejs/node/pull/16709#ref-pullrequest-288960605 |
|
Backport async hooks to v8.x
#18179
| https://github.com/nodejs/node/pull/18179 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
|
baking-for-lts
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts |
|
lts-watch-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x |
| Jan 16, 2018 | https://github.com/nodejs/node/pull/16709#event-1427169689 |
| gibfahn | https://github.com/gibfahn |
|
Jan 16, 2018
| https://github.com/nodejs/node/pull/16709#ref-commit-439112a |
|
| https://github.com/addaleax |
|
| https://github.com/gibfahn |
| test: fix test-cli-node-options on Windows | https://github.com/gibfahn/node/commit/439112a91bcf7bdff5b1ba03fd90b9eb079ddda7 |
| 439112a | https://github.com/gibfahn/node/commit/439112a91bcf7bdff5b1ba03fd90b9eb079ddda7 |
| nodejs#16495 | https://github.com/nodejs/node/pull/16495 |
| nodejs#16495 | https://github.com/nodejs/node/pull/16495 |
| nodejs#16709 | https://github.com/nodejs/node/pull/16709 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Feb 27, 2018 | https://github.com/nodejs/node/pull/16709#event-1493454332 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16709 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/16709/files/d762fc3ab6aa1fb02636fa941fa3528da04e1701 |
|
cli
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/16709 |
|
| https://github.com/addaleax |
|
| https://github.com/gibfahn |
|
| https://github.com/lpinca |
|
| https://github.com/richardlau |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |