René's URL Explorer Experiment


Title: inspector: include node_platform.h header by alexeykuzmin · Pull Request #16677 · nodejs/node · GitHub

Open Graph Title: inspector: include node_platform.h header by alexeykuzmin · Pull Request #16677 · nodejs/node

X Title: inspector: include node_platform.h header by alexeykuzmin · Pull Request #16677 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When Node.js is compiled as a part of the Electron build clang generates a couple of errors (see below). Including a header instead of using a forward declaration fixes them. It would be great if t...

X Description: When Node.js is compiled as a part of the Electron build clang generates a couple of errors (see below). Including a header instead of using a forward declaration fixes them. It would be great if t...

Opengraph URL: https://github.com/nodejs/node/pull/16677

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:47968101-1413-c593-1583-8a197bed9da6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD616:1F7AEB:18DD29C:1F730E1:69917BA3
html-safe-nonce446eb288ecd6a5096b0199d71012821efa6109597b82617364a1167fcd71823f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjE2OjFGN0FFQjoxOEREMjlDOjFGNzMwRTE6Njk5MTdCQTMiLCJ2aXNpdG9yX2lkIjoiNTA0NjQyMzAwNTAzNjY0MTE4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccc567fea114e122ef98633dd51878bdf6cdb4fc92ee66e241111b2aeb319c66c
hovercard-subject-tagpull_request:150194491
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16677/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d53061eb01dd721251aa8d39b0eed3a7d38b965dbaa6cdf3cec84b864f21b065/nodejs/node/pull/16677
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d53061eb01dd721251aa8d39b0eed3a7d38b965dbaa6cdf3cec84b864f21b065/nodejs/node/pull/16677
og:image:altWhen Node.js is compiled as a part of the Electron build clang generates a couple of errors (see below). Including a header instead of using a forward declaration fixes them. It would be great if t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexeykuzmin
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16677#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16677
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16677
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16677
Reloadhttps://github.com/nodejs/node/pull/16677
Reloadhttps://github.com/nodejs/node/pull/16677
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16677
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
alexeykuzminhttps://github.com/alexeykuzmin
nodejs:masterhttps://github.com/nodejs/node/tree/master
alexeykuzmin:include-node-platform-dot-hhttps://github.com/alexeykuzmin/node/tree/include-node-platform-dot-h
Conversationhttps://github.com/nodejs/node/pull/16677
Commits1 (1)https://github.com/nodejs/node/pull/16677/commits
Checkshttps://github.com/nodejs/node/pull/16677/checks
Files changedhttps://github.com/nodejs/node/pull/16677/files
inspector: include node_platform.h headerhttps://github.com/nodejs/node/pull/16677#top
alexeykuzminhttps://github.com/alexeykuzmin
nodejs:masterhttps://github.com/nodejs/node/tree/master
alexeykuzmin:include-node-platform-dot-hhttps://github.com/alexeykuzmin/node/tree/include-node-platform-dot-h
https://github.com/alexeykuzmin
alexeykuzminhttps://github.com/alexeykuzmin
Nov 2, 2017https://github.com/nodejs/node/pull/16677#issue-270518269
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16677
https://github.com/alexeykuzmin
inspector: include node_platform.h headerhttps://github.com/nodejs/node/pull/16677/commits/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
fb5ceddhttps://github.com/nodejs/node/pull/16677/commits/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
Nov 2, 2017https://github.com/nodejs/node/pull/16677#event-1322223245
https://github.com/alexeykuzmin
alexeykuzminhttps://github.com/alexeykuzmin
Nov 2, 2017 https://github.com/nodejs/node/pull/16677#ref-issue-266513327
Technical debt after the Chromium 61 upgrade electron/electron#10836 https://github.com/electron/electron/issues/10836
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 2, 2017 https://github.com/nodejs/node/pull/16677#pullrequestreview-73686385
View reviewed changes https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 2, 2017 https://github.com/nodejs/node/pull/16677#pullrequestreview-73783319
View reviewed changes https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Nov 2, 2017 https://github.com/nodejs/node/pull/16677#pullrequestreview-73840186
View reviewed changes https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 3, 2017 https://github.com/nodejs/node/pull/16677#pullrequestreview-74078247
View reviewed changes https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 3, 2017https://github.com/nodejs/node/pull/16677#issuecomment-341703625
https://ci.nodejs.org/job/node-test-pull-request/11169/https://ci.nodejs.org/job/node-test-pull-request/11169/
Please reload this pagehttps://github.com/nodejs/node/pull/16677
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Nov 5, 2017 https://github.com/nodejs/node/pull/16677#pullrequestreview-74277238
View reviewed changes https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/alexeykuzmin
alexeykuzminhttps://github.com/alexeykuzmin
Nov 6, 2017https://github.com/nodejs/node/pull/16677#issuecomment-342055264
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/16677
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 6, 2017 https://github.com/nodejs/node/pull/16677#ref-commit-916e1cb
https://github.com/alexeykuzmin
https://github.com/gireeshpunathil
inspector: include node_platform.h headerhttps://github.com/nodejs/node/commit/916e1cb72016333635e24fd49966e1295dfeb436
916e1cbhttps://github.com/nodejs/node/commit/916e1cb72016333635e24fd49966e1295dfeb436
#16677https://github.com/nodejs/node/pull/16677
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 6, 2017https://github.com/nodejs/node/pull/16677#issuecomment-342076998
@alexeykuzminhttps://github.com/alexeykuzmin
916e1cbhttps://github.com/nodejs/node/commit/916e1cb72016333635e24fd49966e1295dfeb436
Please reload this pagehttps://github.com/nodejs/node/pull/16677
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Nov 6, 2017https://github.com/nodejs/node/pull/16677#event-1327085339
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 6, 2017https://github.com/nodejs/node/pull/16677#issuecomment-342093637
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/16677
https://github.com/maclover7
maclover7https://github.com/maclover7
Nov 6, 2017https://github.com/nodejs/node/pull/16677#issuecomment-342167215
@gireeshpunathilhttps://github.com/gireeshpunathil
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/16677
cjihrighttps://github.com/cjihrig
Nov 6, 2017 https://github.com/nodejs/node/pull/16677#ref-commit-6074c8c
https://github.com/alexeykuzmin
https://github.com/cjihrig
inspector: include node_platform.h headerhttps://github.com/cjihrig/node/commit/6074c8cdbb06a37d30b43b8e0e4b418951490fa8
6074c8chttps://github.com/cjihrig/node/commit/6074c8cdbb06a37d30b43b8e0e4b418951490fa8
nodejs#16677https://github.com/nodejs/node/pull/16677
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 6, 2017 https://github.com/nodejs/node/pull/16677#ref-pullrequest-271654245
v9.1.0 proposal #16851 https://github.com/nodejs/node/pull/16851
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Nov 14, 2017https://github.com/nodejs/node/pull/16677#event-1341413011
https://github.com/alexeykuzmin
alexeykuzminhttps://github.com/alexeykuzmin
Nov 24, 2017 https://github.com/nodejs/node/pull/16677#ref-issue-276576524
UPSTREAM: Include node_platform.h instead of forward declaration electron/node#25 https://github.com/electron/node/issues/25
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/16677#event-1394783796
MylesBorinshttps://github.com/MylesBorins
Dec 19, 2017 https://github.com/nodejs/node/pull/16677#ref-commit-31e21e7
https://github.com/alexeykuzmin
https://github.com/MylesBorins
inspector: include node_platform.h headerhttps://github.com/nodejs/node/commit/31e21e7d8e06b8dbb3eca51325d229db30e271cd
31e21e7https://github.com/nodejs/node/commit/31e21e7d8e06b8dbb3eca51325d229db30e271cd
#16677https://github.com/nodejs/node/pull/16677
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/16677#ref-pullrequest-283423333
v8.9.4 proposal #17772 https://github.com/nodejs/node/pull/17772
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/16677#ref-commit-bf123f3
https://github.com/alexeykuzmin
https://github.com/gibfahn
inspector: include node_platform.h headerhttps://github.com/nodejs/node/commit/bf123f3dc203945b29ec58d0b8645eb4631ef415
bf123f3https://github.com/nodejs/node/commit/bf123f3dc203945b29ec58d0b8645eb4631ef415
#16677https://github.com/nodejs/node/pull/16677
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 20, 2017 https://github.com/nodejs/node/pull/16677#ref-pullrequest-283426801
v8.9.4 proposal #17774 https://github.com/nodejs/node/pull/17774
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16677
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/eugeneo
eugeneo https://github.com/eugeneo
https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/16677/files/fb5cedd45aeb2a9c75a14dfcab556097f8c7582b
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
Please reload this pagehttps://github.com/nodejs/node/pull/16677
https://github.com/alexeykuzmin
https://github.com/gireeshpunathil
https://github.com/Trott
https://github.com/maclover7
https://github.com/eugeneo
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.