René's URL Explorer Experiment


Title: loader, docs, test: named exports from commonjs modules by devsnek · Pull Request #16675 · nodejs/node · GitHub

Open Graph Title: loader, docs, test: named exports from commonjs modules by devsnek · Pull Request #16675 · nodejs/node

X Title: loader, docs, test: named exports from commonjs modules by devsnek · Pull Request #16675 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: I know a lot of discussion went into the original decision on how mjs would handle cjs modules but after using the system for a while, and talking with a lot of other people in the community, it ju...

X Description: I know a lot of discussion went into the original decision on how mjs would handle cjs modules but after using the system for a while, and talking with a lot of other people in the community, it ju...

Opengraph URL: https://github.com/nodejs/node/pull/16675

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d7a198e5-e034-f263-d9b2-56f6c46d93fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE264:EA672:849C00:B19C60:6A52AB71
html-safe-nonceaae54010a0872d2bd0763fe5ba082d260e103bbb172605bfb06009b1bff9e86c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjY0OkVBNjcyOjg0OUMwMDpCMTlDNjA6NkE1MkFCNzEiLCJ2aXNpdG9yX2lkIjoiNzg2MDcxMTMyNTE2NDU0NjkyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca5bdb59c247acd11bcad9dbab75afbcd436a9d49bc85c9073cb859b322842848
hovercard-subject-tagpull_request:150175674
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16675/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/79dc78651ade4c89b10319d44663ca2a47437a5c0cdf7748666056614c441bac/nodejs/node/pull/16675
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/79dc78651ade4c89b10319d44663ca2a47437a5c0cdf7748666056614c441bac/nodejs/node/pull/16675
og:image:altI know a lot of discussion went into the original decision on how mjs would handle cjs modules but after using the system for a while, and talking with a lot of other people in the community, it ju...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevsnek
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16675#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16675
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16675
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16675
Reloadhttps://github.com/nodejs/node/pull/16675
Reloadhttps://github.com/nodejs/node/pull/16675
Please reload this pagehttps://github.com/nodejs/node/pull/16675
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16675
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 988 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:esm-namespace-from-exportshttps://github.com/devsnek/node/tree/esm-namespace-from-exports
Conversationhttps://github.com/nodejs/node/pull/16675
Commits13 (13)https://github.com/nodejs/node/pull/16675/commits
Checkshttps://github.com/nodejs/node/pull/16675/checks
Files changedhttps://github.com/nodejs/node/pull/16675/files
loader, docs, test: named exports from commonjs moduleshttps://github.com/nodejs/node/pull/16675#top
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:esm-namespace-from-exportshttps://github.com/devsnek/node/tree/esm-namespace-from-exports
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issue-270491545
Please reload this pagehttps://github.com/nodejs/node/pull/16675
nodejs/node-eps#57https://github.com/nodejs/node-eps/issues/57
nodejs/abi-stable-node#256 (comment)https://github.com/nodejs/abi-stable-node/issues/256#issuecomment-325138872
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
loader,docs,test: set named exports based on keys from module.exportshttps://github.com/nodejs/node/pull/16675/commits/81fef20db9e945757631360febf6b1439069d351
81fef20https://github.com/nodejs/node/pull/16675/commits/81fef20db9e945757631360febf6b1439069d351
nodejs/node-eps#57https://github.com/nodejs/node-eps/issues/57
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Nov 2, 2017https://github.com/nodejs/node/pull/16675#event-1322093387
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341283375
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
add test for exporting reserved keywords from cjs from esmhttps://github.com/nodejs/node/pull/16675/commits/d3647ddd4cd5773cfe5159e42412e1624d587e49
d3647ddhttps://github.com/nodejs/node/pull/16675/commits/d3647ddd4cd5773cfe5159e42412e1624d587e49
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73718166
View reviewed changes https://github.com/nodejs/node/pull/16675/files/d3647ddd4cd5773cfe5159e42412e1624d587e49
doc/api/esm.mdhttps://github.com/nodejs/node/pull/16675/files/d3647ddd4cd5773cfe5159e42412e1624d587e49#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148471488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73718368
View reviewed changes https://github.com/nodejs/node/pull/16675/files/d3647ddd4cd5773cfe5159e42412e1624d587e49
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/16675#pullrequestreview-73718368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
test/es-module/test-esm-namespace.mjshttps://github.com/nodejs/node/pull/16675/files/d3647ddd4cd5773cfe5159e42412e1624d587e49#diff-27c9d58f42cd84930a08e21ebffccf95837643c66a13ffc2ca9b51f672f6d1a5
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148471678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/targos
targoshttps://github.com/targos
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341387247
@guybedfordhttps://github.com/guybedford
#16474https://github.com/nodejs/node/issues/16474
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
Slight change of plan with loading (use well-defined __esModule)https://github.com/nodejs/node/pull/16675/commits/e8478e28f5aeaf451f3c921ce1dfe452fbeebc58
e8478e2https://github.com/nodejs/node/pull/16675/commits/e8478e28f5aeaf451f3c921ce1dfe452fbeebc58
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341480325
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/chalk/chalk/blob/e2a4aa427568ff1c5d649739c4d1f8319cf0d072/index.js#L59https://github.com/chalk/chalk/blob/e2a4aa427568ff1c5d649739c4d1f8319cf0d072/index.js#L59
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341486836
Please reload this pagehttps://github.com/nodejs/node/pull/16675
@mcollinahttps://github.com/mcollina
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73866469
View reviewed changes https://github.com/nodejs/node/pull/16675/files/e8478e28f5aeaf451f3c921ce1dfe452fbeebc58
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/16675#pullrequestreview-73866469
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
lib/internal/loader/ModuleRequest.jshttps://github.com/nodejs/node/pull/16675/files/e8478e28f5aeaf451f3c921ce1dfe452fbeebc58#diff-427dcaab7306a76efa5c8e32307a02e87d2ba9e57e5052f828ce6fd77148b8b1
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148597944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148601349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
guybedfordhttps://github.com/guybedford
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148606810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148608418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#event-1323483313
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341500676
@devsnekhttps://github.com/devsnek
babel/babel#95https://github.com/babel/babel/issues/95
Please reload this pagehttps://github.com/nodejs/node/pull/16675
devsnekhttps://github.com/devsnek
November 2, 2017 12:49https://github.com/nodejs/node/pull/16675#commits-pushed-116b470
https://github.com/devsnek
Symbol('esModule') exported from module builtinhttps://github.com/nodejs/node/pull/16675/commits/116b470858b04cdaa1255eea4776079e8c42e4ad
116b470https://github.com/nodejs/node/pull/16675/commits/116b470858b04cdaa1255eea4776079e8c42e4ad
@esmodulehttps://github.com/esmodule
https://github.com/devsnek
remove comment i forgot to removehttps://github.com/nodejs/node/pull/16675/commits/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70
1a53fd1https://github.com/nodejs/node/pull/16675/commits/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73883961
View reviewed changes https://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70
lib/internal/loader/ModuleRequest.jshttps://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70#diff-427dcaab7306a76efa5c8e32307a02e87d2ba9e57e5052f828ce6fd77148b8b1
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148612674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148613110
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148614083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73884479
View reviewed changes https://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70
lib/internal/loader/ModuleRequest.jshttps://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70#diff-427dcaab7306a76efa5c8e32307a02e87d2ba9e57e5052f828ce6fd77148b8b1
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148613098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148615977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73884416
View reviewed changes https://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70
doc/api/esm.mdhttps://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148613037
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148613682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341507809
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73886148
View reviewed changes https://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70
lib/internal/loader/ModuleRequest.jshttps://github.com/nodejs/node/pull/16675/files/1a53fd195ad58ff16e9c391fa1d9d3a8a3969e70#diff-427dcaab7306a76efa5c8e32307a02e87d2ba9e57e5052f828ce6fd77148b8b1
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148614516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148615032
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341509689
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
change up symbol usage, use for(;;), add testshttps://github.com/nodejs/node/pull/16675/commits/ac2b4a1fb000a1337b96f192406a38632521b12f
ac2b4a1https://github.com/nodejs/node/pull/16675/commits/ac2b4a1fb000a1337b96f192406a38632521b12f
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73895735
View reviewed changes https://github.com/nodejs/node/pull/16675/files/ac2b4a1fb000a1337b96f192406a38632521b12f
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/16675#pullrequestreview-73895735
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341520076
Please reload this pagehttps://github.com/nodejs/node/pull/16675
@addaleaxhttps://github.com/addaleax
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341520779
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341521543
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341522873
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341523212
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#issuecomment-341523828
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 2, 2017 https://github.com/nodejs/node/pull/16675#pullrequestreview-73903394
View reviewed changes https://github.com/nodejs/node/pull/16675/files/ac2b4a1fb000a1337b96f192406a38632521b12f
doc/api/esm.mdhttps://github.com/nodejs/node/pull/16675/files/ac2b4a1fb000a1337b96f192406a38632521b12f#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
guybedfordhttps://github.com/guybedford
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148629300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
devsnekhttps://github.com/devsnek
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148629505
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
guybedfordhttps://github.com/guybedford
Nov 2, 2017https://github.com/nodejs/node/pull/16675#discussion_r148632273
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/targos
targoshttps://github.com/targos
Nov 17, 2017 https://github.com/nodejs/node/pull/16675#ref-pullrequest-265097466
Enable explicit .m.js intent for ESM #16170 https://github.com/nodejs/node/pull/16170
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 23, 2017https://github.com/nodejs/node/pull/16675#issuecomment-346704163
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Nov 24, 2017https://github.com/nodejs/node/pull/16675#issuecomment-346832333
@BridgeARhttps://github.com/BridgeAR
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/jacksonrayhamilton
jacksonrayhamiltonhttps://github.com/jacksonrayhamilton
Nov 27, 2017https://github.com/nodejs/node/pull/16675#issuecomment-347101406
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 27, 2017https://github.com/nodejs/node/pull/16675#issuecomment-347214199
@jacksonrayhamiltonhttps://github.com/jacksonrayhamilton
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/jacksonrayhamilton
jacksonrayhamiltonhttps://github.com/jacksonrayhamilton
Nov 28, 2017https://github.com/nodejs/node/pull/16675#issuecomment-347440002
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Nov 28, 2017https://github.com/nodejs/node/pull/16675#issuecomment-347528975
Please reload this pagehttps://github.com/nodejs/node/pull/16675
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
b7405abhttps://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117
7f086ddhttps://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728
Compare https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
December 8, 2017 16:37https://github.com/nodejs/node/pull/16675#event-1379145375
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 12, 2017https://github.com/nodejs/node/pull/16675#issuecomment-351071558
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Dec 12, 2017https://github.com/nodejs/node/pull/16675#issuecomment-351077370
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Dec 15, 2017https://github.com/nodejs/node/pull/16675#issuecomment-351878182
@devsnekhttps://github.com/devsnek
Notes from TC39https://github.com/rwaldron/tc39-notes/blob/master/es8/2017-11/nov-28.md#9iie-discuss-module-order-instantiationevaluation-guarantees
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 15, 2017https://github.com/nodejs/node/pull/16675#issuecomment-351883057
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Dec 15, 2017https://github.com/nodejs/node/pull/16675#issuecomment-351886541
@devsnekhttps://github.com/devsnek
https://github.com/bmeck/node/tree/named-export-corehttps://github.com/bmeck/node/tree/named-export-core
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 17, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352283028
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 17, 2017https://github.com/nodejs/node/pull/16675#event-1391196792
https://github.com/devsnek
devsnekhttps://github.com/devsnek
December 17, 2017 20:30https://github.com/nodejs/node/pull/16675#event-1391196891
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352889913
Please reload this pagehttps://github.com/nodejs/node/pull/16675
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
December 19, 2017 21:34https://github.com/nodejs/node/pull/16675#event-1395014062
https://github.com/devsnek
devsnekhttps://github.com/devsnek
December 19, 2017 21:48https://github.com/nodejs/node/pull/16675#event-1395035302
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352902313
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352914050
Please reload this pagehttps://github.com/nodejs/node/pull/16675
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352914655
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352915129
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352915668
@devsnekhttps://github.com/devsnek
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352916158
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Dec 19, 2017https://github.com/nodejs/node/pull/16675#issuecomment-352916821
@devsnekhttps://github.com/devsnek
https://github.com/nodejs/node-eps/pull/3/files#diff-0355b3cc08860f0ddbc8338ae885599aR68https://github.com/nodejs/node-eps/pull/3/files#diff-0355b3cc08860f0ddbc8338ae885599aR68
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Feb 6, 2018 https://github.com/nodejs/node/pull/16675#ref-issue-294520369
Online Module Summit 2018-04-03 nodejs/modules#9 https://github.com/nodejs/modules/issues/9
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Mar 10, 2018 https://github.com/nodejs/node/pull/16675#ref-pullrequest-291868841
esm: Implement esm mode flag #18392 https://github.com/nodejs/node/pull/18392
https://github.com/devsnek
devsnekhttps://github.com/devsnek
May 14, 2018 https://github.com/nodejs/node/pull/16675#ref-issue-322971924
Feature: Named exports when importing CJS nodejs/modules#81 https://github.com/nodejs/modules/issues/81
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Feb 11, 2019 https://github.com/nodejs/node/pull/16675#ref-pullrequest-408557144
CJS named exports via two-phase execution nodejs/ecmascript-modules#31 https://github.com/nodejs/ecmascript-modules/pull/31
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16675
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/16675/files/c4a6c27a604961d0431eb02d76356fb414365a57
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/16675/files/fe73e26878c94bfd8acfd94c9915bd79fa3b6dcc
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16675/files/1220d06c9748b40eb5083e97baad9150f151688e
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/16675/files/c4a6c27a604961d0431eb02d76356fb414365a57
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/16675/files/fe73e26878c94bfd8acfd94c9915bd79fa3b6dcc
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/jdalton
jdalton https://github.com/jdalton
https://github.com/nodejs/node/pull/16675/files/c4a6c27a604961d0431eb02d76356fb414365a57
https://github.com/loganfsmyth
loganfsmyth https://github.com/loganfsmyth
https://github.com/nodejs/node/pull/16675/files/c4a6c27a604961d0431eb02d76356fb414365a57
https://github.com/bmeck
bmeck https://github.com/bmeck
https://github.com/nodejs/node/pull/16675/files/1220d06c9748b40eb5083e97baad9150f151688e
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/16675
https://github.com/devsnek
https://github.com/addaleax
https://github.com/targos
https://github.com/guybedford
https://github.com/mcollina
https://github.com/apapirovski
https://github.com/ljharb
https://github.com/bmeck
https://github.com/jdalton
https://github.com/Fishrock123
https://github.com/BridgeAR
https://github.com/jacksonrayhamilton
https://github.com/loganfsmyth
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.