René's URL Explorer Experiment


Title: http2: allocate on every chunk send by jasnell · Pull Request #16669 · nodejs/node · GitHub

Open Graph Title: http2: allocate on every chunk send by jasnell · Pull Request #16669 · nodejs/node

X Title: http2: allocate on every chunk send by jasnell · Pull Request #16669 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously, we were using a shared stack allocated buffer to hold the serialized outbound data but that runs into issues if the outgoing stream does not write or copy immediately. Instead, allocate...

X Description: Previously, we were using a shared stack allocated buffer to hold the serialized outbound data but that runs into issues if the outgoing stream does not write or copy immediately. Instead, allocate...

Opengraph URL: https://github.com/nodejs/node/pull/16669

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:677dfe77-1430-63d6-4483-a5332ad47b80
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6A0:20A2E2:12A9D06:195BABD:6A5216DB
html-safe-nonce78817c57b570ac4f24d0731178496f3676f3230fd18074f5792fd4bd6132f527
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkEwOjIwQTJFMjoxMkE5RDA2OjE5NUJBQkQ6NkE1MjE2REIiLCJ2aXNpdG9yX2lkIjoiMzM3NjY3Njc1OTg4NTk3NzMwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0261cc3000e81d3f7c399050d7c8ce8441edfb18fc76edfafa765ff30100fa4c
hovercard-subject-tagpull_request:150108133
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16669/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/520d415f5c8c31912b02cbbfc3505c90709f5aa8959fed4feb85266377b7ebaf/nodejs/node/pull/16669
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/520d415f5c8c31912b02cbbfc3505c90709f5aa8959fed4feb85266377b7ebaf/nodejs/node/pull/16669
og:image:altPreviously, we were using a shared stack allocated buffer to hold the serialized outbound data but that runs into issues if the outgoing stream does not write or copy immediately. Instead, allocate...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16669#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16669
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16669
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16669
Reloadhttps://github.com/nodejs/node/pull/16669
Reloadhttps://github.com/nodejs/node/pull/16669
Please reload this pagehttps://github.com/nodejs/node/pull/16669
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16669
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 984 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-refactor-sendhttps://github.com/jasnell/node/tree/http2-refactor-send
Conversationhttps://github.com/nodejs/node/pull/16669
Commits2 (2)https://github.com/nodejs/node/pull/16669/commits
Checkshttps://github.com/nodejs/node/pull/16669/checks
Files changedhttps://github.com/nodejs/node/pull/16669/files
http2: allocate on every chunk sendhttps://github.com/nodejs/node/pull/16669#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:http2-refactor-sendhttps://github.com/jasnell/node/tree/http2-refactor-send
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 1, 2017https://github.com/nodejs/node/pull/16669#issue-270401137
@apapirovskihttps://github.com/apapirovski
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Nov 1, 2017https://github.com/nodejs/node/pull/16669#event-1321543728
https://github.com/jasnell
jasnellhttps://github.com/jasnell
addaleaxhttps://github.com/addaleax
apapirovskihttps://github.com/apapirovski
mcollinahttps://github.com/mcollina
sebdeckershttps://github.com/sebdeckers
November 1, 2017 18:18https://github.com/nodejs/node/pull/16669#event-1321549533
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 1, 2017 https://github.com/nodejs/node/pull/16669#pullrequestreview-73613609
View reviewed changes https://github.com/nodejs/node/pull/16669/files
apapirovskihttps://github.com/apapirovski
https://github.com/nodejs/node/pull/16669#pullrequestreview-73613609
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16669
src/node_http2.cchttps://github.com/nodejs/node/pull/16669/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
apapirovskihttps://github.com/apapirovski
Nov 1, 2017https://github.com/nodejs/node/pull/16669#discussion_r148379853
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16669
jasnellhttps://github.com/jasnell
Nov 1, 2017https://github.com/nodejs/node/pull/16669#discussion_r148409518
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 1, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341241481
Please reload this pagehttps://github.com/nodejs/node/pull/16669
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Nov 1, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341261401
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 1, 2017 https://github.com/nodejs/node/pull/16669#pullrequestreview-73642487
View reviewed changes https://github.com/nodejs/node/pull/16669/files
src/node_http2.cchttps://github.com/nodejs/node/pull/16669/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771c
addaleaxhttps://github.com/addaleax
Nov 1, 2017https://github.com/nodejs/node/pull/16669#discussion_r148404914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16669
jasnellhttps://github.com/jasnell
Nov 1, 2017https://github.com/nodejs/node/pull/16669#discussion_r148409661
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Nov 1, 2017https://github.com/nodejs/node/pull/16669#event-1322018783
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 1, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341271156
Please reload this pagehttps://github.com/nodejs/node/pull/16669
jasnellhttps://github.com/jasnell
November 1, 2017 22:53https://github.com/nodejs/node/pull/16669#commits-pushed-125e1b5
https://github.com/jasnell
http2: allocate on every chunk sendhttps://github.com/nodejs/node/pull/16669/commits/125e1b5c0dd9891479c5c9e79823f4e43bf8bce5
125e1b5https://github.com/nodejs/node/pull/16669/commits/125e1b5c0dd9891479c5c9e79823f4e43bf8bce5
https://github.com/jasnell
[Squash] address commentshttps://github.com/nodejs/node/pull/16669/commits/1c6ec13d8027fbba6ff84bf75f55841358bda217
1c6ec13https://github.com/nodejs/node/pull/16669/commits/1c6ec13d8027fbba6ff84bf75f55841358bda217
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/afddd0941c2b3e0ff92e2506fbf97b3a7e7d588c..1c6ec13d8027fbba6ff84bf75f55841358bda217
afddd09https://github.com/nodejs/node/commit/afddd0941c2b3e0ff92e2506fbf97b3a7e7d588c
1c6ec13https://github.com/nodejs/node/commit/1c6ec13d8027fbba6ff84bf75f55841358bda217
Compare https://github.com/nodejs/node/compare/afddd0941c2b3e0ff92e2506fbf97b3a7e7d588c..1c6ec13d8027fbba6ff84bf75f55841358bda217
November 2, 2017 05:53https://github.com/nodejs/node/pull/16669#event-1322342067
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 2, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341324810
@apapirovskihttps://github.com/apapirovski
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Nov 2, 2017 https://github.com/nodejs/node/pull/16669#pullrequestreview-73690650
View reviewed changes https://github.com/nodejs/node/pull/16669/files/1c6ec13d8027fbba6ff84bf75f55841358bda217
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 2, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341324994
https://ci.nodejs.org/job/node-test-pull-request/11140/https://ci.nodejs.org/job/node-test-pull-request/11140/
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2017 https://github.com/nodejs/node/pull/16669#pullrequestreview-73713213
View reviewed changes https://github.com/nodejs/node/pull/16669/files/1c6ec13d8027fbba6ff84bf75f55841358bda217
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/16669#pullrequestreview-73713213
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16669
jasnellhttps://github.com/jasnell
Nov 3, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-4db1bc8
https://github.com/jasnell
http2: allocate on every chunk sendhttps://github.com/nodejs/node/commit/4db1bc8f2052a1cd2bab267e026b5ee330f25aad
4db1bc8https://github.com/nodejs/node/commit/4db1bc8f2052a1cd2bab267e026b5ee330f25aad
#16669https://github.com/nodejs/node/pull/16669
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 3, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341773308
4db1bc8https://github.com/nodejs/node/commit/4db1bc8f2052a1cd2bab267e026b5ee330f25aad
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 3, 2017https://github.com/nodejs/node/pull/16669#event-1325332899
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 3, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341792571
https://ci.nodejs.org/job/node-test-pull-request/11140/https://ci.nodejs.org/job/node-test-pull-request/11140/
@jasnellhttps://github.com/jasnell
https://ci.nodejs.org/job/node-test-commit-linuxone/9931/nodes=rhel72-s390x/consolehttps://ci.nodejs.org/job/node-test-commit-linuxone/9931/nodes=rhel72-s390x/console
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 3, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341799148
Please reload this pagehttps://github.com/nodejs/node/pull/16669
addaleaxhttps://github.com/addaleax
Nov 3, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-9420604
https://github.com/addaleax
src: add method to compute storage in WriteWraphttps://github.com/addaleax/node/commit/9420604073f886f2e8f92193b5533032c901500d
9420604https://github.com/addaleax/node/commit/9420604073f886f2e8f92193b5533032c901500d
nodejs#16669https://github.com/nodejs/node/pull/16669
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 3, 2017 https://github.com/nodejs/node/pull/16669#ref-pullrequest-271094195
src: add method to compute storage in WriteWrap #16727 https://github.com/nodejs/node/pull/16727
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 3, 2017https://github.com/nodejs/node/pull/16669#issuecomment-341804123
#16727https://github.com/nodejs/node/pull/16727
Please reload this pagehttps://github.com/nodejs/node/pull/16669
jasnellhttps://github.com/jasnell
Nov 3, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-a5f3b3a
https://github.com/addaleax
https://github.com/jasnell
src: add method to compute storage in WriteWraphttps://github.com/nodejs/node/commit/a5f3b3a6dab18e32ee5e7d0d79a63cec0d5d5cc5
a5f3b3ahttps://github.com/nodejs/node/commit/a5f3b3a6dab18e32ee5e7d0d79a63cec0d5d5cc5
#16727https://github.com/nodejs/node/pull/16727
#16669https://github.com/nodejs/node/pull/16669
cjihrighttps://github.com/cjihrig
Nov 6, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-e3283c7
https://github.com/jasnell
https://github.com/cjihrig
http2: allocate on every chunk sendhttps://github.com/cjihrig/node/commit/e3283c71ce06d7be2b3581eab3a33107cb955505
e3283c7https://github.com/cjihrig/node/commit/e3283c71ce06d7be2b3581eab3a33107cb955505
nodejs#16669https://github.com/nodejs/node/pull/16669
cjihrighttps://github.com/cjihrig
Nov 6, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-a87f846
https://github.com/addaleax
https://github.com/cjihrig
src: add method to compute storage in WriteWraphttps://github.com/cjihrig/node/commit/a87f846cc1c95a716ec56982fe6ab7f5365a2d79
a87f846https://github.com/cjihrig/node/commit/a87f846cc1c95a716ec56982fe6ab7f5365a2d79
nodejs#16727https://github.com/nodejs/node/pull/16727
nodejs#16669https://github.com/nodejs/node/pull/16669
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 6, 2017 https://github.com/nodejs/node/pull/16669#ref-pullrequest-271654245
v9.1.0 proposal #16851 https://github.com/nodejs/node/pull/16851
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Nov 14, 2017https://github.com/nodejs/node/pull/16669#event-1341385256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Dec 7, 2017https://github.com/nodejs/node/pull/16669#event-1377790865
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-7e663d3
https://github.com/jasnell
https://github.com/MylesBorins
http2: allocate on every chunk sendhttps://github.com/nodejs/node/commit/7e663d30c3a1b7ff239e97cafcfc8b217178045e
7e663d3https://github.com/nodejs/node/commit/7e663d30c3a1b7ff239e97cafcfc8b217178045e
#16669https://github.com/nodejs/node/pull/16669
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-8ffb24b
https://github.com/addaleax
https://github.com/MylesBorins
src: add method to compute storage in WriteWraphttps://github.com/nodejs/node/commit/8ffb24bcf9d4879fc5c3d940b7c0dbb9912b7130
8ffb24bhttps://github.com/nodejs/node/commit/8ffb24bcf9d4879fc5c3d940b7c0dbb9912b7130
#16727https://github.com/nodejs/node/pull/16727
#16669https://github.com/nodejs/node/pull/16669
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 7, 2017 https://github.com/nodejs/node/pull/16669#ref-pullrequest-280275791
v8.9.3 proposal #17532 https://github.com/nodejs/node/pull/17532
MylesBorinshttps://github.com/MylesBorins
Dec 8, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-319beaf
https://github.com/jasnell
https://github.com/MylesBorins
http2: allocate on every chunk sendhttps://github.com/nodejs/node/commit/319beaf45ba977b63f3348873453c7f7f2498847
319beafhttps://github.com/nodejs/node/commit/319beaf45ba977b63f3348873453c7f7f2498847
#16669https://github.com/nodejs/node/pull/16669
MylesBorinshttps://github.com/MylesBorins
Dec 8, 2017 https://github.com/nodejs/node/pull/16669#ref-commit-26b43c8
https://github.com/addaleax
https://github.com/MylesBorins
src: add method to compute storage in WriteWraphttps://github.com/nodejs/node/commit/26b43c87ee268e71d9559add01c297891ec69680
26b43c8https://github.com/nodejs/node/commit/26b43c87ee268e71d9559add01c297891ec69680
#16727https://github.com/nodejs/node/pull/16727
#16669https://github.com/nodejs/node/pull/16669
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16669
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/16669/files/1c6ec13d8027fbba6ff84bf75f55841358bda217
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16669/files/afddd0941c2b3e0ff92e2506fbf97b3a7e7d588c
https://github.com/sebdeckers
sebdeckers https://github.com/sebdeckers
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/16669/files/afddd0941c2b3e0ff92e2506fbf97b3a7e7d588c
https://github.com/XadillaX
XadillaX https://github.com/XadillaX
https://github.com/nodejs/node/pull/16669/files/1c6ec13d8027fbba6ff84bf75f55841358bda217
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/16669
https://github.com/jasnell
https://github.com/apapirovski
https://github.com/richardlau
https://github.com/addaleax
https://github.com/mcollina
https://github.com/XadillaX
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.