René's URL Explorer Experiment


Title: test: fix flaky test-async-wrap-uncaughtexception by Trott · Pull Request #16598 · nodejs/node · GitHub

Open Graph Title: test: fix flaky test-async-wrap-uncaughtexception by Trott · Pull Request #16598 · nodejs/node

X Title: test: fix flaky test-async-wrap-uncaughtexception by Trott · Pull Request #16598 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: It's possible for beforeExit to be emitted more than once if work is scheduled by its listeners. Accommodate this fact in the test. Fixes: #16210 Checklist make -j4 test (UNIX), or vcbuild ...

X Description: It's possible for beforeExit to be emitted more than once if work is scheduled by its listeners. Accommodate this fact in the test. Fixes: #16210 Checklist make -j4 test (UNIX), or vcbu...

Opengraph URL: https://github.com/nodejs/node/pull/16598

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0b429a2b-e3ad-745b-33f3-e3d2b9e2c3d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CE6:23810A:1532FD3:1B4566B:69925FF6
html-safe-noncee64d5cac9de697fa2255873c56b2890eae73eee9a4be510f8974ba72858906a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0U2OjIzODEwQToxNTMyRkQzOjFCNDU2NkI6Njk5MjVGRjYiLCJ2aXNpdG9yX2lkIjoiMTI1MzkwMzkzOTkyMjk3Njc1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac98754bbb28a2ae9fd54641e222063ecdca5d485ae23107058f6b25799d5e48c2
hovercard-subject-tagpull_request:149425888
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16598/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2a86c10472b5b3407fa4e2009b4d8ac050882ae83793dc3df632a7ff6f5473c3/nodejs/node/pull/16598
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2a86c10472b5b3407fa4e2009b4d8ac050882ae83793dc3df632a7ff6f5473c3/nodejs/node/pull/16598
og:image:altIt's possible for beforeExit to be emitted more than once if work is scheduled by its listeners. Accommodate this fact in the test. Fixes: #16210 Checklist make -j4 test (UNIX), or vcbuild ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16598#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16598
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16598
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16598
Reloadhttps://github.com/nodejs/node/pull/16598
Reloadhttps://github.com/nodejs/node/pull/16598
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16598
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 717 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-flaky-async-wraphttps://github.com/Trott/io.js/tree/fix-flaky-async-wrap
Conversationhttps://github.com/nodejs/node/pull/16598
Commits1 (1)https://github.com/nodejs/node/pull/16598/commits
Checkshttps://github.com/nodejs/node/pull/16598/checks
Files changedhttps://github.com/nodejs/node/pull/16598/files
test: fix flaky test-async-wrap-uncaughtexceptionhttps://github.com/nodejs/node/pull/16598#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-flaky-async-wraphttps://github.com/Trott/io.js/tree/fix-flaky-async-wrap
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 30, 2017https://github.com/nodejs/node/pull/16598#issue-269466600
#16210https://github.com/nodejs/node/issues/16210
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/Trott
test: fix flaky test-async-wrap-uncaughtexceptionhttps://github.com/nodejs/node/pull/16598/commits/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
a200dbbhttps://github.com/nodejs/node/pull/16598/commits/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
nodejs#16210https://github.com/nodejs/node/issues/16210
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 30, 2017https://github.com/nodejs/node/pull/16598#event-1315886953
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 30, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340330316
@joaocgreishttps://github.com/joaocgreis
@addaleaxhttps://github.com/addaleax
@joyeecheunghttps://github.com/joyeecheung
#16210https://github.com/nodejs/node/issues/16210
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#ref-issue-265540338
Flaky test-async-wrap-uncaughtexception #16210 https://github.com/nodejs/node/issues/16210
https://github.com/mscdex
mscdexhttps://github.com/mscdex
async_wrap https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_wrap
Oct 30, 2017https://github.com/nodejs/node/pull/16598#event-1315955867
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 30, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340349406
https://ci.nodejs.org/job/node-test-pull-request/11083/https://ci.nodejs.org/job/node-test-pull-request/11083/
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 30, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340349451
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#pullrequestreview-72750416
View reviewed changes https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#pullrequestreview-72757955
View reviewed changes https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#pullrequestreview-72759893
View reviewed changes https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/16598#pullrequestreview-72759893
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#pullrequestreview-72760066
View reviewed changes https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#pullrequestreview-72835022
View reviewed changes https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#ref-pullrequest-266313595
deps: update V8 to 6.3 #16271 https://github.com/nodejs/node/pull/16271
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#pullrequestreview-72983356
View reviewed changes https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/refack
refackhttps://github.com/refack
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
Oct 30, 2017https://github.com/nodejs/node/pull/16598#event-1317576355
https://github.com/refack
refackhttps://github.com/refack
Oct 30, 2017 https://github.com/nodejs/node/pull/16598#pullrequestreview-72985223
View reviewed changes https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/16598#pullrequestreview-72985223
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/refack
refackhttps://github.com/refack
Oct 30, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340584551
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 30, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340585231
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 31, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340665982
@refackhttps://github.com/refack
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340760459
https://ci.nodejs.org/job/node-stress-single-test/1475/nodes=ubuntu1604-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1475/nodes=ubuntu1604-64/console
https://ci.nodejs.org/job/node-stress-single-test/1476/nodes=ubuntu1604-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1476/nodes=ubuntu1604-64/console
https://ci.nodejs.org/job/node-stress-single-test/1477/nodes=ubuntu1604-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1477/nodes=ubuntu1604-64/console
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340762533
Please reload this pagehttps://github.com/nodejs/node/pull/16598
@joyeecheunghttps://github.com/joyeecheung
refack/node@master...refack:pr/16412https://github.com/refack/node/compare/master...refack:pr/16412
https://ci.nodejs.org/job/node-stress-single-test/1478/nodes=ubuntu1604-64/https://ci.nodejs.org/job/node-stress-single-test/1478/nodes=ubuntu1604-64/
https://ci.nodejs.org/job/node-stress-single-test/nodes=ubuntu1604-64/1481/consolehttps://ci.nodejs.org/job/node-stress-single-test/nodes=ubuntu1604-64/1481/console
e567402https://github.com/nodejs/node/commit/e567402aba903f7d828d428f1f5738bbf884636c
https://ci.nodejs.org/job/node-stress-single-test/1482/nodes=ubuntu1604-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1482/nodes=ubuntu1604-64/console
https://ci.nodejs.org/job/node-stress-single-test/1483/nodes=ubuntu1604-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1483/nodes=ubuntu1604-64/console
https://ci.nodejs.org/job/node-stress-single-test/1484/nodes=ubuntu1604-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1484/nodes=ubuntu1604-64/console
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/refack
refackhttps://github.com/refack
Oct 31, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340833140
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 1, 2017https://github.com/nodejs/node/pull/16598#issuecomment-340969856
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 2, 2017https://github.com/nodejs/node/pull/16598#issuecomment-341281261
#16210 (comment)https://github.com/nodejs/node/issues/16210#issuecomment-341281181
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 2, 2017https://github.com/nodejs/node/pull/16598#event-1322082073
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 2, 2017 https://github.com/nodejs/node/pull/16598#ref-pullrequest-270717855
test: fix flaky test-async-wrap-uncaughtexception #16692 https://github.com/nodejs/node/pull/16692
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Nov 2, 2017 https://github.com/nodejs/node/pull/16598#ref-pullrequest-270532162
build: remove cctest extension #16680 https://github.com/nodejs/node/pull/16680
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:47https://github.com/nodejs/node/pull/16598#event-5890955321
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16598
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/16598/files/a200dbbe0671fccb1bcf690e99529f91f7c7cc28
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Flaky test-async-wrap-uncaughtexception https://github.com/nodejs/node/issues/16210
Please reload this pagehttps://github.com/nodejs/node/pull/16598
https://github.com/Trott
https://github.com/refack
https://github.com/addaleax
https://github.com/joyeecheung
https://github.com/apapirovski
https://github.com/danbev
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.