| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3627c0c8-5844-74bc-f15b-bdf96d04df0a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5D2:552A0:29AFE52:3737832:6B034BDC |
| html-safe-nonce | a387f8947a004872c662207275806e26d4401ef8bbda49d4d8fb1652ff7698ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUQyOjU1MkEwOjI5QUZFNTI6MzczNzgzMjo2QjAzNEJEQyIsInZpc2l0b3JfaWQiOiI0NTMwMDA2ODA2MDg4NjAwNTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 969b8f6c14a4c2aad932e7da8f21fb4e3e6dff3a5fcba40b2ff6988ef476ed5a |
| hovercard-subject-tag | pull_request:149379190 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16585/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/15a7ba1fa06596d837649d1fc3dbcb8eb3e90fd2def0a207f7e08bf1affb061c/nodejs/node/pull/16585 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/15a7ba1fa06596d837649d1fc3dbcb8eb3e90fd2def0a207f7e08bf1affb061c/nodejs/node/pull/16585 |
| og:image:alt | #15183
Depends on #16584, which should land first.
https://ci.nodejs.org/job/node-test-pull-request/11069/ |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bnoordhuis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/16585#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16585 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16585 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16585 |
| Reload | https://github.com/nodejs/node/pull/16585 |
| Reload | https://github.com/nodejs/node/pull/16585 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues637 (637) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| https://github.com/nodejs/node |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| bnoordhuis:backport-pr15183-v6.x | https://github.com/bnoordhuis/io.js/tree/backport-pr15183-v6.x |
| Conversation | https://github.com/nodejs/node/pull/16585 |
| Commits4 (4) | https://github.com/nodejs/node/pull/16585/commits |
| Checks | https://github.com/nodejs/node/pull/16585/checks |
| Files changed | https://github.com/nodejs/node/pull/16585/files |
| [v6.x backport] src: turn key length exception into CHECK | https://github.com/nodejs/node/pull/16585#top |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| bnoordhuis:backport-pr15183-v6.x | https://github.com/bnoordhuis/io.js/tree/backport-pr15183-v6.x |
|
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 29, 2017 | https://github.com/nodejs/node/pull/16585#issue-269389428 |
| Please reload this page | https://github.com/nodejs/node/pull/16585 |
| #15183 | https://github.com/nodejs/node/pull/15183 |
| #16584 | https://github.com/nodejs/node/pull/16584 |
| https://ci.nodejs.org/job/node-test-pull-request/11069/ | https://ci.nodejs.org/job/node-test-pull-request/11069/ |
| Please reload this page | https://github.com/nodejs/node/pull/16585 |
| shigeki | https://github.com/shigeki |
| October 29, 2017 11:33 | https://github.com/nodejs/node/pull/16585#commits-pushed-16c08c5 |
|
| https://github.com/shigeki |
|
| https://github.com/bnoordhuis |
| crypto: warn if counter mode used in createCipher | https://github.com/nodejs/node/pull/16585/commits/16c08c5baee61b803aaa8c9f63891f5a439b6315 |
| 16c08c5 | https://github.com/nodejs/node/pull/16585/commits/16c08c5baee61b803aaa8c9f63891f5a439b6315 |
| nodejs#13801 | https://github.com/nodejs/node/issues/13801 |
| nodejs#13821 | https://github.com/nodejs/node/pull/13821 |
|
| https://github.com/bnoordhuis |
| test: add regression test for counter mode warning | https://github.com/nodejs/node/pull/16585/commits/0be25bba09c97688b5852b87b24da3cb22fedf66 |
| 0be25bb | https://github.com/nodejs/node/pull/16585/commits/0be25bba09c97688b5852b87b24da3cb22fedf66 |
| nodejs#13821 | https://github.com/nodejs/node/pull/13821 |
| nodejs#9405 | https://github.com/nodejs/node/pull/9405 |
| nodejs#13821 | https://github.com/nodejs/node/pull/13821 |
| nodejs#9405 | https://github.com/nodejs/node/pull/9405 |
|
| https://github.com/shigeki |
|
| https://github.com/bnoordhuis |
| crypto: fix error of createCipher in wrap mode | https://github.com/nodejs/node/pull/16585/commits/07e141c8285299ea1259186ee5f2900de98fc8cf |
| 07e141c | https://github.com/nodejs/node/pull/16585/commits/07e141c8285299ea1259186ee5f2900de98fc8cf |
| http://openssl.6102.n7.nabble.com/AES-Key-Wrap-in-FIPS-Mode-td50238.html | http://openssl.6102.n7.nabble.com/AES-Key-Wrap-in-FIPS-Mode-td50238.html |
| nodejs#15009 | https://github.com/nodejs/node/issues/15009 |
| nodejs#15037 | https://github.com/nodejs/node/pull/15037 |
|
| https://github.com/bnoordhuis |
| src: turn key length exception into CHECK | https://github.com/nodejs/node/pull/16585/commits/5b1484d299ea810e5664e8a9408afbb900c90c85 |
| 5b1484d | https://github.com/nodejs/node/pull/16585/commits/5b1484d299ea810e5664e8a9408afbb900c90c85 |
| nodejs#15183 | https://github.com/nodejs/node/pull/15183 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x |
| Oct 29, 2017 | https://github.com/nodejs/node/pull/16585#event-1315486744 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/16585#ref-pullrequest-255058042 |
|
src: turn key length exception into CHECK
#15183
| https://github.com/nodejs/node/pull/15183 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 14, 2017
| https://github.com/nodejs/node/pull/16585#ref-commit-8b70ad1 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| src: turn key length exception into CHECK | https://github.com/nodejs/node/commit/8b70ad1932c4d734d2cc6fe43ceec5d40332e635 |
| 8b70ad1 | https://github.com/nodejs/node/commit/8b70ad1932c4d734d2cc6fe43ceec5d40332e635 |
| #16585 | https://github.com/nodejs/node/pull/16585 |
| #15183 | https://github.com/nodejs/node/pull/15183 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/16585#issuecomment-344365848 |
| 8b70ad1 | https://github.com/nodejs/node/commit/8b70ad1932c4d734d2cc6fe43ceec5d40332e635 |
| Please reload this page | https://github.com/nodejs/node/pull/16585 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 14, 2017 | https://github.com/nodejs/node/pull/16585#event-1341563942 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 21, 2017
| https://github.com/nodejs/node/pull/16585#ref-commit-a62f563 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| src: turn key length exception into CHECK | https://github.com/nodejs/node/commit/a62f56358822e8deeb0bdd5ffb9b804e2f4bd8c1 |
| a62f563 | https://github.com/nodejs/node/commit/a62f56358822e8deeb0bdd5ffb9b804e2f4bd8c1 |
| #16585 | https://github.com/nodejs/node/pull/16585 |
| #15183 | https://github.com/nodejs/node/pull/15183 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 28, 2017
| https://github.com/nodejs/node/pull/16585#ref-commit-79171e0 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| src: turn key length exception into CHECK | https://github.com/nodejs/node/commit/79171e0c2f16fff17f5ab7a4899b2be0c2574c17 |
| 79171e0 | https://github.com/nodejs/node/commit/79171e0c2f16fff17f5ab7a4899b2be0c2574c17 |
| #16585 | https://github.com/nodejs/node/pull/16585 |
| #15183 | https://github.com/nodejs/node/pull/15183 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16585 |
| Please reload this page | https://github.com/nodejs/node/pull/16585 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Please reload this page | https://github.com/nodejs/node/pull/16585 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/shigeki |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |