| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b33c4abc-8d89-e738-2999-80d7966fb9bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A618:62524:DC5D3:121CFA:6B036C8F |
| html-safe-nonce | 3c5e29884314672ae76d59b07fdbe0f46509a178e1a2c5f203da9520fd7986c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjE4OjYyNTI0OkRDNUQzOjEyMUNGQTo2QjAzNkM4RiIsInZpc2l0b3JfaWQiOiI3MzE1MTEzODk4NjI0MTE3OTAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 774e7c9208c7f878387f562553bf93a124a4fc7357eafe47aee19191bcf92c0b |
| hovercard-subject-tag | pull_request:149378994 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/16584/files |
| twitter:image | https://avatars.githubusercontent.com/u/275871?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/275871?s=400&v=4 |
| og:image:alt | #15037
Depends on #16583, which should land first.
https://ci.nodejs.org/job/node-test-pull-request/11068/ |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16584/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16584%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16584%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16584/files |
| Reload | https://github.com/nodejs/node/pull/16584/files |
| Reload | https://github.com/nodejs/node/pull/16584/files |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues639 (639) | https://github.com/nodejs/node/issues |
| Pull requests668 (668) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| bnoordhuis:backport-pr15037-v6.x | https://github.com/bnoordhuis/io.js/tree/backport-pr15037-v6.x |
|
Conversation
1
| https://github.com/nodejs/node/pull/16584 |
|
Commits
3
| https://github.com/nodejs/node/pull/16584/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/16584/checks |
|
Files changed
| https://github.com/nodejs/node/pull/16584/files |
| Please reload this page | https://github.com/nodejs/node/pull/16584/files |
|
[v6.x backport] crypto: fix error of createCipher in wrap mode
| https://github.com/nodejs/node/pull/16584/files#top |
|
Show all changes
3 commits
| https://github.com/nodejs/node/pull/16584/files |
|
16c08c5
crypto: warn if counter mode used in createCipher
shigeki Jun 20, 2017
| https://github.com/nodejs/node/pull/16584/commits/16c08c5baee61b803aaa8c9f63891f5a439b6315 |
|
0be25bb
test: add regression test for counter mode warning
bnoordhuis Oct 29, 2017
| https://github.com/nodejs/node/pull/16584/commits/0be25bba09c97688b5852b87b24da3cb22fedf66 |
|
07e141c
crypto: fix error of createCipher in wrap mode
shigeki Aug 24, 2017
| https://github.com/nodejs/node/pull/16584/commits/07e141c8285299ea1259186ee5f2900de98fc8cf |
|
Clear filters
| https://github.com/nodejs/node/pull/16584/files |
| Please reload this page | https://github.com/nodejs/node/pull/16584/files |
| Please reload this page | https://github.com/nodejs/node/pull/16584/files |
|
crypto.md
| https://github.com/nodejs/node/pull/16584/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
|
node_crypto.cc
| https://github.com/nodejs/node/pull/16584/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
|
test-crypto-binary-default.js
| https://github.com/nodejs/node/pull/16584/files#diff-24a43aa57f26b99400c65fab80f5d23ea2fc8735798c140ea599fa1cb1f90e6a |
|
test-crypto-cipher-decipher.js
| https://github.com/nodejs/node/pull/16584/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa |
|
test-crypto-cipheriv-decipheriv.js
| https://github.com/nodejs/node/pull/16584/files#diff-77375f40b12761d3a2a450e63fb6d44546462cb02a9409f26b4b851506cc033f |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/16584/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
|
View file
| https://github.com/bnoordhuis/io.js/blob/07e141c8285299ea1259186ee5f2900de98fc8cf/doc/api/crypto.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/16584/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/16584/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
|
| https://github.com/nodejs/node/pull/16584/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
|
| https://github.com/nodejs/node/pull/16584/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
|
| https://github.com/nodejs/node/pull/16584/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/16584/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
|
View file
| https://github.com/bnoordhuis/io.js/blob/07e141c8285299ea1259186ee5f2900de98fc8cf/src/node_crypto.cc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/16584/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/16584/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
|
| https://github.com/nodejs/node/pull/16584/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
|
| https://github.com/nodejs/node/pull/16584/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
|
| https://github.com/nodejs/node/pull/16584/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| test/parallel/test-crypto-binary-default.js | https://github.com/nodejs/node/pull/16584/files#diff-24a43aa57f26b99400c65fab80f5d23ea2fc8735798c140ea599fa1cb1f90e6a |
|
View file
| https://github.com/bnoordhuis/io.js/blob/07e141c8285299ea1259186ee5f2900de98fc8cf/test/parallel/test-crypto-binary-default.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/16584/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/16584/files#diff-24a43aa57f26b99400c65fab80f5d23ea2fc8735798c140ea599fa1cb1f90e6a |
|
| https://github.com/nodejs/node/pull/16584/files#diff-24a43aa57f26b99400c65fab80f5d23ea2fc8735798c140ea599fa1cb1f90e6a |
| test/parallel/test-crypto-cipher-decipher.js | https://github.com/nodejs/node/pull/16584/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa |
|
View file
| https://github.com/bnoordhuis/io.js/blob/07e141c8285299ea1259186ee5f2900de98fc8cf/test/parallel/test-crypto-cipher-decipher.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/16584/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/16584/files#diff-553dfdec542c8a82c02a3b192cc8b53de78c2e528be8640d52543d7715260afa |
| test/parallel/test-crypto-cipheriv-decipheriv.js | https://github.com/nodejs/node/pull/16584/files#diff-77375f40b12761d3a2a450e63fb6d44546462cb02a9409f26b4b851506cc033f |
|
View file
| https://github.com/bnoordhuis/io.js/blob/07e141c8285299ea1259186ee5f2900de98fc8cf/test/parallel/test-crypto-cipheriv-decipheriv.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/16584/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/16584/files#diff-77375f40b12761d3a2a450e63fb6d44546462cb02a9409f26b4b851506cc033f |
|
| https://github.com/nodejs/node/pull/16584/files#diff-77375f40b12761d3a2a450e63fb6d44546462cb02a9409f26b4b851506cc033f |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |