René's URL Explorer Experiment


Title: [v6.x backport] crypto: warn if counter mode used in createCipher by bnoordhuis · Pull Request #16583 · nodejs/node · GitHub

Open Graph Title: [v6.x backport] crypto: warn if counter mode used in createCipher by bnoordhuis · Pull Request #16583 · nodejs/node

X Title: [v6.x backport] crypto: warn if counter mode used in createCipher by bnoordhuis · Pull Request #16583 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: #13821 https://ci.nodejs.org/job/node-test-pull-request/11067/

X Description: #13821 https://ci.nodejs.org/job/node-test-pull-request/11067/

Opengraph URL: https://github.com/nodejs/node/pull/16583

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5eaae8d4-7a33-6b30-3a57-5d4950d4047d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC190:C707B:58F79C:7115AB:6B035087
html-safe-nonce396879587f6405c9414f175290582ba4301f951f1dbc44dfcfc97bc007e074b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTkwOkM3MDdCOjU4Rjc5Qzo3MTE1QUI6NkIwMzUwODciLCJ2aXNpdG9yX2lkIjoiMjc0MjE4MjM2NjU0MDk0MzQ5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacab40c718c8f5666b81858de708ea0538855c8e0e4b42abc7f158fd9be0382fd0
hovercard-subject-tagpull_request:149378525
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16583/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/22b152af541b51c2b2357739fba22a4adcfb45175d707059a09769acc8e000d7/nodejs/node/pull/16583
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/22b152af541b51c2b2357739fba22a4adcfb45175d707059a09769acc8e000d7/nodejs/node/pull/16583
og:image:alt#13821 https://ci.nodejs.org/job/node-test-pull-request/11067/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16583#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16583
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16583
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16583
Reloadhttps://github.com/nodejs/node/pull/16583
Reloadhttps://github.com/nodejs/node/pull/16583
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
bnoordhuishttps://github.com/bnoordhuis
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
bnoordhuis:backport-pr13821-v6.xhttps://github.com/bnoordhuis/io.js/tree/backport-pr13821-v6.x
Conversationhttps://github.com/nodejs/node/pull/16583
Commits2 (2)https://github.com/nodejs/node/pull/16583/commits
Checkshttps://github.com/nodejs/node/pull/16583/checks
Files changedhttps://github.com/nodejs/node/pull/16583/files
[v6.x backport] crypto: warn if counter mode used in createCipherhttps://github.com/nodejs/node/pull/16583#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
bnoordhuis:backport-pr13821-v6.xhttps://github.com/bnoordhuis/io.js/tree/backport-pr13821-v6.x
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 29, 2017https://github.com/nodejs/node/pull/16583#issue-269388330
Please reload this pagehttps://github.com/nodejs/node/pull/16583
#13821https://github.com/nodejs/node/pull/13821
https://ci.nodejs.org/job/node-test-pull-request/11067/https://ci.nodejs.org/job/node-test-pull-request/11067/
Please reload this pagehttps://github.com/nodejs/node/pull/16583
shigekihttps://github.com/shigeki
October 29, 2017 11:33https://github.com/nodejs/node/pull/16583#commits-pushed-16c08c5
https://github.com/shigeki
https://github.com/bnoordhuis
crypto: warn if counter mode used in createCipherhttps://github.com/nodejs/node/pull/16583/commits/16c08c5baee61b803aaa8c9f63891f5a439b6315
16c08c5https://github.com/nodejs/node/pull/16583/commits/16c08c5baee61b803aaa8c9f63891f5a439b6315
nodejs#13801https://github.com/nodejs/node/issues/13801
nodejs#13821https://github.com/nodejs/node/pull/13821
https://github.com/bnoordhuis
test: add regression test for counter mode warninghttps://github.com/nodejs/node/pull/16583/commits/0be25bba09c97688b5852b87b24da3cb22fedf66
0be25bbhttps://github.com/nodejs/node/pull/16583/commits/0be25bba09c97688b5852b87b24da3cb22fedf66
nodejs#13821https://github.com/nodejs/node/pull/13821
nodejs#9405https://github.com/nodejs/node/pull/9405
nodejs#13821https://github.com/nodejs/node/pull/13821
nodejs#9405https://github.com/nodejs/node/pull/9405
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x
Oct 29, 2017https://github.com/nodejs/node/pull/16583#event-1315482137
crypto: warn if counter mode used in createCipher #13821 https://github.com/nodejs/node/pull/13821
[v6.x backport] crypto: fix error of createCipher in wrap mode #16584 https://github.com/nodejs/node/pull/16584
MylesBorinshttps://github.com/MylesBorins
Nov 14, 2017 https://github.com/nodejs/node/pull/16583#ref-commit-11256f7
https://github.com/shigeki
https://github.com/MylesBorins
crypto: warn if counter mode used in createCipherhttps://github.com/nodejs/node/commit/11256f7b20ae345d8b562103e8792d48d0fdafe9
11256f7https://github.com/nodejs/node/commit/11256f7b20ae345d8b562103e8792d48d0fdafe9
#16583https://github.com/nodejs/node/pull/16583
#13801https://github.com/nodejs/node/issues/13801
#13821https://github.com/nodejs/node/pull/13821
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 14, 2017https://github.com/nodejs/node/pull/16583#issuecomment-344364966
11256f7https://github.com/nodejs/node/commit/11256f7b20ae345d8b562103e8792d48d0fdafe9
Please reload this pagehttps://github.com/nodejs/node/pull/16583
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 14, 2017https://github.com/nodejs/node/pull/16583#event-1341558636
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
November 14, 2017 19:29https://github.com/nodejs/node/pull/16583#event-1341594371
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/16583#ref-commit-eed1b1f
https://github.com/shigeki
https://github.com/MylesBorins
crypto: warn if counter mode used in createCipherhttps://github.com/nodejs/node/commit/eed1b1f171064e3b475658cda24519ab7ad840dc
eed1b1fhttps://github.com/nodejs/node/commit/eed1b1f171064e3b475658cda24519ab7ad840dc
#16583https://github.com/nodejs/node/pull/16583
#13801https://github.com/nodejs/node/issues/13801
#13821https://github.com/nodejs/node/pull/13821
MylesBorinshttps://github.com/MylesBorins
Nov 28, 2017 https://github.com/nodejs/node/pull/16583#ref-commit-7115079
https://github.com/shigeki
https://github.com/MylesBorins
crypto: warn if counter mode used in createCipherhttps://github.com/nodejs/node/commit/7115079c4f1d155895d0294f8af1ff03c2f41622
7115079https://github.com/nodejs/node/commit/7115079c4f1d155895d0294f8af1ff03c2f41622
#16583https://github.com/nodejs/node/pull/16583
#13801https://github.com/nodejs/node/issues/13801
#13821https://github.com/nodejs/node/pull/13821
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16583
Please reload this pagehttps://github.com/nodejs/node/pull/16583
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/16583
https://github.com/bnoordhuis
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com/shigeki
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.