René's URL Explorer Experiment


Title: src: explicitly register built-in modules by yhwang · Pull Request #16565 · nodejs/node · GitHub

Open Graph Title: src: explicitly register built-in modules by yhwang · Pull Request #16565 · nodejs/node

X Title: src: explicitly register built-in modules by yhwang · Pull Request #16565 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously, built-in modules are registered before main() via __attribute__((constructor)) mechanism in GCC and similiar mechanism in MSVC. This causes some issues when node is built as static libr...

X Description: Previously, built-in modules are registered before main() via __attribute__((constructor)) mechanism in GCC and similiar mechanism in MSVC. This causes some issues when node is built as static libr...

Mail addresses
yh.wang@ibm.com

Opengraph URL: https://github.com/nodejs/node/pull/16565

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:685d6d1e-ea56-40aa-331a-64d60c4f11d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB98C:1A4B81:2CADD35:3957BE7:69913505
html-safe-noncee889d4aa9a72c28f6acdfa1c0feae3585e3648393e4ac280fef0da6bf2d5fe75
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOThDOjFBNEI4MToyQ0FERDM1OjM5NTdCRTc6Njk5MTM1MDUiLCJ2aXNpdG9yX2lkIjoiNjI3MDI1OTA0OTY3NTE3NTE3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9c7251ec30e74623e0ded4a9c3f72f077b692eba8e2212a32a43e4f2d1e7020b
hovercard-subject-tagpull_request:149287102
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16565/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/50a8e59d1ecb677e54cb641e63f605178258e5b651f7bb740871901ae3ba0255/nodejs/node/pull/16565
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50a8e59d1ecb677e54cb641e63f605178258e5b651f7bb740871901ae3ba0255/nodejs/node/pull/16565
og:image:altPreviously, built-in modules are registered before main() via __attribute__((constructor)) mechanism in GCC and similiar mechanism in MSVC. This causes some issues when node is built as static libr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyhwang
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16565#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16565
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16565
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16565
Reloadhttps://github.com/nodejs/node/pull/16565
Reloadhttps://github.com/nodejs/node/pull/16565
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16565
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 710 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
yhwanghttps://github.com/yhwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
yhwang:remove-attr-constructorhttps://github.com/yhwang/node/tree/remove-attr-constructor
Conversationhttps://github.com/nodejs/node/pull/16565
Commits1 (1)https://github.com/nodejs/node/pull/16565/commits
Checkshttps://github.com/nodejs/node/pull/16565/checks
Files changedhttps://github.com/nodejs/node/pull/16565/files
src: explicitly register built-in moduleshttps://github.com/nodejs/node/pull/16565#top
yhwanghttps://github.com/yhwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
yhwang:remove-attr-constructorhttps://github.com/yhwang/node/tree/remove-attr-constructor
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Oct 27, 2017https://github.com/nodejs/node/pull/16565#issue-269236622
Please reload this pagehttps://github.com/nodejs/node/pull/16565
#14986 (comment)https://github.com/nodejs/node/pull/14986#issuecomment-332758206
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Oct 27, 2017https://github.com/nodejs/node/pull/16565#event-1314700979
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 27, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72634040
View reviewed changes https://github.com/nodejs/node/pull/16565/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/16565#pullrequestreview-72634040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node.hhttps://github.com/nodejs/node/pull/16565/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
addaleaxhttps://github.com/addaleax
Oct 27, 2017https://github.com/nodejs/node/pull/16565#discussion_r147519843
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node.hhttps://github.com/nodejs/node/pull/16565/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
addaleaxhttps://github.com/addaleax
Oct 27, 2017https://github.com/nodejs/node/pull/16565#discussion_r147519978
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node.hhttps://github.com/nodejs/node/pull/16565/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
addaleaxhttps://github.com/addaleax
Oct 27, 2017https://github.com/nodejs/node/pull/16565#discussion_r147520002
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node.hhttps://github.com/nodejs/node/pull/16565/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
addaleaxhttps://github.com/addaleax
Oct 27, 2017https://github.com/nodejs/node/pull/16565#discussion_r147520065
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
yhwanghttps://github.com/yhwang
Oct 27, 2017https://github.com/nodejs/node/pull/16565#discussion_r147521724
Please reload this pagehttps://github.com/nodejs/node/pull/16565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
bnoordhuishttps://github.com/bnoordhuis
October 27, 2017 21:27https://github.com/nodejs/node/pull/16565#event-1314726101
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Oct 27, 2017https://github.com/nodejs/node/pull/16565#event-1314744497
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/1616f7a037a8a992916a3638a92b089a5a543c8d..5d48b6874cecade3fd1e39bcc66d8d8b2ac89337
1616f7ahttps://github.com/nodejs/node/commit/1616f7a037a8a992916a3638a92b089a5a543c8d
5d48b68https://github.com/nodejs/node/commit/5d48b6874cecade3fd1e39bcc66d8d8b2ac89337
Compare https://github.com/nodejs/node/compare/1616f7a037a8a992916a3638a92b089a5a543c8d..5d48b6874cecade3fd1e39bcc66d8d8b2ac89337
October 27, 2017 22:34https://github.com/nodejs/node/pull/16565#event-1314824910
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Oct 27, 2017https://github.com/nodejs/node/pull/16565#issuecomment-340113043
Please reload this pagehttps://github.com/nodejs/node/pull/16565
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Oct 28, 2017https://github.com/nodejs/node/pull/16565#event-1314937465
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 28, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72660427
View reviewed changes https://github.com/nodejs/node/pull/16565/files
src/node.hhttps://github.com/nodejs/node/pull/16565/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
Fishrock123https://github.com/Fishrock123
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147543427
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
addaleaxhttps://github.com/addaleax
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147552726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Oct 28, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72665027
View reviewed changes https://github.com/nodejs/node/pull/16565/files
gireeshpunathilhttps://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/16565#pullrequestreview-72665027
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 28, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72669907
View reviewed changes https://github.com/nodejs/node/pull/16565/files
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
addaleaxhttps://github.com/addaleax
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147552697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
yhwanghttps://github.com/yhwang
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147557674
Please reload this pagehttps://github.com/nodejs/node/pull/16565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/16565
addaleaxhttps://github.com/addaleax
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147557939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@yhwanghttps://github.com/yhwang
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 28, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72675452
View reviewed changes https://github.com/nodejs/node/pull/16565/files
src/node.cchttps://github.com/nodejs/node/pull/16565/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
bnoordhuishttps://github.com/bnoordhuis
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147558139
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
bnoordhuishttps://github.com/bnoordhuis
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147558201
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
bnoordhuishttps://github.com/bnoordhuis
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147558544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
bnoordhuishttps://github.com/bnoordhuis
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147558562
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
bnoordhuishttps://github.com/bnoordhuis
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147558610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node.cchttps://github.com/nodejs/node/pull/16565/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
bnoordhuishttps://github.com/bnoordhuis
Oct 28, 2017https://github.com/nodejs/node/pull/16565#discussion_r147558770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/5762a406eb5b4142f55208967d6d1dd9acc7bc7c..5c33fe40971c53dc7d0d47cb3a99e7ab43261877
5762a40https://github.com/nodejs/node/commit/5762a406eb5b4142f55208967d6d1dd9acc7bc7c
5c33fe4https://github.com/nodejs/node/commit/5c33fe40971c53dc7d0d47cb3a99e7ab43261877
Compare https://github.com/nodejs/node/compare/5762a406eb5b4142f55208967d6d1dd9acc7bc7c..5c33fe40971c53dc7d0d47cb3a99e7ab43261877
October 29, 2017 07:23https://github.com/nodejs/node/pull/16565#event-1315431614
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Oct 29, 2017https://github.com/nodejs/node/pull/16565#issuecomment-340242796
@bnoordhuishttps://github.com/bnoordhuis
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 29, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72691408
View reviewed changes https://github.com/nodejs/node/pull/16565/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/16565#pullrequestreview-72691408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
bnoordhuishttps://github.com/bnoordhuis
Oct 29, 2017https://github.com/nodejs/node/pull/16565#discussion_r147574661
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
bnoordhuishttps://github.com/bnoordhuis
Oct 29, 2017https://github.com/nodejs/node/pull/16565#discussion_r147574696
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
yhwanghttps://github.com/yhwang
Oct 29, 2017https://github.com/nodejs/node/pull/16565#discussion_r147587556
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72703050
View reviewed changes https://github.com/nodejs/node/pull/16565/files
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/5c33fe40971c53dc7d0d47cb3a99e7ab43261877..9d5676bacb8713036aea3828d2c423e4153c3d6f
5c33fe4https://github.com/nodejs/node/commit/5c33fe40971c53dc7d0d47cb3a99e7ab43261877
9d5676bhttps://github.com/nodejs/node/commit/9d5676bacb8713036aea3828d2c423e4153c3d6f
Compare https://github.com/nodejs/node/compare/5c33fe40971c53dc7d0d47cb3a99e7ab43261877..9d5676bacb8713036aea3828d2c423e4153c3d6f
October 29, 2017 17:06https://github.com/nodejs/node/pull/16565#event-1315608412
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 29, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72710786
View reviewed changes https://github.com/nodejs/node/pull/16565/files
src/node_internals.hhttps://github.com/nodejs/node/pull/16565/files#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
TimothyGuhttps://github.com/TimothyGu
Oct 29, 2017https://github.com/nodejs/node/pull/16565#discussion_r147595129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
test/cctest/node_module_reg.cchttps://github.com/nodejs/node/pull/16565/files#diff-e4fcdad0a1d72bcb5eb7b5dcf62efa69fca65104f40fa234494e9a78d6f6dbf0
TimothyGuhttps://github.com/TimothyGu
Oct 29, 2017https://github.com/nodejs/node/pull/16565#discussion_r147595133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
yhwanghttps://github.com/yhwang
Oct 30, 2017https://github.com/nodejs/node/pull/16565#discussion_r147609111
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/6c15dbda5af0cffd62b2ead593a7a48321aa5d59..5d4200a5cc7b0cff93228990fceb9a13c02665e4
6c15dbdhttps://github.com/nodejs/node/commit/6c15dbda5af0cffd62b2ead593a7a48321aa5d59
5d4200ahttps://github.com/nodejs/node/commit/5d4200a5cc7b0cff93228990fceb9a13c02665e4
Compare https://github.com/nodejs/node/compare/6c15dbda5af0cffd62b2ead593a7a48321aa5d59..5d4200a5cc7b0cff93228990fceb9a13c02665e4
October 30, 2017 02:43https://github.com/nodejs/node/pull/16565#event-1315883821
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 30, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-72862132
View reviewed changes https://github.com/nodejs/node/pull/16565/files
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/d9b54381160fbf15a4a7f448a9dad8e926ee2388..d0f06d38844d1d9ef5025f4db64d3d7a86921c79
d9b5438https://github.com/nodejs/node/commit/d9b54381160fbf15a4a7f448a9dad8e926ee2388
d0f06d3https://github.com/nodejs/node/commit/d0f06d38844d1d9ef5025f4db64d3d7a86921c79
Compare https://github.com/nodejs/node/compare/d9b54381160fbf15a4a7f448a9dad8e926ee2388..d0f06d38844d1d9ef5025f4db64d3d7a86921c79
October 31, 2017 19:03https://github.com/nodejs/node/pull/16565#event-1319513104
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Oct 31, 2017https://github.com/nodejs/node/pull/16565#issuecomment-340874569
Please reload this pagehttps://github.com/nodejs/node/pull/16565
@Fishrock123https://github.com/Fishrock123
@addaleaxhttps://github.com/addaleax
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/d0f06d38844d1d9ef5025f4db64d3d7a86921c79..074e201697871e204726c8cb4e838231dcc3a836
d0f06d3https://github.com/nodejs/node/commit/d0f06d38844d1d9ef5025f4db64d3d7a86921c79
074e201https://github.com/nodejs/node/commit/074e201697871e204726c8cb4e838231dcc3a836
Compare https://github.com/nodejs/node/compare/d0f06d38844d1d9ef5025f4db64d3d7a86921c79..074e201697871e204726c8cb4e838231dcc3a836
October 31, 2017 22:04https://github.com/nodejs/node/pull/16565#event-1319813301
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 1, 2017 https://github.com/nodejs/node/pull/16565#pullrequestreview-73597992
View reviewed changes https://github.com/nodejs/node/pull/16565/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/16565#pullrequestreview-73597992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.nodejs.org/job/node-test-pull-request/11133/https://ci.nodejs.org/job/node-test-pull-request/11133/
Please reload this pagehttps://github.com/nodejs/node/pull/16565
src/node_v8.cchttps://github.com/nodejs/node/pull/16565/files#diff-b31178bc5d9c07672e946e9dc0b52d163fa8e24220f6f4d2157eac2578c7041b
bnoordhuishttps://github.com/bnoordhuis
Nov 1, 2017https://github.com/nodejs/node/pull/16565#discussion_r148366503
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
yhwanghttps://github.com/yhwang
Nov 1, 2017https://github.com/nodejs/node/pull/16565#discussion_r148377129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Nov 1, 2017https://github.com/nodejs/node/pull/16565#issuecomment-341235157
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Dec 12, 2017https://github.com/nodejs/node/pull/16565#issuecomment-350901856
Please reload this pagehttps://github.com/nodejs/node/pull/16565
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16565#ref-commit-a37dce4
https://github.com/yhwang
https://github.com/MylesBorins
src: explicitly register built-in moduleshttps://github.com/nodejs/node/commit/a37dce40d832b377aa46954a3b3401f0ec8b6bce
a37dce4https://github.com/nodejs/node/commit/a37dce40d832b377aa46954a3b3401f0ec8b6bce
#14986 (comment)https://github.com/nodejs/node/pull/14986#issuecomment-332758206
#17625https://github.com/nodejs/node/pull/17625
#16565https://github.com/nodejs/node/pull/16565
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backported-to-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v9.x
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Dec 12, 2017https://github.com/nodejs/node/pull/16565#event-1382902843
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16565#ref-commit-9c7a42a
https://github.com/yhwang
https://github.com/MylesBorins
src: explicitly register built-in moduleshttps://github.com/nodejs/node/commit/9c7a42a2e48e6dbcda7ce15bcf3988f3c4f0b23f
9c7a42ahttps://github.com/nodejs/node/commit/9c7a42a2e48e6dbcda7ce15bcf3988f3c4f0b23f
#14986 (comment)https://github.com/nodejs/node/pull/14986#issuecomment-332758206
#17625https://github.com/nodejs/node/pull/17625
#16565https://github.com/nodejs/node/pull/16565
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 12, 2017 https://github.com/nodejs/node/pull/16565#ref-pullrequest-281312309
v9.3.0 proposal #17631 https://github.com/nodejs/node/pull/17631
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 19, 2017https://github.com/nodejs/node/pull/16565#event-1395122045
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 19, 2017 https://github.com/nodejs/node/pull/16565#ref-pullrequest-274536887
src: use NODE_BUILTIN_MODULE_CONTEXT_AWARE() macro #17071 https://github.com/nodejs/node/pull/17071
deepak1556https://github.com/deepak1556
Jan 5, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-699fb9a
https://github.com/deepak1556
REVIEW: Explicitly register builtin moduleshttps://github.com/electron/electron/commit/699fb9af075d94e5bc2185472ead417a50df31f4
699fb9ahttps://github.com/electron/electron/commit/699fb9af075d94e5bc2185472ead417a50df31f4
nodejs/node#16565https://github.com/nodejs/node/pull/16565
codebyterehttps://github.com/codebytere
Jan 5, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-13577c6
https://github.com/deepak1556
https://github.com/codebytere
REVIEW: Explicitly register builtin moduleshttps://github.com/electron/electron/commit/13577c6c237dd5ca89dd955f143de2f112c2f2c1
13577c6https://github.com/electron/electron/commit/13577c6c237dd5ca89dd955f143de2f112c2f2c1
nodejs/node#16565https://github.com/nodejs/node/pull/16565
codebyterehttps://github.com/codebytere
Jan 6, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-bf5ecaf
https://github.com/codebytere
Upgrade to node v9.3.0 (https://github.com/electron/electron/commit/bf5ecaf3e37a5c8d75e0f777f9abfc478ec3ed9c
#11507https://github.com/electron/electron/pull/11507
)https://github.com/electron/electron/commit/bf5ecaf3e37a5c8d75e0f777f9abfc478ec3ed9c
bf5ecafhttps://github.com/electron/electron/commit/bf5ecaf3e37a5c8d75e0f777f9abfc478ec3ed9c
nodejs/node#16565https://github.com/nodejs/node/pull/16565
nodejs/node#17085https://github.com/nodejs/node/pull/17085
nodejs/node#15538https://github.com/nodejs/node/pull/15538
nodejs/node#16700https://github.com/nodejs/node/pull/16700
Semver Minor Tracking nodejs/Release#298 https://github.com/nodejs/Release/issues/298
Backport async hooks to v8.x #18179 https://github.com/nodejs/node/pull/18179
gibfahnhttps://github.com/gibfahn
Jan 17, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-5d03e0c
https://github.com/yhwang
https://github.com/gibfahn
src: explicitly register built-in moduleshttps://github.com/gibfahn/node/commit/5d03e0c78963111ad6e248e211ee9b0b7cf0054d
5d03e0chttps://github.com/gibfahn/node/commit/5d03e0c78963111ad6e248e211ee9b0b7cf0054d
nodejs#16565https://github.com/nodejs/node/pull/16565
nodejs#18179https://github.com/nodejs/node/pull/18179
nodejs#14986 (comment)https://github.com/nodejs/node/pull/14986#issuecomment-332758206
MylesBorinshttps://github.com/MylesBorins
Jan 19, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-e71beba
https://github.com/yhwang
https://github.com/MylesBorins
src: explicitly register built-in moduleshttps://github.com/nodejs/node/commit/e71beba14f1545a15aa9f12ed73c0e00d22e0049
e71bebahttps://github.com/nodejs/node/commit/e71beba14f1545a15aa9f12ed73c0e00d22e0049
#18179https://github.com/nodejs/node/pull/18179
#16565https://github.com/nodejs/node/pull/16565
#14986 (comment)https://github.com/nodejs/node/pull/14986#issuecomment-332758206
zcbenzhttps://github.com/zcbenz
Jan 31, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-77ec7e3
https://github.com/codebytere
https://github.com/zcbenz
Upgrade to node v9.3.0 (https://github.com/electron/electron/commit/77ec7e3df5c3e8c58bfe8d4ef2081a982cf9da37
#11507https://github.com/electron/electron/pull/11507
)https://github.com/electron/electron/commit/77ec7e3df5c3e8c58bfe8d4ef2081a982cf9da37
77ec7e3https://github.com/electron/electron/commit/77ec7e3df5c3e8c58bfe8d4ef2081a982cf9da37
nodejs/node#16565https://github.com/nodejs/node/pull/16565
nodejs/node#17085https://github.com/nodejs/node/pull/17085
nodejs/node#15538https://github.com/nodejs/node/pull/15538
nodejs/node#16700https://github.com/nodejs/node/pull/16700
alexeykuzminhttps://github.com/alexeykuzmin
Feb 21, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-577b71a
https://github.com/codebytere
https://github.com/alexeykuzmin
Upgrade to node v9.3.0 (https://github.com/electron/electron/commit/577b71a9e22a1c9282c5407f4286c7bc23c35f07
#11507https://github.com/electron/electron/pull/11507
)https://github.com/electron/electron/commit/577b71a9e22a1c9282c5407f4286c7bc23c35f07
577b71ahttps://github.com/electron/electron/commit/577b71a9e22a1c9282c5407f4286c7bc23c35f07
nodejs/node#16565https://github.com/nodejs/node/pull/16565
nodejs/node#17085https://github.com/nodejs/node/pull/17085
nodejs/node#15538https://github.com/nodejs/node/pull/15538
nodejs/node#16700https://github.com/nodejs/node/pull/16700
alexeykuzminhttps://github.com/alexeykuzmin
Feb 22, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-5624070
https://github.com/codebytere
https://github.com/alexeykuzmin
Upgrade to node v9.3.0 (https://github.com/electron/electron/commit/56240704f211f1830846fd5765d7f5bef2a1028a
#11507https://github.com/electron/electron/pull/11507
)https://github.com/electron/electron/commit/56240704f211f1830846fd5765d7f5bef2a1028a
5624070https://github.com/electron/electron/commit/56240704f211f1830846fd5765d7f5bef2a1028a
nodejs/node#16565https://github.com/nodejs/node/pull/16565
nodejs/node#17085https://github.com/nodejs/node/pull/17085
nodejs/node#15538https://github.com/nodejs/node/pull/15538
nodejs/node#16700https://github.com/nodejs/node/pull/16700
zcbenzhttps://github.com/zcbenz
Feb 23, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-6c2f7e5
https://github.com/codebytere
https://github.com/zcbenz
Upgrade to node v9.3.0 (https://github.com/electron/electron/commit/6c2f7e524f65f3c6851860495a0dd6bde03a1522
#11507https://github.com/electron/electron/pull/11507
)https://github.com/electron/electron/commit/6c2f7e524f65f3c6851860495a0dd6bde03a1522
6c2f7e5https://github.com/electron/electron/commit/6c2f7e524f65f3c6851860495a0dd6bde03a1522
nodejs/node#16565https://github.com/nodejs/node/pull/16565
nodejs/node#17085https://github.com/nodejs/node/pull/17085
nodejs/node#15538https://github.com/nodejs/node/pull/15538
nodejs/node#16700https://github.com/nodejs/node/pull/16700
zcbenzhttps://github.com/zcbenz
Feb 23, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-0e5b6f9
https://github.com/codebytere
https://github.com/zcbenz
Upgrade to node v9.3.0 (https://github.com/electron/electron/commit/0e5b6f93000e4718c9e35332ddbd0f6b76cdd585
#11507https://github.com/electron/electron/pull/11507
)https://github.com/electron/electron/commit/0e5b6f93000e4718c9e35332ddbd0f6b76cdd585
0e5b6f9https://github.com/electron/electron/commit/0e5b6f93000e4718c9e35332ddbd0f6b76cdd585
nodejs/node#16565https://github.com/nodejs/node/pull/16565
nodejs/node#17085https://github.com/nodejs/node/pull/17085
nodejs/node#15538https://github.com/nodejs/node/pull/15538
nodejs/node#16700https://github.com/nodejs/node/pull/16700
sethluhttps://github.com/sethlu
May 3, 2018 https://github.com/nodejs/node/pull/16565#ref-commit-c9a057c
https://github.com/codebytere
https://github.com/sethlu
Upgrade to node v9.3.0 (https://github.com/sethlu/electron/commit/c9a057c5410079b0895022da3cc8d322c1594f40
electron#11507https://github.com/electron/electron/pull/11507
)https://github.com/sethlu/electron/commit/c9a057c5410079b0895022da3cc8d322c1594f40
c9a057chttps://github.com/sethlu/electron/commit/c9a057c5410079b0895022da3cc8d322c1594f40
nodejs/node#16565https://github.com/nodejs/node/pull/16565
nodejs/node#17085https://github.com/nodejs/node/pull/17085
nodejs/node#15538https://github.com/nodejs/node/pull/15538
nodejs/node#16700https://github.com/nodejs/node/pull/16700
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backported-to-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v8.x
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Aug 17, 2018https://github.com/nodejs/node/pull/16565#event-1795374535
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
Mar 6, 2019 https://github.com/nodejs/node/pull/16565#ref-pullrequest-417889334
refactor: load electron builtin modules with process._linkedBinding electron/electron#17247 https://github.com/electron/electron/pull/17247
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16565
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16565/files/5d48b6874cecade3fd1e39bcc66d8d8b2ac89337
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/16565/files/074e201697871e204726c8cb4e838231dcc3a836
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16565/files/5c33fe40971c53dc7d0d47cb3a99e7ab43261877
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/16565/files/5d4200a5cc7b0cff93228990fceb9a13c02665e4
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/16565/files/5d48b6874cecade3fd1e39bcc66d8d8b2ac89337
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/16565/files/5d48b6874cecade3fd1e39bcc66d8d8b2ac89337
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/16565/files/9d5676bacb8713036aea3828d2c423e4153c3d6f
https://github.com/gibfahn
gibfahn https://github.com/gibfahn
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/16565
https://github.com/yhwang
https://github.com/mhdawson
https://github.com/gibfahn
https://github.com/MylesBorins
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com/Fishrock123
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.