René's URL Explorer Experiment


Title: repl: runtime deprecate NODE_REPL_HISTORY_FILE by maclover7 · Pull Request #16505 · nodejs/node · GitHub

Open Graph Title: repl: runtime deprecate NODE_REPL_HISTORY_FILE by maclover7 · Pull Request #16505 · nodejs/node

X Title: repl: runtime deprecate NODE_REPL_HISTORY_FILE by maclover7 · Pull Request #16505 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: #13876 Just a note that I've been trying to add tests for this, but it's been difficult because it seems like most REPL tests directly patch into internals, and are not run via a chil...

X Description: Refs: #13876 Just a note that I've been trying to add tests for this, but it's been difficult because it seems like most REPL tests directly patch into internals, and are not run vi...

Opengraph URL: https://github.com/nodejs/node/pull/16505

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:25e91ff8-8deb-2d2d-9d4a-2f976f3b61df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC646:1525EF:8041F7:AA2074:6A517D8F
html-safe-nonce8ce1f4584016370f42e1165461ba2490e8cb39d1a91c524cd37f528fcd1312f8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjQ2OjE1MjVFRjo4MDQxRjc6QUEyMDc0OjZBNTE3RDhGIiwidmlzaXRvcl9pZCI6IjU0NTA1NDY2OTAyMzU3NTQzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8aef93c1802764098097830a6f92dd69c9753d5c7244a985165471f5d9e96eee
hovercard-subject-tagpull_request:148800576
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16505/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a63b31c093453703238996f89038348492585cbf537b042cc127cb74c3328df1/nodejs/node/pull/16505
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a63b31c093453703238996f89038348492585cbf537b042cc127cb74c3328df1/nodejs/node/pull/16505
og:image:altRefs: #13876 Just a note that I've been trying to add tests for this, but it's been difficult because it seems like most REPL tests directly patch into internals, and are not run via a chil...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaclover7
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released01c62704ef24df49056c63892a149b775e1353d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16505#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16505
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16505
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16505
Reloadhttps://github.com/nodejs/node/pull/16505
Reloadhttps://github.com/nodejs/node/pull/16505
Please reload this pagehttps://github.com/nodejs/node/pull/16505
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16505
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 981 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
maclover7https://github.com/maclover7
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/16505
Commits6 (6)https://github.com/nodejs/node/pull/16505/commits
Checkshttps://github.com/nodejs/node/pull/16505/checks
Files changedhttps://github.com/nodejs/node/pull/16505/files
repl: runtime deprecate NODE_REPL_HISTORY_FILEhttps://github.com/nodejs/node/pull/16505#top
maclover7https://github.com/maclover7
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/maclover7
maclover7https://github.com/maclover7
Oct 25, 2017https://github.com/nodejs/node/pull/16505#issue-268576635
#13876https://github.com/nodejs/node/pull/13876
@jasnellhttps://github.com/jasnell
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Oct 25, 2017https://github.com/nodejs/node/pull/16505#event-1310913421
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 26, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-72251214
View reviewed changes https://github.com/nodejs/node/pull/16505/files
lib/internal/repl.jshttps://github.com/nodejs/node/pull/16505/files#diff-9cd07c7ad9c46c7c8d814cbc516c17c695e3b27747c13e6afa7fba33a4d11bb0
lpincahttps://github.com/lpinca
Oct 26, 2017https://github.com/nodejs/node/pull/16505#discussion_r147190610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
maclover7https://github.com/maclover7
Oct 26, 2017https://github.com/nodejs/node/pull/16505#discussion_r147267860
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/lance
lancehttps://github.com/lance
Nov 3, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-74103443
View reviewed changes https://github.com/nodejs/node/pull/16505/files
lib/internal/repl.jshttps://github.com/nodejs/node/pull/16505/files#diff-9cd07c7ad9c46c7c8d814cbc516c17c695e3b27747c13e6afa7fba33a4d11bb0
lancehttps://github.com/lance
Nov 3, 2017https://github.com/nodejs/node/pull/16505#discussion_r148802545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
maclover7https://github.com/maclover7
Nov 23, 2017https://github.com/nodejs/node/pull/16505#discussion_r152821176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
addaleaxhttps://github.com/addaleax
Nov 30, 2017https://github.com/nodejs/node/pull/16505#discussion_r154140695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lancehttps://github.com/lance
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/16505
lancehttps://github.com/lance
Nov 30, 2017https://github.com/nodejs/node/pull/16505#discussion_r154145673
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 23, 2017https://github.com/nodejs/node/pull/16505#issuecomment-346599946
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/lance
lancehttps://github.com/lance
Nov 30, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-80264392
View reviewed changes https://github.com/nodejs/node/pull/16505/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 30, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-80300970
View reviewed changes https://github.com/nodejs/node/pull/16505/files
https://github.com/maclover7
maclover7https://github.com/maclover7
Nov 30, 2017https://github.com/nodejs/node/pull/16505#issuecomment-348333020
https://ci.nodejs.org/job/node-test-pull-request/11827/https://ci.nodejs.org/job/node-test-pull-request/11827/
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/maclover7
maclover7https://github.com/maclover7
Nov 30, 2017https://github.com/nodejs/node/pull/16505#issuecomment-348350487
https://ci.nodejs.org/job/node-test-pull-request/11829/https://ci.nodejs.org/job/node-test-pull-request/11829/
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 4, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-80734949
View reviewed changes https://github.com/nodejs/node/pull/16505/files
lib/internal/repl.jshttps://github.com/nodejs/node/pull/16505/files#diff-9cd07c7ad9c46c7c8d814cbc516c17c695e3b27747c13e6afa7fba33a4d11bb0
Trotthttps://github.com/Trott
Dec 4, 2017https://github.com/nodejs/node/pull/16505#discussion_r154556555
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 4, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-80734970
View reviewed changes https://github.com/nodejs/node/pull/16505/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/16505#pullrequestreview-80734970
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/Trott
Trotthttps://github.com/Trott
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Dec 4, 2017https://github.com/nodejs/node/pull/16505#event-1369722512
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 4, 2017https://github.com/nodejs/node/pull/16505#issuecomment-348856239
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 4, 2017https://github.com/nodejs/node/pull/16505#issuecomment-348856271
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/targos
targoshttps://github.com/targos
Dec 4, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-80775002
View reviewed changes https://github.com/nodejs/node/pull/16505/files
https://github.com/targos
targoshttps://github.com/targos
Dec 4, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-80775279
View reviewed changes https://github.com/nodejs/node/pull/16505/files
lib/internal/repl.jshttps://github.com/nodejs/node/pull/16505/files#diff-9cd07c7ad9c46c7c8d814cbc516c17c695e3b27747c13e6afa7fba33a4d11bb0
targoshttps://github.com/targos
Dec 4, 2017https://github.com/nodejs/node/pull/16505#discussion_r154592536
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 4, 2017https://github.com/nodejs/node/pull/16505#issuecomment-348989166
@targoshttps://github.com/targos
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/targos
targoshttps://github.com/targos
Dec 4, 2017 https://github.com/nodejs/node/pull/16505#pullrequestreview-80877026
View reviewed changes https://github.com/nodejs/node/pull/16505/files
lib/internal/repl.jshttps://github.com/nodejs/node/pull/16505/files#diff-9cd07c7ad9c46c7c8d814cbc516c17c695e3b27747c13e6afa7fba33a4d11bb0
targoshttps://github.com/targos
Dec 4, 2017https://github.com/nodejs/node/pull/16505#discussion_r154679345
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 4, 2017https://github.com/nodejs/node/pull/16505#issuecomment-349096224
@targoshttps://github.com/targos
https://ci.nodejs.org/job/node-test-pull-request/11871/https://ci.nodejs.org/job/node-test-pull-request/11871/
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 6, 2017https://github.com/nodejs/node/pull/16505#issuecomment-349494764
https://ci.nodejs.org/job/node-test-binary-windows/13342/COMPILED_BY=vcbt2015,RUNNER=win10,RUN_SUBSET=1/consolehttps://ci.nodejs.org/job/node-test-binary-windows/13342/COMPILED_BY=vcbt2015,RUNNER=win10,RUN_SUBSET=1/console
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
b7405abhttps://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117
7f086ddhttps://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728
Compare https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
December 8, 2017 16:37https://github.com/nodejs/node/pull/16505#event-1379145269
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 11, 2017https://github.com/nodejs/node/pull/16505#issuecomment-350875822
per the TAP extended resultshttps://ci.nodejs.org/job/node-test-binary-windows/13342/COMPILED_BY=vcbt2015,RUNNER=win10,RUN_SUBSET=1/tapResults/
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 28, 2017https://github.com/nodejs/node/pull/16505#issuecomment-354375210
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/bzoz
bzozhttps://github.com/bzoz
Dec 29, 2017https://github.com/nodejs/node/pull/16505#issuecomment-354457809
https://github.com/maclover7/node/blob/2476814b0a315655d3eac33cd6eb6f4a710a9510/test/parallel/test-repl-persistent-history.js#L130-L134https://github.com/maclover7/node/blob/2476814b0a315655d3eac33cd6eb6f4a710a9510/test/parallel/test-repl-persistent-history.js#L130-L134
https://github.com/maclover7/node/blob/2476814b0a315655d3eac33cd6eb6f4a710a9510/test/parallel/test-repl-persistent-history.js#L177-L183https://github.com/maclover7/node/blob/2476814b0a315655d3eac33cd6eb6f4a710a9510/test/parallel/test-repl-persistent-history.js#L177-L183
Please reload this pagehttps://github.com/nodejs/node/pull/16505
maclover7https://github.com/maclover7
January 1, 2018 20:25https://github.com/nodejs/node/pull/16505#commits-pushed-ad7c486
https://github.com/maclover7
repl: runtime deprecate NODE_REPL_HISTORY_FILEhttps://github.com/nodejs/node/pull/16505/commits/ad7c486ece800b8e4d7a083c65b931a247a7121e
ad7c486https://github.com/nodejs/node/pull/16505/commits/ad7c486ece800b8e4d7a083c65b931a247a7121e
#13876https://github.com/nodejs/node/pull/13876
https://github.com/maclover7
[squash] move dep to separate function, add testshttps://github.com/nodejs/node/pull/16505/commits/a13300080e74da20bcde55e2378c2a4d942c15d7
a133000https://github.com/nodejs/node/pull/16505/commits/a13300080e74da20bcde55e2378c2a4d942c15d7
https://github.com/maclover7
fix lint errorhttps://github.com/nodejs/node/pull/16505/commits/4f3c85a4d5dcae7c1b7af091d6f0cf6107eca1de
4f3c85ahttps://github.com/nodejs/node/pull/16505/commits/4f3c85a4d5dcae7c1b7af091d6f0cf6107eca1de
https://github.com/maclover7
fix nitshttps://github.com/nodejs/node/pull/16505/commits/d17c56aab970102f72f89172d9d8e4b4550404f4
d17c56ahttps://github.com/nodejs/node/pull/16505/commits/d17c56aab970102f72f89172d9d8e4b4550404f4
https://github.com/maclover7
remove extra spacehttps://github.com/nodejs/node/pull/16505/commits/da8d65b9f6963d0f212f59cec50f3c46f42dc360
da8d65bhttps://github.com/nodejs/node/pull/16505/commits/da8d65b9f6963d0f212f59cec50f3c46f42dc360
https://github.com/maclover7
squashhttps://github.com/nodejs/node/pull/16505/commits/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
9a8cf0dhttps://github.com/nodejs/node/pull/16505/commits/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
https://github.com/maclover7
maclover7https://github.com/maclover7
Jan 2, 2018https://github.com/nodejs/node/pull/16505#issuecomment-354691995
https://ci.nodejs.org/job/node-test-pull-request/12365/https://ci.nodejs.org/job/node-test-pull-request/12365/
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 2, 2018 https://github.com/nodejs/node/pull/16505#pullrequestreview-86113981
View reviewed changes https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/16505#pullrequestreview-86113981
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/maclover7
maclover7https://github.com/maclover7
Jan 2, 2018https://github.com/nodejs/node/pull/16505#issuecomment-354893662
@bzozhttps://github.com/bzoz
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/bzoz
bzozhttps://github.com/bzoz
Jan 4, 2018https://github.com/nodejs/node/pull/16505#issuecomment-355175754
execSync to call ATTRIB +H to set make file hiddenhttps://github.com/nodejs/node/blob/ecf6e79362faad747f50405d7f36a5d5006c3e97/test/parallel/test-repl-persistent-history.js#L187-L199
always write something to stderr, even if it is an empty bufferhttps://github.com/nodejs/node/blob/ecf6e79362faad747f50405d7f36a5d5006c3e97/lib/child_process.js#L636-L639
hijackStderr callbackhttps://github.com/maclover7/node/blob/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d/test/parallel/test-repl-persistent-history.js#L276-L282
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/lance
lancehttps://github.com/lance
Jan 4, 2018https://github.com/nodejs/node/pull/16505#issuecomment-355389009
@bzozhttps://github.com/bzoz
herehttps://github.com/nodejs/node/pull/7005
#7005 (comment)https://github.com/nodejs/node/pull/7005#issuecomment-226548110
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jan 5, 2018https://github.com/nodejs/node/pull/16505#event-1411439986
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 19, 2018 https://github.com/nodejs/node/pull/16505#pullrequestreview-90167224
View reviewed changes https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
test/parallel/test-repl-persistent-history.jshttps://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d#diff-9cabb17955a9fe6e3e407e55da2c3c617ed211fb41f7ed740d572a288c00ed7d
BridgeARhttps://github.com/BridgeAR
Jan 19, 2018https://github.com/nodejs/node/pull/16505#discussion_r162668208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 19, 2018https://github.com/nodejs/node/pull/16505#issuecomment-359018148
@maclover7https://github.com/maclover7
@bzozhttps://github.com/bzoz
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/maclover7
maclover7https://github.com/maclover7
force-pushedhttps://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c
bb5575ahttps://github.com/nodejs/node/commit/bb5575aa75fd3071724d5eccde39a3041e1af57a
993b716https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c
Compare https://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c
January 26, 2018 22:02https://github.com/nodejs/node/pull/16505#event-1444448275
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab
993b716https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c
082f952https://github.com/nodejs/node/commit/082f9525d92532867bc7172acebdf9b89a715dab
Compare https://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab
January 26, 2018 22:36https://github.com/nodejs/node/pull/16505#event-1444493250
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 31, 2018https://github.com/nodejs/node/pull/16505#issuecomment-361798172
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 31, 2018 https://github.com/nodejs/node/pull/16505#pullrequestreview-93058398
View reviewed changes https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
https://github.com/bzoz
bzozhttps://github.com/bzoz
Feb 1, 2018 https://github.com/nodejs/node/pull/16505#pullrequestreview-93276660
View reviewed changes https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
bzozhttps://github.com/bzoz
https://github.com/nodejs/node/pull/16505#pullrequestreview-93276660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 7, 2018https://github.com/nodejs/node/pull/16505#issuecomment-363642046
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 7, 2018https://github.com/nodejs/node/pull/16505#event-1461529986
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16505
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16505/files/eb111f55df59d07850a764dbcccd6a960340591b
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/16505/files/3e56a6c00e3ced9505b4380a305516d18e37571a
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/16505/files/2a226b9956a58431b2c7fc484f62f252137da574
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/16505/files/50cbad1f456b132669eba3d6f6c9aa1a9d62f027
https://github.com/bzoz
bzoz https://github.com/bzoz
https://github.com/nodejs/node/pull/16505/files/9a8cf0df6fb317d70bbc313877250e5ff3b8c41d
https://github.com/lance
lance https://github.com/lance
https://github.com/nodejs/node/pull/16505/files/eb111f55df59d07850a764dbcccd6a960340591b
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/16505
https://github.com/maclover7
https://github.com/BridgeAR
https://github.com/Trott
https://github.com/bzoz
https://github.com/lance
https://github.com/mcollina
https://github.com/jasnell
https://github.com/addaleax
https://github.com/lpinca
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.