René's URL Explorer Experiment


Title: crypto: migrate crypto.randomBytes to internal/errors by jasnell · Pull Request #16454 · nodejs/node · GitHub

Open Graph Title: crypto: migrate crypto.randomBytes to internal/errors by jasnell · Pull Request #16454 · nodejs/node

X Title: crypto: migrate crypto.randomBytes to internal/errors by jasnell · Pull Request #16454 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously had migrated randomBytesFill, this gives the same treatment to crypto.randomBytes() Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are includ...

X Description: Previously had migrated randomBytesFill, this gives the same treatment to crypto.randomBytes() Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are includ...

Opengraph URL: https://github.com/nodejs/node/pull/16454

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c601ac60-5bd5-2c04-170e-eb43f84b33aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC36A:2BD59E:7D2784:A9B67B:6AED2EA3
html-safe-nonce25429bcaa5fee0540d82ec799cc06f1bdffa5cfd7ec5e8f0f745b7621d2fdae8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzZBOjJCRDU5RTo3RDI3ODQ6QTlCNjdCOjZBRUQyRUEzIiwidmlzaXRvcl9pZCI6IjExODk0OTMyNjQ1OTUzNjU1MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf23ca70811c386a2f477e1666538a46bafd77a25a56bb654cec7bca4a4cb3fce
hovercard-subject-tagpull_request:148491053
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16454/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d263ec95625172fc7d14601f3c61ac16b9ee72095f0d8a3154d1dcafb60ec788/nodejs/node/pull/16454
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d263ec95625172fc7d14601f3c61ac16b9ee72095f0d8a3154d1dcafb60ec788/nodejs/node/pull/16454
og:image:altPreviously had migrated randomBytesFill, this gives the same treatment to crypto.randomBytes() Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are includ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16454#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16454
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16454
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16454
Reloadhttps://github.com/nodejs/node/pull/16454
Reloadhttps://github.com/nodejs/node/pull/16454
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:crypto-randombytes-internal-errorshttps://github.com/jasnell/node/tree/crypto-randombytes-internal-errors
Conversationhttps://github.com/nodejs/node/pull/16454
Commits1 (1)https://github.com/nodejs/node/pull/16454/commits
Checkshttps://github.com/nodejs/node/pull/16454/checks
Files changedhttps://github.com/nodejs/node/pull/16454/files
crypto: migrate crypto.randomBytes to internal/errorshttps://github.com/nodejs/node/pull/16454#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:crypto-randombytes-internal-errorshttps://github.com/jasnell/node/tree/crypto-randombytes-internal-errors
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 24, 2017https://github.com/nodejs/node/pull/16454#issue-268156948
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16454
https://github.com/jasnell
crypto: migrate crypto.randomBytes to internal/errorshttps://github.com/nodejs/node/pull/16454/commits/4a7096e7cbab9f4bb56c44185565f3282de01883
4a7096ehttps://github.com/nodejs/node/pull/16454/commits/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/jasnell
jasnellhttps://github.com/jasnell
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Oct 24, 2017https://github.com/nodejs/node/pull/16454#event-1308480490
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Oct 24, 2017https://github.com/nodejs/node/pull/16454#event-1308480577
https://github.com/targos
targoshttps://github.com/targos
Oct 24, 2017 https://github.com/nodejs/node/pull/16454#pullrequestreview-71675725
View reviewed changes https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Oct 24, 2017 https://github.com/nodejs/node/pull/16454#pullrequestreview-71696799
View reviewed changes https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2017https://github.com/nodejs/node/pull/16454#issuecomment-339211665
https://ci.nodejs.org/job/node-test-pull-request/10946/https://ci.nodejs.org/job/node-test-pull-request/10946/
Please reload this pagehttps://github.com/nodejs/node/pull/16454
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2017https://github.com/nodejs/node/pull/16454#issuecomment-339211683
Please reload this pagehttps://github.com/nodejs/node/pull/16454
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 25, 2017 https://github.com/nodejs/node/pull/16454#pullrequestreview-71829945
View reviewed changes https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 25, 2017 https://github.com/nodejs/node/pull/16454#pullrequestreview-71863140
View reviewed changes https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 25, 2017https://github.com/nodejs/node/pull/16454#issuecomment-339405530
Please reload this pagehttps://github.com/nodejs/node/pull/16454
jasnellhttps://github.com/jasnell
Oct 26, 2017 https://github.com/nodejs/node/pull/16454#ref-commit-0a03e35
https://github.com/jasnell
crypto: migrate crypto.randomBytes to internal/errorshttps://github.com/nodejs/node/commit/0a03e350fb6fac67ac85809af947c8dce1a8e569
https://github.com/nodejs/node/commit/0a03e350fb6fac67ac85809af947c8dce1a8e569#comments
0a03e35https://github.com/nodejs/node/commit/0a03e350fb6fac67ac85809af947c8dce1a8e569
#16454https://github.com/nodejs/node/pull/16454
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 26, 2017https://github.com/nodejs/node/pull/16454#issuecomment-339698484
0a03e35https://github.com/nodejs/node/commit/0a03e350fb6fac67ac85809af947c8dce1a8e569
Please reload this pagehttps://github.com/nodejs/node/pull/16454
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 26, 2017https://github.com/nodejs/node/pull/16454#event-1312185467
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16454#ref-commit-1e8222a
https://github.com/jasnell
https://github.com/addaleax
crypto: migrate crypto.randomBytes to internal/errorshttps://github.com/ayojs/ayo/commit/1e8222a976e49d1d093df99897c3b9a9603075d4
1e8222ahttps://github.com/ayojs/ayo/commit/1e8222a976e49d1d093df99897c3b9a9603075d4
nodejs/node#16454https://github.com/nodejs/node/pull/16454
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/16454#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
https://github.com/sehrope
sehropehttps://github.com/sehrope
Nov 5, 2017 https://github.com/nodejs/node/pull/16454#ref-issue-271289221
Possible regression with crypto.randomBytes(size, null) #16778 https://github.com/nodejs/node/issues/16778
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16454#ref-commit-f0ef3f6
https://github.com/jasnell
https://github.com/addaleax
crypto: migrate crypto.randomBytes to internal/errorshttps://github.com/ayojs/ayo/commit/f0ef3f6749be2dcccbc6513cf0eb9164640339a8
f0ef3f6https://github.com/ayojs/ayo/commit/f0ef3f6749be2dcccbc6513cf0eb9164640339a8
nodejs/node#16454https://github.com/nodejs/node/pull/16454
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Dec 10, 2017 https://github.com/nodejs/node/pull/16454#ref-pullrequest-280841002
doc: note that randomBytes throws when passed null #17594 https://github.com/nodejs/node/pull/17594
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16454
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/16454/files/4a7096e7cbab9f4bb56c44185565f3282de01883
Please reload this pagehttps://github.com/nodejs/node/pull/16454
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/16454
https://github.com/jasnell
https://github.com/apapirovski
https://github.com/lpinca
https://github.com/targos
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.