| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e2872917-ad92-3adb-31ec-466566be58b1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B9CA:120B97:E43878:12345FB:6991524A |
| html-safe-nonce | 827e5c063005d02eb0034b43abb2b3679c4c3e46a57d7c516e547b11d5943d11 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUNBOjEyMEI5NzpFNDM4Nzg6MTIzNDVGQjo2OTkxNTI0QSIsInZpc2l0b3JfaWQiOiIxMTQ4MzU5NjQ1NTE5MjM3NzA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0b1b44aee5d3b4e6e9cbdd70f5fa4bbc9d99e2434f36b6e0ecc13da4a2570e6a |
| hovercard-subject-tag | pull_request:148048975 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16401/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1fb68e11541f865cd81e3dafb1ba346645b328fb4889703beb83ef7de38301bb/nodejs/node/pull/16401 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1fb68e11541f865cd81e3dafb1ba346645b328fb4889703beb83ef7de38301bb/nodejs/node/pull/16401 |
| og:image:alt | The initials of expected in TypeError[ERR_INVALID_ARG_TYPE] are inconsistent.
This PR is to:
Unify the initial usage of TypeError[INVALID_ARG_TYPE]
Add an argument check before construct an error
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | starkwang |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16401#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16401 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16401 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16401 |
| Reload | https://github.com/nodejs/node/pull/16401 |
| Reload | https://github.com/nodejs/node/pull/16401 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| starkwang | https://github.com/starkwang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| starkwang:improve-invalid-arg-type | https://github.com/starkwang/node/tree/improve-invalid-arg-type |
| Conversation | https://github.com/nodejs/node/pull/16401 |
| Commits1 (1) | https://github.com/nodejs/node/pull/16401/commits |
| Checks | https://github.com/nodejs/node/pull/16401/checks |
| Files changed | https://github.com/nodejs/node/pull/16401/files |
| lib: improve the usage of TypeError[INVALID_ARG_TYPE] | https://github.com/nodejs/node/pull/16401#top |
| starkwang | https://github.com/starkwang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| starkwang:improve-invalid-arg-type | https://github.com/starkwang/node/tree/improve-invalid-arg-type |
|
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Oct 23, 2017 | https://github.com/nodejs/node/pull/16401#issue-267554671 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| #16383 | https://github.com/nodejs/node/issues/16383 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Oct 23, 2017 | https://github.com/nodejs/node/pull/16401#event-1304959962 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Oct 23, 2017
| https://github.com/nodejs/node/pull/16401#pullrequestreview-71217939 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16401/files |
| apapirovski | https://github.com/apapirovski |
| https://github.com/nodejs/node/pull/16401#pullrequestreview-71217939 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| lib/internal/crypto/random.js | https://github.com/nodejs/node/pull/16401/files#diff-afe151ccd22dba4dff750df92b5c0062736027ed4d23ae2eade177b5f215b9ef |
| apapirovski | https://github.com/apapirovski |
| Oct 23, 2017 | https://github.com/nodejs/node/pull/16401#discussion_r146296863 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Oct 23, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-338706414 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| force-pushed | https://github.com/nodejs/node/compare/393b85c9a12e524e6094aa3f0889a85751806b20..670dab35a3182fb4d04a930b8bb6fa9907ffdc0c |
| 393b85c | https://github.com/nodejs/node/commit/393b85c9a12e524e6094aa3f0889a85751806b20 |
| 670dab3 | https://github.com/nodejs/node/commit/670dab35a3182fb4d04a930b8bb6fa9907ffdc0c |
|
Compare
| https://github.com/nodejs/node/compare/393b85c9a12e524e6094aa3f0889a85751806b20..670dab35a3182fb4d04a930b8bb6fa9907ffdc0c |
| October 23, 2017 16:29 | https://github.com/nodejs/node/pull/16401#event-1306023929 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Oct 23, 2017 | https://github.com/nodejs/node/pull/16401#event-1306130289 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 23, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-338734050 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 24, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-338934723 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 27, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-339979706 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 27, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-339980177 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Oct 27, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-339980629 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Oct 27, 2017
| https://github.com/nodejs/node/pull/16401#pullrequestreview-72515466 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16401/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/16401/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| apapirovski | https://github.com/apapirovski |
| Oct 27, 2017 | https://github.com/nodejs/node/pull/16401#discussion_r147419780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 27, 2017
| https://github.com/nodejs/node/pull/16401#pullrequestreview-72516053 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16401/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/16401#pullrequestreview-72516053 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/16401/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| joyeecheung | https://github.com/joyeecheung |
| Oct 27, 2017 | https://github.com/nodejs/node/pull/16401#discussion_r147420244 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/16401/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| joyeecheung | https://github.com/joyeecheung |
| Oct 27, 2017 | https://github.com/nodejs/node/pull/16401#discussion_r147420371 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Oct 27, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-340012816 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-340133965 |
| @starkwang | https://github.com/starkwang |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| force-pushed | https://github.com/nodejs/node/compare/670dab35a3182fb4d04a930b8bb6fa9907ffdc0c..c74148d1e9c17f96171ca17eacf1a940b212b3d9 |
| 670dab3 | https://github.com/nodejs/node/commit/670dab35a3182fb4d04a930b8bb6fa9907ffdc0c |
| c74148d | https://github.com/nodejs/node/commit/c74148d1e9c17f96171ca17eacf1a940b212b3d9 |
|
Compare
| https://github.com/nodejs/node/compare/670dab35a3182fb4d04a930b8bb6fa9907ffdc0c..c74148d1e9c17f96171ca17eacf1a940b212b3d9 |
| October 28, 2017 10:36 | https://github.com/nodejs/node/pull/16401#event-1315107680 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-340179623 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-340185582 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| #16401 (comment) | https://github.com/nodejs/node/pull/16401#issuecomment-340133965 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#event-1315144635 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| force-pushed | https://github.com/nodejs/node/compare/c74148d1e9c17f96171ca17eacf1a940b212b3d9..75e6dd50fdf4d35ab0b10f5137590558f1fdbb9e |
| c74148d | https://github.com/nodejs/node/commit/c74148d1e9c17f96171ca17eacf1a940b212b3d9 |
| 75e6dd5 | https://github.com/nodejs/node/commit/75e6dd50fdf4d35ab0b10f5137590558f1fdbb9e |
|
Compare
| https://github.com/nodejs/node/compare/c74148d1e9c17f96171ca17eacf1a940b212b3d9..75e6dd50fdf4d35ab0b10f5137590558f1fdbb9e |
| October 28, 2017 15:32 | https://github.com/nodejs/node/pull/16401#event-1315212320 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-340199338 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 28, 2017
| https://github.com/nodejs/node/pull/16401#pullrequestreview-72676346 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16401/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/16401#pullrequestreview-72676346 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| lib/fs.js | https://github.com/nodejs/node/pull/16401/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| joyeecheung | https://github.com/joyeecheung |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#discussion_r147559013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-340205124 |
| https://ci.nodejs.org/job/node-test-pull-request/11055/ | https://ci.nodejs.org/job/node-test-pull-request/11055/ |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 28, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-340221302 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| force-pushed | https://github.com/nodejs/node/compare/75e6dd50fdf4d35ab0b10f5137590558f1fdbb9e..6638db67ad1f3401b5d8df3a6d1ca128a534fea5 |
| 75e6dd5 | https://github.com/nodejs/node/commit/75e6dd50fdf4d35ab0b10f5137590558f1fdbb9e |
| 6638db6 | https://github.com/nodejs/node/commit/6638db67ad1f3401b5d8df3a6d1ca128a534fea5 |
|
Compare
| https://github.com/nodejs/node/compare/75e6dd50fdf4d35ab0b10f5137590558f1fdbb9e..6638db67ad1f3401b5d8df3a6d1ca128a534fea5 |
| November 3, 2017 14:13 | https://github.com/nodejs/node/pull/16401#event-1324938626 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-343632114 |
| @jasnell | https://github.com/jasnell |
| @joyeecheung | https://github.com/joyeecheung |
| @tniessen | https://github.com/tniessen |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-343641219 |
| https://ci.nodejs.org/job/node-test-pull-request/11352/ | https://ci.nodejs.org/job/node-test-pull-request/11352/ |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16401#event-1337114453 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Nov 11, 2017
| https://github.com/nodejs/node/pull/16401#pullrequestreview-75924115 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16401/files |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-343642378 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 11, 2017
| https://github.com/nodejs/node/pull/16401#pullrequestreview-75927169 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16401/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/16401#pullrequestreview-75927169 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16401#ref-commit-c179254 |
|
| https://github.com/starkwang |
|
| https://github.com/evanlucas |
| lib: improve the usage of TypeError[INVALID_ARG_TYPE] | https://github.com/nodejs/node/commit/c1792544e832dfdc7fd78cdf4792570f12b90f4c |
| c179254 | https://github.com/nodejs/node/commit/c1792544e832dfdc7fd78cdf4792570f12b90f4c |
| #16401 | https://github.com/nodejs/node/pull/16401 |
| #16383 | https://github.com/nodejs/node/issues/16383 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 13, 2017
| https://github.com/nodejs/node/pull/16401#ref-pullrequest-273462029 |
|
v9.2.0 proposal
#16992
| https://github.com/nodejs/node/pull/16992 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-345288386 |
| the guide | https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16401#event-1347455746 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-345320688 |
| @MylesBorins | https://github.com/MylesBorins |
| #16401 (comment) | https://github.com/nodejs/node/pull/16401#issuecomment-340185582 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16401#event-1347659730 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Nov 17, 2017 | https://github.com/nodejs/node/pull/16401#issuecomment-345321113 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
| https://github.com/starkwang |
| starkwang | https://github.com/starkwang |
|
Dec 9, 2017
| https://github.com/nodejs/node/pull/16401#ref-pullrequest-280724507 |
|
tools: add lowercase-name-for-primitive eslint rule
#17568
| https://github.com/nodejs/node/pull/17568 |
| starkwang | https://github.com/starkwang |
|
Dec 9, 2017
| https://github.com/nodejs/node/pull/16401#ref-commit-ea94065 |
|
| https://github.com/starkwang |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/starkwang/node/commit/ea940653b1f1f1e19750aab77364920d83b66f5a |
| ea94065 | https://github.com/starkwang/node/commit/ea940653b1f1f1e19750aab77364920d83b66f5a |
| nodejs#16401 | https://github.com/nodejs/node/pull/16401 |
| addaleax | https://github.com/addaleax |
|
Dec 13, 2017
| https://github.com/nodejs/node/pull/16401#ref-commit-a2bdcba |
|
| https://github.com/starkwang |
|
| https://github.com/addaleax |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/addaleax/node/commit/a2bdcbab5fea61b67f0614a0573e5ac5c2ffe004 |
| a2bdcba | https://github.com/addaleax/node/commit/a2bdcbab5fea61b67f0614a0573e5ac5c2ffe004 |
| nodejs#16401 | https://github.com/nodejs/node/pull/16401 |
| nodejs#17568 | https://github.com/nodejs/node/pull/17568 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/16401#ref-pullrequest-276132326 |
|
test: refactor concat string to template string
#17252
| https://github.com/nodejs/node/pull/17252 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 8, 2018
| https://github.com/nodejs/node/pull/16401#ref-commit-3ad8cf1 |
|
| https://github.com/starkwang |
|
| https://github.com/MylesBorins |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/nodejs/node/commit/3ad8cf14f5bf40b8ddca482843ed3f79601069da |
| 3ad8cf1 | https://github.com/nodejs/node/commit/3ad8cf14f5bf40b8ddca482843ed3f79601069da |
| #16401 | https://github.com/nodejs/node/pull/16401 |
| #17568 | https://github.com/nodejs/node/pull/17568 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 22, 2018
| https://github.com/nodejs/node/pull/16401#ref-commit-dc480f8 |
|
| https://github.com/starkwang |
|
| https://github.com/MylesBorins |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/nodejs/node/commit/dc480f84f9b6cb06674a77289047917e9ea76635 |
| dc480f8 | https://github.com/nodejs/node/commit/dc480f84f9b6cb06674a77289047917e9ea76635 |
| #16401 | https://github.com/nodejs/node/pull/16401 |
| #17568 | https://github.com/nodejs/node/pull/17568 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 22, 2018
| https://github.com/nodejs/node/pull/16401#ref-commit-0f002dd |
|
| https://github.com/starkwang |
|
| https://github.com/MylesBorins |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/nodejs/node/commit/0f002dd02a25b66ac69f090cac02d998a08e0acd |
| 0f002dd | https://github.com/nodejs/node/commit/0f002dd02a25b66ac69f090cac02d998a08e0acd |
| #16401 | https://github.com/nodejs/node/pull/16401 |
| #17568 | https://github.com/nodejs/node/pull/17568 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 11, 2018
| https://github.com/nodejs/node/pull/16401#ref-commit-de25741 |
|
| https://github.com/starkwang |
|
| https://github.com/MylesBorins |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/nodejs/node/commit/de25741fece0fb12e68ac82b2847e8b2791fd546 |
| de25741 | https://github.com/nodejs/node/commit/de25741fece0fb12e68ac82b2847e8b2791fd546 |
| #16401 | https://github.com/nodejs/node/pull/16401 |
| #17568 | https://github.com/nodejs/node/pull/17568 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 12, 2018
| https://github.com/nodejs/node/pull/16401#ref-commit-f0c1855 |
|
| https://github.com/starkwang |
|
| https://github.com/MylesBorins |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/nodejs/node/commit/f0c1855db23ae96a734eddea3f69c4d2f1c40551 |
| f0c1855 | https://github.com/nodejs/node/commit/f0c1855db23ae96a734eddea3f69c4d2f1c40551 |
| #16401 | https://github.com/nodejs/node/pull/16401 |
| #17568 | https://github.com/nodejs/node/pull/17568 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 13, 2018
| https://github.com/nodejs/node/pull/16401#ref-commit-7821a4c |
|
| https://github.com/starkwang |
|
| https://github.com/MylesBorins |
| tools: add lowercase-name-for-primitive eslint rule | https://github.com/nodejs/node/commit/7821a4c89907482ef81df125f0d4ef2750ba99f2 |
| 7821a4c | https://github.com/nodejs/node/commit/7821a4c89907482ef81df125f0d4ef2750ba99f2 |
| #16401 | https://github.com/nodejs/node/pull/16401 |
| #17568 | https://github.com/nodejs/node/pull/17568 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16401 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/16401/files/6638db67ad1f3401b5d8df3a6d1ca128a534fea5 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/16401/files/c22b736945d56b75dadc4f4e501ae6d46b8ee6e2 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/16401/files/c22b736945d56b75dadc4f4e501ae6d46b8ee6e2 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/16401/files/75e6dd50fdf4d35ab0b10f5137590558f1fdbb9e |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/16401/files/6638db67ad1f3401b5d8df3a6d1ca128a534fea5 |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/16401/files/670dab35a3182fb4d04a930b8bb6fa9907ffdc0c |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
lib: inconsistent initial of expected in TypeError[ERR_INVALID_ARG_TYPE]
| https://github.com/nodejs/node/issues/16383 |
| Please reload this page | https://github.com/nodejs/node/pull/16401 |
|
| https://github.com/starkwang |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/joyeecheung |
|
| https://github.com/apapirovski |
|
| https://github.com/tniessen |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/TimothyGu |
|
| https://github.com/MylesBorins |
|
| https://github.com/mcollina |
|
| https://github.com/benjamingr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |