René's URL Explorer Experiment


Title: src: use new V8 API in vm module by fhinkel · Pull Request #16293 · nodejs/node · GitHub

Open Graph Title: src: use new V8 API in vm module by fhinkel · Pull Request #16293 · nodejs/node

X Title: src: use new V8 API in vm module by fhinkel · Pull Request #16293 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR removes the CopyProperties() hack in the vm module, i.e., Contextify. Instead, it uses different V8 API methods, that allow interception of DefineProperty() and do not flatten accessor desc...

X Description: This PR removes the CopyProperties() hack in the vm module, i.e., Contextify. Instead, it uses different V8 API methods, that allow interception of DefineProperty() and do not flatten accessor desc...

Opengraph URL: https://github.com/nodejs/node/pull/16293

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:879c5359-4ca9-9336-01e9-40afd26afd70
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6F0:12F8D5:18C153:1F9159:6991D850
html-safe-noncec3fe79c8e72fae4a59710577e739acecfbc93b10ede912f8a80806cec2868ff1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkYwOjEyRjhENToxOEMxNTM6MUY5MTU5OjY5OTFEODUwIiwidmlzaXRvcl9pZCI6IjI2NDc2ODc2MzEzOTYyNjQwMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc9e476d4b177202f68a80e875b9402f46e674d71e2f097a4258462cc70552d18
hovercard-subject-tagpull_request:147320167
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16293/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8433daa0e94f0bfcf6a42acfd371e3ba39849ff0db1a606ae8d680cc0ad42a20/nodejs/node/pull/16293
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8433daa0e94f0bfcf6a42acfd371e3ba39849ff0db1a606ae8d680cc0ad42a20/nodejs/node/pull/16293
og:image:altThis PR removes the CopyProperties() hack in the vm module, i.e., Contextify. Instead, it uses different V8 API methods, that allow interception of DefineProperty() and do not flatten accessor desc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefhinkel
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16293#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16293
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16293
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16293
Reloadhttps://github.com/nodejs/node/pull/16293
Reloadhttps://github.com/nodejs/node/pull/16293
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/16293
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:Oct/defineProphttps://github.com/fhinkel/node/tree/Oct/defineProp
Conversationhttps://github.com/nodejs/node/pull/16293
Commits1 (1)https://github.com/nodejs/node/pull/16293/commits
Checkshttps://github.com/nodejs/node/pull/16293/checks
Files changedhttps://github.com/nodejs/node/pull/16293/files
src: use new V8 API in vm modulehttps://github.com/nodejs/node/pull/16293#top
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:Oct/defineProphttps://github.com/fhinkel/node/tree/Oct/defineProp
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 18, 2017https://github.com/nodejs/node/pull/16293#issue-266519190
Please reload this pagehttps://github.com/nodejs/node/pull/16293
#10223https://github.com/nodejs/node/issues/10223
https://github.com/AnnaMaghttps://github.com/AnnaMag
#13265https://github.com/nodejs/node/pull/13265
#6283https://github.com/nodejs/node/issues/6283
#15114https://github.com/nodejs/node/pull/15114
#13265https://github.com/nodejs/node/pull/13265
#2734https://github.com/nodejs/node/issues/2734
#10223https://github.com/nodejs/node/issues/10223
#11803https://github.com/nodejs/node/issues/11803
#11902https://github.com/nodejs/node/issues/11902
37a3a15https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f
PRhttps://github.com/nodejs/node/pull/16294
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Oct 18, 2017https://github.com/nodejs/node/pull/16293#event-1299222211
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 18, 2017 https://github.com/nodejs/node/pull/16293#ref-pullrequest-266520029
deps: cherry-pick 37a3a15c3 from V8 upstream #16294 https://github.com/nodejs/node/pull/16294
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Oct 18, 2017https://github.com/nodejs/node/pull/16293#event-1299260100
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 18, 2017 https://github.com/nodejs/node/pull/16293#pullrequestreview-70244880
View reviewed changes https://github.com/nodejs/node/pull/16293/files
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/16293#pullrequestreview-70244880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017 https://github.com/nodejs/node/pull/16293#pullrequestreview-70272212
View reviewed changes https://github.com/nodejs/node/pull/16293/files
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145467375
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145612480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145467783
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145612773
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145468252
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145619684
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
bnoordhuishttps://github.com/bnoordhuis
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145649807
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145670657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
objects.cchttps://github.com/v8/v8/blob/6f93d59d9204101ee11c3ed9513c7012b0f75169/src/objects.cc#L7673
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145469000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145619831
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145469081
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145619877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145471344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145612114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145473827
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145619981
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145474915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145621120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
test/parallel/test-vm-global-non-writable-properties.jshttps://github.com/nodejs/node/pull/16293/files#diff-f00008915b70ea9b3af0136d4d89b4a76ffbe56ad110d4301810f0413c446598
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145475179
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145621283
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
test/parallel/test-vm-strict-assign.jshttps://github.com/nodejs/node/pull/16293/files#diff-24d6a7e3310c28916be75dc23f5f71059ded285679f0915d2c5a1efec41aa6e6
bnoordhuishttps://github.com/bnoordhuis
Oct 18, 2017https://github.com/nodejs/node/pull/16293#discussion_r145475365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145621367
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
9.0.0https://github.com/nodejs/node/milestone/25
Oct 18, 2017https://github.com/nodejs/node/pull/16293#event-1299694295
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337811293
@cpojerhttps://github.com/cpojer
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 19, 2017https://github.com/nodejs/node/pull/16293#event-1300532168
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337826311
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
force-pushedhttps://github.com/nodejs/node/compare/5eb8aaf2f581e79920c7f474ad919d9cd62986d0..324c91282502c7fa066dce4d12883a79f4df15c8
5eb8aafhttps://github.com/nodejs/node/commit/5eb8aaf2f581e79920c7f474ad919d9cd62986d0
324c912https://github.com/nodejs/node/commit/324c91282502c7fa066dce4d12883a79f4df15c8
Compare https://github.com/nodejs/node/compare/5eb8aaf2f581e79920c7f474ad919d9cd62986d0..324c91282502c7fa066dce4d12883a79f4df15c8
October 19, 2017 08:08https://github.com/nodejs/node/pull/16293#event-1300568854
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337832256
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
force-pushedhttps://github.com/nodejs/node/compare/367473e0cf70434259aa36c3251c5d16877796d7..fecefd04f9b97e99976cb73be2cb1ac72e37cc64
367473ehttps://github.com/nodejs/node/commit/367473e0cf70434259aa36c3251c5d16877796d7
fecefd0https://github.com/nodejs/node/commit/fecefd04f9b97e99976cb73be2cb1ac72e37cc64
Compare https://github.com/nodejs/node/compare/367473e0cf70434259aa36c3251c5d16877796d7..fecefd04f9b97e99976cb73be2cb1ac72e37cc64
October 19, 2017 08:19https://github.com/nodejs/node/pull/16293#event-1300584168
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 19, 2017 https://github.com/nodejs/node/pull/16293#pullrequestreview-70479618
View reviewed changes https://github.com/nodejs/node/pull/16293/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/16293#pullrequestreview-70479618
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@AnnaMaghttps://github.com/AnnaMag
Please reload this pagehttps://github.com/nodejs/node/pull/16293
src/node_contextify.cchttps://github.com/nodejs/node/pull/16293/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
bnoordhuishttps://github.com/bnoordhuis
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145650857
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145669598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
test/parallel/test-vm-global-non-writable-properties.jshttps://github.com/nodejs/node/pull/16293/files#diff-f00008915b70ea9b3af0136d4d89b4a76ffbe56ad110d4301810f0413c446598
bnoordhuishttps://github.com/bnoordhuis
Oct 19, 2017https://github.com/nodejs/node/pull/16293#discussion_r145651067
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
force-pushedhttps://github.com/nodejs/node/compare/743de90a55b4786a6067167d38f972c620053475..03358aabc15a6d9ce23266f5102de91e5c69994f
743de90https://github.com/nodejs/node/commit/743de90a55b4786a6067167d38f972c620053475
03358aahttps://github.com/nodejs/node/commit/03358aabc15a6d9ce23266f5102de91e5c69994f
Compare https://github.com/nodejs/node/compare/743de90a55b4786a6067167d38f972c620053475..03358aabc15a6d9ce23266f5102de91e5c69994f
October 19, 2017 11:51https://github.com/nodejs/node/pull/16293#event-1300918268
https://github.com/cpojer
cpojerhttps://github.com/cpojer
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337886749
@fhinkelhttps://github.com/fhinkel
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2017 https://github.com/nodejs/node/pull/16293#pullrequestreview-70519510
View reviewed changes https://github.com/nodejs/node/pull/16293/files
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337896600
Please reload this pagehttps://github.com/nodejs/node/pull/16293
@cpojerhttps://github.com/cpojer
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/cpojer
cpojerhttps://github.com/cpojer
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337901309
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 19, 2017 https://github.com/nodejs/node/pull/16293#ref-issue-266840928
Channel closed error when running tests with Node 9.0.0-pre jestjs/jest#4731 https://github.com/jestjs/jest/issues/4731
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337906636
@cpojerhttps://github.com/cpojer
jestjs/jest#4731https://github.com/jestjs/jest/issues/4731
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/SimenB
SimenBhttps://github.com/SimenB
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337927590
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/rvagg/node-worker-farmhttps://github.com/rvagg/node-worker-farm
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/SimenB
SimenBhttps://github.com/SimenB
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337959110
Please reload this pagehttps://github.com/nodejs/node/pull/16293
f2b01cbhttps://github.com/nodejs/node/commit/f2b01cba7b48c2410a692fe1cb29b2e88a6c5cab
#4670https://github.com/nodejs/node/pull/4670
f2b01cbhttps://github.com/nodejs/node/commit/f2b01cba7b48c2410a692fe1cb29b2e88a6c5cab
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 19, 2017 https://github.com/nodejs/node/pull/16293#pullrequestreview-70598018
View reviewed changes https://github.com/nodejs/node/pull/16293/files
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 19, 2017https://github.com/nodejs/node/pull/16293#issuecomment-337962590
@SimenBhttps://github.com/SimenB
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/SimenB
SimenBhttps://github.com/SimenB
Oct 19, 2017 https://github.com/nodejs/node/pull/16293#ref-issue-266913499
node v9 rc breaks test suite of worker-farm #16322 https://github.com/nodejs/node/issues/16322
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
force-pushedhttps://github.com/nodejs/node/compare/96fcee8a4e908a39c19fdb38edfd021355433e8c..65394132bada43792db924a92a1c384ae0bf8f84
96fcee8https://github.com/nodejs/node/commit/96fcee8a4e908a39c19fdb38edfd021355433e8c
6539413https://github.com/nodejs/node/commit/65394132bada43792db924a92a1c384ae0bf8f84
Compare https://github.com/nodejs/node/compare/96fcee8a4e908a39c19fdb38edfd021355433e8c..65394132bada43792db924a92a1c384ae0bf8f84
October 23, 2017 03:34https://github.com/nodejs/node/pull/16293#event-1304839621
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 23, 2017https://github.com/nodejs/node/pull/16293#issuecomment-338608991
https://ci.nodejs.org/job/node-test-pull-request/10919/https://ci.nodejs.org/job/node-test-pull-request/10919/
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
src: use new V8 API in vm modulehttps://github.com/nodejs/node/pull/16293/commits/f7d22e5d0089f96301bc80605214ae6ee9e93f4d
f7d22e5https://github.com/nodejs/node/pull/16293/commits/f7d22e5d0089f96301bc80605214ae6ee9e93f4d
nodejs#10223https://github.com/nodejs/node/issues/10223
https://github.com/AnnaMaghttps://github.com/AnnaMag
nodejs#13265https://github.com/nodejs/node/pull/13265
https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6fhttps://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f
nodejs#6283https://github.com/nodejs/node/issues/6283
nodejs#15114https://github.com/nodejs/node/pull/15114
nodejs#13265https://github.com/nodejs/node/pull/13265
nodejs#2734https://github.com/nodejs/node/issues/2734
nodejs#10223https://github.com/nodejs/node/issues/10223
nodejs#11803https://github.com/nodejs/node/issues/11803
nodejs#11902https://github.com/nodejs/node/issues/11902
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
force-pushedhttps://github.com/nodejs/node/compare/65394132bada43792db924a92a1c384ae0bf8f84..f7d22e5d0089f96301bc80605214ae6ee9e93f4d
6539413https://github.com/nodejs/node/commit/65394132bada43792db924a92a1c384ae0bf8f84
f7d22e5https://github.com/nodejs/node/commit/f7d22e5d0089f96301bc80605214ae6ee9e93f4d
Compare https://github.com/nodejs/node/compare/65394132bada43792db924a92a1c384ae0bf8f84..f7d22e5d0089f96301bc80605214ae6ee9e93f4d
October 23, 2017 11:01https://github.com/nodejs/node/pull/16293#event-1305374920
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 23, 2017https://github.com/nodejs/node/pull/16293#issuecomment-338625959
https://ci.nodejs.org/job/node-test-pull-request/10920/https://ci.nodejs.org/job/node-test-pull-request/10920/
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 23, 2017https://github.com/nodejs/node/pull/16293#issuecomment-338645306
f1d6b04https://github.com/nodejs/node/commit/f1d6b04ac95abe9ddbb6817b215bcdc6bef33ada
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 23, 2017https://github.com/nodejs/node/pull/16293#event-1305525447
fhinkelhttps://github.com/fhinkel
Oct 23, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-f1d6b04
https://github.com/fhinkel
src: use new V8 API in vm modulehttps://github.com/fhinkel/node/commit/f1d6b04ac95abe9ddbb6817b215bcdc6bef33ada
f1d6b04https://github.com/fhinkel/node/commit/f1d6b04ac95abe9ddbb6817b215bcdc6bef33ada
nodejs#10223https://github.com/nodejs/node/issues/10223
https://github.com/AnnaMaghttps://github.com/AnnaMag
nodejs#13265https://github.com/nodejs/node/pull/13265
https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6fhttps://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f
nodejs#16293https://github.com/nodejs/node/pull/16293
nodejs#2734https://github.com/nodejs/node/issues/2734
nodejs#10223https://github.com/nodejs/node/issues/10223
nodejs#11803https://github.com/nodejs/node/issues/11803
nodejs#11902https://github.com/nodejs/node/issues/11902
nodejs#6283https://github.com/nodejs/node/issues/6283
nodejs#15114https://github.com/nodejs/node/pull/15114
nodejs#13265https://github.com/nodejs/node/pull/13265
https://github.com/targos
targoshttps://github.com/targos
Oct 23, 2017https://github.com/nodejs/node/pull/16293#issuecomment-338645710
@AnnaMaghttps://github.com/AnnaMag
Please reload this pagehttps://github.com/nodejs/node/pull/16293
targoshttps://github.com/targos
Oct 23, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-2c27b2e
https://github.com/targos
test: add test for prop interceptors on sandboxhttps://github.com/targos/node/commit/2c27b2e71c7f6341348fb552e36994fb88e0cedc
2c27b2ehttps://github.com/targos/node/commit/2c27b2e71c7f6341348fb552e36994fb88e0cedc
nodejs#16293https://github.com/nodejs/node/pull/16293
https://github.com/targos
targoshttps://github.com/targos
Oct 23, 2017 https://github.com/nodejs/node/pull/16293#ref-pullrequest-267670996
test: add test for prop interceptors on sandbox #16409 https://github.com/nodejs/node/pull/16409
sandbox inheritied properties flattened after vm.runInNewContext #5350 https://github.com/nodejs/node/issues/5350
test: fix test for inherited properties on vm #16411 https://github.com/nodejs/node/pull/16411
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Oct 24, 2017 https://github.com/nodejs/node/pull/16293#ref-pullrequest-231862789
vm: remove CopyProperties()- code review #13265 https://github.com/nodejs/node/pull/13265
fhinkelhttps://github.com/fhinkel
Oct 25, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-76dde73
https://github.com/fhinkel
test: fix test for inherited properties on vmhttps://github.com/fhinkel/node/commit/76dde73b0cd9a8c555ca77bae6ed4adceeb418d5
76dde73https://github.com/fhinkel/node/commit/76dde73b0cd9a8c555ca77bae6ed4adceeb418d5
nodejs#16293https://github.com/nodejs/node/pull/16293
nodejs#5350https://github.com/nodejs/node/issues/5350
nodejs#5350https://github.com/nodejs/node/issues/5350
nodejs#16293https://github.com/nodejs/node/pull/16293
fhinkelhttps://github.com/fhinkel
Oct 25, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-ed116dc
https://github.com/fhinkel
test: fix test for inherited properties on vmhttps://github.com/fhinkel/node/commit/ed116dc3c65a6d568e2de7c09bd1c6f9db2c9b24
ed116dchttps://github.com/fhinkel/node/commit/ed116dc3c65a6d568e2de7c09bd1c6f9db2c9b24
nodejs#16293https://github.com/nodejs/node/pull/16293
nodejs#5350https://github.com/nodejs/node/issues/5350
nodejs#16411https://github.com/nodejs/node/pull/16411
nodejs#5350https://github.com/nodejs/node/issues/5350
nodejs#16293https://github.com/nodejs/node/pull/16293
targoshttps://github.com/targos
Oct 26, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-a37a0ad
https://github.com/targos
test: add test for prop interceptors on sandboxhttps://github.com/nodejs/node/commit/a37a0ad5f6880a133a2091bd8ac0092e3d1b7688
a37a0adhttps://github.com/nodejs/node/commit/a37a0ad5f6880a133a2091bd8ac0092e3d1b7688
#16409https://github.com/nodejs/node/pull/16409
#16293https://github.com/nodejs/node/pull/16293
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-acaf4bf
https://github.com/fhinkel
https://github.com/addaleax
src: use new V8 API in vm modulehttps://github.com/ayojs/ayo/commit/acaf4bff0473e01935d9f32909b868649ac17b83
acaf4bfhttps://github.com/ayojs/ayo/commit/acaf4bff0473e01935d9f32909b868649ac17b83
nodejs/node#10223https://github.com/nodejs/node/issues/10223
https://github.com/AnnaMaghttps://github.com/AnnaMag
nodejs/node#13265https://github.com/nodejs/node/pull/13265
https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6fhttps://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f
nodejs/node#16293https://github.com/nodejs/node/pull/16293
nodejs/node#2734https://github.com/nodejs/node/issues/2734
nodejs/node#10223https://github.com/nodejs/node/issues/10223
nodejs/node#11803https://github.com/nodejs/node/issues/11803
nodejs/node#11902https://github.com/nodejs/node/issues/11902
nodejs/node#6283https://github.com/nodejs/node/issues/6283
nodejs/node#15114https://github.com/nodejs/node/pull/15114
nodejs/node#13265https://github.com/nodejs/node/pull/13265
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-c1d9226
https://github.com/fhinkel
https://github.com/addaleax
test: fix test for inherited properties on vmhttps://github.com/ayojs/ayo/commit/c1d9226f0ad4abed642637bd8beac879b1e189ad
c1d9226https://github.com/ayojs/ayo/commit/c1d9226f0ad4abed642637bd8beac879b1e189ad
nodejs/node#16293https://github.com/nodejs/node/pull/16293
nodejs/node#5350https://github.com/nodejs/node/issues/5350
nodejs/node#16411https://github.com/nodejs/node/pull/16411
nodejs/node#5350https://github.com/nodejs/node/issues/5350
nodejs/node#16293https://github.com/nodejs/node/pull/16293
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-914ab9c
https://github.com/targos
https://github.com/addaleax
test: add test for prop interceptors on sandboxhttps://github.com/ayojs/ayo/commit/914ab9cdae04496b3c182756dfdcd4a828c3fbe0
914ab9chttps://github.com/ayojs/ayo/commit/914ab9cdae04496b3c182756dfdcd4a828c3fbe0
nodejs/node#16409https://github.com/nodejs/node/pull/16409
nodejs/node#16293https://github.com/nodejs/node/pull/16293
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/16293#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
gibfahnhttps://github.com/gibfahn
Oct 30, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-c10d53f
https://github.com/fhinkel
https://github.com/gibfahn
test: fix test for inherited properties on vmhttps://github.com/nodejs/node/commit/c10d53f04393eb4edc6db328ee2c3cc2470336f6
c10d53fhttps://github.com/nodejs/node/commit/c10d53f04393eb4edc6db328ee2c3cc2470336f6
#16293https://github.com/nodejs/node/pull/16293
#5350https://github.com/nodejs/node/issues/5350
#16411https://github.com/nodejs/node/pull/16411
#5350https://github.com/nodejs/node/issues/5350
#16293https://github.com/nodejs/node/pull/16293
https://github.com/MSLaguana
MSLaguanahttps://github.com/MSLaguana
Oct 31, 2017 https://github.com/nodejs/node/pull/16293#ref-issue-270127588
vm.runInContext is not fully supported after upstream change nodejs/node-chakracore#420 https://github.com/nodejs/node-chakracore/issues/420
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-4502da1
https://github.com/fhinkel
https://github.com/addaleax
src: use new V8 API in vm modulehttps://github.com/ayojs/ayo/commit/4502da176a7813a5ca1986b96969b0ea2a8d3cfc
4502da1https://github.com/ayojs/ayo/commit/4502da176a7813a5ca1986b96969b0ea2a8d3cfc
nodejs/node#10223https://github.com/nodejs/node/issues/10223
https://github.com/AnnaMaghttps://github.com/AnnaMag
nodejs/node#13265https://github.com/nodejs/node/pull/13265
https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6fhttps://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f
nodejs/node#16293https://github.com/nodejs/node/pull/16293
nodejs/node#2734https://github.com/nodejs/node/issues/2734
nodejs/node#10223https://github.com/nodejs/node/issues/10223
nodejs/node#11803https://github.com/nodejs/node/issues/11803
nodejs/node#11902https://github.com/nodejs/node/issues/11902
nodejs/node#6283https://github.com/nodejs/node/issues/6283
nodejs/node#15114https://github.com/nodejs/node/pull/15114
nodejs/node#13265https://github.com/nodejs/node/pull/13265
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-58d58f4
https://github.com/fhinkel
https://github.com/addaleax
test: fix test for inherited properties on vmhttps://github.com/ayojs/ayo/commit/58d58f4bc62d69e17439fb3a1739f703e6bd2ab3
58d58f4https://github.com/ayojs/ayo/commit/58d58f4bc62d69e17439fb3a1739f703e6bd2ab3
nodejs/node#16293https://github.com/nodejs/node/pull/16293
nodejs/node#5350https://github.com/nodejs/node/issues/5350
nodejs/node#16411https://github.com/nodejs/node/pull/16411
nodejs/node#5350https://github.com/nodejs/node/issues/5350
nodejs/node#16293https://github.com/nodejs/node/pull/16293
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16293#ref-commit-1bca772
https://github.com/targos
https://github.com/addaleax
test: add test for prop interceptors on sandboxhttps://github.com/ayojs/ayo/commit/1bca772eee05fc38a77d7447e2504bb16d984052
1bca772https://github.com/ayojs/ayo/commit/1bca772eee05fc38a77d7447e2504bb16d984052
nodejs/node#16409https://github.com/nodejs/node/pull/16409
nodejs/node#16293https://github.com/nodejs/node/pull/16293
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16293
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/16293/files/96fcee8a4e908a39c19fdb38edfd021355433e8c
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/16293/files/6c8ffbfb832095391af525e73a61370c9105592b
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16293/files/0ce0757a913c3814ff10a4012be7fa4b59e710d5
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/16293/files/96fcee8a4e908a39c19fdb38edfd021355433e8c
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/16293/files/03358aabc15a6d9ce23266f5102de91e5c69994f
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/16293/files/96fcee8a4e908a39c19fdb38edfd021355433e8c
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
9.0.0 https://github.com/nodejs/node/milestone/25
vm: known issue with CopyProperties throw on empty code https://github.com/nodejs/node/issues/11902
assert.deepStrictEqual() fails to compare ES6 style object properties https://github.com/nodejs/node/issues/11803
Object.defineProperty on the global object does not handle 'writable' properly in vm context https://github.com/nodejs/node/issues/10223
vm: accessor properties get converted to data properties inside the vm https://github.com/nodejs/node/issues/2734
Please reload this pagehttps://github.com/nodejs/node/pull/16293
https://github.com/fhinkel
https://github.com/TimothyGu
https://github.com/cpojer
https://github.com/SimenB
https://github.com/targos
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.