René's URL Explorer Experiment


Title: http2: support generic `Duplex` streams by addaleax · Pull Request #16269 · nodejs/node · GitHub

Open Graph Title: http2: support generic `Duplex` streams by addaleax · Pull Request #16269 · nodejs/node

X Title: http2: support generic `Duplex` streams by addaleax · Pull Request #16269 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Commits: src: allow top-level calls into JSStream Allow JSStream instances to be used more flexibly by explicitly enabling calls that have no JS stack below them. src: turn JS stream into a ful...

X Description: Commits: src: allow top-level calls into JSStream Allow JSStream instances to be used more flexibly by explicitly enabling calls that have no JS stack below them. src: turn JS stream into a ful...

Opengraph URL: https://github.com/nodejs/node/pull/16269

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:860b8bcc-d7dc-09ad-5b14-332a425dccb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9648:E530F:11C757D:17A5594:6AED5993
html-safe-nonce0ef8a17c7b3c5dd55840fdab0365da440b2511e0af307d8229a0530ab3b17797
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjQ4OkU1MzBGOjExQzc1N0Q6MTdBNTU5NDo2QUVENTk5MyIsInZpc2l0b3JfaWQiOiI4ODAwOTQyNzQyMTU4NzkzMTA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6bbe4124f4df7e3ddb4712d6d4c593fbe0110ab0baecbb528cb7fc7b0d2ea6fc
hovercard-subject-tagpull_request:147172965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16269/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2fc071abd774c2870e1d3c245ca26b344df95e95660efd0fe473661d6d31e6f5/nodejs/node/pull/16269
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2fc071abd774c2870e1d3c245ca26b344df95e95660efd0fe473661d6d31e6f5/nodejs/node/pull/16269
og:image:altCommits: src: allow top-level calls into JSStream Allow JSStream instances to be used more flexibly by explicitly enabling calls that have no JS stack below them. src: turn JS stream into a ful...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/16269/#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16269%2F
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16269%2F
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/16269/
Reloadhttps://github.com/nodejs/node/pull/16269/
Reloadhttps://github.com/nodejs/node/pull/16269/
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http2-generic-streamshttps://github.com/addaleax/node/tree/http2-generic-streams
Conversationhttps://github.com/nodejs/node/pull/16269
Commits4 (4)https://github.com/nodejs/node/pull/16269/commits
Checkshttps://github.com/nodejs/node/pull/16269/checks
Files changedhttps://github.com/nodejs/node/pull/16269/files
http2: support generic Duplex streamshttps://github.com/nodejs/node/pull/16269/#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:http2-generic-streamshttps://github.com/addaleax/node/tree/http2-generic-streams
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#issue-266305597
#16256https://github.com/nodejs/node/issues/16256
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#event-1297960102
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#event-1297960168
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2017 https://github.com/nodejs/node/pull/16269/#ref-issue-266101331
We "need" a way to create an Http2Session from a socket #16256 https://github.com/nodejs/node/issues/16256
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#issuecomment-337401869
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://ci.nodejs.org/job/node-test-commit/13238/https://ci.nodejs.org/job/node-test-commit/13238/
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/a0b1a2efd5e54124b9fad2b1700e9cd618937e07..fe69dca5725365663886fff0e509531fab66ddbe
a0b1a2ehttps://github.com/nodejs/node/commit/a0b1a2efd5e54124b9fad2b1700e9cd618937e07
fe69dcahttps://github.com/nodejs/node/commit/fe69dca5725365663886fff0e509531fab66ddbe
Compare https://github.com/nodejs/node/compare/a0b1a2efd5e54124b9fad2b1700e9cd618937e07..fe69dca5725365663886fff0e509531fab66ddbe
October 17, 2017 23:14https://github.com/nodejs/node/pull/16269/#event-1297985528
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/16269/#pullrequestreview-70062292
View reviewed changes https://github.com/nodejs/node/pull/16269/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/16269/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
jasnellhttps://github.com/jasnell
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145283985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
jasnellhttps://github.com/jasnell
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145284163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145284251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145284471
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
jasnellhttps://github.com/jasnell
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145285125
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
jasnellhttps://github.com/jasnell
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145285502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 18, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145358539
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/16269/#pullrequestreview-70062937
View reviewed changes https://github.com/nodejs/node/pull/16269/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/16269/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
jasnellhttps://github.com/jasnell
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145284600
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 18, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145358542
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145968476
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146036754
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
jasnellhttps://github.com/jasnell
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146041519
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/jasnell
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
October 17, 2017 23:43https://github.com/nodejs/node/pull/16269/#event-1298026615
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/16269/#pullrequestreview-70065133
View reviewed changes https://github.com/nodejs/node/pull/16269/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/16269/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
jasnellhttps://github.com/jasnell
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145286656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 18, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145358557
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
jasnellhttps://github.com/jasnell
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146041314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/16269/#pullrequestreview-70065841
View reviewed changes https://github.com/nodejs/node/pull/16269/files
test/parallel/test-http2-generic-streams.jshttps://github.com/nodejs/node/pull/16269/files#diff-ba359c9b4633f94d06b65b47ecc2fd8b83f6caf1b80b00fd75db747c01fbcb9e
jasnellhttps://github.com/jasnell
Oct 17, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145287319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 18, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145358563
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
jasnellhttps://github.com/jasnell
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146041664
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 18, 2017 https://github.com/nodejs/node/pull/16269/#pullrequestreview-70111921
View reviewed changes https://github.com/nodejs/node/pull/16269/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/16269/#pullrequestreview-70111921
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 18, 2017https://github.com/nodejs/node/pull/16269/#issuecomment-337520147
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Oct 20, 2017 https://github.com/nodejs/node/pull/16269/#pullrequestreview-70844006
View reviewed changes https://github.com/nodejs/node/pull/16269/files
apapirovskihttps://github.com/apapirovski
https://github.com/nodejs/node/pull/16269/#pullrequestreview-70844006
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/16269/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145964762
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146039748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146042127
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
test/parallel/test-http2-generic-streams-sendfile.jshttps://github.com/nodejs/node/pull/16269/files#diff-04d876d4143de250a39a6aa9330e10a9b1c941c3af06084dc3f42f5c388ccffb
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145965458
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146040180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
test/parallel/test-http2-generic-streams-sendfile.jshttps://github.com/nodejs/node/pull/16269/files#diff-04d876d4143de250a39a6aa9330e10a9b1c941c3af06084dc3f42f5c388ccffb
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145965818
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146040343
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
jasnellhttps://github.com/jasnell
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146040786
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146042749
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146043654
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
test/common/README.mdhttps://github.com/nodejs/node/pull/16269/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r145966791
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146040565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
apapirovskihttps://github.com/apapirovski
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146042209
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
Oct 20, 2017https://github.com/nodejs/node/pull/16269/#discussion_r146042484
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 20, 2017 https://github.com/nodejs/node/pull/16269/#pullrequestreview-70935624
View reviewed changes https://github.com/nodejs/node/pull/16269/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/5bb1fa584de88528a8e4904f6e78adab58dcbc9b..621d2d77564a656bbe0af079cdc8b5905d9e2823
5bb1fa5https://github.com/nodejs/node/commit/5bb1fa584de88528a8e4904f6e78adab58dcbc9b
621d2d7https://github.com/nodejs/node/commit/621d2d77564a656bbe0af079cdc8b5905d9e2823
Compare https://github.com/nodejs/node/compare/5bb1fa584de88528a8e4904f6e78adab58dcbc9b..621d2d77564a656bbe0af079cdc8b5905d9e2823
October 20, 2017 18:58https://github.com/nodejs/node/pull/16269/#event-1303579683
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 22, 2017https://github.com/nodejs/node/pull/16269/#issuecomment-338482433
https://ci.nodejs.org/job/node-test-commit/13370/https://ci.nodejs.org/job/node-test-commit/13370/
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
addaleaxhttps://github.com/addaleax
October 22, 2017 17:05https://github.com/nodejs/node/pull/16269/#commits-pushed-0b947ab
https://github.com/addaleax
src: allow top-level calls into JSStreamhttps://github.com/nodejs/node/pull/16269/commits/0b947ab94dd17c002ba1b3885456664dd93fbd42
0b947abhttps://github.com/nodejs/node/pull/16269/commits/0b947ab94dd17c002ba1b3885456664dd93fbd42
nodejs#16269https://github.com/nodejs/node/pull/16269
https://github.com/addaleax
src: turn JS stream into a full duplexhttps://github.com/nodejs/node/pull/16269/commits/4c674f7a361d1d27ca9c9a0de22fc1af7d420008
4c674f7https://github.com/nodejs/node/pull/16269/commits/4c674f7a361d1d27ca9c9a0de22fc1af7d420008
nodejs#16269https://github.com/nodejs/node/pull/16269
https://github.com/addaleax
test: add makeDuplexPair() helperhttps://github.com/nodejs/node/pull/16269/commits/ac1b4750cdf5c5f17d04acf18be47b070e2ef455
ac1b475https://github.com/nodejs/node/pull/16269/commits/ac1b4750cdf5c5f17d04acf18be47b070e2ef455
nodejs#16269https://github.com/nodejs/node/pull/16269
https://github.com/addaleax
http2: support generic Duplex streamshttps://github.com/nodejs/node/pull/16269/commits/966e621e16ceaf06a1b8e37d39e5a2d6a93fe379
966e621https://github.com/nodejs/node/pull/16269/commits/966e621e16ceaf06a1b8e37d39e5a2d6a93fe379
nodejs#16256https://github.com/nodejs/node/issues/16256
nodejs#16269https://github.com/nodejs/node/pull/16269
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/2a666de1940ba1305b7a81989c3d388e3a5d94c7..966e621e16ceaf06a1b8e37d39e5a2d6a93fe379
2a666dehttps://github.com/nodejs/node/commit/2a666de1940ba1305b7a81989c3d388e3a5d94c7
966e621https://github.com/nodejs/node/commit/966e621e16ceaf06a1b8e37d39e5a2d6a93fe379
Compare https://github.com/nodejs/node/compare/2a666de1940ba1305b7a81989c3d388e3a5d94c7..966e621e16ceaf06a1b8e37d39e5a2d6a93fe379
October 22, 2017 15:07https://github.com/nodejs/node/pull/16269/#event-1304557582
addaleaxhttps://github.com/addaleax
Oct 22, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-f54889a
https://github.com/addaleax
test: add makeDuplexPair() helperhttps://github.com/addaleax/node/commit/f54889ae000f2d01039ceaaa158dbba99a5b933f
f54889ahttps://github.com/addaleax/node/commit/f54889ae000f2d01039ceaaa158dbba99a5b933f
nodejs#16269https://github.com/nodejs/node/pull/16269
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 23, 2017https://github.com/nodejs/node/pull/16269/#issuecomment-338691443
ba4a0a6...ab16eechttps://github.com/nodejs/node/compare/ba4a0a6f5f9f0172e182da4e9000fec8956d0689...ab16eec4369f60f14014933886f84a926488f368
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 23, 2017https://github.com/nodejs/node/pull/16269/#event-1305852603
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
October 23, 2017 15:11https://github.com/nodejs/node/pull/16269/#event-1305852754
addaleaxhttps://github.com/addaleax
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-127f83a
https://github.com/addaleax
src: allow top-level calls into JSStreamhttps://github.com/nodejs/node/commit/127f83ab8d243d1c248b1fa7373c5f58426696f1
127f83ahttps://github.com/nodejs/node/commit/127f83ab8d243d1c248b1fa7373c5f58426696f1
#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-170bc31
https://github.com/addaleax
src: turn JS stream into a full duplexhttps://github.com/nodejs/node/commit/170bc3166963a9d8811b5bcdd45de6b12827f55c
170bc31https://github.com/nodejs/node/commit/170bc3166963a9d8811b5bcdd45de6b12827f55c
#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-e340a66
https://github.com/addaleax
test: add makeDuplexPair() helperhttps://github.com/nodejs/node/commit/e340a66cb1c951620b360b9420269b36c742ba57
e340a66https://github.com/nodejs/node/commit/e340a66cb1c951620b360b9420269b36c742ba57
#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-ab16eec
https://github.com/addaleax
http2: support generic Duplex streamshttps://github.com/nodejs/node/commit/ab16eec4369f60f14014933886f84a926488f368
ab16eechttps://github.com/nodejs/node/commit/ab16eec4369f60f14014933886f84a926488f368
#16256https://github.com/nodejs/node/issues/16256
#16269https://github.com/nodejs/node/pull/16269
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-2788cb7
https://github.com/addaleax
https://github.com/MylesBorins
src: allow top-level calls into JSStreamhttps://github.com/nodejs/node/commit/2788cb75245ce9aa7247d97f698fecc8f5804188
2788cb7https://github.com/nodejs/node/commit/2788cb75245ce9aa7247d97f698fecc8f5804188
#16269https://github.com/nodejs/node/pull/16269
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-d356022
https://github.com/addaleax
https://github.com/MylesBorins
src: turn JS stream into a full duplexhttps://github.com/nodejs/node/commit/d356022087fe51a8ca10f8e64a4c231556eb4388
d356022https://github.com/nodejs/node/commit/d356022087fe51a8ca10f8e64a4c231556eb4388
#16269https://github.com/nodejs/node/pull/16269
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-80b0dcf
https://github.com/addaleax
https://github.com/MylesBorins
test: add makeDuplexPair() helperhttps://github.com/nodejs/node/commit/80b0dcfd2b9424024770757445ece48d5eccabea
80b0dcfhttps://github.com/nodejs/node/commit/80b0dcfd2b9424024770757445ece48d5eccabea
#16269https://github.com/nodejs/node/pull/16269
MylesBorinshttps://github.com/MylesBorins
Oct 23, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-63036a8
https://github.com/addaleax
https://github.com/MylesBorins
http2: support generic Duplex streamshttps://github.com/nodejs/node/commit/63036a8d6db1ed2e1eeb075270f9cac5eceab02c
63036a8https://github.com/nodejs/node/commit/63036a8d6db1ed2e1eeb075270f9cac5eceab02c
#16256https://github.com/nodejs/node/issues/16256
#16269https://github.com/nodejs/node/pull/16269
MylesBorinshttps://github.com/MylesBorins
Oct 24, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-9aa31bc
https://github.com/MylesBorins
2017-10-24, Node.js Version 8.8.0 (Current)https://github.com/nodejs/node/commit/9aa31bccb4e3ee16d4dc908c083f3d0f9d0e7801
https://github.com/nodejs/node/commit/9aa31bccb4e3ee16d4dc908c083f3d0f9d0e7801#comments
9aa31bchttps://github.com/nodejs/node/commit/9aa31bccb4e3ee16d4dc908c083f3d0f9d0e7801
#8188https://github.com/nodejs/node/pull/8188
#15685https://github.com/nodejs/node/pull/15685
#15685https://github.com/nodejs/node/pull/15685
#16269https://github.com/nodejs/node/pull/16269
#15445https://github.com/nodejs/node/pull/15445
CVE-2017-14919https://github.com/advisories/GHSA-mvc4-gp8c-r52f
https://github.com/nodejs-private/node-private/pull/95https://github.com/nodejs-private/node-private/pull/95
https://github.com/nodejs-private/node-private/pull/98https://github.com/nodejs-private/node-private/pull/98
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-162da27
https://github.com/addaleax
src: allow top-level calls into JSStreamhttps://github.com/ayojs/ayo/commit/162da2781f98d61f1a1cdbcccfe81f5c964f7c6b
162da27https://github.com/ayojs/ayo/commit/162da2781f98d61f1a1cdbcccfe81f5c964f7c6b
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-1d3ec4a
https://github.com/addaleax
src: turn JS stream into a full duplexhttps://github.com/ayojs/ayo/commit/1d3ec4a1a67888cf9c2d70bb6d82f466dee71020
1d3ec4ahttps://github.com/ayojs/ayo/commit/1d3ec4a1a67888cf9c2d70bb6d82f466dee71020
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-4b1f83a
https://github.com/addaleax
test: add makeDuplexPair() helperhttps://github.com/ayojs/ayo/commit/4b1f83a33a11f3dc3a5ce31daa519bfdc93cb069
4b1f83ahttps://github.com/ayojs/ayo/commit/4b1f83a33a11f3dc3a5ce31daa519bfdc93cb069
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-dbef020
https://github.com/addaleax
http2: support generic Duplex streamshttps://github.com/ayojs/ayo/commit/dbef020c28f6b79d49d762828aad1f6416fa18e7
dbef020https://github.com/ayojs/ayo/commit/dbef020c28f6b79d49d762828aad1f6416fa18e7
nodejs/node#16256https://github.com/nodejs/node/issues/16256
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Oct 26, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-e0a3e55
https://github.com/MylesBorins
https://github.com/addaleax
2017-10-24, Node.js Version 8.8.0 (Current)https://github.com/ayojs/ayo/commit/e0a3e550ea9f1cec6cdbed65ebaf2c0f7bafe08c
e0a3e55https://github.com/ayojs/ayo/commit/e0a3e550ea9f1cec6cdbed65ebaf2c0f7bafe08c
nodejs/node#8188https://github.com/nodejs/node/pull/8188
nodejs/node#15685https://github.com/nodejs/node/pull/15685
nodejs/node#15685https://github.com/nodejs/node/pull/15685
nodejs/node#16269https://github.com/nodejs/node/pull/16269
nodejs/node#15445https://github.com/nodejs/node/pull/15445
CVE-2017-14919https://github.com/advisories/GHSA-mvc4-gp8c-r52f
nodejs-private/node-private#95https://github.com/nodejs-private/node-private/pull/95
nodejs-private/node-private#98https://github.com/nodejs-private/node-private/pull/98
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-6cbef5a
https://github.com/addaleax
src: allow top-level calls into JSStreamhttps://github.com/ayojs/ayo/commit/6cbef5a659a232870b82e3e550a2c6ebc204abeb
6cbef5ahttps://github.com/ayojs/ayo/commit/6cbef5a659a232870b82e3e550a2c6ebc204abeb
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-4e57be1
https://github.com/addaleax
src: turn JS stream into a full duplexhttps://github.com/ayojs/ayo/commit/4e57be1188f9236eaf3254b31289b2872d009875
4e57be1https://github.com/ayojs/ayo/commit/4e57be1188f9236eaf3254b31289b2872d009875
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-862d9c4
https://github.com/addaleax
test: add makeDuplexPair() helperhttps://github.com/ayojs/ayo/commit/862d9c4e4ce22958e3139650710da6dab3a3f48b
862d9c4https://github.com/ayojs/ayo/commit/862d9c4e4ce22958e3139650710da6dab3a3f48b
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-39ef416
https://github.com/addaleax
http2: support generic Duplex streamshttps://github.com/ayojs/ayo/commit/39ef4166933878375c0f8b3fe86d42b284944ff4
39ef416https://github.com/ayojs/ayo/commit/39ef4166933878375c0f8b3fe86d42b284944ff4
nodejs/node#16256https://github.com/nodejs/node/issues/16256
nodejs/node#16269https://github.com/nodejs/node/pull/16269
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/16269/#ref-commit-40cbb25
https://github.com/MylesBorins
https://github.com/addaleax
2017-10-24, Node.js Version 8.8.0 (Current)https://github.com/ayojs/ayo/commit/40cbb25094ab45c5c04bd0ce062a519be8b7a084
40cbb25https://github.com/ayojs/ayo/commit/40cbb25094ab45c5c04bd0ce062a519be8b7a084
nodejs/node#8188https://github.com/nodejs/node/pull/8188
nodejs/node#15685https://github.com/nodejs/node/pull/15685
nodejs/node#15685https://github.com/nodejs/node/pull/15685
nodejs/node#16269https://github.com/nodejs/node/pull/16269
nodejs/node#15445https://github.com/nodejs/node/pull/15445
CVE-2017-14919https://github.com/advisories/GHSA-mvc4-gp8c-r52f
nodejs-private/node-private#95https://github.com/nodejs-private/node-private/pull/95
nodejs-private/node-private#98https://github.com/nodejs-private/node-private/pull/98
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 15, 2018https://github.com/nodejs/node/pull/16269/#event-1425143465
MylesBorinshttps://github.com/MylesBorins
Jan 22, 2018 https://github.com/nodejs/node/pull/16269/#ref-commit-ca667b9
https://github.com/addaleax
https://github.com/MylesBorins
test: add makeDuplexPair() helperhttps://github.com/nodejs/node/commit/ca667b9a3ba03e314d1b2f377fdd4560d88a7da7
ca667b9https://github.com/nodejs/node/commit/ca667b9a3ba03e314d1b2f377fdd4560d88a7da7
#16269https://github.com/nodejs/node/pull/16269
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2018 https://github.com/nodejs/node/pull/16269/#ref-pullrequest-291141723
v6.13.0 proposal #18342 https://github.com/nodejs/node/pull/18342
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2018 https://github.com/nodejs/node/pull/16269/#ref-commit-b43fe60
https://github.com/addaleax
https://github.com/MylesBorins
test: add makeDuplexPair() helperhttps://github.com/nodejs/node/commit/b43fe6040fbc9d3035529f98835bc70aa09539ba
b43fe60https://github.com/nodejs/node/commit/b43fe6040fbc9d3035529f98835bc70aa09539ba
#16269https://github.com/nodejs/node/pull/16269
MylesBorinshttps://github.com/MylesBorins
Feb 12, 2018 https://github.com/nodejs/node/pull/16269/#ref-commit-9d2c604
https://github.com/addaleax
https://github.com/MylesBorins
test: add makeDuplexPair() helperhttps://github.com/nodejs/node/commit/9d2c60420a4bc4deae02e997305d4fd6c2d7e7f8
9d2c604https://github.com/nodejs/node/commit/9d2c60420a4bc4deae02e997305d4fd6c2d7e7f8
#16269https://github.com/nodejs/node/pull/16269
MylesBorinshttps://github.com/MylesBorins
Feb 13, 2018 https://github.com/nodejs/node/pull/16269/#ref-commit-af3e074
https://github.com/addaleax
https://github.com/MylesBorins
test: add makeDuplexPair() helperhttps://github.com/nodejs/node/commit/af3e07424950b86a7251c247eac0d9a9d90e3127
af3e074https://github.com/nodejs/node/commit/af3e07424950b86a7251c247eac0d9a9d90e3127
#16269https://github.com/nodejs/node/pull/16269
uannoarehttps://github.com/uannoare
Oct 8, 2025 https://github.com/nodejs/node/pull/16269/#ref-commit-b9cdef5
https://github.com/MylesBorins
2017-10-24, Node.js Version 8.8.0 (Current)https://github.com/uannoare/node/commit/b9cdef5a4b3b5a426770fa7d13c14dbc02975a9a
b9cdef5https://github.com/uannoare/node/commit/b9cdef5a4b3b5a426770fa7d13c14dbc02975a9a
nodejs/node#8188https://github.com/nodejs/node/pull/8188
nodejs/node#15685https://github.com/nodejs/node/pull/15685
nodejs/node#15685https://github.com/nodejs/node/pull/15685
nodejs/node#16269https://github.com/nodejs/node/pull/16269
nodejs/node#15445https://github.com/nodejs/node/pull/15445
CVE-2017-14919https://github.com/advisories/GHSA-mvc4-gp8c-r52f
https://github.com/nodejs-private/node-private/pull/95https://github.com/nodejs-private/node-private/pull/95
https://github.com/nodejs-private/node-private/pull/98https://github.com/nodejs-private/node-private/pull/98
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 14, 2026 https://github.com/nodejs/node/pull/16269/#ref-pullrequest-5429537653
quic: add Http3Session, so you can explicitly pick the app protocol #65993 https://github.com/nodejs/node/pull/65993
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/16269/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16269%2F
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/16269/files/fe69dca5725365663886fff0e509531fab66ddbe
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/16269/files/5bb1fa584de88528a8e4904f6e78adab58dcbc9b
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/16269/files/b454b36ef4da43db54ae18697aa7e8eac333f56c
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/16269/
https://github.com/addaleax
https://github.com/apapirovski
https://github.com/mcollina
https://github.com/jasnell
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.