| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2dcc61cd-e9c5-e1ff-5a3a-c564c5e3d79f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B902:19FB97:1C5CC6:28221E:696A0F7C |
| html-safe-nonce | ef03d12261bafe698f9e35d251279a8c15e80f0dd623d4ad5cbb2b6d67f13618 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTAyOjE5RkI5NzoxQzVDQzY6MjgyMjFFOjY5NkEwRjdDIiwidmlzaXRvcl9pZCI6IjgwMDIzMzM5NDkxNjY5MTgzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 03e1216d4b03f8edb1211c4fcc99475aab085295c6bba2580574a2e183cbee4c |
| hovercard-subject-tag | pull_request:146810023 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/16237/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8183b587ec10186734ac2e658b5999c1de43f92132775ef13b6c2e280548fd00/nodejs/node/pull/16237 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8183b587ec10186734ac2e658b5999c1de43f92132775ef13b6c2e280548fd00/nodejs/node/pull/16237 |
| og:image:alt | This commit changes node's handling of two-byte characters in the path component
of an http URL. Previously, node would just strip the higher byte when
generating the request. So this code:
htt... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bennofs |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/16237#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16237 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16237 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/16237 |
| Reload | https://github.com/nodejs/node/pull/16237 |
| Reload | https://github.com/nodejs/node/pull/16237 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
698
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/16237#issue-comment-box |
| bennofs | https://github.com/bennofs |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bennofs:master | https://github.com/bennofs/node/tree/master |
|
http: disallow two-byte characters in URL path
| https://github.com/nodejs/node/pull/16237#top |
| bennofs | https://github.com/bennofs |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bennofs:master | https://github.com/bennofs/node/tree/master |
|
Conversation
45
| https://github.com/nodejs/node/pull/16237 |
|
Commits
4
| https://github.com/nodejs/node/pull/16237/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/16237/checks |
|
Files changed
| https://github.com/nodejs/node/pull/16237/files |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#issue-265804323 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#event-1295036664 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 16, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-69599673 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files |
| test/parallel/test-http-client-invalid-path.js | https://github.com/nodejs/node/pull/16237/files#diff-81e37bb18bd7f17440f6c877aefb270ed99fbb2c75bee5aad566507544a11ab0 |
| lpinca | https://github.com/lpinca |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r144880780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 16, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-69620551 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files |
| lib/_http_client.js | https://github.com/nodejs/node/pull/16237/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| joyeecheung | https://github.com/joyeecheung |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r144899001 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-336948969 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| @bennofs | https://github.com/bennofs |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-336950664 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-336952234 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://www.blackhat.com/docs/us-17/thursday/us-17-Tsai-A-New-Era-Of-SSRF-Exploiting-URL-Parser-In-Trending-Programming-Languages.pdf | https://www.blackhat.com/docs/us-17/thursday/us-17-Tsai-A-New-Era-Of-SSRF-Exploiting-URL-Parser-In-Trending-Programming-Languages.pdf |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| bnoordhuis | https://github.com/bnoordhuis |
| mscdex | https://github.com/mscdex |
| October 16, 2017 17:03 | https://github.com/nodejs/node/pull/16237#event-1295264677 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Oct 16, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-69633375 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files |
| lib/_http_client.js | https://github.com/nodejs/node/pull/16237/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| mscdex | https://github.com/mscdex |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r144910438 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bennofs | https://github.com/bennofs |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r144915264 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r144957867 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #13296 (comment) | https://github.com/nodejs/node/issues/13296#issuecomment-305162413 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bennofs | https://github.com/bennofs |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r144967219 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bennofs | https://github.com/bennofs |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r144967881 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 18, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r145523643 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bennofs | https://github.com/bennofs |
| Oct 19, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r145679626 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| apapirovski | https://github.com/apapirovski |
| Oct 19, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r145709907 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| apapirovski | https://github.com/apapirovski |
| Oct 19, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r145712057 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #13296 | https://github.com/nodejs/node/issues/13296 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bnoordhuis | https://github.com/bnoordhuis |
| Oct 19, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r145797449 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-336962348 |
| @bennofs | https://github.com/bennofs |
| https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md | https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-337257414 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-337264827 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 19, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-70598987 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/16237#pullrequestreview-70598987 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Oct 19, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-337961857 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 19, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-337963574 |
| @apapirovski | https://github.com/apapirovski |
| #8923 | https://github.com/nodejs/node/pull/8923 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-338253092 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| bennofs | https://github.com/bennofs |
| November 22, 2017 18:40 | https://github.com/nodejs/node/pull/16237#commits-pushed-844a470 |
|
| https://github.com/bennofs |
| http: disallow two-byte characters in URL path | https://github.com/nodejs/node/pull/16237/commits/844a470fbb7ee02b21a0b38abcae37eb9d3e0234 |
| 844a470 | https://github.com/nodejs/node/pull/16237/commits/844a470fbb7ee02b21a0b38abcae37eb9d3e0234 |
| http://example.com/.` | http://example.com/.` |
|
| https://github.com/bennofs |
| fixup! http: disallow two-byte characters in URL path | https://github.com/nodejs/node/pull/16237/commits/eab523ce8117455bfe015a069e42725ed0716fbf |
| eab523c | https://github.com/nodejs/node/pull/16237/commits/eab523ce8117455bfe015a069e42725ed0716fbf |
|
| https://github.com/bennofs |
| fixup! http: disallow two-byte characters in URL path | https://github.com/nodejs/node/pull/16237/commits/58ac26f60ea622d97acfec61c5e017ce22e8f9d2 |
| 58ac26f | https://github.com/nodejs/node/pull/16237/commits/58ac26f60ea622d97acfec61c5e017ce22e8f9d2 |
|
| https://github.com/bennofs |
| http: always use regex for invalid path check | https://github.com/nodejs/node/pull/16237/commits/60b3290a50879ade234835c95c16109e19757baa |
| 60b3290 | https://github.com/nodejs/node/pull/16237/commits/60b3290a50879ade234835c95c16109e19757baa |
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346425224 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346425726 |
| https://ci.nodejs.org/job/node-test-pull-request/11638/ | https://ci.nodejs.org/job/node-test-pull-request/11638/ |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-78530070 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-78537539 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346432941 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346433105 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346433584 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| force-pushed | https://github.com/nodejs/node/compare/31e71d1c0822dc59d8e2376b0ea6d2c95ccc13dd..60b3290a50879ade234835c95c16109e19757baa |
| 31e71d1 | https://github.com/nodejs/node/commit/31e71d1c0822dc59d8e2376b0ea6d2c95ccc13dd |
| 60b3290 | https://github.com/nodejs/node/commit/60b3290a50879ade234835c95c16109e19757baa |
|
Compare
| https://github.com/nodejs/node/compare/31e71d1c0822dc59d8e2376b0ea6d2c95ccc13dd..60b3290a50879ade234835c95c16109e19757baa |
| November 22, 2017 21:43 | https://github.com/nodejs/node/pull/16237#event-1354908267 |
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346481561 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346481811 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346488367 |
| @apapirovski | https://github.com/apapirovski |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346488656 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346488695 |
| @bennofs | https://github.com/bennofs |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Nov 22, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-78593147 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files/60b3290a50879ade234835c95c16109e19757baa |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 22, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346489115 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Nov 23, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-78613046 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files/60b3290a50879ade234835c95c16109e19757baa |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346591540 |
| https://ci.nodejs.org/job/node-test-pull-request/11665/ | https://ci.nodejs.org/job/node-test-pull-request/11665/ |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/16237#event-1355606696 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346597825 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1103/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1103/ |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1104/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1104/ |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346645218 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/bennofs |
| bennofs | https://github.com/bennofs |
| Nov 23, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-346647694 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/Mickael-van-der-Beek |
| Mickael-van-der-Beek | https://github.com/Mickael-van-der-Beek |
|
Nov 29, 2017
| https://github.com/nodejs/node/pull/16237#ref-issue-277834301 |
|
Node.js / HTTP-Parser not handling UTF-8 encoded HTTP header values
#17390
| https://github.com/nodejs/node/issues/17390 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 1, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-348604147 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Dec 2, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-348705050 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 3, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-348755917 |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Dec 7, 2017
| https://github.com/nodejs/node/pull/16237#ref-pullrequest-280134197 |
|
http: simplify isInvalidPath
#17525
| https://github.com/nodejs/node/pull/17525 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Dec 7, 2017
| https://github.com/nodejs/node/pull/16237#pullrequestreview-82011731 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/16237/files/60b3290a50879ade234835c95c16109e19757baa |
| lib/_http_client.js | https://github.com/nodejs/node/pull/16237/files/60b3290a50879ade234835c95c16109e19757baa#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| TimothyGu | https://github.com/TimothyGu |
| Dec 7, 2017 | https://github.com/nodejs/node/pull/16237#discussion_r155655998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728 |
| b7405ab | https://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117 |
| 7f086dd | https://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728 |
|
Compare
| https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728 |
| December 8, 2017 16:37 | https://github.com/nodejs/node/pull/16237#event-1379145173 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Dec 10, 2017 | https://github.com/nodejs/node/pull/16237#event-1380226479 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/16237#issuecomment-351067978 |
| b961d9f | https://github.com/nodejs/node/commit/b961d9fd83c963657c2305ed13ff447573eac852 |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/16237#event-1383646850 |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/16237#ref-commit-b961d9f |
|
| https://github.com/bennofs |
|
| https://github.com/BridgeAR |
| http: disallow two-byte characters in URL path | https://github.com/nodejs/node/commit/b961d9fd83c963657c2305ed13ff447573eac852 |
|
| https://github.com/nodejs/node/commit/b961d9fd83c963657c2305ed13ff447573eac852#comments |
| b961d9f | https://github.com/nodejs/node/commit/b961d9fd83c963657c2305ed13ff447573eac852 |
| http://example.com/.` | http://example.com/.` |
| #16237 | https://github.com/nodejs/node/pull/16237 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 13, 2017 | https://github.com/nodejs/node/pull/16237#event-1384949003 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
security
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asecurity |
| Jan 28, 2018 | https://github.com/nodejs/node/pull/16237#event-1445368348 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F16237 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/16237/files/018e7ac43a1172248a2e82e1d492512c2cd59f47 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/16237/files/018e7ac43a1172248a2e82e1d492512c2cd59f47 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/16237/files/31e71d1c0822dc59d8e2376b0ea6d2c95ccc13dd |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/16237/files/31e71d1c0822dc59d8e2376b0ea6d2c95ccc13dd |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/16237/files/60b3290a50879ade234835c95c16109e19757baa |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/16237/files/31e71d1c0822dc59d8e2376b0ea6d2c95ccc13dd |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/16237/files/60b3290a50879ade234835c95c16109e19757baa |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/16237/files/60b3290a50879ade234835c95c16109e19757baa |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
security
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asecurity |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/16237 |
|
| https://github.com/bennofs |
|
| https://github.com/apapirovski |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com/bnoordhuis |
|
| https://github.com/mscdex |
|
| https://github.com/lpinca |
|
| https://github.com/TimothyGu |
|
| https://github.com/joyeecheung |
|
| https://github.com/ChALkeR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |