René's URL Explorer Experiment


Title: AsyncWrap minor fixes by trevnorris · Pull Request #1614 · nodejs/node · GitHub

Open Graph Title: AsyncWrap minor fixes by trevnorris · Pull Request #1614 · nodejs/node

X Title: AsyncWrap minor fixes by trevnorris · Pull Request #1614 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Finally getting around to finishing the AsyncWrap implementation. Here are some mostly minor changes. One specifically is breaking. Instead of needing to set the object field to enable/disable call...

X Description: Finally getting around to finishing the AsyncWrap implementation. Here are some mostly minor changes. One specifically is breaking. Instead of needing to set the object field to enable/disable call...

Opengraph URL: https://github.com/nodejs/node/pull/1614

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:53f7f4a1-7721-a239-9f12-5cd5a0fa097e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE754:13657F:4B307B:6DBFFF:6A4E09A4
html-safe-nonce74d9aaef9c1675a0c4574a8cc0248549d9d0cba96c7df995da0ca849d502da5e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzU0OjEzNjU3Rjo0QjMwN0I6NkRCRkZGOjZBNEUwOUE0IiwidmlzaXRvcl9pZCI6IjQ0NTU1MDM0OTAxNTY3MjY2OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac49643a107717719a904e12432deda039fd16bfc421015bc14f5ce36bf6501ca6
hovercard-subject-tagpull_request:34681168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1614/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5d66883618527dce7557e1a60cda20ee9ac69b597a5ec16aa7d5a069c66458b3/nodejs/node/pull/1614
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5d66883618527dce7557e1a60cda20ee9ac69b597a5ec16aa7d5a069c66458b3/nodejs/node/pull/1614
og:image:altFinally getting around to finishing the AsyncWrap implementation. Here are some mostly minor changes. One specifically is breaking. Instead of needing to set the object field to enable/disable call...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1614#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1614
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1614
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1614
Reloadhttps://github.com/nodejs/node/pull/1614
Reloadhttps://github.com/nodejs/node/pull/1614
Please reload this pagehttps://github.com/nodejs/node/pull/1614
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1614
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:async-wrap-minor-fixeshttps://github.com/trevnorris/node/tree/async-wrap-minor-fixes
Conversationhttps://github.com/nodejs/node/pull/1614
Commits4 (4)https://github.com/nodejs/node/pull/1614/commits
Checkshttps://github.com/nodejs/node/pull/1614/checks
Files changedhttps://github.com/nodejs/node/pull/1614/files
AsyncWrap minor fixeshttps://github.com/nodejs/node/pull/1614#top
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:async-wrap-minor-fixeshttps://github.com/trevnorris/node/tree/async-wrap-minor-fixes
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
May 4, 2015https://github.com/nodejs/node/pull/1614#issue-73143607
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1614
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/72d62fbcc78d2db6e58fac4310e1708d51b72527..d7e0c53a9a5fb58e1fb9a3197718755fc2d0c3ab
72d62fbhttps://github.com/nodejs/node/commit/72d62fbcc78d2db6e58fac4310e1708d51b72527
d7e0c53https://github.com/nodejs/node/commit/d7e0c53a9a5fb58e1fb9a3197718755fc2d0c3ab
Compare https://github.com/nodejs/node/compare/72d62fbcc78d2db6e58fac4310e1708d51b72527..d7e0c53a9a5fb58e1fb9a3197718755fc2d0c3ab
May 4, 2015 22:29https://github.com/nodejs/node/pull/1614#event-296712128
https://github.com/trevnorris
async-wrap: don't call init callback unnecessarilyhttps://github.com/nodejs/node/pull/1614/commits/3f5159017f536302d916a6533770b00463d98ea8
3f51590https://github.com/nodejs/node/pull/1614/commits/3f5159017f536302d916a6533770b00463d98ea8
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/d7e0c53a9a5fb58e1fb9a3197718755fc2d0c3ab..13e52fef9cfdef1fb64713486ad0c5e776c73dbc
d7e0c53https://github.com/nodejs/node/commit/d7e0c53a9a5fb58e1fb9a3197718755fc2d0c3ab
13e52fehttps://github.com/nodejs/node/commit/13e52fef9cfdef1fb64713486ad0c5e776c73dbc
Compare https://github.com/nodejs/node/compare/d7e0c53a9a5fb58e1fb9a3197718755fc2d0c3ab..13e52fef9cfdef1fb64713486ad0c5e776c73dbc
May 4, 2015 22:44https://github.com/nodejs/node/pull/1614#event-296722561
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 4, 2015https://github.com/nodejs/node/pull/1614#issuecomment-98880042
Please reload this pagehttps://github.com/nodejs/node/pull/1614
trevnorrishttps://github.com/trevnorris
May 4, 2015 17:02https://github.com/nodejs/node/pull/1614#commits-pushed-cc0385e
https://github.com/trevnorris
async-wrap: pass PROVIDER as first arg to inithttps://github.com/nodejs/node/pull/1614/commits/cc0385e022515bb99f67140c8b3c273b23d2cc1f
cc0385ehttps://github.com/nodejs/node/pull/1614/commits/cc0385e022515bb99f67140c8b3c273b23d2cc1f
https://github.com/trevnorris
async-wrap: set flags using functionshttps://github.com/nodejs/node/pull/1614/commits/7740d5e80802e9181b49a877ff69fed416040e5b
7740d5ehttps://github.com/nodejs/node/pull/1614/commits/7740d5e80802e9181b49a877ff69fed416040e5b
https://github.com/trevnorris
async-wrap: remove before/after calls in inithttps://github.com/nodejs/node/pull/1614/commits/eed38b373ef94e1563323c6165ea81f6e95ac91b
eed38b3https://github.com/nodejs/node/pull/1614/commits/eed38b373ef94e1563323c6165ea81f6e95ac91b
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/13e52fef9cfdef1fb64713486ad0c5e776c73dbc..eed38b373ef94e1563323c6165ea81f6e95ac91b
13e52fehttps://github.com/nodejs/node/commit/13e52fef9cfdef1fb64713486ad0c5e776c73dbc
eed38b3https://github.com/nodejs/node/commit/eed38b373ef94e1563323c6165ea81f6e95ac91b
Compare https://github.com/nodejs/node/compare/13e52fef9cfdef1fb64713486ad0c5e776c73dbc..eed38b373ef94e1563323c6165ea81f6e95ac91b
May 4, 2015 23:04https://github.com/nodejs/node/pull/1614#event-296732486
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
May 4, 2015https://github.com/nodejs/node/pull/1614#issuecomment-98880791
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1614
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 4, 2015https://github.com/nodejs/node/pull/1614#event-296734483
bnoordhuishttps://github.com/bnoordhuis
May 4, 2015 https://github.com/nodejs/node/pull/1614#discussion-diff-29633704
View reviewed changes https://github.com/nodejs/node/pull/1614/files/eed38b373ef94e1563323c6165ea81f6e95ac91b#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
src/async-wrap.cchttps://github.com/nodejs/node/pull/1614/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
bnoordhuishttps://github.com/bnoordhuis
May 4, 2015https://github.com/nodejs/node/pull/1614#discussion_r29633704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1614
trevnorrishttps://github.com/trevnorris
May 5, 2015https://github.com/nodejs/node/pull/1614#discussion_r29640143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1614
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 4, 2015https://github.com/nodejs/node/pull/1614#issuecomment-98883921
Please reload this pagehttps://github.com/nodejs/node/pull/1614
trevnorrishttps://github.com/trevnorris
May 5, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-84bf609
https://github.com/trevnorris
async-wrap: don't call init callback unnecessarilyhttps://github.com/nodejs/node/commit/84bf609fd2dce0343157d2bf8afa323744fd3107
84bf609https://github.com/nodejs/node/commit/84bf609fd2dce0343157d2bf8afa323744fd3107
#1614https://github.com/nodejs/node/pull/1614
trevnorrishttps://github.com/trevnorris
May 5, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-4b2c786
https://github.com/trevnorris
async-wrap: pass PROVIDER as first arg to inithttps://github.com/nodejs/node/commit/4b2c78644972cdbeeb498f287640e3d6067a814f
4b2c786https://github.com/nodejs/node/commit/4b2c78644972cdbeeb498f287640e3d6067a814f
#1614https://github.com/nodejs/node/pull/1614
trevnorrishttps://github.com/trevnorris
May 5, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-bd42ba0
https://github.com/trevnorris
async-wrap: set flags using functionshttps://github.com/nodejs/node/commit/bd42ba056afe1efe9a4f58f1274d9305c4998a1f
bd42ba0https://github.com/nodejs/node/commit/bd42ba056afe1efe9a4f58f1274d9305c4998a1f
#1614https://github.com/nodejs/node/pull/1614
trevnorrishttps://github.com/trevnorris
May 5, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-7dde95a
https://github.com/trevnorris
async-wrap: remove before/after calls in inithttps://github.com/nodejs/node/commit/7dde95a8bdd1b5aaeb3bb68a1f0abf7cfc8b3c96
7dde95ahttps://github.com/nodejs/node/commit/7dde95a8bdd1b5aaeb3bb68a1f0abf7cfc8b3c96
#1614https://github.com/nodejs/node/pull/1614
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
May 5, 2015https://github.com/nodejs/node/pull/1614#issuecomment-98905564
84bf609https://github.com/nodejs/node/commit/84bf609fd2dce0343157d2bf8afa323744fd3107
4b2c786https://github.com/nodejs/node/commit/4b2c78644972cdbeeb498f287640e3d6067a814f
bd42ba0https://github.com/nodejs/node/commit/bd42ba056afe1efe9a4f58f1274d9305c4998a1f
7dde95ahttps://github.com/nodejs/node/commit/7dde95a8bdd1b5aaeb3bb68a1f0abf7cfc8b3c96
Please reload this pagehttps://github.com/nodejs/node/pull/1614
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
May 5, 2015https://github.com/nodejs/node/pull/1614#event-296807239
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
May 5, 2015 02:09https://github.com/nodejs/node/pull/1614#event-296807407
https://github.com/rvagg
rvagghttps://github.com/rvagg
May 5, 2015 https://github.com/nodejs/node/pull/1614#ref-pullrequest-73395140
Release proposal: v2.0.1 #1629 https://github.com/nodejs/node/pull/1629
Fishrock123https://github.com/Fishrock123
May 19, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-a2b6650
https://github.com/trevnorris
https://github.com/Fishrock123
async-wrap: don't call init callback unnecessarilyhttps://github.com/Fishrock123/node/commit/a2b66501c510cebd4dafd4e446d2c14c1d691929
a2b6650https://github.com/Fishrock123/node/commit/a2b66501c510cebd4dafd4e446d2c14c1d691929
nodejs#1614https://github.com/nodejs/node/pull/1614
Fishrock123https://github.com/Fishrock123
May 19, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-c8b05e4
https://github.com/trevnorris
https://github.com/Fishrock123
async-wrap: pass PROVIDER as first arg to inithttps://github.com/Fishrock123/node/commit/c8b05e421cebd2764413cfbe233efdda5c7c86df
c8b05e4https://github.com/Fishrock123/node/commit/c8b05e421cebd2764413cfbe233efdda5c7c86df
nodejs#1614https://github.com/nodejs/node/pull/1614
Fishrock123https://github.com/Fishrock123
May 19, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-a703e07
https://github.com/trevnorris
https://github.com/Fishrock123
async-wrap: set flags using functionshttps://github.com/Fishrock123/node/commit/a703e0711008ef6ed2ba206069b850b6c4ffce03
a703e07https://github.com/Fishrock123/node/commit/a703e0711008ef6ed2ba206069b850b6c4ffce03
nodejs#1614https://github.com/nodejs/node/pull/1614
Fishrock123https://github.com/Fishrock123
May 19, 2015 https://github.com/nodejs/node/pull/1614#ref-commit-54ae094
https://github.com/trevnorris
https://github.com/Fishrock123
async-wrap: remove before/after calls in inithttps://github.com/Fishrock123/node/commit/54ae094b9a100055fca924d7bdf5e689a6d087f1
54ae094https://github.com/Fishrock123/node/commit/54ae094b9a100055fca924d7bdf5e689a6d087f1
nodejs#1614https://github.com/nodejs/node/pull/1614
https://github.com/Qard
Qardhttps://github.com/Qard
Jun 25, 2015 https://github.com/nodejs/node/pull/1614#ref-pullrequest-56035549
async-wrap: always call before and after hooks #665 https://github.com/nodejs/node/pull/665
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1614
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/1614
https://github.com/trevnorris
https://github.com/bnoordhuis
https://github.com/brendanashworth
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.