| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7b65efec-0b88-de62-33af-e6821e977248 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA02:CD884:A35ECB:E4D8FF:6A4E7D1A |
| html-safe-nonce | 4c6dd65d71f35c064772cb75817d443d6e049d3584195192c340aaa1fca7225e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTAyOkNEODg0OkEzNUVDQjpFNEQ4RkY6NkE0RTdEMUEiLCJ2aXNpdG9yX2lkIjoiNDYzNTQxMTU4Mjc2Mjc3Nzg4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2c0f47c4433e3fd3c532d77096960ef93da794743930c171b9b15f07d0b46107 |
| hovercard-subject-tag | pull_request:34595481 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1596/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2240ab57427588fe44d532f546fb8ebd9b6a101328420a39524c2d7c7b2692ad/nodejs/node/pull/1596 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2240ab57427588fe44d532f546fb8ebd9b6a101328420a39524c2d7c7b2692ad/nodejs/node/pull/1596 |
| og:image:alt | Makes the ParseEncoding symbol visible to addons on Windows. It was already visible on Unices.
I ran into this when writing an addon that used ParseEncoding; the VS2013 build failed with:
(Link ta... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ivan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/1596#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1596 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1596 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/1596 |
| Reload | https://github.com/nodejs/node/pull/1596 |
| Reload | https://github.com/nodejs/node/pull/1596 |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ivan | https://github.com/ivan |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/1596 |
| Commits1 (1) | https://github.com/nodejs/node/pull/1596/commits |
| Checks | https://github.com/nodejs/node/pull/1596/checks |
| Files changed | https://github.com/nodejs/node/pull/1596/files |
| src: export the ParseEncoding function on Windows | https://github.com/nodejs/node/pull/1596#top |
| ivan | https://github.com/ivan |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
| https://github.com/ivan |
| ivan | https://github.com/ivan |
| May 3, 2015 | https://github.com/nodejs/node/pull/1596#issue-72736890 |
| nodejs/node-v0.x-archive#3811 | https://github.com/nodejs/node-v0.x-archive/issues/3811 |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| May 3, 2015 | https://github.com/nodejs/node/pull/1596#event-295625134 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| May 4, 2015 | https://github.com/nodejs/node/pull/1596#event-296357406 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#issuecomment-99879151 |
| @indutny | https://github.com/indutny |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| indutny | https://github.com/indutny |
|
May 7, 2015
| https://github.com/nodejs/node/pull/1596#discussion-diff-29858396 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1596/files/c1b70fa43e96ffb7130af94e755f22e0bcee8cbb#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e |
| src/node.h | https://github.com/nodejs/node/pull/1596/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e |
| indutny | https://github.com/indutny |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#discussion_r29858396 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| ivan | https://github.com/ivan |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#discussion_r29867375 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#issuecomment-99893862 |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
|
| https://github.com/ivan |
| src: export the ParseEncoding function on Windows | https://github.com/nodejs/node/pull/1596/commits/86342c738294ad6313fd2edfe77c76b92a23eb50 |
| 86342c7 | https://github.com/nodejs/node/pull/1596/commits/86342c738294ad6313fd2edfe77c76b92a23eb50 |
| https://github.com/ivan |
| ivan | https://github.com/ivan |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#issuecomment-99924382 |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#issuecomment-99924966 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#issuecomment-99925026 |
| @ivan | https://github.com/ivan |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#issuecomment-99925925 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
May 7, 2015
| https://github.com/nodejs/node/pull/1596#ref-pullrequest-73395140 |
|
Release proposal: v2.0.1
#1629
| https://github.com/nodejs/node/pull/1629 |
| Fishrock123 | https://github.com/Fishrock123 |
|
May 7, 2015
| https://github.com/nodejs/node/pull/1596#ref-commit-c43855c |
|
| https://github.com/ivan |
|
| https://github.com/Fishrock123 |
| src: export the ParseEncoding function on Windows | https://github.com/nodejs/node/commit/c43855c49cb7ef7b4ae46749e9f89ab5376de09a |
| c43855c | https://github.com/nodejs/node/commit/c43855c49cb7ef7b4ae46749e9f89ab5376de09a |
| #1596 | https://github.com/nodejs/node/pull/1596 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#issuecomment-99931512 |
| c43855c | https://github.com/nodejs/node/commit/c43855c49cb7ef7b4ae46749e9f89ab5376de09a |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 7, 2015 | https://github.com/nodejs/node/pull/1596#event-299454593 |
| Fishrock123 | https://github.com/Fishrock123 |
|
May 19, 2015
| https://github.com/nodejs/node/pull/1596#ref-commit-98b1109 |
|
| https://github.com/ivan |
|
| https://github.com/Fishrock123 |
| src: export the ParseEncoding function on Windows | https://github.com/Fishrock123/node/commit/98b1109b5eade447726179f538b2dd4d38a4a7c5 |
| 98b1109 | https://github.com/Fishrock123/node/commit/98b1109b5eade447726179f538b2dd4d38a4a7c5 |
| nodejs#1596 | https://github.com/nodejs/node/pull/1596 |
| https://github.com/B020239 |
| B020239 | https://github.com/B020239 |
|
Mar 9, 2024
| https://github.com/nodejs/node/pull/1596#ref-pullrequest-2177369443 |
|
[Snyk] Upgrade chai from 4.4.1 to 5.1.0
B020239/node#7
| https://github.com/B020239/node/pull/7 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1596 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
|
add NODE_EXTERN to node::Encode
| https://github.com/nodejs/node-v0.x-archive/issues/3811 |
| Please reload this page | https://github.com/nodejs/node/pull/1596 |
|
| https://github.com/ivan |
|
| https://github.com/Fishrock123 |
|
| https://github.com/indutny |
|
| https://github.com/mscdex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |