| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e949d264-4483-a0d3-4802-7020b9e9e975 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9268:280881:D94378:1314911:696A65CA |
| html-safe-nonce | 4952a053b74cdac50675914ba722e97ff9f31d4a7f0252e121f6f8ba4a9cbb25 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjY4OjI4MDg4MTpEOTQzNzg6MTMxNDkxMTo2OTZBNjVDQSIsInZpc2l0b3JfaWQiOiI4Njg4ODc5NTc2NDMyNjY2MDU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 362f3577cd90602a91f490344e709b0042722d83e789857fe4a4a6f79a795deb |
| hovercard-subject-tag | pull_request:144291255 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15743/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7a45b6eeac9c49b9855d4699f0f5823b989ee50a2f3d696b817e9c0f89fcbbea/nodejs/node/pull/15743 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7a45b6eeac9c49b9855d4699f0f5823b989ee50a2f3d696b817e9c0f89fcbbea/nodejs/node/pull/15743 |
| og:image:alt | Add tests ported from Web Platform Tests.
Graduate TextEncoder / TextDecoder from experimental
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are includ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/15743#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15743 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15743 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/15743 |
| Reload | https://github.com/nodejs/node/pull/15743 |
| Reload | https://github.com/nodejs/node/pull/15743 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/15743#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:graduate-encoding | https://github.com/jasnell/node/tree/graduate-encoding |
|
util: graduate TextEncoder/TextDecoder, tests
| https://github.com/nodejs/node/pull/15743#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:graduate-encoding | https://github.com/jasnell/node/tree/graduate-encoding |
|
Conversation
33
| https://github.com/nodejs/node/pull/15743 |
|
Commits
10
| https://github.com/nodejs/node/pull/15743/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/15743/checks |
|
Files changed
| https://github.com/nodejs/node/pull/15743/files |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 2, 2017 | https://github.com/nodejs/node/pull/15743#issue-262238503 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
encoding
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aencoding |
| Oct 2, 2017 | https://github.com/nodejs/node/pull/15743#event-1274927804 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Oct 2, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-333675093 |
| https://ci.nodejs.org/job/node-test-pull-request/10385/ | https://ci.nodejs.org/job/node-test-pull-request/10385/ |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 3, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-66626217 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| test/parallel/test-whatwg-encoding-fatal-streaming.js | https://github.com/nodejs/node/pull/15743/files#diff-ec7f43109f26ca513f8022f9a73fa089c2e5617927c65674a0899d3f26798a81 |
| refack | https://github.com/refack |
| Oct 3, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r142286298 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/blob/c5f243a5f5417af24c10b294d1d57d5dbf64fea3/test/parallel/test-whatwg-url-searchparams-append.js#L8-L13 | https://github.com/nodejs/node/blob/c5f243a5f5417af24c10b294d1d57d5dbf64fea3/test/parallel/test-whatwg-url-searchparams-append.js#L8-L13 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| jasnell | https://github.com/jasnell |
| Oct 3, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r142290627 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| joyeecheung | https://github.com/joyeecheung |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r145030096 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Oct 3, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-66882998 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Oct 3, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-333965867 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 3, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-66894521 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 3, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-333988860 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Oct 13, 2017 | https://github.com/nodejs/node/pull/15743#event-1293049676 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 13, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-336570364 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://ci.nodejs.org/job/node-test-pull-request/10700/ | https://ci.nodejs.org/job/node-test-pull-request/10700/ |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 13, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-336575032 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 13, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-336588065 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| October 14, 2017 04:09 | https://github.com/nodejs/node/pull/15743#event-1293269831 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 14, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-336622260 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Oct 15, 2017
| https://github.com/nodejs/node/pull/15743#ref-issue-258284238 |
|
Import TextDecoder/TextEncoder Web Platform Tests
#15442
| https://github.com/nodejs/node/issues/15442 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-336944593 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Oct 16, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-69621698 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 17, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-69768303 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| test/parallel/test-whatwg-encoding-fatal-streaming.js | https://github.com/nodejs/node/pull/15743/files#diff-ec7f43109f26ca513f8022f9a73fa089c2e5617927c65674a0899d3f26798a81 |
| joyeecheung | https://github.com/joyeecheung |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r145030096 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Oct 17, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-69769288 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| TimothyGu | https://github.com/TimothyGu |
| https://github.com/nodejs/node/pull/15743#pullrequestreview-69769288 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-337123767 |
| nodejs/build#419 | https://github.com/nodejs/build/issues/419 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-337222291 |
| @joyeecheung | https://github.com/joyeecheung |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/c5f243a5f5417af24c10b294d1d57d5dbf64fea3..56b1cb63ab7a399218866eb5dbb0ce6d3fe94ad8 |
| c5f243a | https://github.com/nodejs/node/commit/c5f243a5f5417af24c10b294d1d57d5dbf64fea3 |
| 56b1cb6 | https://github.com/nodejs/node/commit/56b1cb63ab7a399218866eb5dbb0ce6d3fe94ad8 |
|
Compare
| https://github.com/nodejs/node/compare/c5f243a5f5417af24c10b294d1d57d5dbf64fea3..56b1cb63ab7a399218866eb5dbb0ce6d3fe94ad8 |
| October 20, 2017 19:23 | https://github.com/nodejs/node/pull/15743#event-1303617742 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-338312654 |
| @joyeecheung | https://github.com/joyeecheung |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-338313133 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://ci.nodejs.org/job/node-test-commit-linux-nointl/6 | https://ci.nodejs.org/job/node-test-commit-linux-nointl/6 |
| https://ci.nodejs.org/job/node-test-pull-request/10877/ | https://ci.nodejs.org/job/node-test-pull-request/10877/ |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-338335976 |
| #16250 | https://github.com/nodejs/node/pull/16250 |
| https://ci.nodejs.org/job/node-test-commit-linux-nointl/7 | https://ci.nodejs.org/job/node-test-commit-linux-nointl/7 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Oct 20, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-70979828 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| test/parallel/test-whatwg-encoding-internals.js | https://github.com/nodejs/node/pull/15743/files#diff-3b0a866c9cbdcf7c5a06f9b392f4bc9ca90c270cfdf0751e998b9db9f1d322df |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146078870 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| test/parallel/test-whatwg-encoding-surrogates-utf8.js | https://github.com/nodejs/node/pull/15743/files#diff-2d248bb27b1d50b437570a4ddda4bee81f47741cd4bcb6c0a24a4641c40a02ca |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146078947 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| test/parallel/test-whatwg-encoding-textdecoder-ignorebom.js | https://github.com/nodejs/node/pull/15743/files#diff-f70918b0b7b145ad36ee9b95bfe87f3e711b64b15d7ee4ef9c9f0ecfc43337c7 |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146079060 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| test/parallel/test-whatwg-encoding-textdecoder-streaming.js | https://github.com/nodejs/node/pull/15743/files#diff-4fbc5b775c4b80e76871adf5aa9a43578faac13a0f248d005fc80c015fab6660 |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146079146 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| test/parallel/test-whatwg-encoding-textdecoder.js | https://github.com/nodejs/node/pull/15743/files#diff-abf9e78de12d39f4317e9780546f22f05c4bcb48d9dbe9eeb23562c04d2d7d55 |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146079255 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| test/parallel/test-whatwg-encoding-textencoder-utf16-surrogates.js | https://github.com/nodejs/node/pull/15743/files#diff-a9f3b47c96a5366a00edb570cc16d7eaf17852ffcfef4a68e6096d06bb1f72f7 |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146079311 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| test/parallel/test-whatwg-encoding-textencoder.js | https://github.com/nodejs/node/pull/15743/files#diff-ee0b973c12a874759440f3a82cf63aec1841b33f169f68da285a5a3692bf78df |
| TimothyGu | https://github.com/TimothyGu |
| Oct 20, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146079443 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Oct 21, 2017
| https://github.com/nodejs/node/pull/15743#pullrequestreview-71005902 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15743/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/15743#pullrequestreview-71005902 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| test/parallel/test-whatwg-encoding-fatal-streaming.js | https://github.com/nodejs/node/pull/15743/files#diff-ec7f43109f26ca513f8022f9a73fa089c2e5617927c65674a0899d3f26798a81 |
| joyeecheung | https://github.com/joyeecheung |
| Oct 21, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146103918 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| TimothyGu | https://github.com/TimothyGu |
| Oct 23, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146414595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| jasnell | https://github.com/jasnell |
| Oct 24, 2017 | https://github.com/nodejs/node/pull/15743#discussion_r146448546 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 21, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-338387781 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| nodejs/build#685 | https://github.com/nodejs/build/issues/685 |
| nodejs/build#688 | https://github.com/nodejs/build/issues/688 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Oct 21, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-338392913 |
| nodejs/build#688 | https://github.com/nodejs/build/issues/688 |
| nodejs/build#419 | https://github.com/nodejs/build/issues/419 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
|
| https://github.com/jasnell |
| util: graduate TextEncoder/TextDecoder, tests | https://github.com/nodejs/node/pull/15743/commits/87922733c091d38a0919972574426fd7e68fcb90 |
| 8792273 | https://github.com/nodejs/node/pull/15743/commits/87922733c091d38a0919972574426fd7e68fcb90 |
| jasnell | https://github.com/jasnell |
| October 23, 2017 21:02 | https://github.com/nodejs/node/pull/15743#commits-pushed-52b6b94 |
|
| https://github.com/jasnell |
| [Squash] | https://github.com/nodejs/node/pull/15743/commits/52b6b94955d0dce22090ad984ebc1a6b340af49e |
| 52b6b94 | https://github.com/nodejs/node/pull/15743/commits/52b6b94955d0dce22090ad984ebc1a6b340af49e |
|
| https://github.com/jasnell |
| [Squash] | https://github.com/nodejs/node/pull/15743/commits/45f7c792ff2a8e05dd593a0cc1d9eaf78abf50a7 |
| 45f7c79 | https://github.com/nodejs/node/pull/15743/commits/45f7c792ff2a8e05dd593a0cc1d9eaf78abf50a7 |
|
| https://github.com/jasnell |
| [Squash] | https://github.com/nodejs/node/pull/15743/commits/dcbcfa3bfe3953dcb3e2b4f7f4a2773630d1579c |
| dcbcfa3 | https://github.com/nodejs/node/pull/15743/commits/dcbcfa3bfe3953dcb3e2b4f7f4a2773630d1579c |
|
| https://github.com/jasnell |
| [Squash] | https://github.com/nodejs/node/pull/15743/commits/795bb3ea90d75ea73812a35d3dde47305c1b222e |
| 795bb3e | https://github.com/nodejs/node/pull/15743/commits/795bb3ea90d75ea73812a35d3dde47305c1b222e |
| jasnell | https://github.com/jasnell |
|
Oct 24, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-7f9eb4c |
|
| https://github.com/jasnell |
| util: graduate TextEncoder/TextDecoder, tests | https://github.com/nodejs/node/commit/7f9eb4c29c38e2c49209230ebf29aa486aed9aca |
| 7f9eb4c | https://github.com/nodejs/node/commit/7f9eb4c29c38e2c49209230ebf29aa486aed9aca |
| #15743 | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 24, 2017 | https://github.com/nodejs/node/pull/15743#issuecomment-338869286 |
| 7f9eb4c | https://github.com/nodejs/node/commit/7f9eb4c29c38e2c49209230ebf29aa486aed9aca |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 24, 2017 | https://github.com/nodejs/node/pull/15743#event-1306948171 |
| addaleax | https://github.com/addaleax |
|
Oct 26, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-6371494 |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
| util: graduate TextEncoder/TextDecoder, tests | https://github.com/ayojs/ayo/commit/637149474c4af1c2996fd3aadddd07a461bc6389 |
| 6371494 | https://github.com/ayojs/ayo/commit/637149474c4af1c2996fd3aadddd07a461bc6389 |
| nodejs/node#15743 | https://github.com/nodejs/node/pull/15743 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 30, 2017
| https://github.com/nodejs/node/pull/15743#ref-pullrequest-254697213 |
|
Proposal: 2017-10-31, Version 9.0.0 (Current)
#15135
| https://github.com/nodejs/node/pull/15135 |
| gibfahn | https://github.com/gibfahn |
|
Oct 30, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-046d64b |
|
| https://github.com/jasnell |
|
| https://github.com/gibfahn |
| util: graduate TextEncoder/TextDecoder, tests | https://github.com/nodejs/node/commit/046d64b9ce8839069f6fcb00a0b3bb2a6bcb5d2e |
| 046d64b | https://github.com/nodejs/node/commit/046d64b9ce8839069f6fcb00a0b3bb2a6bcb5d2e |
| #15743 | https://github.com/nodejs/node/pull/15743 |
| gibfahn | https://github.com/gibfahn |
|
Oct 31, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-8fd75fb |
|
| https://github.com/jasnell |
|
| https://github.com/gibfahn |
| util: graduate TextEncoder/TextDecoder, tests | https://github.com/nodejs/node/commit/8fd75fb9b56576d0f9f9cbaee19f86794427c38f |
| 8fd75fb | https://github.com/nodejs/node/commit/8fd75fb9b56576d0f9f9cbaee19f86794427c38f |
| #15743 | https://github.com/nodejs/node/pull/15743 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Oct 31, 2017
| https://github.com/nodejs/node/pull/15743#ref-pullrequest-269803210 |
|
v8.9.0 proposal
#16630
| https://github.com/nodejs/node/pull/16630 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 31, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-f5e614a |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release | https://github.com/nodejs/node/commit/f5e614a3eeae654a07a4c6519e8cb205df9f3765 |
| f5e614a | https://github.com/nodejs/node/commit/f5e614a3eeae654a07a4c6519e8cb205df9f3765 |
| #16620 | https://github.com/nodejs/node/pull/16620 |
| #16509 | https://github.com/nodejs/node/pull/16509 |
| #16330 | https://github.com/nodejs/node/pull/16330 |
| #16397 | https://github.com/nodejs/node/pull/16397 |
| #15743 | https://github.com/nodejs/node/pull/15743 |
| #16630 | https://github.com/nodejs/node/pull/16630 |
| gibfahn | https://github.com/gibfahn |
|
Oct 31, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-f76ce0a |
|
| https://github.com/gibfahn |
| 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release | https://github.com/nodejs/node/commit/f76ce0a75641991bfc235775a4747c978e0e281b |
| f76ce0a | https://github.com/nodejs/node/commit/f76ce0a75641991bfc235775a4747c978e0e281b |
| #16620 | https://github.com/nodejs/node/pull/16620 |
| #16509 | https://github.com/nodejs/node/pull/16509 |
| #16330 | https://github.com/nodejs/node/pull/16330 |
| #16397 | https://github.com/nodejs/node/pull/16397 |
| #15743 | https://github.com/nodejs/node/pull/15743 |
| #16630 | https://github.com/nodejs/node/pull/16630 |
| gibfahn | https://github.com/gibfahn |
|
Oct 31, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-8025bba |
|
| https://github.com/gibfahn |
| 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release | https://github.com/nodejs/node/commit/8025bba1a38f7d9b8ba152e45c6a9198f5e49186 |
| 8025bba | https://github.com/nodejs/node/commit/8025bba1a38f7d9b8ba152e45c6a9198f5e49186 |
| #16620 | https://github.com/nodejs/node/pull/16620 |
| #16509 | https://github.com/nodejs/node/pull/16509 |
| #16330 | https://github.com/nodejs/node/pull/16330 |
| #16397 | https://github.com/nodejs/node/pull/16397 |
| #15743 | https://github.com/nodejs/node/pull/15743 |
| #16630 | https://github.com/nodejs/node/pull/16630 |
| jasnell | https://github.com/jasnell |
|
Oct 31, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-daa286a |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
| 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release | https://github.com/nodejs/node/commit/daa286a30c8ef439ee195bf928306d9cead988a3 |
| daa286a | https://github.com/nodejs/node/commit/daa286a30c8ef439ee195bf928306d9cead988a3 |
| #16620 | https://github.com/nodejs/node/pull/16620 |
| #16509 | https://github.com/nodejs/node/pull/16509 |
| #16330 | https://github.com/nodejs/node/pull/16330 |
| #16397 | https://github.com/nodejs/node/pull/16397 |
| #15743 | https://github.com/nodejs/node/pull/15743 |
| #16630 | https://github.com/nodejs/node/pull/16630 |
| Qard | https://github.com/Qard |
|
Nov 2, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-781098d |
|
| https://github.com/gibfahn |
|
| https://github.com/Qard |
| 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release | https://github.com/ayojs/ayo/commit/781098d6dfc9d3849dc7b41ac6e206340dc73c0e |
| 781098d | https://github.com/ayojs/ayo/commit/781098d6dfc9d3849dc7b41ac6e206340dc73c0e |
| nodejs/node#16620 | https://github.com/nodejs/node/pull/16620 |
| nodejs/node#16509 | https://github.com/nodejs/node/pull/16509 |
| nodejs/node#16330 | https://github.com/nodejs/node/pull/16330 |
| nodejs/node#16397 | https://github.com/nodejs/node/pull/16397 |
| nodejs/node#15743 | https://github.com/nodejs/node/pull/15743 |
| nodejs/node#16630 | https://github.com/nodejs/node/pull/16630 |
| Qard | https://github.com/Qard |
|
Nov 2, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-ad502ca |
|
| https://github.com/gibfahn |
|
| https://github.com/Qard |
| 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release | https://github.com/ayojs/ayo/commit/ad502ca1e48bd8d93a3e6f5aa0456484379c0936 |
| ad502ca | https://github.com/ayojs/ayo/commit/ad502ca1e48bd8d93a3e6f5aa0456484379c0936 |
| nodejs/node#16620 | https://github.com/nodejs/node/pull/16620 |
| nodejs/node#16509 | https://github.com/nodejs/node/pull/16509 |
| nodejs/node#16330 | https://github.com/nodejs/node/pull/16330 |
| nodejs/node#16397 | https://github.com/nodejs/node/pull/16397 |
| nodejs/node#15743 | https://github.com/nodejs/node/pull/15743 |
| nodejs/node#16630 | https://github.com/nodejs/node/pull/16630 |
| https://github.com/schmod |
| schmod | https://github.com/schmod |
|
Nov 2, 2017
| https://github.com/nodejs/node/pull/15743#ref-issue-270786868 |
|
Proposal: Initial "Active LTS" release should follow LTS policies
nodejs/Release#281
| https://github.com/nodejs/Release/issues/281 |
| addaleax | https://github.com/addaleax |
|
Dec 7, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-f332483 |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
| util: graduate TextEncoder/TextDecoder, tests | https://github.com/ayojs/ayo/commit/f332483bbca877fa4c6ce2a06f3bb9611bbaa478 |
| f332483 | https://github.com/ayojs/ayo/commit/f332483bbca877fa4c6ce2a06f3bb9611bbaa478 |
| nodejs/node#15743 | https://github.com/nodejs/node/pull/15743 |
| addaleax | https://github.com/addaleax |
|
Dec 7, 2017
| https://github.com/nodejs/node/pull/15743#ref-commit-ceddd58 |
|
| https://github.com/gibfahn |
|
| https://github.com/addaleax |
| 2017-10-31, Version 8.9.0 'Carbon' (LTS) Release | https://github.com/ayojs/ayo/commit/ceddd580061d169319d57667472ad6f1a4ed42aa |
| ceddd58 | https://github.com/ayojs/ayo/commit/ceddd580061d169319d57667472ad6f1a4ed42aa |
| nodejs/node#16620 | https://github.com/nodejs/node/pull/16620 |
| nodejs/node#16509 | https://github.com/nodejs/node/pull/16509 |
| nodejs/node#16330 | https://github.com/nodejs/node/pull/16330 |
| nodejs/node#16397 | https://github.com/nodejs/node/pull/16397 |
| nodejs/node#15743 | https://github.com/nodejs/node/pull/15743 |
| nodejs/node#16630 | https://github.com/nodejs/node/pull/16630 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jan 15, 2018 | https://github.com/nodejs/node/pull/15743#event-1425146549 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 15, 2018 | https://github.com/nodejs/node/pull/15743#issuecomment-357804017 |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15743 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/15743/files/c5f243a5f5417af24c10b294d1d57d5dbf64fea3 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/15743/files/c5f243a5f5417af24c10b294d1d57d5dbf64fea3 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/15743/files/df0a9bf80d7e2f32eb12003b10f556bbeb02279a |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/15743/files/c5f243a5f5417af24c10b294d1d57d5dbf64fea3 |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/15743/files/df0a9bf80d7e2f32eb12003b10f556bbeb02279a |
|
encoding
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aencoding |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/15743 |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/mhdawson |
|
| https://github.com/tniessen |
|
| https://github.com/TimothyGu |
|
| https://github.com/joyeecheung |
|
| https://github.com/gibfahn |
|
| https://github.com/refack |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |