René's URL Explorer Experiment


Title: Backport fixes to v1.x by Fishrock123 · Pull Request #1560 · nodejs/node · GitHub

Open Graph Title: Backport fixes to v1.x by Fishrock123 · Pull Request #1560 · nodejs/node

X Title: Backport fixes to v1.x by Fishrock123 · Pull Request #1560 · nodejs/node

Description: Just fixes. Especially to the tests and how the CI runs are now run, this will make v1.x CI runs viable again. Also, due to the string_decoder thing, might be worthwhile to do a 1.8.2 in the coming...

Open Graph Description: Just fixes. Especially to the tests and how the CI runs are now run, this will make v1.x CI runs viable again. Also, due to the string_decoder thing, might be worthwhile to do a 1.8.2 in the coming...

X Description: Just fixes. Especially to the tests and how the CI runs are now run, this will make v1.x CI runs viable again. Also, due to the string_decoder thing, might be worthwhile to do a 1.8.2 in the coming...

Opengraph URL: https://github.com/nodejs/node/pull/1560

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b043e438-8469-ee7e-2560-9a2e1ff9040f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE184:2518BB:E3ED0:122DB6:696AFDE8
html-safe-nonce04997a80a76037409f18d9cb4f05c54c5d4bb6fe1448d028d7dd933e62aa434d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTg0OjI1MThCQjpFM0VEMDoxMjJEQjY6Njk2QUZERTgiLCJ2aXNpdG9yX2lkIjoiMzkyMDYxNjYyNTM5OTMzMjMyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3d4427a862a126973c1d459b551e35673928d37e5662d4edc89a2cc80f2e625c
hovercard-subject-tagpull_request:34374673
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1560/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0b37cf824e982948758357bdb642c6cdfe00a03ccee60eb594799d4b08845d3c/nodejs/node/pull/1560
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0b37cf824e982948758357bdb642c6cdfe00a03ccee60eb594799d4b08845d3c/nodejs/node/pull/1560
og:image:altJust fixes. Especially to the tests and how the CI runs are now run, this will make v1.x CI runs viable again. Also, due to the string_decoder thing, might be worthwhile to do a 1.8.2 in the coming...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFishrock123
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1560#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1560
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1560
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1560
Reloadhttps://github.com/nodejs/node/pull/1560
Reloadhttps://github.com/nodejs/node/pull/1560
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1560
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/1560
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/1560#issue-comment-box
Fishrock123https://github.com/Fishrock123
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Fishrock123:backport-to-v1.xhttps://github.com/Fishrock123/node/tree/backport-to-v1.x
Backport fixes to v1.x https://github.com/nodejs/node/pull/1560#top
Fishrock123https://github.com/Fishrock123
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Fishrock123:backport-to-v1.xhttps://github.com/Fishrock123/node/tree/backport-to-v1.x
Conversation 6 https://github.com/nodejs/node/pull/1560
Commits 6 https://github.com/nodejs/node/pull/1560/commits
Checks 0 https://github.com/nodejs/node/pull/1560/checks
Files changed https://github.com/nodejs/node/pull/1560/files
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 29, 2015https://github.com/nodejs/node/pull/1560#issue-71908073
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.com/mscdex
mscdexhttps://github.com/mscdex
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
Apr 29, 2015https://github.com/nodejs/node/pull/1560#event-293137753
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 29, 2015https://github.com/nodejs/node/pull/1560#issuecomment-97480973
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 29, 2015https://github.com/nodejs/node/pull/1560#issuecomment-97503037
#1559https://github.com/nodejs/node/pull/1559
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 29, 2015 https://github.com/nodejs/node/pull/1560#ref-pullrequest-71854686
stream_base: dispatch reqs in the stream impl #1558 https://github.com/nodejs/node/pull/1558
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Apr 30, 2015https://github.com/nodejs/node/pull/1560#issuecomment-97902667
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 30, 2015https://github.com/nodejs/node/pull/1560#issuecomment-97903997
@chrisdickinsonhttps://github.com/chrisdickinson
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 14, 2015https://github.com/nodejs/node/pull/1560#issuecomment-102078408
Please reload this pagehttps://github.com/nodejs/node/pull/1560
siteguihttps://github.com/sitegui
May 14, 2015 11:45https://github.com/nodejs/node/pull/1560#commits-pushed-71274b0
https://github.com/sitegui
https://github.com/Fishrock123
tls_wrap: use localhost if options.host is emptyhttps://github.com/nodejs/node/pull/1560/commits/71274b0263083942e2affed0f959fe98a7366781
71274b0https://github.com/nodejs/node/pull/1560/commits/71274b0263083942e2affed0f959fe98a7366781
nodejs#1493https://github.com/nodejs/node/pull/1493
nodejs#1560https://github.com/nodejs/node/pull/1560
a7d7463https://github.com/Fishrock123/node/commit/a7d74633f20e285395f5e2860bdac56381603476
nodejs#1489https://github.com/nodejs/node/issues/1489
https://github.com/rvagg
https://github.com/Fishrock123
test: adjust Makefile/test-ci, add to vcbuild.bathttps://github.com/nodejs/node/pull/1560/commits/5896fe5cd33408221981b70d7dce279b95b119ce
5896fe5https://github.com/nodejs/node/pull/1560/commits/5896fe5cd33408221981b70d7dce279b95b119ce
nodejs#1530https://github.com/nodejs/node/pull/1530
nodejs#1560https://github.com/nodejs/node/pull/1560
5472139https://github.com/Fishrock123/node/commit/547213913b2e1525c15968916452995ab14e2195
https://github.com/rvagg
https://github.com/Fishrock123
build: remove -J from test-cihttps://github.com/nodejs/node/pull/1560/commits/65dd10e9c028020d1a09fc36a02a4412b95d6cce
65dd10ehttps://github.com/nodejs/node/pull/1560/commits/65dd10e9c028020d1a09fc36a02a4412b95d6cce
nodejs#1544https://github.com/nodejs/node/pull/1544
nodejs#1560https://github.com/nodejs/node/pull/1560
2a3c8c1https://github.com/Fishrock123/node/commit/2a3c8c187e4462f93169b6c98bea552edcace972
https://github.com/mscdex
https://github.com/Fishrock123
string_decoder: don't cache Buffer.isEncodinghttps://github.com/nodejs/node/pull/1560/commits/898d4238208e46fc0f402c6f978ae0f77cb8edce
898d423https://github.com/nodejs/node/pull/1560/commits/898d4238208e46fc0f402c6f978ae0f77cb8edce
nodejs#1547https://github.com/nodejs/node/issues/1547
nodejs#1548https://github.com/nodejs/node/pull/1548
nodejs#1560https://github.com/nodejs/node/pull/1560
0fa6c4ahttps://github.com/Fishrock123/node/commit/0fa6c4a6fc7ed4a2dfe821f1d3a46d5f6ff43e69
https://github.com/julianduque
https://github.com/Fishrock123
fs: validate fd on fs.writehttps://github.com/nodejs/node/pull/1560/commits/4030545af609cefbb698dbbca721be8977cedf9f
4030545https://github.com/nodejs/node/pull/1560/commits/4030545af609cefbb698dbbca721be8977cedf9f
nodejs#1553https://github.com/nodejs/node/pull/1553
nodejs#1560https://github.com/nodejs/node/pull/1560
f9c681chttps://github.com/Fishrock123/node/commit/f9c681cf627caf89b5c7eaacf154fdefb747c7e0
https://github.com/rvagg
https://github.com/Fishrock123
test: extend timeouts for ARMv6https://github.com/nodejs/node/pull/1560/commits/32a6dbcf23d86386800551967c2df06e156d6a62
32a6dbchttps://github.com/nodejs/node/pull/1560/commits/32a6dbcf23d86386800551967c2df06e156d6a62
nodejs#1554https://github.com/nodejs/node/pull/1554
nodejs#1560https://github.com/nodejs/node/pull/1560
f9b226chttps://github.com/Fishrock123/node/commit/f9b226c1c1e5bfbf355f9fabe03e50333676cc05
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/fe08db924c6667355de46815a0ac3989493cf012..32a6dbcf23d86386800551967c2df06e156d6a62
fe08db9https://github.com/nodejs/node/commit/fe08db924c6667355de46815a0ac3989493cf012
32a6dbchttps://github.com/nodejs/node/commit/32a6dbcf23d86386800551967c2df06e156d6a62
Compare https://github.com/nodejs/node/compare/fe08db924c6667355de46815a0ac3989493cf012..32a6dbcf23d86386800551967c2df06e156d6a62
May 14, 2015 15:46https://github.com/nodejs/node/pull/1560#event-304985977
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
32a6dbchttps://github.com/nodejs/node/commit/32a6dbcf23d86386800551967c2df06e156d6a62
May 14, 2015https://github.com/nodejs/node/pull/1560#event-304986821
LTS Working Group Kickoff #1346 https://github.com/nodejs/node/issues/1346
Release proposal: v1.8.2 #1703 https://github.com/nodejs/node/issues/1703
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
May 15, 2015https://github.com/nodejs/node/pull/1560#issuecomment-102262167
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
v1.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av1.x
May 21, 2015https://github.com/nodejs/node/pull/1560#event-310871679
https://github.com/B020239
B020239https://github.com/B020239
Mar 9, 2024 https://github.com/nodejs/node/pull/1560#ref-pullrequest-2177369443
[Snyk] Upgrade chai from 4.4.1 to 5.1.0 B020239/node#7 https://github.com/B020239/node/pull/7
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1560
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
Please reload this pagehttps://github.com/nodejs/node/pull/1560
https://github.com/Fishrock123
https://github.com/bnoordhuis
https://github.com/chrisdickinson
https://github.com/jbergstroem
https://github.com/mscdex
https://github.com/sitegui
https://github.com/rvagg
https://github.com/julianduque
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.