| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b82c558d-cb2d-3fa1-3bd4-7c674df56bef |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A9B2:A6D52:5A0BBAF:7F00BF7:6A500983 |
| html-safe-nonce | 72c44417f1ae68a8ebc0bc631af82ba5971e612abe6fe0f607e0a55a4725132c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUIyOkE2RDUyOjVBMEJCQUY6N0YwMEJGNzo2QTUwMDk4MyIsInZpc2l0b3JfaWQiOiI0MjM1OTE3NjgyMjE2NTM2NDUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | eaa60ffd33855107d61ed4eaeb3a2ade3c361696af54cfff51ea6d2eb818f5ec |
| hovercard-subject-tag | pull_request:142268380 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15520/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/97319a265180f4e856c4da38b012f01833661f00d4bf69fa917e866ffe83fefd/nodejs/node/pull/15520 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/97319a265180f4e856c4da38b012f01833661f00d4bf69fa917e866ffe83fefd/nodejs/node/pull/15520 |
| og:image:alt | Ref: #15404
Fixes: #15505
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test, http |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mcollina |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93a615b89b7dcbdb6b678f4772931ecc28ada82a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/15520#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15520 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15520 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/15520 |
| Reload | https://github.com/nodejs/node/pull/15520 |
| Reload | https://github.com/nodejs/node/pull/15520 |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:fix-flaky-http-test | https://github.com/mcollina/node/tree/fix-flaky-http-test |
| Conversation | https://github.com/nodejs/node/pull/15520 |
| Commits1 (1) | https://github.com/nodejs/node/pull/15520/commits |
| Checks | https://github.com/nodejs/node/pull/15520/checks |
| Files changed | https://github.com/nodejs/node/pull/15520/files |
| test: defer abort with setTimeout | https://github.com/nodejs/node/pull/15520#top |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:fix-flaky-http-test | https://github.com/mcollina/node/tree/fix-flaky-http-test |
|
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issue-259394467 |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| #15505 | https://github.com/nodejs/node/issues/15505 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#event-1258798602 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331069856 |
| https://ci.nodejs.org/job/node-test-pull-request/10175/ | https://ci.nodejs.org/job/node-test-pull-request/10175/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#event-1258805046 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/ec53a15cdc277570d0c09e5a9065b399f04f47f1..71f0b14d7b4f403c7957e4f60017282502346ede |
| ec53a15 | https://github.com/nodejs/node/commit/ec53a15cdc277570d0c09e5a9065b399f04f47f1 |
| 71f0b14 | https://github.com/nodejs/node/commit/71f0b14d7b4f403c7957e4f60017282502346ede |
|
Compare
| https://github.com/nodejs/node/compare/ec53a15cdc277570d0c09e5a9065b399f04f47f1..71f0b14d7b4f403c7957e4f60017282502346ede |
| September 21, 2017 07:43 | https://github.com/nodejs/node/pull/15520#event-1258854160 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331078799 |
| https://ci.nodejs.org/job/node-test-pull-request/10176/ | https://ci.nodejs.org/job/node-test-pull-request/10176/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/71f0b14d7b4f403c7957e4f60017282502346ede..cfaf6bf34430e93b65b9b791128a94b62bf5323f |
| 71f0b14 | https://github.com/nodejs/node/commit/71f0b14d7b4f403c7957e4f60017282502346ede |
| cfaf6bf | https://github.com/nodejs/node/commit/cfaf6bf34430e93b65b9b791128a94b62bf5323f |
|
Compare
| https://github.com/nodejs/node/compare/71f0b14d7b4f403c7957e4f60017282502346ede..cfaf6bf34430e93b65b9b791128a94b62bf5323f |
| September 21, 2017 08:00 | https://github.com/nodejs/node/pull/15520#event-1258876624 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331082298 |
| https://ci.nodejs.org/job/node-test-pull-request/10177/ | https://ci.nodejs.org/job/node-test-pull-request/10177/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-64215852 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| lpinca | https://github.com/lpinca |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r140182527 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331093994 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331096964 |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331144329 |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-64277572 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/cfaf6bf34430e93b65b9b791128a94b62bf5323f..87728042b281eba6c4b55bd847b032159596b177 |
| cfaf6bf | https://github.com/nodejs/node/commit/cfaf6bf34430e93b65b9b791128a94b62bf5323f |
| 8772804 | https://github.com/nodejs/node/commit/87728042b281eba6c4b55bd847b032159596b177 |
|
Compare
| https://github.com/nodejs/node/compare/cfaf6bf34430e93b65b9b791128a94b62bf5323f..87728042b281eba6c4b55bd847b032159596b177 |
| September 21, 2017 15:49 | https://github.com/nodejs/node/pull/15520#event-1259675589 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331199481 |
| https://ci.nodejs.org/job/node-test-pull-request/10181/ | https://ci.nodejs.org/job/node-test-pull-request/10181/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/87728042b281eba6c4b55bd847b032159596b177..a2ba6b8b40464c2b087cce3b51cda220474f28fc |
| 8772804 | https://github.com/nodejs/node/commit/87728042b281eba6c4b55bd847b032159596b177 |
| a2ba6b8 | https://github.com/nodejs/node/commit/a2ba6b8b40464c2b087cce3b51cda220474f28fc |
|
Compare
| https://github.com/nodejs/node/compare/87728042b281eba6c4b55bd847b032159596b177..a2ba6b8b40464c2b087cce3b51cda220474f28fc |
| September 21, 2017 16:06 | https://github.com/nodejs/node/pull/15520#event-1259706524 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 21, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331204311 |
| https://ci.nodejs.org/job/node-test-pull-request/10182/ | https://ci.nodejs.org/job/node-test-pull-request/10182/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/a2ba6b8b40464c2b087cce3b51cda220474f28fc..a4c7be870293e565d92a33eb8ead75b081afaf41 |
| a2ba6b8 | https://github.com/nodejs/node/commit/a2ba6b8b40464c2b087cce3b51cda220474f28fc |
| a4c7be8 | https://github.com/nodejs/node/commit/a4c7be870293e565d92a33eb8ead75b081afaf41 |
|
Compare
| https://github.com/nodejs/node/compare/a2ba6b8b40464c2b087cce3b51cda220474f28fc..a4c7be870293e565d92a33eb8ead75b081afaf41 |
| September 22, 2017 13:34 | https://github.com/nodejs/node/pull/15520#event-1261250384 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 22, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331448390 |
| https://ci.nodejs.org/job/node-test-pull-request/10193/ | https://ci.nodejs.org/job/node-test-pull-request/10193/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/a4c7be870293e565d92a33eb8ead75b081afaf41..9b36dfa12a957597f4d7a0d5375dd0607247ba07 |
| a4c7be8 | https://github.com/nodejs/node/commit/a4c7be870293e565d92a33eb8ead75b081afaf41 |
| 9b36dfa | https://github.com/nodejs/node/commit/9b36dfa12a957597f4d7a0d5375dd0607247ba07 |
|
Compare
| https://github.com/nodejs/node/compare/a4c7be870293e565d92a33eb8ead75b081afaf41..9b36dfa12a957597f4d7a0d5375dd0607247ba07 |
| September 22, 2017 15:02 | https://github.com/nodejs/node/pull/15520#event-1261414830 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 22, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331472583 |
| https://ci.nodejs.org/job/node-test-pull-request/10197/ | https://ci.nodejs.org/job/node-test-pull-request/10197/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/9b36dfa12a957597f4d7a0d5375dd0607247ba07..643f8a86395ac703c62aa88aff8b06c6d255e168 |
| 9b36dfa | https://github.com/nodejs/node/commit/9b36dfa12a957597f4d7a0d5375dd0607247ba07 |
| 643f8a8 | https://github.com/nodejs/node/commit/643f8a86395ac703c62aa88aff8b06c6d255e168 |
|
Compare
| https://github.com/nodejs/node/compare/9b36dfa12a957597f4d7a0d5375dd0607247ba07..643f8a86395ac703c62aa88aff8b06c6d255e168 |
| September 22, 2017 15:22 | https://github.com/nodejs/node/pull/15520#event-1261452225 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 22, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331478173 |
| https://ci.nodejs.org/job/node-test-pull-request/10199/ | https://ci.nodejs.org/job/node-test-pull-request/10199/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/643f8a86395ac703c62aa88aff8b06c6d255e168..830dda8e58c029aabf86a95f5e770fec6fc7febb |
| 643f8a8 | https://github.com/nodejs/node/commit/643f8a86395ac703c62aa88aff8b06c6d255e168 |
| 830dda8 | https://github.com/nodejs/node/commit/830dda8e58c029aabf86a95f5e770fec6fc7febb |
|
Compare
| https://github.com/nodejs/node/compare/643f8a86395ac703c62aa88aff8b06c6d255e168..830dda8e58c029aabf86a95f5e770fec6fc7febb |
| September 22, 2017 15:50 | https://github.com/nodejs/node/pull/15520#event-1261504237 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 22, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331487979 |
| https://ci.nodejs.org/job/node-test-pull-request/10202/ | https://ci.nodejs.org/job/node-test-pull-request/10202/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 25, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331774853 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/830dda8e58c029aabf86a95f5e770fec6fc7febb..d34934562824dbe7442b9bd934162844b37b5f0d |
| 830dda8 | https://github.com/nodejs/node/commit/830dda8e58c029aabf86a95f5e770fec6fc7febb |
| d349345 | https://github.com/nodejs/node/commit/d34934562824dbe7442b9bd934162844b37b5f0d |
|
Compare
| https://github.com/nodejs/node/compare/830dda8e58c029aabf86a95f5e770fec6fc7febb..d34934562824dbe7442b9bd934162844b37b5f0d |
| September 25, 2017 07:04 | https://github.com/nodejs/node/pull/15520#event-1263105348 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 25, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331794604 |
| https://ci.nodejs.org/job/node-test-pull-request/10248/ | https://ci.nodejs.org/job/node-test-pull-request/10248/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 25, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-64904739 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| BridgeAR | https://github.com/BridgeAR |
| Sep 25, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r140783802 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| mcollina | https://github.com/mcollina |
| Sep 25, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r140794195 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/d34934562824dbe7442b9bd934162844b37b5f0d..717a67ad5d9c4c4eb4927e4b1b4f3a34a26d6870 |
| d349345 | https://github.com/nodejs/node/commit/d34934562824dbe7442b9bd934162844b37b5f0d |
| 717a67a | https://github.com/nodejs/node/commit/717a67ad5d9c4c4eb4927e4b1b4f3a34a26d6870 |
|
Compare
| https://github.com/nodejs/node/compare/d34934562824dbe7442b9bd934162844b37b5f0d..717a67ad5d9c4c4eb4927e4b1b4f3a34a26d6870 |
| September 25, 2017 16:12 | https://github.com/nodejs/node/pull/15520#event-1264042464 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 25, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331933343 |
| https://ci.nodejs.org/job/node-test-pull-request/10253/ | https://ci.nodejs.org/job/node-test-pull-request/10253/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 25, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-331945730 |
| https://ci.nodejs.org/job/node-test-pull-request/10255/ | https://ci.nodejs.org/job/node-test-pull-request/10255/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/061f7a927fb8fd30ec74c5e129c578fed32e2bd5..f2061d820b0885c9630747b1077f738dabc0ef1c |
| 061f7a9 | https://github.com/nodejs/node/commit/061f7a927fb8fd30ec74c5e129c578fed32e2bd5 |
| f2061d8 | https://github.com/nodejs/node/commit/f2061d820b0885c9630747b1077f738dabc0ef1c |
|
Compare
| https://github.com/nodejs/node/compare/061f7a927fb8fd30ec74c5e129c578fed32e2bd5..f2061d820b0885c9630747b1077f738dabc0ef1c |
| September 26, 2017 09:54 | https://github.com/nodejs/node/pull/15520#event-1265376785 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-332149030 |
| https://ci.nodejs.org/job/node-test-pull-request/10273/ | https://ci.nodejs.org/job/node-test-pull-request/10273/ |
| @jasnell | https://github.com/jasnell |
| @lpinca | https://github.com/lpinca |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 26, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-65167808 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| lpinca | https://github.com/lpinca |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141016522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 26, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-65168386 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| lpinca | https://github.com/lpinca |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141016994 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 26, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-65169753 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| lpinca | https://github.com/lpinca |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141018126 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/f2061d820b0885c9630747b1077f738dabc0ef1c..7d6a0aaa8492b04acab3a945d797f674f5b4000e |
| f2061d8 | https://github.com/nodejs/node/commit/f2061d820b0885c9630747b1077f738dabc0ef1c |
| 7d6a0aa | https://github.com/nodejs/node/commit/7d6a0aaa8492b04acab3a945d797f674f5b4000e |
|
Compare
| https://github.com/nodejs/node/compare/f2061d820b0885c9630747b1077f738dabc0ef1c..7d6a0aaa8492b04acab3a945d797f674f5b4000e |
| September 26, 2017 10:54 | https://github.com/nodejs/node/pull/15520#event-1265473133 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-332162182 |
| @lpinca | https://github.com/lpinca |
| https://ci.nodejs.org/job/node-test-pull-request/10274/ | https://ci.nodejs.org/job/node-test-pull-request/10274/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 26, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-65179494 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| lpinca | https://github.com/lpinca |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141026463 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| lpinca | https://github.com/lpinca |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141026490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 26, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-65208114 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| cjihrig | https://github.com/cjihrig |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141050781 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15520/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| cjihrig | https://github.com/cjihrig |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141051020 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| lpinca | https://github.com/lpinca |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141053491 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| cjihrig | https://github.com/cjihrig |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141054475 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| lpinca | https://github.com/lpinca |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141056129 |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| cjihrig | https://github.com/cjihrig |
| Sep 26, 2017 | https://github.com/nodejs/node/pull/15520#discussion_r141056888 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/7d6a0aaa8492b04acab3a945d797f674f5b4000e..adf649aaf2dc3af106db02242197449d55a22a8d |
| 7d6a0aa | https://github.com/nodejs/node/commit/7d6a0aaa8492b04acab3a945d797f674f5b4000e |
| adf649a | https://github.com/nodejs/node/commit/adf649aaf2dc3af106db02242197449d55a22a8d |
|
Compare
| https://github.com/nodejs/node/compare/7d6a0aaa8492b04acab3a945d797f674f5b4000e..adf649aaf2dc3af106db02242197449d55a22a8d |
| September 27, 2017 11:25 | https://github.com/nodejs/node/pull/15520#event-1267569449 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 27, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-332491225 |
| https://ci.nodejs.org/job/node-test-pull-request/10286/ | https://ci.nodejs.org/job/node-test-pull-request/10286/ |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
|
| https://github.com/mcollina |
| test: fix http-writable-true-after-close flakyness | https://github.com/nodejs/node/pull/15520/commits/dfd4c63553eda9fcefac695dedbe16042529a41a |
| dfd4c63 | https://github.com/nodejs/node/pull/15520/commits/dfd4c63553eda9fcefac695dedbe16042529a41a |
| nodejs#15404 | https://github.com/nodejs/node/pull/15404 |
| nodejs#15505 | https://github.com/nodejs/node/issues/15505 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/adf649aaf2dc3af106db02242197449d55a22a8d..dfd4c63553eda9fcefac695dedbe16042529a41a |
| adf649a | https://github.com/nodejs/node/commit/adf649aaf2dc3af106db02242197449d55a22a8d |
| dfd4c63 | https://github.com/nodejs/node/commit/dfd4c63553eda9fcefac695dedbe16042529a41a |
|
Compare
| https://github.com/nodejs/node/compare/adf649aaf2dc3af106db02242197449d55a22a8d..dfd4c63553eda9fcefac695dedbe16042529a41a |
| September 27, 2017 11:27 | https://github.com/nodejs/node/pull/15520#event-1267572703 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 27, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-332491596 |
| https://ci.nodejs.org/job/node-test-pull-request/10287/ | https://ci.nodejs.org/job/node-test-pull-request/10287/ |
| @cjihrig | https://github.com/cjihrig |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 27, 2017
| https://github.com/nodejs/node/pull/15520#pullrequestreview-65516327 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15520/files/dfd4c63553eda9fcefac695dedbe16042529a41a |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Sep 27, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-332506733 |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 27, 2017 | https://github.com/nodejs/node/pull/15520#issuecomment-332515082 |
| 1fe9b53 | https://github.com/nodejs/node/commit/1fe9b535a78a23a9549b544ec4a4f76614f45c5c |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 27, 2017 | https://github.com/nodejs/node/pull/15520#event-1267731647 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| September 27, 2017 13:09 | https://github.com/nodejs/node/pull/15520#event-1267731796 |
| mcollina | https://github.com/mcollina |
|
Sep 27, 2017
| https://github.com/nodejs/node/pull/15520#ref-commit-1fe9b53 |
|
| https://github.com/mcollina |
| test: fix http-writable-true-after-close flakyness | https://github.com/nodejs/node/commit/1fe9b535a78a23a9549b544ec4a4f76614f45c5c |
| 1fe9b53 | https://github.com/nodejs/node/commit/1fe9b535a78a23a9549b544ec4a4f76614f45c5c |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| #15505 | https://github.com/nodejs/node/issues/15505 |
| #15520 | https://github.com/nodejs/node/pull/15520 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 28, 2017
| https://github.com/nodejs/node/pull/15520#ref-commit-067c5e4 |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| test: fix http-writable-true-after-close flakyness | https://github.com/MylesBorins/node/commit/067c5e4a2805b2953b3c1f07afd5413a66ddce44 |
| 067c5e4 | https://github.com/MylesBorins/node/commit/067c5e4a2805b2953b3c1f07afd5413a66ddce44 |
| nodejs#15404 | https://github.com/nodejs/node/pull/15404 |
| nodejs#15505 | https://github.com/nodejs/node/issues/15505 |
| nodejs#15520 | https://github.com/nodejs/node/pull/15520 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 29, 2017
| https://github.com/nodejs/node/pull/15520#ref-commit-f2fde76 |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| test: fix http-writable-true-after-close flakyness | https://github.com/nodejs/node/commit/f2fde76aeaeda3453b88ff1fba6eaeb94ae2ac69 |
| f2fde76 | https://github.com/nodejs/node/commit/f2fde76aeaeda3453b88ff1fba6eaeb94ae2ac69 |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| #15505 | https://github.com/nodejs/node/issues/15505 |
| #15520 | https://github.com/nodejs/node/pull/15520 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 30, 2017
| https://github.com/nodejs/node/pull/15520#ref-issue-261820515 |
|
CentOS 5
nodejs/build#898
| https://github.com/nodejs/build/issues/898 |
| addaleax | https://github.com/addaleax |
|
Sep 30, 2017
| https://github.com/nodejs/node/pull/15520#ref-commit-14c9585 |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
| test: fix http-writable-true-after-close flakyness | https://github.com/addaleax/ayo/commit/14c9585baa472183bc4f71ba4d062da212b6549e |
| 14c9585 | https://github.com/addaleax/ayo/commit/14c9585baa472183bc4f71ba4d062da212b6549e |
| nodejs/node#15404 | https://github.com/nodejs/node/pull/15404 |
| nodejs/node#15505 | https://github.com/nodejs/node/issues/15505 |
| nodejs/node#15520 | https://github.com/nodejs/node/pull/15520 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 30, 2017
| https://github.com/nodejs/node/pull/15520#ref-issue-261857085 |
|
investigate flaky parallel/test-http-writable-true-after-close on macOS
#15700
| https://github.com/nodejs/node/issues/15700 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 3, 2017
| https://github.com/nodejs/node/pull/15520#ref-pullrequest-262583553 |
|
v8.7.0 proposal
#15762
| https://github.com/nodejs/node/pull/15762 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 3, 2017
| https://github.com/nodejs/node/pull/15520#ref-commit-0aea258 |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| test: fix http-writable-true-after-close flakyness | https://github.com/nodejs/node/commit/0aea258f0e2c40307679e0796b4f16e34db3650a |
| 0aea258 | https://github.com/nodejs/node/commit/0aea258f0e2c40307679e0796b4f16e34db3650a |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| #15505 | https://github.com/nodejs/node/issues/15505 |
| #15520 | https://github.com/nodejs/node/pull/15520 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/15520#event-1297565280 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Feb 12, 2022
| https://github.com/nodejs/node/pull/15520#ref-pullrequest-1133568960 |
|
[Snyk] Upgrade eslint from 7.32.0 to 8.7.0
Iceymann18777/node#4
| https://github.com/Iceymann18777/node/pull/4 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15520 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/15520/files/7d6a0aaa8492b04acab3a945d797f674f5b4000e |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/15520/files/d34934562824dbe7442b9bd934162844b37b5f0d |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/15520/files/cfaf6bf34430e93b65b9b791128a94b62bf5323f |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/15520/files/dfd4c63553eda9fcefac695dedbe16042529a41a |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/15520 |
|
| https://github.com/mcollina |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |