René's URL Explorer Experiment


Title: fs: refactor close to use destroy by mcollina · Pull Request #15407 · nodejs/node · GitHub

Open Graph Title: fs: refactor close to use destroy by mcollina · Pull Request #15407 · nodejs/node

X Title: fs: refactor close to use destroy by mcollina · Pull Request #15407 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refactor close() to use destroy() and not vice versa in ReadStream. Avoid races between WriteStream.close and WriteStream.write, by aliasing close to end(). Fixes: #2006 Checklist make -j4 test ...

X Description: Refactor close() to use destroy() and not vice versa in ReadStream. Avoid races between WriteStream.close and WriteStream.write, by aliasing close to end(). Fixes: #2006 Checklist make -j4 test ...

Opengraph URL: https://github.com/nodejs/node/pull/15407

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:554c534b-5c0c-4d90-f099-c1760b6d2540
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD848:48B83:85F2A3:BC7AFA:6A4FD281
html-safe-nonced0db7f24f26c28036d1816b0d18e0240a6e0d2ea60ed70d34d094b86b2761a69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODQ4OjQ4QjgzOjg1RjJBMzpCQzdBRkE6NkE0RkQyODEiLCJ2aXNpdG9yX2lkIjoiMTk0OTY0MjI4MjAxMDM5OTM2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac12e9573c2de5d36f2b6453bfec1a007bb21b0c68cff55844da69c2f941e6b3e9
hovercard-subject-tagpull_request:141053068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15407/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8fd448f8fa32ff9425e667a423aaee04fc9c8d30eb4a030a73a4260643c9fc55/nodejs/node/pull/15407
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8fd448f8fa32ff9425e667a423aaee04fc9c8d30eb4a030a73a4260643c9fc55/nodejs/node/pull/15407
og:image:altRefactor close() to use destroy() and not vice versa in ReadStream. Avoid races between WriteStream.close and WriteStream.write, by aliasing close to end(). Fixes: #2006 Checklist make -j4 test ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/15407#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15407
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15407
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/15407
Reloadhttps://github.com/nodejs/node/pull/15407
Reloadhttps://github.com/nodejs/node/pull/15407
Please reload this pagehttps://github.com/nodejs/node/pull/15407
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/15407
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:fs-destroyhttps://github.com/mcollina/node/tree/fs-destroy
Conversationhttps://github.com/nodejs/node/pull/15407
Commits1 (1)https://github.com/nodejs/node/pull/15407/commits
Checkshttps://github.com/nodejs/node/pull/15407/checks
Files changedhttps://github.com/nodejs/node/pull/15407/files
fs: refactor close to use destroyhttps://github.com/nodejs/node/pull/15407#top
mcollinahttps://github.com/mcollina
nodejs:masterhttps://github.com/nodejs/node/tree/master
mcollina:fs-destroyhttps://github.com/mcollina/node/tree/fs-destroy
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2017https://github.com/nodejs/node/pull/15407#issue-257691219
Please reload this pagehttps://github.com/nodejs/node/pull/15407
#2006https://github.com/nodejs/node/issues/2006
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Sep 14, 2017https://github.com/nodejs/node/pull/15407#event-1249051598
https://github.com/mcollina
mcollinahttps://github.com/mcollina
bnoordhuishttps://github.com/bnoordhuis
jasnellhttps://github.com/jasnell
September 14, 2017 11:50https://github.com/nodejs/node/pull/15407#event-1249051602
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Sep 14, 2017https://github.com/nodejs/node/pull/15407#event-1249051671
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Sep 14, 2017https://github.com/nodejs/node/pull/15407#event-1249056227
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 14, 2017 https://github.com/nodejs/node/pull/15407#pullrequestreview-62723920
View reviewed changes https://github.com/nodejs/node/pull/15407/files
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/15407#pullrequestreview-62723920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2017https://github.com/nodejs/node/pull/15407#issuecomment-329459362
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 14, 2017https://github.com/nodejs/node/pull/15407#issuecomment-329459548
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2017 https://github.com/nodejs/node/pull/15407#ref-issue-89184463
Closing fs streams early could call close during or before I/O #2006 https://github.com/nodejs/node/issues/2006
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2017https://github.com/nodejs/node/pull/15407#issuecomment-329460015
https://ci.nodejs.org/job/node-test-pull-request/10075/https://ci.nodejs.org/job/node-test-pull-request/10075/
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 19, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330612047
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/991/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/991/
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 19, 2017 https://github.com/nodejs/node/pull/15407#pullrequestreview-63776471
View reviewed changes https://github.com/nodejs/node/pull/15407/files
lib/fs.jshttps://github.com/nodejs/node/pull/15407/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
BridgeARhttps://github.com/BridgeAR
Sep 19, 2017https://github.com/nodejs/node/pull/15407#discussion_r139795064
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15407
mcollinahttps://github.com/mcollina
Sep 20, 2017https://github.com/nodejs/node/pull/15407#discussion_r139912347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 20, 2017 https://github.com/nodejs/node/pull/15407#pullrequestreview-63841961
View reviewed changes https://github.com/nodejs/node/pull/15407/files
test/parallel/test-fs-read-stream-double-close.jshttps://github.com/nodejs/node/pull/15407/files#diff-79f1b040c0d48941c9ef8ee19e154bf9a81bf052616ad6756edce1d49ccc8e07
cjihrighttps://github.com/cjihrig
Sep 20, 2017https://github.com/nodejs/node/pull/15407#discussion_r139852400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/b577e46fbed33b8817e352953bea77c962849e2f..276ef74ee2c04a389fe58c8e9b1f2e1ebdf2dda4
b577e46https://github.com/nodejs/node/commit/b577e46fbed33b8817e352953bea77c962849e2f
276ef74https://github.com/nodejs/node/commit/276ef74ee2c04a389fe58c8e9b1f2e1ebdf2dda4
Compare https://github.com/nodejs/node/compare/b577e46fbed33b8817e352953bea77c962849e2f..276ef74ee2c04a389fe58c8e9b1f2e1ebdf2dda4
September 20, 2017 09:20https://github.com/nodejs/node/pull/15407#event-1257051502
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330796102
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/992/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/992/
https://ci.nodejs.org/job/node-test-pull-request/10157/https://ci.nodejs.org/job/node-test-pull-request/10157/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/993/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/993/
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
fs: refactor close to use destroyhttps://github.com/nodejs/node/pull/15407/commits/2985acaa93f0a4920928d9d1e86694e242595e34
2985acahttps://github.com/nodejs/node/pull/15407/commits/2985acaa93f0a4920928d9d1e86694e242595e34
nodejs#2006https://github.com/nodejs/node/issues/2006
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/276ef74ee2c04a389fe58c8e9b1f2e1ebdf2dda4..2985acaa93f0a4920928d9d1e86694e242595e34
276ef74https://github.com/nodejs/node/commit/276ef74ee2c04a389fe58c8e9b1f2e1ebdf2dda4
2985acahttps://github.com/nodejs/node/commit/2985acaa93f0a4920928d9d1e86694e242595e34
Compare https://github.com/nodejs/node/compare/276ef74ee2c04a389fe58c8e9b1f2e1ebdf2dda4..2985acaa93f0a4920928d9d1e86694e242595e34
September 20, 2017 14:37https://github.com/nodejs/node/pull/15407#event-1257570877
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330872635
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330872932
https://ci.nodejs.org/job/node-test-pull-request/10162/https://ci.nodejs.org/job/node-test-pull-request/10162/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/994/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/994/
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330911158
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330913941
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330914830
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/refack
refackhttps://github.com/refack
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330941316
@mcollinahttps://github.com/mcollina
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/994/nodes=ubuntu1604-64/testReport/(root)/citgm/readable_stream_v2_3_3/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/994/nodes=ubuntu1604-64/testReport/(root)/citgm/readable_stream_v2_3_3/
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/refack
refackhttps://github.com/refack
Sep 20, 2017https://github.com/nodejs/node/pull/15407#issuecomment-330971587
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/refack
refackhttps://github.com/refack
Sep 20, 2017 https://github.com/nodejs/node/pull/15407#pullrequestreview-64108146
View reviewed changes https://github.com/nodejs/node/pull/15407/files/2985acaa93f0a4920928d9d1e86694e242595e34
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/15407#pullrequestreview-64108146
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 21, 2017https://github.com/nodejs/node/pull/15407#issuecomment-331071623
e5c290bhttps://github.com/nodejs/node/commit/e5c290bed9775bdddd74650995f3358373af8097
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 21, 2017https://github.com/nodejs/node/pull/15407#event-1258809918
https://github.com/mcollina
mcollinahttps://github.com/mcollina
September 21, 2017 07:09https://github.com/nodejs/node/pull/15407#event-1258809991
mcollinahttps://github.com/mcollina
Sep 21, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-e5c290b
https://github.com/mcollina
fs: refactor close to use destroyhttps://github.com/nodejs/node/commit/e5c290bed9775bdddd74650995f3358373af8097
e5c290bhttps://github.com/nodejs/node/commit/e5c290bed9775bdddd74650995f3358373af8097
#2006https://github.com/nodejs/node/issues/2006
#15407https://github.com/nodejs/node/pull/15407
Qardhttps://github.com/Qard
Sep 21, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-2b37cad
https://github.com/mcollina
fs: refactor close to use destroyhttps://github.com/Qard/ayo/commit/2b37cad868e88656fe5ad87c66af76eac47461f8
2b37cadhttps://github.com/Qard/ayo/commit/2b37cad868e88656fe5ad87c66af76eac47461f8
nodejs/node#2006https://github.com/nodejs/node/issues/2006
nodejs/node#15407https://github.com/nodejs/node/pull/15407
Qardhttps://github.com/Qard
Sep 21, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-375dc5a
https://github.com/mcollina
fs: refactor close to use destroyhttps://github.com/Qard/ayo/commit/375dc5a46fa66d7c2aad3a411ecb450867eb0841
375dc5ahttps://github.com/Qard/ayo/commit/375dc5a46fa66d7c2aad3a411ecb450867eb0841
nodejs/node#2006https://github.com/nodejs/node/issues/2006
nodejs/node#15407https://github.com/nodejs/node/pull/15407
lukaszewczakhttps://github.com/lukaszewczak
Sep 23, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-90f7d9f
https://github.com/mcollina
https://github.com/lukaszewczak
fs: refactor close to use destroyhttps://github.com/lukaszewczak/node/commit/90f7d9f14d8ee26f93189638c22faef6a83c7fe9
90f7d9fhttps://github.com/lukaszewczak/node/commit/90f7d9f14d8ee26f93189638c22faef6a83c7fe9
nodejs#2006https://github.com/nodejs/node/issues/2006
nodejs#15407https://github.com/nodejs/node/pull/15407
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-6891ac2
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
6891ac2https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-7165af5
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
7165af5https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-a618552
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
a618552https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/15407#ref-commit-8d28704
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
8d28704https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/15407#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
https://github.com/Plamen5kov
Plamen5kovhttps://github.com/Plamen5kov
Dec 12, 2017 https://github.com/nodejs/node/pull/15407#ref-pullrequest-281361961
fix(snapshot): use autoclose option on writestream NativeScript/nativescript-dev-webpack#345 https://github.com/NativeScript/nativescript-dev-webpack/pull/345
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 5, 2018 https://github.com/nodejs/node/pull/15407#ref-pullrequest-286239275
fs: guarantee order of callbacks in ws.close #18002 https://github.com/nodejs/node/pull/18002
mcollinahttps://github.com/mcollina
Jan 5, 2018 https://github.com/nodejs/node/pull/15407#ref-commit-0a4854d
https://github.com/mcollina
fs: guarantee order of callbacks in ws.closehttps://github.com/mcollina/node/commit/0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
0a4854dhttps://github.com/mcollina/node/commit/0a4854dbec67e5a40c7a2de3ce7b26fc8ec84b39
nodejs#17951https://github.com/nodejs/node/issues/17951
nodejs#15407https://github.com/nodejs/node/pull/15407
mcollinahttps://github.com/mcollina
Jan 8, 2018 https://github.com/nodejs/node/pull/15407#ref-commit-acf56be
https://github.com/mcollina
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/commit/acf56be536ee67e3696f3c2b097cfd176d3d76c6
acf56behttps://github.com/nodejs/node/commit/acf56be536ee67e3696f3c2b097cfd176d3d76c6
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
#18002https://github.com/nodejs/node/pull/18002
#17951https://github.com/nodejs/node/issues/17951
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/15407#ref-commit-4dc53f5
https://github.com/mcollina
https://github.com/MylesBorins
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/commit/4dc53f5c94590e228eb576f16969eddd158720e4
4dc53f5https://github.com/nodejs/node/commit/4dc53f5c94590e228eb576f16969eddd158720e4
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
#18002https://github.com/nodejs/node/pull/18002
#17951https://github.com/nodejs/node/issues/17951
MylesBorinshttps://github.com/MylesBorins
Jan 10, 2018 https://github.com/nodejs/node/pull/15407#ref-commit-f148556
https://github.com/mcollina
https://github.com/MylesBorins
fs: guarantee order of callbacks in ws.closehttps://github.com/nodejs/node/commit/f1485565efe79ea154afdfd3eaa68eae28160805
f148556https://github.com/nodejs/node/commit/f1485565efe79ea154afdfd3eaa68eae28160805
#17951https://github.com/nodejs/node/issues/17951
#15407https://github.com/nodejs/node/pull/15407
#18002https://github.com/nodejs/node/pull/18002
#17951https://github.com/nodejs/node/issues/17951
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 17, 2018 https://github.com/nodejs/node/pull/15407#ref-pullrequest-289455243
Do not rely on Node.js internals gulpjs/vinyl-fs#296 https://github.com/gulpjs/vinyl-fs/pull/296
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 19, 2019 https://github.com/nodejs/node/pull/15407#ref-pullrequest-482391425
[x] stream: don't emit finish after destroy() #29205 https://github.com/nodejs/node/pull/29205
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15407
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/15407/files/b577e46fbed33b8817e352953bea77c962849e2f
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/15407/files/b577e46fbed33b8817e352953bea77c962849e2f
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/15407/files/b577e46fbed33b8817e352953bea77c962849e2f
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/15407/files/2985acaa93f0a4920928d9d1e86694e242595e34
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Closing fs streams early could call close during or before I/O https://github.com/nodejs/node/issues/2006
Please reload this pagehttps://github.com/nodejs/node/pull/15407
https://github.com/mcollina
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com/MylesBorins
https://github.com/refack
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.