| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e2a3d90b-4560-a4db-833b-4904fd7bbdbb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB74:34DA5A:474639C:655A66B:6A4FD21F |
| html-safe-nonce | bc7ac1f9f849830920f66d9c51ebedaf96d04b41ad0d11478856e028ea576ff8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjc0OjM0REE1QTo0NzQ2MzlDOjY1NUE2NkI6NkE0RkQyMUYiLCJ2aXNpdG9yX2lkIjoiNTc4MzcwNjQ0NDM5MTkyMDk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 196ccd5a3abed135a49fd51e15f08c5dfa4b3ec5b62d111bce5584553c177a04 |
| hovercard-subject-tag | pull_request:141023454 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15404/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/357fca479d4d999b8c253bb68a435022153197e08ac2277d1e808cd36d1bf32d/nodejs/node/pull/15404 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/357fca479d4d999b8c253bb68a435022153197e08ac2277d1e808cd36d1bf32d/nodejs/node/pull/15404 |
| og:image:alt | Setting writable = false in IncomingMessage.end made some errors
being swallowed in some very popular OSS libraries that we must
support. This commit add some of those use cases, so we avoid furthe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mcollina |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/15404#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15404 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15404 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/15404 |
| Reload | https://github.com/nodejs/node/pull/15404 |
| Reload | https://github.com/nodejs/node/pull/15404 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:fix-15029 | https://github.com/mcollina/node/tree/fix-15029 |
| Conversation | https://github.com/nodejs/node/pull/15404 |
| Commits1 (1) | https://github.com/nodejs/node/pull/15404/commits |
| Checks | https://github.com/nodejs/node/pull/15404/checks |
| Files changed | https://github.com/nodejs/node/pull/15404/files |
| http: revert #14024 writable is never set to false | https://github.com/nodejs/node/pull/15404#top |
| mcollina | https://github.com/mcollina |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mcollina:fix-15029 | https://github.com/mcollina/node/tree/fix-15029 |
|
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issue-257651710 |
| #14024 | https://github.com/nodejs/node/pull/14024 |
| #15029 | https://github.com/nodejs/node/issues/15029 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#event-1248827312 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| jasnell | https://github.com/jasnell |
| September 14, 2017 09:24 | https://github.com/nodejs/node/pull/15404#event-1248827365 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15404#ref-pullrequest-239943418 |
|
http: OutgoingMessage change writable after end
#14024
| https://github.com/nodejs/node/pull/14024 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-329426181 |
| @trygve-lie | https://github.com/trygve-lie |
| @SimenB | https://github.com/SimenB |
| @Kasher | https://github.com/Kasher |
| @gireeshpunathil | https://github.com/gireeshpunathil |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/SimenB |
| SimenB | https://github.com/SimenB |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15404#ref-issue-253904883 |
|
"premature close" error not thrown in node 8.2.0 or newer
mafintosh/end-of-stream#14
| https://github.com/mafintosh/end-of-stream/issues/14 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-329445689 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15404#pullrequestreview-62720688 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15404/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/15404#pullrequestreview-62720688 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-329459621 |
| @jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/15404/files#diff-0957961bda9af181fe86099a4cbd825e | https://github.com/nodejs/node/pull/15404/files#diff-0957961bda9af181fe86099a4cbd825e |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15404#pullrequestreview-62761026 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15404/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/15404#pullrequestreview-62761026 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| test/parallel/test-http-writable-true-after-close.js | https://github.com/nodejs/node/pull/15404/files#diff-14db70792cc3d1784aaedcb2cacd9b2054470e6520d3d51bf91453f3b08e9811 |
| cjihrig | https://github.com/cjihrig |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#discussion_r138903228 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-329498837 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-329499729 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-329502888 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| @mscdex | https://github.com/mscdex |
| https://github.com/mafintosh/end-of-stream/blob/master/index.js#L24-L26 | https://github.com/mafintosh/end-of-stream/blob/master/index.js#L24-L26 |
| https://github.com/mafintosh/end-of-stream/blob/master/index.js#L56-L59 | https://github.com/mafintosh/end-of-stream/blob/master/index.js#L56-L59 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/SimenB |
| SimenB | https://github.com/SimenB |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15404#ref-issue-252868575 |
|
Possible bug in streams between node 8.1.4 and 8.2.0
#15029
| https://github.com/nodejs/node/issues/15029 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/2d398255a2caa52c9e63c3d2ff42adb0b56f053c..c0eb9f810f997cb2bf918e7adfcd5c4bb936b88c |
| 2d39825 | https://github.com/nodejs/node/commit/2d398255a2caa52c9e63c3d2ff42adb0b56f053c |
| c0eb9f8 | https://github.com/nodejs/node/commit/c0eb9f810f997cb2bf918e7adfcd5c4bb936b88c |
|
Compare
| https://github.com/nodejs/node/compare/2d398255a2caa52c9e63c3d2ff42adb0b56f053c..c0eb9f810f997cb2bf918e7adfcd5c4bb936b88c |
| September 14, 2017 14:48 | https://github.com/nodejs/node/pull/15404#event-1249372588 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-329506227 |
| https://ci.nodejs.org/job/node-test-pull-request/10078/ | https://ci.nodejs.org/job/node-test-pull-request/10078/ |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-330611227 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/990/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/990/ |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 19, 2017
| https://github.com/nodejs/node/pull/15404#pullrequestreview-63779328 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15404/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/15404#pullrequestreview-63779328 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
|
| https://github.com/mcollina |
| http: revert | https://github.com/nodejs/node/pull/15404/commits/cccf9348ab7051f6babe89ee38e3076c84782810 |
| nodejs#14024 | https://github.com/nodejs/node/pull/14024 |
| writable is never set to false | https://github.com/nodejs/node/pull/15404/commits/cccf9348ab7051f6babe89ee38e3076c84782810 |
| cccf934 | https://github.com/nodejs/node/pull/15404/commits/cccf9348ab7051f6babe89ee38e3076c84782810 |
| nodejs#14024 | https://github.com/nodejs/node/pull/14024 |
| nodejs#15029 | https://github.com/nodejs/node/issues/15029 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| force-pushed | https://github.com/nodejs/node/compare/c0eb9f810f997cb2bf918e7adfcd5c4bb936b88c..cccf9348ab7051f6babe89ee38e3076c84782810 |
| c0eb9f8 | https://github.com/nodejs/node/commit/c0eb9f810f997cb2bf918e7adfcd5c4bb936b88c |
| cccf934 | https://github.com/nodejs/node/commit/cccf9348ab7051f6babe89ee38e3076c84782810 |
|
Compare
| https://github.com/nodejs/node/compare/c0eb9f810f997cb2bf918e7adfcd5c4bb936b88c..cccf9348ab7051f6babe89ee38e3076c84782810 |
| September 20, 2017 09:31 | https://github.com/nodejs/node/pull/15404#event-1257070558 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 20, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-330798644 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 20, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-330800900 |
| 8589c70 | https://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 20, 2017 | https://github.com/nodejs/node/pull/15404#event-1257086710 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| September 20, 2017 09:41 | https://github.com/nodejs/node/pull/15404#event-1257086808 |
| mcollina | https://github.com/mcollina |
|
Sep 20, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-8589c70 |
|
| https://github.com/mcollina |
| http: revert | https://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696 |
| #14024 | https://github.com/nodejs/node/pull/14024 |
| writable is never set to false | https://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696 |
| 8589c70 | https://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696 |
| #14024 | https://github.com/nodejs/node/pull/14024 |
| #15029 | https://github.com/nodejs/node/issues/15029 |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| jasnell | https://github.com/jasnell |
|
Sep 20, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-771c2ac |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
| http: revert | https://github.com/nodejs/node/commit/771c2ac7c295a773445d86e1dcd6d2722aff2137 |
| #14024 | https://github.com/nodejs/node/pull/14024 |
| writable is never set to false | https://github.com/nodejs/node/commit/771c2ac7c295a773445d86e1dcd6d2722aff2137 |
| 771c2ac | https://github.com/nodejs/node/commit/771c2ac7c295a773445d86e1dcd6d2722aff2137 |
| #14024 | https://github.com/nodejs/node/pull/14024 |
| #15029 | https://github.com/nodejs/node/issues/15029 |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Sep 20, 2017
| https://github.com/nodejs/node/pull/15404#ref-issue-259304066 |
|
test-http-writable-true-after-close failure on centos
#15505
| https://github.com/nodejs/node/issues/15505 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 20, 2017
| https://github.com/nodejs/node/pull/15404#ref-pullrequest-259314305 |
|
Node.js 8.6.0 Release Proposal
#15509
| https://github.com/nodejs/node/pull/15509 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/15404#ref-pullrequest-259394467 |
|
test: defer abort with setTimeout
#15520
| https://github.com/nodejs/node/pull/15520 |
| Qard | https://github.com/Qard |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-d272433 |
|
| https://github.com/mcollina |
| http: revert #14024 writable is never set to false | https://github.com/Qard/ayo/commit/d272433f6ad758e1a73b65646bb70526018ddd98 |
| d272433 | https://github.com/Qard/ayo/commit/d272433f6ad758e1a73b65646bb70526018ddd98 |
| nodejs/node#14024 | https://github.com/nodejs/node/pull/14024 |
| nodejs/node#15029 | https://github.com/nodejs/node/issues/15029 |
| nodejs/node#15404 | https://github.com/nodejs/node/pull/15404 |
| Qard | https://github.com/Qard |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-4638c68 |
|
| https://github.com/mcollina |
| http: revert #14024 writable is never set to false | https://github.com/Qard/ayo/commit/4638c6873afea2e21f69c94cab8bcdd65d45e921 |
| 4638c68 | https://github.com/Qard/ayo/commit/4638c6873afea2e21f69c94cab8bcdd65d45e921 |
| nodejs/node#14024 | https://github.com/nodejs/node/pull/14024 |
| nodejs/node#15029 | https://github.com/nodejs/node/issues/15029 |
| nodejs/node#15404 | https://github.com/nodejs/node/pull/15404 |
| mcollina | https://github.com/mcollina |
|
Sep 27, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-dfd4c63 |
|
| https://github.com/mcollina |
| test: fix http-writable-true-after-close flakyness | https://github.com/mcollina/node/commit/dfd4c63553eda9fcefac695dedbe16042529a41a |
| dfd4c63 | https://github.com/mcollina/node/commit/dfd4c63553eda9fcefac695dedbe16042529a41a |
| nodejs#15404 | https://github.com/nodejs/node/pull/15404 |
| nodejs#15505 | https://github.com/nodejs/node/issues/15505 |
| mcollina | https://github.com/mcollina |
|
Sep 27, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-1fe9b53 |
|
| https://github.com/mcollina |
| test: fix http-writable-true-after-close flakyness | https://github.com/nodejs/node/commit/1fe9b535a78a23a9549b544ec4a4f76614f45c5c |
| 1fe9b53 | https://github.com/nodejs/node/commit/1fe9b535a78a23a9549b544ec4a4f76614f45c5c |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| #15505 | https://github.com/nodejs/node/issues/15505 |
| #15520 | https://github.com/nodejs/node/pull/15520 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 28, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-067c5e4 |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| test: fix http-writable-true-after-close flakyness | https://github.com/MylesBorins/node/commit/067c5e4a2805b2953b3c1f07afd5413a66ddce44 |
| 067c5e4 | https://github.com/MylesBorins/node/commit/067c5e4a2805b2953b3c1f07afd5413a66ddce44 |
| nodejs#15404 | https://github.com/nodejs/node/pull/15404 |
| nodejs#15505 | https://github.com/nodejs/node/issues/15505 |
| nodejs#15520 | https://github.com/nodejs/node/pull/15520 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 29, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-f2fde76 |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| test: fix http-writable-true-after-close flakyness | https://github.com/nodejs/node/commit/f2fde76aeaeda3453b88ff1fba6eaeb94ae2ac69 |
| f2fde76 | https://github.com/nodejs/node/commit/f2fde76aeaeda3453b88ff1fba6eaeb94ae2ac69 |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| #15505 | https://github.com/nodejs/node/issues/15505 |
| #15520 | https://github.com/nodejs/node/pull/15520 |
| addaleax | https://github.com/addaleax |
|
Sep 30, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-14c9585 |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
| test: fix http-writable-true-after-close flakyness | https://github.com/addaleax/ayo/commit/14c9585baa472183bc4f71ba4d062da212b6549e |
| 14c9585 | https://github.com/addaleax/ayo/commit/14c9585baa472183bc4f71ba4d062da212b6549e |
| nodejs/node#15404 | https://github.com/nodejs/node/pull/15404 |
| nodejs/node#15505 | https://github.com/nodejs/node/issues/15505 |
| nodejs/node#15520 | https://github.com/nodejs/node/pull/15520 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 3, 2017
| https://github.com/nodejs/node/pull/15404#ref-commit-0aea258 |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| test: fix http-writable-true-after-close flakyness | https://github.com/nodejs/node/commit/0aea258f0e2c40307679e0796b4f16e34db3650a |
| 0aea258 | https://github.com/nodejs/node/commit/0aea258f0e2c40307679e0796b4f16e34db3650a |
| #15404 | https://github.com/nodejs/node/pull/15404 |
| #15505 | https://github.com/nodejs/node/issues/15505 |
| #15520 | https://github.com/nodejs/node/pull/15520 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/15404#event-1295770637 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 16, 2017 | https://github.com/nodejs/node/pull/15404#issuecomment-337056166 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Apr 23, 2018
| https://github.com/nodejs/node/pull/15404#ref-issue-316905378 |
|
reevaluate how to set writable = false in IncomingMessage
#20233
| https://github.com/nodejs/node/issues/20233 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 16, 2019
| https://github.com/nodejs/node/pull/15404#ref-pullrequest-468473536 |
|
http: writable set to false
#28715
| https://github.com/nodejs/node/pull/28715 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15404 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/15404/files/7a94a5e4b12a5773bd9a6d74f3a96c2febda2d6b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/15404/files/7a94a5e4b12a5773bd9a6d74f3a96c2febda2d6b |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/15404/files/c0eb9f810f997cb2bf918e7adfcd5c4bb936b88c |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
Possible bug in streams between node 8.1.4 and 8.2.0
| https://github.com/nodejs/node/issues/15029 |
| Please reload this page | https://github.com/nodejs/node/pull/15404 |
|
| https://github.com/mcollina |
|
| https://github.com/mafintosh |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |