| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c31a7303-5058-9df6-7975-f804f60223b0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CBBA:2DA286:14AB597:1C895DA:6A4DF016 |
| html-safe-nonce | d9b67a569f1ab15f8c592c9615ddbc4b379641204758a5ded152897677ddf407 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkJBOjJEQTI4NjoxNEFCNTk3OjFDODk1REE6NkE0REYwMTYiLCJ2aXNpdG9yX2lkIjoiOTA3MDgxNzMwNDI1MDI4MjAwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3827da9681960f8cc27dd3e08e421d43c19b02962c63d3870bf934ebeb684511 |
| hovercard-subject-tag | pull_request:140934783 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15398/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7939ce4d29f109d87e87139effe15cf7667c654693412c8e9b9e0e22f5397147/nodejs/node/pull/15398 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7939ce4d29f109d87e87139effe15cf7667c654693412c8e9b9e0e22f5397147/nodejs/node/pull/15398 |
| og:image:alt | This is one of the last changes I think is necessary to make assert.deepStrictEqual really great.
As a side-effect I also improved the performance for Float*Array immensely. It depends on the size ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BridgeAR |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f4bb89367ca678f057d79b1abc45d6675b1bd5b2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/15398#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15398 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15398 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/15398 |
| Reload | https://github.com/nodejs/node/pull/15398 |
| Reload | https://github.com/nodejs/node/pull/15398 |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| BridgeAR:assert-minus-zero | https://github.com/BridgeAR/node/tree/assert-minus-zero |
| Conversation | https://github.com/nodejs/node/pull/15398 |
| Commits2 (2) | https://github.com/nodejs/node/pull/15398/commits |
| Checks | https://github.com/nodejs/node/pull/15398/checks |
| Files changed | https://github.com/nodejs/node/pull/15398/files |
| assert: use Same-value equality in deepStrictEqual | https://github.com/nodejs/node/pull/15398#top |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| BridgeAR:assert-minus-zero | https://github.com/BridgeAR/node/tree/assert-minus-zero |
|
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 13, 2017 | https://github.com/nodejs/node/pull/15398#issue-257527348 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
|
| https://github.com/BridgeAR |
| assert: use Same-value equality in deepStrictEqual | https://github.com/nodejs/node/pull/15398/commits/10aaa3208407155cbee30451d09b4c6300efad7e |
| 10aaa32 | https://github.com/nodejs/node/pull/15398/commits/10aaa3208407155cbee30451d09b4c6300efad7e |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Sep 13, 2017 | https://github.com/nodejs/node/pull/15398#event-1248116317 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
| Sep 13, 2017 | https://github.com/nodejs/node/pull/15398#event-1248116396 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Trott | https://github.com/Trott |
| September 13, 2017 21:29 | https://github.com/nodejs/node/pull/15398#event-1248116473 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 13, 2017
| https://github.com/nodejs/node/pull/15398#pullrequestreview-62586639 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Sep 13, 2017
| https://github.com/nodejs/node/pull/15398#pullrequestreview-62604543 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15398#pullrequestreview-62751496 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15398#pullrequestreview-62899035 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/15398#pullrequestreview-62899035 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
| doc/api/assert.md | https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97 |
| Trott | https://github.com/Trott |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15398#discussion_r139021530 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
| BridgeAR | https://github.com/BridgeAR |
| Sep 15, 2017 | https://github.com/nodejs/node/pull/15398#discussion_r139253626 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
| lib/assert.js | https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f |
| Trott | https://github.com/Trott |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15398#discussion_r139021786 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
| jasnell | https://github.com/jasnell |
| Sep 15, 2017 | https://github.com/nodejs/node/pull/15398#discussion_r139198637 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
| BridgeAR | https://github.com/BridgeAR |
| Sep 15, 2017 | https://github.com/nodejs/node/pull/15398#discussion_r139253609 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
|
| https://github.com/BridgeAR |
| [squash] address comments | https://github.com/nodejs/node/pull/15398/commits/a6f20938d7c3275ce0c173b53414a8aa956b4abe |
| a6f2093 | https://github.com/nodejs/node/pull/15398/commits/a6f20938d7c3275ce0c173b53414a8aa956b4abe |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 15, 2017 | https://github.com/nodejs/node/pull/15398#issuecomment-329917096 |
| https://ci.nodejs.org/job/node-test-pull-request/10102/ | https://ci.nodejs.org/job/node-test-pull-request/10102/ |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 16, 2017 | https://github.com/nodejs/node/pull/15398#issuecomment-329941545 |
| b0d3bec | https://github.com/nodejs/node/commit/b0d3bec95ccbf06f54a1373c20c78699f0712e2d |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 16, 2017 | https://github.com/nodejs/node/pull/15398#event-1252042721 |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 16, 2017
| https://github.com/nodejs/node/pull/15398#ref-commit-b0d3bec |
|
| https://github.com/BridgeAR |
| assert: use Same-value equality in deepStrictEqual | https://github.com/nodejs/node/commit/b0d3bec95ccbf06f54a1373c20c78699f0712e2d |
| b0d3bec | https://github.com/nodejs/node/commit/b0d3bec95ccbf06f54a1373c20c78699f0712e2d |
| #15398 | https://github.com/nodejs/node/pull/15398 |
| addaleax | https://github.com/addaleax |
|
Sep 17, 2017
| https://github.com/nodejs/node/pull/15398#ref-commit-8da49c1 |
|
| https://github.com/BridgeAR |
|
| https://github.com/addaleax |
| assert: use Same-value equality in deepStrictEqual | https://github.com/addaleax/ayo/commit/8da49c143bfd7dc4c93d9bf80a0462655b8772c9 |
| 8da49c1 | https://github.com/addaleax/ayo/commit/8da49c143bfd7dc4c93d9bf80a0462655b8772c9 |
| nodejs/node#15398 | https://github.com/nodejs/node/pull/15398 |
| Qard | https://github.com/Qard |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/15398#ref-commit-b2fed41 |
|
| https://github.com/BridgeAR |
| assert: use Same-value equality in deepStrictEqual | https://github.com/Qard/ayo/commit/b2fed41aaf9194018d38c7e4c6a79726e59e7cf0 |
| b2fed41 | https://github.com/Qard/ayo/commit/b2fed41aaf9194018d38c7e4c6a79726e59e7cf0 |
| nodejs/node#15398 | https://github.com/nodejs/node/pull/15398 |
| decareano | https://github.com/decareano |
|
Sep 22, 2017
| https://github.com/nodejs/node/pull/15398#ref-commit-5b371f8 |
|
| https://github.com/decareano |
| formatting fix and scar deleted | https://github.com/decareano/node/commit/5b371f8a550dbefa79c4f1e164b6e1f830ad29eb |
| 5b371f8 | https://github.com/decareano/node/commit/5b371f8a550dbefa79c4f1e164b6e1f830ad29eb |
| nodejs#15163 | https://github.com/nodejs/node/pull/15163 |
| nodejs#15048 | https://github.com/nodejs/node/issues/15048 |
| nodejs#15398 | https://github.com/nodejs/node/pull/15398 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 30, 2017
| https://github.com/nodejs/node/pull/15398#ref-pullrequest-254697213 |
|
Proposal: 2017-10-31, Version 9.0.0 (Current)
#15135
| https://github.com/nodejs/node/pull/15135 |
| https://github.com/bradennapier |
| bradennapier | https://github.com/bradennapier |
|
Nov 3, 2017
| https://github.com/nodejs/node/pull/15398#ref-issue-270938179 |
|
[REQUEST]: Document Breaking Changes in 9.0
#16713
| https://github.com/nodejs/node/issues/16713 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| April 1, 2019 23:37 | https://github.com/nodejs/node/pull/15398#event-2244906498 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15398 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/15398/files/10aaa3208407155cbee30451d09b4c6300efad7e |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/15398 |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |