René's URL Explorer Experiment


Title: src: turn key length exception into CHECK by bnoordhuis · Pull Request #15183 · nodejs/node · GitHub

Open Graph Title: src: turn key length exception into CHECK by bnoordhuis · Pull Request #15183 · nodejs/node

X Title: src: turn key length exception into CHECK by bnoordhuis · Pull Request #15183 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This exception can logically never happen because of the key stretching that takes place first. Failure must therefore be a bug in Node.js and not in the executing script.

X Description: This exception can logically never happen because of the key stretching that takes place first. Failure must therefore be a bug in Node.js and not in the executing script.

Opengraph URL: https://github.com/nodejs/node/pull/15183

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca7462e8-88c0-0985-828d-df5f9d38cdbd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA128:3F5E9C:412C88:53075F:6B034865
html-safe-nonce8c0c6616f880027f08997a486ce081423d3f8909ba8afaf0728e05e281db8eb6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTI4OjNGNUU5Qzo0MTJDODg6NTMwNzVGOjZCMDM0ODY1IiwidmlzaXRvcl9pZCI6IjIxMjU5Njc5NTA5OTY1MjMxMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac88bea6304dd8c4fff69850b217055b89598e663881236af79d35de8db36a6b3b
hovercard-subject-tagpull_request:139169630
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15183/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/934fc73fb0eddcab59801b719c511a0e4241e937dea66ab7b48c444b08f6e577/nodejs/node/pull/15183
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/934fc73fb0eddcab59801b719c511a0e4241e937dea66ab7b48c444b08f6e577/nodejs/node/pull/15183
og:image:altThis exception can logically never happen because of the key stretching that takes place first. Failure must therefore be a bug in Node.js and not in the executing script.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/15183#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15183
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15183
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/15183
Reloadhttps://github.com/nodejs/node/pull/15183
Reloadhttps://github.com/nodejs/node/pull/15183
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:keylenchkhttps://github.com/bnoordhuis/io.js/tree/keylenchk
Conversationhttps://github.com/nodejs/node/pull/15183
Commits1 (1)https://github.com/nodejs/node/pull/15183/commits
Checkshttps://github.com/nodejs/node/pull/15183/checks
Files changedhttps://github.com/nodejs/node/pull/15183/files
src: turn key length exception into CHECKhttps://github.com/nodejs/node/pull/15183#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:keylenchkhttps://github.com/bnoordhuis/io.js/tree/keylenchk
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 4, 2017https://github.com/nodejs/node/pull/15183#issue-255058042
Please reload this pagehttps://github.com/nodejs/node/pull/15183
https://github.com/bnoordhuis
src: turn key length exception into CHECKhttps://github.com/nodejs/node/pull/15183/commits/294b31b8b859c67c72ee1002c47908b01c9d85bb
294b31bhttps://github.com/nodejs/node/pull/15183/commits/294b31b8b859c67c72ee1002c47908b01c9d85bb
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Sep 4, 2017https://github.com/nodejs/node/pull/15183#event-1233636169
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 4, 2017 https://github.com/nodejs/node/pull/15183#pullrequestreview-60437669
View reviewed changes https://github.com/nodejs/node/pull/15183/files/294b31b8b859c67c72ee1002c47908b01c9d85bb
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 5, 2017 https://github.com/nodejs/node/pull/15183#pullrequestreview-60677090
View reviewed changes https://github.com/nodejs/node/pull/15183/files/294b31b8b859c67c72ee1002c47908b01c9d85bb
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 7, 2017https://github.com/nodejs/node/pull/15183#issuecomment-327691439
https://ci.nodejs.org/job/node-test-pull-request/9970/https://ci.nodejs.org/job/node-test-pull-request/9970/
Please reload this pagehttps://github.com/nodejs/node/pull/15183
jasnellhttps://github.com/jasnell
Sep 7, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-964beed
https://github.com/bnoordhuis
https://github.com/jasnell
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/964beed2f2669d6192cd916c93dc0d7c5194beac
964beedhttps://github.com/nodejs/node/commit/964beed2f2669d6192cd916c93dc0d7c5194beac
#15183https://github.com/nodejs/node/pull/15183
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 7, 2017https://github.com/nodejs/node/pull/15183#issuecomment-327706313
964beedhttps://github.com/nodejs/node/commit/964beed2f2669d6192cd916c93dc0d7c5194beac
Please reload this pagehttps://github.com/nodejs/node/pull/15183
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 7, 2017https://github.com/nodejs/node/pull/15183#event-1238195140
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 10, 2017https://github.com/nodejs/node/pull/15183#issuecomment-328315552
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/15183
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Sep 10, 2017https://github.com/nodejs/node/pull/15183#event-1242047485
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 10, 2017https://github.com/nodejs/node/pull/15183#issuecomment-328336410
@MylesBorinshttps://github.com/MylesBorins
#15037https://github.com/nodejs/node/pull/15037
Please reload this pagehttps://github.com/nodejs/node/pull/15183
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Sep 10, 2017https://github.com/nodejs/node/pull/15183#event-1242215729
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 10, 2017https://github.com/nodejs/node/pull/15183#issuecomment-328345948
Please reload this pagehttps://github.com/nodejs/node/pull/15183
MylesBorinshttps://github.com/MylesBorins
Sep 10, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-8e58fed
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/8e58fed76afe3f34299ac62aaae60108b25b0089
8e58fedhttps://github.com/nodejs/node/commit/8e58fed76afe3f34299ac62aaae60108b25b0089
#15183https://github.com/nodejs/node/pull/15183
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 10, 2017 https://github.com/nodejs/node/pull/15183#ref-pullrequest-256481168
v8.5.0 proposal #15308 https://github.com/nodejs/node/pull/15308
MylesBorinshttps://github.com/MylesBorins
Sep 11, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-23df8fc
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/23df8fcc4699dd03fe9e703df31c2c8532495476
23df8fchttps://github.com/nodejs/node/commit/23df8fcc4699dd03fe9e703df31c2c8532495476
#15183https://github.com/nodejs/node/pull/15183
MylesBorinshttps://github.com/MylesBorins
Sep 11, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-59aec29
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/59aec29af4be608178eccf453664db20347a527a
59aec29https://github.com/nodejs/node/commit/59aec29af4be608178eccf453664db20347a527a
#15183https://github.com/nodejs/node/pull/15183
MylesBorinshttps://github.com/MylesBorins
Sep 12, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-f81812b
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/f81812b1ff2da76edbf2daffdfb9039f709506e4
f81812bhttps://github.com/nodejs/node/commit/f81812b1ff2da76edbf2daffdfb9039f709506e4
#15183https://github.com/nodejs/node/pull/15183
addaleaxhttps://github.com/addaleax
Sep 13, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-19a9c87
https://github.com/bnoordhuis
https://github.com/addaleax
src: turn key length exception into CHECKhttps://github.com/addaleax/node/commit/19a9c87e618a6f91b63b5008c4d0a03f6fd678d7
19a9c87https://github.com/addaleax/node/commit/19a9c87e618a6f91b63b5008c4d0a03f6fd678d7
nodejs#15183https://github.com/nodejs/node/pull/15183
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Sep 20, 2017https://github.com/nodejs/node/pull/15183#event-1258243534
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 20, 2017https://github.com/nodejs/node/pull/15183#issuecomment-330977996
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/15183
bnoordhuishttps://github.com/bnoordhuis
Oct 29, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-5b1484d
https://github.com/bnoordhuis
src: turn key length exception into CHECKhttps://github.com/bnoordhuis/io.js/commit/5b1484d299ea810e5664e8a9408afbb900c90c85
5b1484dhttps://github.com/bnoordhuis/io.js/commit/5b1484d299ea810e5664e8a9408afbb900c90c85
nodejs#15183https://github.com/nodejs/node/pull/15183
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 29, 2017 https://github.com/nodejs/node/pull/15183#ref-pullrequest-269389428
[v6.x backport] src: turn key length exception into CHECK #16585 https://github.com/nodejs/node/pull/16585
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 29, 2017https://github.com/nodejs/node/pull/15183#issuecomment-340253778
#16585https://github.com/nodejs/node/pull/16585
Please reload this pagehttps://github.com/nodejs/node/pull/15183
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
October 29, 2017 11:03https://github.com/nodejs/node/pull/15183#event-1315488515
MylesBorinshttps://github.com/MylesBorins
Nov 14, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-8b70ad1
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/8b70ad1932c4d734d2cc6fe43ceec5d40332e635
8b70ad1https://github.com/nodejs/node/commit/8b70ad1932c4d734d2cc6fe43ceec5d40332e635
#16585https://github.com/nodejs/node/pull/16585
#15183https://github.com/nodejs/node/pull/15183
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Nov 14, 2017https://github.com/nodejs/node/pull/15183#event-1341563420
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/15183#ref-pullrequest-275653593
v6.12.1 proposal #17180 https://github.com/nodejs/node/pull/17180
MylesBorinshttps://github.com/MylesBorins
Nov 21, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-a62f563
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/a62f56358822e8deeb0bdd5ffb9b804e2f4bd8c1
a62f563https://github.com/nodejs/node/commit/a62f56358822e8deeb0bdd5ffb9b804e2f4bd8c1
#16585https://github.com/nodejs/node/pull/16585
#15183https://github.com/nodejs/node/pull/15183
MylesBorinshttps://github.com/MylesBorins
Nov 28, 2017 https://github.com/nodejs/node/pull/15183#ref-commit-79171e0
https://github.com/bnoordhuis
https://github.com/MylesBorins
src: turn key length exception into CHECKhttps://github.com/nodejs/node/commit/79171e0c2f16fff17f5ab7a4899b2be0c2574c17
79171e0https://github.com/nodejs/node/commit/79171e0c2f16fff17f5ab7a4899b2be0c2574c17
#16585https://github.com/nodejs/node/pull/16585
#15183https://github.com/nodejs/node/pull/15183
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15183
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/15183/files/294b31b8b859c67c72ee1002c47908b01c9d85bb
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/15183/files/294b31b8b859c67c72ee1002c47908b01c9d85bb
Please reload this pagehttps://github.com/nodejs/node/pull/15183
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/15183
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.