René's URL Explorer Experiment


Title: tls: re-allow falsey option values by addaleax · Pull Request #15131 · nodejs/node · GitHub

Open Graph Title: tls: re-allow falsey option values by addaleax · Pull Request #15131 · nodejs/node

X Title: tls: re-allow falsey option values by addaleax · Pull Request #15131 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: 5723c4c was an unintentional breaking change in that it changed the behaviour of tls.createSecureContext() to throw on false-y input rather than ignoring it. This breaks real-world applications lik...

X Description: 5723c4c was an unintentional breaking change in that it changed the behaviour of tls.createSecureContext() to throw on false-y input rather than ignoring it. This breaks real-world applications lik...

Opengraph URL: https://github.com/nodejs/node/pull/15131

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ba6f3a7f-f18a-032e-b03f-6175ffe76b7b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0C4:1F19:1CCDC96:292DC49:6A4F6A12
html-safe-nonce5b7627b139f456cae2723f957cf27320c0464e56a42695c4401fa0e652dd59d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEM0OjFGMTk6MUNDREM5NjoyOTJEQzQ5OjZBNEY2QTEyIiwidmlzaXRvcl9pZCI6IjI2NTE5NTkyNTU1NTc0MzM4NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac49a4903cf9290600fbc7b87bce633e8ad729bedeb86253c85a34a33981f2ff9a
hovercard-subject-tagpull_request:138902049
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15131/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6118011b4b21067bfae766e6e8236fa687fdb9358bc023272451fd7a3f2ec934/nodejs/node/pull/15131
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6118011b4b21067bfae766e6e8236fa687fdb9358bc023272451fd7a3f2ec934/nodejs/node/pull/15131
og:image:alt5723c4c was an unintentional breaking change in that it changed the behaviour of tls.createSecureContext() to throw on false-y input rather than ignoring it. This breaks real-world applications lik...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/15131#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15131
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15131
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/15131
Reloadhttps://github.com/nodejs/node/pull/15131
Reloadhttps://github.com/nodejs/node/pull/15131
Please reload this pagehttps://github.com/nodejs/node/pull/15131
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/15131
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:ca-nullhttps://github.com/addaleax/node/tree/ca-null
Conversationhttps://github.com/nodejs/node/pull/15131
Commits1 (1)https://github.com/nodejs/node/pull/15131/commits
Checkshttps://github.com/nodejs/node/pull/15131/checks
Files changedhttps://github.com/nodejs/node/pull/15131/files
tls: re-allow falsey option valueshttps://github.com/nodejs/node/pull/15131#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:ca-nullhttps://github.com/addaleax/node/tree/ca-null
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 1, 2017https://github.com/nodejs/node/pull/15131#issue-254655877
5723c4chttps://github.com/nodejs/node/commit/5723c4c5f06f1382cc7962c64f31a7f96ca8a668
#15053https://github.com/nodejs/node/pull/15053
@mscdexhttps://github.com/mscdex
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/addaleax
tls: re-allow falsey option valueshttps://github.com/nodejs/node/pull/15131/commits/14227c25e607863f964a7b981376184342cb5409
14227c2https://github.com/nodejs/node/pull/15131/commits/14227c25e607863f964a7b981376184342cb5409
5723c4chttps://github.com/addaleax/node/commit/5723c4c5f06f1382cc7962c64f31a7f96ca8a668
nodejs#15053https://github.com/nodejs/node/pull/15053
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Sep 1, 2017https://github.com/nodejs/node/pull/15131#event-1231447505
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 1, 2017 https://github.com/nodejs/node/pull/15131#ref-pullrequest-253170723
tls: replace forEach with for #15053 https://github.com/nodejs/node/pull/15053
https://github.com/refack
refackhttps://github.com/refack
Sep 1, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60150165
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 1, 2017https://github.com/nodejs/node/pull/15131#issuecomment-326594755
https://ci.nodejs.org/job/node-test-pull-request/9912/https://ci.nodejs.org/job/node-test-pull-request/9912/
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 1, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60184061
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 1, 2017https://github.com/nodejs/node/pull/15131#issuecomment-326635646
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 1, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60193347
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 1, 2017https://github.com/nodejs/node/pull/15131#issuecomment-326636921
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 2, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60269512
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 2, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60276649
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Sep 3, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60286901
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/targos
targoshttps://github.com/targos
Sep 4, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60399459
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 5, 2017 https://github.com/nodejs/node/pull/15131#ref-pullrequest-255134188
Fix npm install failure #15191 https://github.com/nodejs/node/pull/15191
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60588142
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/15131#pullrequestreview-60588142
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017https://github.com/nodejs/node/pull/15131#issuecomment-327167521
https://ci.nodejs.org/job/node-test-pull-request/9947/https://ci.nodejs.org/job/node-test-pull-request/9947/
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Sep 5, 2017 https://github.com/nodejs/node/pull/15131#pullrequestreview-60595299
View reviewed changes https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Sep 5, 2017https://github.com/nodejs/node/pull/15131#issuecomment-327277979
#15053https://github.com/nodejs/node/pull/15053
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017https://github.com/nodejs/node/pull/15131#issuecomment-327295247
Please reload this pagehttps://github.com/nodejs/node/pull/15131
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017https://github.com/nodejs/node/pull/15131#issuecomment-327297652
#15208https://github.com/nodejs/node/issues/15208
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/refack
refackhttps://github.com/refack
Sep 5, 2017https://github.com/nodejs/node/pull/15131#issuecomment-327297749
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017https://github.com/nodejs/node/pull/15131#issuecomment-327298407
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017https://github.com/nodejs/node/pull/15131#issuecomment-327299210
1403d28https://github.com/nodejs/node/commit/1403d28e7ded280e7582daa6e999164588d2234e
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017https://github.com/nodejs/node/pull/15131#event-1235679022
mhdawsonhttps://github.com/mhdawson
Sep 5, 2017 https://github.com/nodejs/node/pull/15131#ref-commit-1403d28
https://github.com/addaleax
https://github.com/mhdawson
tls: re-allow falsey option valueshttps://github.com/nodejs/node/commit/1403d28e7ded280e7582daa6e999164588d2234e
1403d28https://github.com/nodejs/node/commit/1403d28e7ded280e7582daa6e999164588d2234e
5723c4chttps://github.com/nodejs/node/commit/5723c4c5f06f1382cc7962c64f31a7f96ca8a668
#15131https://github.com/nodejs/node/pull/15131
#15053https://github.com/nodejs/node/pull/15053
https://github.com/refack
refackhttps://github.com/refack
Sep 8, 2017 https://github.com/nodejs/node/pull/15131#ref-pullrequest-254911277
assert: handle enum. symbol keys in deepStrictEqual #15169 https://github.com/nodejs/node/pull/15169
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Sep 10, 2017https://github.com/nodejs/node/pull/15131#event-1242047220
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Sep 10, 2017https://github.com/nodejs/node/pull/15131#issuecomment-328315520
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
September 10, 2017 18:34https://github.com/nodejs/node/pull/15131#event-1242290787
addaleaxhttps://github.com/addaleax
Sep 13, 2017 https://github.com/nodejs/node/pull/15131#ref-commit-db352fb
https://github.com/addaleax
tls: re-allow falsey option valueshttps://github.com/addaleax/node/commit/db352fb489f87088574522b803b2fc3cab41a8da
db352fbhttps://github.com/addaleax/node/commit/db352fb489f87088574522b803b2fc3cab41a8da
5723c4chttps://github.com/addaleax/node/commit/5723c4c5f06f1382cc7962c64f31a7f96ca8a668
nodejs#15131https://github.com/nodejs/node/pull/15131
nodejs#15053https://github.com/nodejs/node/pull/15053
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/15131#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Nov 16, 2017https://github.com/nodejs/node/pull/15131#event-1346165457
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15131
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/aqrln
aqrln https://github.com/aqrln
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/15131/files/14227c25e607863f964a7b981376184342cb5409
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/15131
https://github.com/addaleax
https://github.com/jasnell
https://github.com/mscdex
https://github.com/mhdawson
https://github.com/sam-github
https://github.com/refack
https://github.com/MylesBorins
https://github.com/benjamingr
https://github.com/lpinca
https://github.com/TimothyGu
https://github.com/targos
https://github.com/aqrln
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.