René's URL Explorer Experiment


Title: lib/src: exit on gc unhandled promise by BridgeAR · Pull Request #15126 · nodejs/node · GitHub

Open Graph Title: lib/src: exit on gc unhandled promise by BridgeAR · Pull Request #15126 · nodejs/node

X Title: lib/src: exit on gc unhandled promise by BridgeAR · Pull Request #15126 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is a follow up on #12010. Is is not complete and mainly a rebase with a few minor fixes. All contributions go to @Fishrock123, @addaleax, @matthewloring and @ofrobots. I have no idea about C++...

X Description: This is a follow up on #12010. Is is not complete and mainly a rebase with a few minor fixes. All contributions go to @Fishrock123, @addaleax, @matthewloring and @ofrobots. I have no idea about C++...

Opengraph URL: https://github.com/nodejs/node/pull/15126

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:245b4db2-5e9c-ebb2-dd49-1d51bfcc271b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96F4:13DDC4:4135CB7:5ACCD02:6A4F611E
html-safe-nonce33406376c6272950f4d8cf62b73f03237cd98e5111b3ebaa2770ff7d334cdecc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkY0OjEzRERDNDo0MTM1Q0I3OjVBQ0NEMDI6NkE0RjYxMUUiLCJ2aXNpdG9yX2lkIjoiMjc1NzExNDEzODE2MTI3NTE2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4d901bda722c2b01074b3fc7825e58108843cd89ed7b15af2d96a39adacda8c2
hovercard-subject-tagpull_request:138791554
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15126/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03fa8e468618961133cd3c6103cc4e854093510c96c6b511d5d3bd46513ac1c3/nodejs/node/pull/15126
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03fa8e468618961133cd3c6103cc4e854093510c96c6b511d5d3bd46513ac1c3/nodejs/node/pull/15126
og:image:altThis is a follow up on #12010. Is is not complete and mainly a rebase with a few minor fixes. All contributions go to @Fishrock123, @addaleax, @matthewloring and @ofrobots. I have no idea about C++...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/15126#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15126
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15126
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/15126
Reloadhttps://github.com/nodejs/node/pull/15126
Reloadhttps://github.com/nodejs/node/pull/15126
Please reload this pagehttps://github.com/nodejs/node/pull/15126
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/15126
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:exit-unhandled-promisehttps://github.com/BridgeAR/node/tree/exit-unhandled-promise
Conversationhttps://github.com/nodejs/node/pull/15126
Commits6 (6)https://github.com/nodejs/node/pull/15126/commits
Checkshttps://github.com/nodejs/node/pull/15126/checks
Files changedhttps://github.com/nodejs/node/pull/15126/files
lib/src: exit on gc unhandled promisehttps://github.com/nodejs/node/pull/15126#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:exit-unhandled-promisehttps://github.com/BridgeAR/node/tree/exit-unhandled-promise
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 1, 2017https://github.com/nodejs/node/pull/15126#issue-254501431
Please reload this pagehttps://github.com/nodejs/node/pull/15126
#12010https://github.com/nodejs/node/pull/12010
@Fishrock123https://github.com/Fishrock123
@addaleaxhttps://github.com/addaleax
@matthewloringhttps://github.com/matthewloring
@ofrobotshttps://github.com/ofrobots
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Sep 1, 2017https://github.com/nodejs/node/pull/15126#event-1230551292
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Sep 1, 2017https://github.com/nodejs/node/pull/15126#event-1230553400
https://github.com/vkurchatkin
vkurchatkinhttps://github.com/vkurchatkin
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Sep 1, 2017https://github.com/nodejs/node/pull/15126#event-1230554486
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 1, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326459551
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 1, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326459751
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 1, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326462659
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 1, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326466975
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 1, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326471572
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Sep 1, 2017 https://github.com/nodejs/node/pull/15126#pullrequestreview-60047973
View reviewed changes https://github.com/nodejs/node/pull/15126/files
test/message/promise_fast_handled_reject.outhttps://github.com/nodejs/node/pull/15126/files#diff-850a7a992504e3af0f90c208ed2ace83b7f7a3d70064b5c990b4f1d5e0b680c5
TimothyGuhttps://github.com/TimothyGu
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136500265
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Sep 1, 2017 https://github.com/nodejs/node/pull/15126#pullrequestreview-60062382
View reviewed changes https://github.com/nodejs/node/pull/15126/files
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/15126/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
silverwindhttps://github.com/silverwind
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136513360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
targoshttps://github.com/targos
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136527940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 1, 2017 https://github.com/nodejs/node/pull/15126#pullrequestreview-60098665
View reviewed changes https://github.com/nodejs/node/pull/15126/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/15126#pullrequestreview-60098665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/parallel/test-promises-handled-reject.jshttps://github.com/nodejs/node/pull/15126/files#diff-994ec3a3dd7b6ab432b012598a9879cc615cbfa0b1d0b5683c70f507311ba6c7
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136544695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 21, 2017https://github.com/nodejs/node/pull/15126#discussion_r140264165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/parallel/test-promises-gc-before-handled.jshttps://github.com/nodejs/node/pull/15126/files#diff-4faae413fd8d64b3764f656e02c6b20cb30dc028996253d773430f2bfee03d26
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136544750
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/parallel/test-promises-gc-before-handled.jshttps://github.com/nodejs/node/pull/15126/files#diff-4faae413fd8d64b3764f656e02c6b20cb30dc028996253d773430f2bfee03d26
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136544882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
addaleaxhttps://github.com/addaleax
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136554143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136555192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 21, 2017https://github.com/nodejs/node/pull/15126#discussion_r140264811
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/message/promise_reject.jshttps://github.com/nodejs/node/pull/15126/files#diff-fb7be8430d0ecc61ce61a48a1cdfc7e7b78a24418d081424968cbf8f738b0137
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136545173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 21, 2017https://github.com/nodejs/node/pull/15126#discussion_r140264933
Please reload this pagehttps://github.com/nodejs/node/pull/15126
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
Fishrock123https://github.com/Fishrock123
Oct 7, 2017https://github.com/nodejs/node/pull/15126#discussion_r143341236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/message/promise_fast_reject.jshttps://github.com/nodejs/node/pull/15126/files#diff-6720be9386837ada3b485b5a5d96e099339e6a0c3dcb8c12eab7b5f20405fab8
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136545220
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/message/promise_fast_handled_reject.jshttps://github.com/nodejs/node/pull/15126/files#diff-a50db73345cea8a3df7cfa85237addef4cc8db1b5f61dd87be7c83c51b1b56e8
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136545576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 21, 2017https://github.com/nodejs/node/pull/15126#discussion_r140270530
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/message/promise_fast_handled_reject.jshttps://github.com/nodejs/node/pull/15126/files#diff-a50db73345cea8a3df7cfa85237addef4cc8db1b5f61dd87be7c83c51b1b56e8
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136545616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 21, 2017https://github.com/nodejs/node/pull/15126#discussion_r140270307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
test/addons-napi/test_promise/test.jshttps://github.com/nodejs/node/pull/15126/files#diff-2b4ebc0188ad082a459c6ee75cb6e78d8e67419413b001bfc8ec11fb2a94e1cb
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136545711
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 21, 2017https://github.com/nodejs/node/pull/15126#discussion_r140271148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/15126
lib/internal/process/promises.jshttps://github.com/nodejs/node/pull/15126/files#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136546452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136546651
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
Jessidhiahttps://github.com/Jessidhia
Sep 20, 2017https://github.com/nodejs/node/pull/15126#discussion_r139857291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 26, 2017https://github.com/nodejs/node/pull/15126#discussion_r140957217
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
lib/internal/process/promises.jshttps://github.com/nodejs/node/pull/15126/files#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#discussion_r136546729
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
BridgeARhttps://github.com/BridgeAR
Sep 26, 2017https://github.com/nodejs/node/pull/15126#discussion_r140957224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 1, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326549408
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 4, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326943007
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 4, 2017https://github.com/nodejs/node/pull/15126#issuecomment-326945184
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Sep 5, 2017https://github.com/nodejs/node/pull/15126#event-1234677413
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 12, 2017 https://github.com/nodejs/node/pull/15126#ref-pullrequest-225208618
lib,src: eagerly exit process on unhanded promise rejections #12734 https://github.com/nodejs/node/pull/12734
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 20, 2017 https://github.com/nodejs/node/pull/15126#ref-pullrequest-216578404
lib,src: exit process on unhandled promise rejection cleanup #12010 https://github.com/nodejs/node/pull/12010
Fishrock123https://github.com/Fishrock123
September 26, 2017 01:54https://github.com/nodejs/node/pull/15126#commits-pushed-711d699
https://github.com/Fishrock123
https://github.com/BridgeAR
lib,src: throw on unhanded promise rejectionshttps://github.com/nodejs/node/pull/15126/commits/711d699d249c9d44859a45dc6ce54844dc8ed386
711d699https://github.com/nodejs/node/pull/15126/commits/711d699d249c9d44859a45dc6ce54844dc8ed386
nodejs#5292https://github.com/nodejs/node/pull/5292
nodejs/promises#26https://github.com/nodejs/promises/issues/26
nodejs#6355https://github.com/nodejs/node/pull/6355
nodejs#6375https://github.com/nodejs/node/pull/6375
https://github.com/BridgeAR
lib: follow up to exit earlyhttps://github.com/nodejs/node/pull/15126/commits/af11384393897286a30190d6621bb21718a115d0
af11384https://github.com/nodejs/node/pull/15126/commits/af11384393897286a30190d6621bb21718a115d0
https://github.com/BridgeAR
[squash] fix linter errorshttps://github.com/nodejs/node/pull/15126/commits/19c7eb364a3b9669a1d9e6535b30344bb8038511
19c7eb3https://github.com/nodejs/node/pull/15126/commits/19c7eb364a3b9669a1d9e6535b30344bb8038511
https://github.com/BridgeAR
[squash] fix a test and remove unnecessary fnhttps://github.com/nodejs/node/pull/15126/commits/69bfdd6131b90e8db099bd04368203400632e82b
69bfdd6https://github.com/nodejs/node/pull/15126/commits/69bfdd6131b90e8db099bd04368203400632e82b
https://github.com/BridgeAR
[squash] address commentshttps://github.com/nodejs/node/pull/15126/commits/5d2c83e916b0f550de4cab04f09636f4cf442707
5d2c83ehttps://github.com/nodejs/node/pull/15126/commits/5d2c83e916b0f550de4cab04f09636f4cf442707
https://github.com/BridgeAR
[squash] fix testhttps://github.com/nodejs/node/pull/15126/commits/8fd484e1779dbb376e543a5fd43d7221d625870e
8fd484ehttps://github.com/nodejs/node/pull/15126/commits/8fd484e1779dbb376e543a5fd43d7221d625870e
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/0452cded63c8bfc94ef0bf79e78137521d669ec3..8fd484e1779dbb376e543a5fd43d7221d625870e
0452cdehttps://github.com/nodejs/node/commit/0452cded63c8bfc94ef0bf79e78137521d669ec3
8fd484ehttps://github.com/nodejs/node/commit/8fd484e1779dbb376e543a5fd43d7221d625870e
Compare https://github.com/nodejs/node/compare/0452cded63c8bfc94ef0bf79e78137521d669ec3..8fd484e1779dbb376e543a5fd43d7221d625870e
September 26, 2017 05:19https://github.com/nodejs/node/pull/15126#event-1264995854
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 26, 2017https://github.com/nodejs/node/pull/15126#issuecomment-332089116
Please reload this pagehttps://github.com/nodejs/node/pull/15126
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Oct 1, 2017https://github.com/nodejs/node/pull/15126#issuecomment-333416179
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 2, 2017https://github.com/nodejs/node/pull/15126#issuecomment-333629886
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 7, 2017 https://github.com/nodejs/node/pull/15126#pullrequestreview-67843493
View reviewed changes https://github.com/nodejs/node/pull/15126/files/8fd484e1779dbb376e543a5fd43d7221d625870e
Fishrock123https://github.com/Fishrock123
https://github.com/nodejs/node/pull/15126#pullrequestreview-67843493
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
src/node.cchttps://github.com/nodejs/node/pull/15126/files/8fd484e1779dbb376e543a5fd43d7221d625870e#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
Fishrock123https://github.com/Fishrock123
Oct 7, 2017https://github.com/nodejs/node/pull/15126#discussion_r143341189
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 7, 2017 https://github.com/nodejs/node/pull/15126#pullrequestreview-67843584
View reviewed changes https://github.com/nodejs/node/pull/15126/files/8fd484e1779dbb376e543a5fd43d7221d625870e
src/node.cchttps://github.com/nodejs/node/pull/15126/files/8fd484e1779dbb376e543a5fd43d7221d625870e#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
Fishrock123https://github.com/Fishrock123
Oct 7, 2017https://github.com/nodejs/node/pull/15126#discussion_r143341268
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 9, 2017https://github.com/nodejs/node/pull/15126#issuecomment-335079309
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Oct 24, 2017https://github.com/nodejs/node/pull/15126#issuecomment-338936476
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
b7405abhttps://github.com/nodejs/node/commit/b7405ab011606373ae7bf28e4bf0b4c912fc2117
7f086ddhttps://github.com/nodejs/node/commit/7f086dd6016d9f85b1bc01680addfa53fadd2728
Compare https://github.com/nodejs/node/compare/b7405ab011606373ae7bf28e4bf0b4c912fc2117..7f086dd6016d9f85b1bc01680addfa53fadd2728
December 8, 2017 16:37https://github.com/nodejs/node/pull/15126#event-1379145033
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
Dec 15, 2017https://github.com/nodejs/node/pull/15126#event-1390345847
https://github.com/billinghamj
billinghamjhttps://github.com/billinghamj
Jan 11, 2018https://github.com/nodejs/node/pull/15126#issuecomment-356796569
Please reload this pagehttps://github.com/nodejs/node/pull/15126
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jan 11, 2018 https://github.com/nodejs/node/pull/15126#ref-issue-287928643
premature doEmitWarning Unhandled promise rejection #18108 https://github.com/nodejs/node/issues/18108
https://github.com/maclover7
maclover7https://github.com/maclover7
force-pushedhttps://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c
bb5575ahttps://github.com/nodejs/node/commit/bb5575aa75fd3071724d5eccde39a3041e1af57a
993b716https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c
Compare https://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c
January 26, 2018 22:02https://github.com/nodejs/node/pull/15126#event-1444448057
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab
993b716https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c
082f952https://github.com/nodejs/node/commit/082f9525d92532867bc7172acebdf9b89a715dab
Compare https://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab
January 26, 2018 22:36https://github.com/nodejs/node/pull/15126#event-1444492977
https://github.com/targos
targoshttps://github.com/targos
Feb 3, 2018https://github.com/nodejs/node/pull/15126#issuecomment-362832449
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 3, 2018https://github.com/nodejs/node/pull/15126#issuecomment-362832682
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 2, 2018 https://github.com/nodejs/node/pull/15126#ref-pullrequest-286571155
assert: adds rejects() and doesNotReject() #18023 https://github.com/nodejs/node/pull/18023
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 12, 2018https://github.com/nodejs/node/pull/15126#issuecomment-380904130
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 17, 2018https://github.com/nodejs/node/pull/15126#issuecomment-381977362
#20097https://github.com/nodejs/node/pull/20097
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 17, 2018https://github.com/nodejs/node/pull/15126#event-1578715026
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
April 1, 2019 23:37https://github.com/nodejs/node/pull/15126#event-2244906804
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Sep 15, 2020 https://github.com/nodejs/node/pull/15126#ref-issue-689632204
Voting on the default behavior for Promise unhandled rejections nodejs/TSC#916 https://github.com/nodejs/TSC/issues/916
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15126
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/15126/files/0452cded63c8bfc94ef0bf79e78137521d669ec3
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/15126/files/0452cded63c8bfc94ef0bf79e78137521d669ec3
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/15126/files/0452cded63c8bfc94ef0bf79e78137521d669ec3
https://github.com/Jessidhia
Jessidhia https://github.com/Jessidhia
https://github.com/nodejs/node/pull/15126/files/0452cded63c8bfc94ef0bf79e78137521d669ec3
https://github.com/silverwind
silverwind https://github.com/silverwind
https://github.com/nodejs/node/pull/15126/files/0452cded63c8bfc94ef0bf79e78137521d669ec3
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/15126/files/8fd484e1779dbb376e543a5fd43d7221d625870e
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/15126/files/0452cded63c8bfc94ef0bf79e78137521d669ec3
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/15126
https://github.com/BridgeAR
https://github.com/addaleax
https://github.com/jasnell
https://github.com/benjamingr
https://github.com/bnoordhuis
https://github.com/mhdawson
https://github.com/mcollina
https://github.com/billinghamj
https://github.com/targos
https://github.com/Jessidhia
https://github.com/silverwind
https://github.com/Fishrock123
https://github.com/TimothyGu
https://github.com/vkurchatkin
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.