| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:609b873b-824b-e4da-4993-9a94171d2725 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83A6:2110F2:49B9E:62C4C:6A517E64 |
| html-safe-nonce | b2148eefe9e348d4e38325385c8794c779baf2f9e3efa1d4537112c0d9834154 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0E2OjIxMTBGMjo0OUI5RTo2MkM0Qzo2QTUxN0U2NCIsInZpc2l0b3JfaWQiOiI2NDE4NTEwMDI5Mjc2Njc1Njg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5d7ae57589eb0039f91213fdbae18ebb6c11548a4e6f52c3a684d36aa31dfcba |
| hovercard-subject-tag | pull_request:138383775 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15088/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e95be2b8f48307096d745fc387439f2d61caa64ce284cbeb5cecfbe46c1d25df/nodejs/node/pull/15088 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e95be2b8f48307096d745fc387439f2d61caa64ce284cbeb5cecfbe46c1d25df/nodejs/node/pull/15088 |
| og:image:alt | As per discussion in abi-stable-node:
nodejs/abi-stable-node#256,
take a refactor to napi_addon_register_func such that
the result from the register function is assigned to
the module exports prope... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | boingoing |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d01c62704ef24df49056c63892a149b775e1353d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/15088#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15088 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15088 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/15088 |
| Reload | https://github.com/nodejs/node/pull/15088 |
| Reload | https://github.com/nodejs/node/pull/15088 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
981
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| boingoing | https://github.com/boingoing |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| boingoing:refactor_napi_addon_register_func | https://github.com/boingoing/node/tree/refactor_napi_addon_register_func |
| Conversation | https://github.com/nodejs/node/pull/15088 |
| Commits1 (1) | https://github.com/nodejs/node/pull/15088/commits |
| Checks | https://github.com/nodejs/node/pull/15088/checks |
| Files changed | https://github.com/nodejs/node/pull/15088/files |
| n-api: refactor napi_addon_register_func | https://github.com/nodejs/node/pull/15088#top |
| boingoing | https://github.com/boingoing |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| boingoing:refactor_napi_addon_register_func | https://github.com/boingoing/node/tree/refactor_napi_addon_register_func |
|
| https://github.com/boingoing |
| boingoing | https://github.com/boingoing |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#issue-253943116 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#event-1227287700 |
| https://github.com/boingoing |
| boingoing | https://github.com/boingoing |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#ref-issue-235940580 |
|
ES6 module loader compatibility
nodejs/abi-stable-node#256
| https://github.com/nodejs/abi-stable-node/issues/256 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59514304 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/5_function_factory/binding.c | https://github.com/nodejs/node/pull/15088/files#diff-7dd1c3fb1d4b7201a4bcfb0b3ce34bce0c862b78e9644e377974049985e09165 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136032548 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| boingoing | https://github.com/boingoing |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136129704 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515108 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515108 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#event-1227352447 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515525 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/4_object_factory/binding.c | https://github.com/nodejs/node/pull/15088/files#diff-1104cf2c1f716944f5c4ebb7fc415dccb3c6a6d332e2ae1e5a7e9fad3c692b5d |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515605 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/7_factory_wrap/binding.cc | https://github.com/nodejs/node/pull/15088/files#diff-c46cd139331f86d76d858b3080cbaa3d09ac7c3f15573be3124249dea36e9e11 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033689 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515664 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/8_passing_wrapped/binding.cc | https://github.com/nodejs/node/pull/15088/files#diff-3527b64ab0da1008926b8de5a1cd5a01c6f58eca70b06f50cca937b9337f4fb1 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033740 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515721 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/test_array/test_array.c | https://github.com/nodejs/node/pull/15088/files#diff-4fdcbfa71e830117de30c52775969fe7c0e603f0c350d3d63b0177468f5f6fdc |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033783 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515763 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/test_async/test_async.cc | https://github.com/nodejs/node/pull/15088/files#diff-2889c59b9919da710138b856572d63a6599e15e5ed33aec727a45bd4a859560d |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033814 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515806 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/test_buffer/test_buffer.c | https://github.com/nodejs/node/pull/15088/files#diff-6ca8a4699ad7c986f6ff0d9723aeae1b3f7f12df7a00a79a817ba542ea178a7b |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033857 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515845 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| test/addons-napi/test_constructor/test_constructor.c | https://github.com/nodejs/node/pull/15088/files#diff-c4f246e0c46bdf66805d32e725c7202f714df4e02be0c4cfd88bd6e6f0871411 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033899 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515904 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59515904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| JerryScript module initializer | https://github.com/jerryscript-project/jerryscript/blob/master/docs/12.EXT-REFERENCE-MODULE.md#jerryx_native_module_on_resolve_t |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_conversions/test_conversions.c | https://github.com/nodejs/node/pull/15088/files#diff-ea923e1990641da9d60770ca904aecf51259a881ba6e9bd7bb33dc5e0fffb1a5 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136033950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_error/test_error.cc | https://github.com/nodejs/node/pull/15088/files#diff-d8f0bc41fc513ada4cdce3ae713ad8da7031b12c75b0e434ac5d41e049e91b0c |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034032 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_exception/test_exception.c | https://github.com/nodejs/node/pull/15088/files#diff-c7c5ee78dec8eff5edf5c62e004af4e7cc7d347b7ebe2bee998bb21bbe9cfd74 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034059 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_general/test_general.c | https://github.com/nodejs/node/pull/15088/files#diff-50caefd180cbd3f5ceea114a2ac4a6b87222e1af246af80655f6a789e7248384 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034102 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_handle_scope/test_handle_scope.c | https://github.com/nodejs/node/pull/15088/files#diff-713437a2141d55d6309340426517f26082b2bc96ef7afdf3e3550c6fe535e4b3 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034126 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_properties/test_properties.c | https://github.com/nodejs/node/pull/15088/files#diff-56779bafc7369b8de67be99c4a39ede57b695077c2f57929656e04bf49a3c486 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034261 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_reference/test_reference.c | https://github.com/nodejs/node/pull/15088/files#diff-946d641b980a90684b1113b68bf2d7ff0ab1d2437d2a2e5a77e1f32946854d91 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034285 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_string/test_string.c | https://github.com/nodejs/node/pull/15088/files#diff-6eeaa9aca1f5d43b76acb7764aa899ef9e5cb205b904b72ac0a985db5a91c34d |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034305 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_symbol/test_symbol.c | https://github.com/nodejs/node/pull/15088/files#diff-a53df531fa197bdd049d07ff1f2aee85c459c49b0c5b6e9aed0c08351b6195ab |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034324 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| test/addons-napi/test_typedarray/test_typedarray.c | https://github.com/nodejs/node/pull/15088/files#diff-c357dba3946d1c1b13e0ff597c9f28a9211cd794cbe0857b9c68a5566a6f0097 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136034341 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/RReverser |
| RReverser | https://github.com/RReverser |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-325967283 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59587985 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| src/node_api.cc | https://github.com/nodejs/node/pull/15088/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| mhdawson | https://github.com/mhdawson |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136096604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @kkoopa | https://github.com/kkoopa |
| @rvagg | https://github.com/rvagg |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| kkoopa | https://github.com/kkoopa |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136099966 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| RReverser | https://github.com/RReverser |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136101355 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136107692 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 1550858 | https://github.com/nodejs/node/commit/15508589a163b0c9f09ac608281f9ebb015d4deb |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136108132 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| mhdawson | https://github.com/mhdawson |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136208214 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| digitalinfinity | https://github.com/digitalinfinity |
| Aug 31, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136236038 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| RReverser | https://github.com/RReverser |
| Aug 31, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136401056 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @digitalinfinity | https://github.com/digitalinfinity |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| digitalinfinity | https://github.com/digitalinfinity |
| Aug 31, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136448482 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @RReverser | https://github.com/RReverser |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-326020941 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-251080587 |
|
n-api: remove n-api module loading flag
#14902
| https://github.com/nodejs/node/pull/14902 |
| https://github.com/boingoing |
| boingoing | https://github.com/boingoing |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-326054725 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/boingoing |
| boingoing | https://github.com/boingoing |
| force-pushed | https://github.com/nodejs/node/compare/ea5c16df569e180909b2c52ee8215accded29b25..4fd35785662b70591152feef0f65a6819a0bc789 |
| ea5c16d | https://github.com/nodejs/node/commit/ea5c16df569e180909b2c52ee8215accded29b25 |
| 4fd3578 | https://github.com/nodejs/node/commit/4fd35785662b70591152feef0f65a6819a0bc789 |
|
Compare
| https://github.com/nodejs/node/compare/ea5c16df569e180909b2c52ee8215accded29b25..4fd35785662b70591152feef0f65a6819a0bc789 |
| August 30, 2017 23:36 | https://github.com/nodejs/node/pull/15088#event-1228606471 |
| https://github.com/boingoing |
| boingoing | https://github.com/boingoing |
| Aug 31, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-326162101 |
| @mhdawson | https://github.com/mhdawson |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
|
Aug 31, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-59744976 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/15088/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| digitalinfinity | https://github.com/digitalinfinity |
| Aug 31, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136235815 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| boingoing | https://github.com/boingoing |
| Aug 31, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136238725 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| src/node_api.cc | https://github.com/nodejs/node/pull/15088/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| digitalinfinity | https://github.com/digitalinfinity |
| Aug 31, 2017 | https://github.com/nodejs/node/pull/15088#discussion_r136236038 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 1, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-326692477 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 5, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-327289226 |
| @boingoing | https://github.com/boingoing |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 5, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-327293413 |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 6, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-327624118 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 7, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-327878026 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
|
| https://github.com/boingoing |
| n-api: refactor napi_addon_register_func | https://github.com/nodejs/node/pull/15088/commits/746af62dba8d6e672e04f3a3584ab8ba090bbdc4 |
| 746af62 | https://github.com/nodejs/node/pull/15088/commits/746af62dba8d6e672e04f3a3584ab8ba090bbdc4 |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| https://github.com/boingoing |
| boingoing | https://github.com/boingoing |
| force-pushed | https://github.com/nodejs/node/compare/fb68fc75b596a224bb2ce40a7a3c538e07907b0b..746af62dba8d6e672e04f3a3584ab8ba090bbdc4 |
| fb68fc7 | https://github.com/nodejs/node/commit/fb68fc75b596a224bb2ce40a7a3c538e07907b0b |
| 746af62 | https://github.com/nodejs/node/commit/746af62dba8d6e672e04f3a3584ab8ba090bbdc4 |
|
Compare
| https://github.com/nodejs/node/compare/fb68fc75b596a224bb2ce40a7a3c538e07907b0b..746af62dba8d6e672e04f3a3584ab8ba090bbdc4 |
| September 14, 2017 09:38 | https://github.com/nodejs/node/pull/15088#event-1248852536 |
| https://github.com/boingoing |
| boingoing | https://github.com/boingoing |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-329431223 |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15088#pullrequestreview-62853702 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/15088/files/746af62dba8d6e672e04f3a3584ab8ba090bbdc4 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/15088#pullrequestreview-62853702 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15088#issuecomment-329578722 |
| 92e5f5c | https://github.com/nodejs/node/commit/92e5f5cc09fdbf223a418aef1154b2b75b3f9dcd |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/15088#event-1249835376 |
| mhdawson | https://github.com/mhdawson |
|
Sep 14, 2017
| https://github.com/nodejs/node/pull/15088#ref-commit-92e5f5c |
|
| https://github.com/boingoing |
|
| https://github.com/mhdawson |
| n-api: refactor napi_addon_register_func | https://github.com/nodejs/node/commit/92e5f5cc09fdbf223a418aef1154b2b75b3f9dcd |
| 92e5f5c | https://github.com/nodejs/node/commit/92e5f5cc09fdbf223a418aef1154b2b75b3f9dcd |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| #15088 | https://github.com/nodejs/node/pull/15088 |
| addaleax | https://github.com/addaleax |
|
Sep 17, 2017
| https://github.com/nodejs/node/pull/15088#ref-commit-888e767 |
|
| https://github.com/boingoing |
|
| https://github.com/addaleax |
| n-api: refactor napi_addon_register_func | https://github.com/addaleax/ayo/commit/888e7679f92013251c36ab5d6c6ccd46a134ddb0 |
| 888e767 | https://github.com/addaleax/ayo/commit/888e7679f92013251c36ab5d6c6ccd46a134ddb0 |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| nodejs/node#15088 | https://github.com/nodejs/node/pull/15088 |
| jasnell | https://github.com/jasnell |
|
Sep 20, 2017
| https://github.com/nodejs/node/pull/15088#ref-commit-8f12b9d |
|
| https://github.com/boingoing |
|
| https://github.com/jasnell |
| n-api: refactor napi_addon_register_func | https://github.com/nodejs/node/commit/8f12b9dce45251408e117f75731ac67b733e0d59 |
| 8f12b9d | https://github.com/nodejs/node/commit/8f12b9dce45251408e117f75731ac67b733e0d59 |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| #15088 | https://github.com/nodejs/node/pull/15088 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 20, 2017
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-259314305 |
|
Node.js 8.6.0 Release Proposal
#15509
| https://github.com/nodejs/node/pull/15509 |
| Qard | https://github.com/Qard |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/15088#ref-commit-cfd1b74 |
|
| https://github.com/boingoing |
| n-api: refactor napi_addon_register_func | https://github.com/Qard/ayo/commit/cfd1b7401f52d2a55ac912e65901a2277c39915b |
| cfd1b74 | https://github.com/Qard/ayo/commit/cfd1b7401f52d2a55ac912e65901a2277c39915b |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| nodejs/node#15088 | https://github.com/nodejs/node/pull/15088 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/15088#event-1296105600 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/15088#ref-commit-ab1870a |
|
| https://github.com/boingoing |
| n-api: refactor napi_addon_register_func | https://github.com/gabrielschulhof/node/commit/ab1870a4f503f197af2b303a1dd7fe0101f42020 |
| ab1870a | https://github.com/gabrielschulhof/node/commit/ab1870a4f503f197af2b303a1dd7fe0101f42020 |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| nodejs#15088 | https://github.com/nodejs/node/pull/15088 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/15088#ref-commit-50cb48b |
|
| https://github.com/boingoing |
|
| https://github.com/MylesBorins |
| n-api: refactor napi_addon_register_func | https://github.com/nodejs/node/commit/50cb48b55c36db4dea5fc90564757e795b9e68e3 |
| 50cb48b | https://github.com/nodejs/node/commit/50cb48b55c36db4dea5fc90564757e795b9e68e3 |
| nodejs/abi-stable-node#256 | https://github.com/nodejs/abi-stable-node/issues/256 |
| #19447 | https://github.com/nodejs/node/pull/19447 |
| #15088 | https://github.com/nodejs/node/pull/15088 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-313968187 |
|
v6.14.2 proposal
#19996
| https://github.com/nodejs/node/pull/19996 |
| https://github.com/adamlaska |
| adamlaska | https://github.com/adamlaska |
|
May 13, 2022
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-1235695566 |
|
[Snyk] Fix for 1 vulnerabilities
adamlaska/node#67
| https://github.com/adamlaska/node/pull/67 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Apr 27, 2023
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-1685924609 |
|
[Snyk] Fix for 20 vulnerabilities
aliscco/alisco-node#253
| https://github.com/aliscco/alisco-node/pull/253 |
|
[Snyk] Fix for 16 vulnerabilities
aliscco/alisco-node#304
| https://github.com/aliscco/alisco-node/pull/304 |
|
[Snyk] Fix for 18 vulnerabilities
aliscco/alisco-node#310
| https://github.com/aliscco/alisco-node/pull/310 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Apr 28, 2023
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-1687855700 |
|
[Snyk] Fix for 20 vulnerabilities
aliscco/alisco-node#314
| https://github.com/aliscco/alisco-node/pull/314 |
|
[Snyk] Fix for 9 vulnerabilities
aliscco/alisco-node#330
| https://github.com/aliscco/alisco-node/pull/330 |
|
[Snyk] Fix for 19 vulnerabilities
aliscco/alisco-node#334
| https://github.com/aliscco/alisco-node/pull/334 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Apr 28, 2023
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-1689046654 |
|
[Snyk] Fix for 114 vulnerabilities
aliscco/alisco-node#338
| https://github.com/aliscco/alisco-node/pull/338 |
| https://github.com/aliscco |
| aliscco | https://github.com/aliscco |
|
Apr 28, 2023
| https://github.com/nodejs/node/pull/15088#ref-pullrequest-1689126461 |
|
[Snyk] Fix for 8 vulnerabilities
aliscco/alisco-node#342
| https://github.com/aliscco/alisco-node/pull/342 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15088 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/15088/files/ea5c16df569e180909b2c52ee8215accded29b25 |
|
| https://github.com/digitalinfinity |
|
digitalinfinity
| https://github.com/digitalinfinity |
|
| https://github.com/nodejs/node/pull/15088/files/ea5c16df569e180909b2c52ee8215accded29b25 |
|
| https://github.com/RReverser |
|
RReverser
| https://github.com/RReverser |
|
| https://github.com/nodejs/node/pull/15088/files/ea5c16df569e180909b2c52ee8215accded29b25 |
|
| https://github.com/kkoopa |
|
kkoopa
| https://github.com/kkoopa |
|
| https://github.com/nodejs/node/pull/15088/files/ea5c16df569e180909b2c52ee8215accded29b25 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/15088/files/746af62dba8d6e672e04f3a3584ab8ba090bbdc4 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/15088 |
|
| https://github.com/boingoing |
|
| https://github.com/RReverser |
|
| https://github.com/mhdawson |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/digitalinfinity |
|
| https://github.com/kkoopa |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |