René's URL Explorer Experiment


Title: assert: fix boxed primitives in deep*Equal by BridgeAR · Pull Request #15050 · nodejs/node · GitHub

Open Graph Title: assert: fix boxed primitives in deep*Equal by BridgeAR · Pull Request #15050 · nodejs/node

X Title: assert: fix boxed primitives in deep*Equal by BridgeAR · Pull Request #15050 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Unbox all primitives and compare them as well instead of only comparing boxed strings. This is blocked by #15036 because there is a test case from N-API that currently only passes because deepStric...

X Description: Unbox all primitives and compare them as well instead of only comparing boxed strings. This is blocked by #15036 because there is a test case from N-API that currently only passes because deepStric...

Opengraph URL: https://github.com/nodejs/node/pull/15050

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4e999233-f4b7-59f0-c599-81da63825df2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE572:35A293:12A009:1A9369:6A4E63C3
html-safe-nonce6175af7c79d2e3f780196581fc123d2aaf8dfa5254810f5e5ff108e5775013aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTcyOjM1QTI5MzoxMkEwMDk6MUE5MzY5OjZBNEU2M0MzIiwidmlzaXRvcl9pZCI6IjY4Mjc3OTkyNzI3NTYyNDEzNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac028fef477ee4b1876f68b1829bac1c0bf98c598317115051d68a3a79bd958925
hovercard-subject-tagpull_request:137820102
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15050/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fe8b00bf2df8b00b7d091008663f913cee92ba76f39148314ffd1d7288085e2a/nodejs/node/pull/15050
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fe8b00bf2df8b00b7d091008663f913cee92ba76f39148314ffd1d7288085e2a/nodejs/node/pull/15050
og:image:altUnbox all primitives and compare them as well instead of only comparing boxed strings. This is blocked by #15036 because there is a test case from N-API that currently only passes because deepStric...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/15050#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15050
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15050
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/15050
Reloadhttps://github.com/nodejs/node/pull/15050
Reloadhttps://github.com/nodejs/node/pull/15050
Please reload this pagehttps://github.com/nodejs/node/pull/15050
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/15050
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:assert-boxedhttps://github.com/BridgeAR/node/tree/assert-boxed
Conversationhttps://github.com/nodejs/node/pull/15050
Commits2 (2)https://github.com/nodejs/node/pull/15050/commits
Checkshttps://github.com/nodejs/node/pull/15050/checks
Files changedhttps://github.com/nodejs/node/pull/15050/files
assert: fix boxed primitives in deep*Equalhttps://github.com/nodejs/node/pull/15050#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:assert-boxedhttps://github.com/BridgeAR/node/tree/assert-boxed
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017https://github.com/nodejs/node/pull/15050#issue-253138753
Please reload this pagehttps://github.com/nodejs/node/pull/15050
#15036https://github.com/nodejs/node/pull/15036
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Aug 27, 2017https://github.com/nodejs/node/pull/15050#event-1222682900
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Aug 27, 2017https://github.com/nodejs/node/pull/15050#event-1222682913
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017 https://github.com/nodejs/node/pull/15050#ref-pullrequest-253031920
assert: use same value equal for deepStrictEqual NaN #15036 https://github.com/nodejs/node/pull/15036
https://github.com/kunalspathak
kunalspathakhttps://github.com/kunalspathak
Aug 28, 2017 https://github.com/nodejs/node/pull/15050#pullrequestreview-59074963
View reviewed changes https://github.com/nodejs/node/pull/15050/files
lib/assert.jshttps://github.com/nodejs/node/pull/15050/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
kunalspathakhttps://github.com/kunalspathak
Aug 28, 2017https://github.com/nodejs/node/pull/15050#discussion_r135640649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/73f7077cdc9ea5b74a973e41153720ed692086a7..b2887a7a98f969363a820bc49313da912c7a0c6c
73f7077https://github.com/nodejs/node/commit/73f7077cdc9ea5b74a973e41153720ed692086a7
b2887a7https://github.com/nodejs/node/commit/b2887a7a98f969363a820bc49313da912c7a0c6c
Compare https://github.com/nodejs/node/compare/73f7077cdc9ea5b74a973e41153720ed692086a7..b2887a7a98f969363a820bc49313da912c7a0c6c
August 29, 2017 05:51https://github.com/nodejs/node/pull/15050#event-1224968723
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 29, 2017https://github.com/nodejs/node/pull/15050#issuecomment-325562328
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Aug 29, 2017https://github.com/nodejs/node/pull/15050#event-1224969795
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2017https://github.com/nodejs/node/pull/15050#issuecomment-325730720
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 29, 2017 https://github.com/nodejs/node/pull/15050#pullrequestreview-59313741
View reviewed changes https://github.com/nodejs/node/pull/15050/files
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/15050#pullrequestreview-59313741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 30, 2017https://github.com/nodejs/node/pull/15050#issuecomment-325973656
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/961/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/961/
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/b2887a7a98f969363a820bc49313da912c7a0c6c..fd96e2669ed43fc958276a286976094770091bbb
b2887a7https://github.com/nodejs/node/commit/b2887a7a98f969363a820bc49313da912c7a0c6c
fd96e26https://github.com/nodejs/node/commit/fd96e2669ed43fc958276a286976094770091bbb
Compare https://github.com/nodejs/node/compare/b2887a7a98f969363a820bc49313da912c7a0c6c..fd96e2669ed43fc958276a286976094770091bbb
September 1, 2017 05:47https://github.com/nodejs/node/pull/15050#event-1230783991
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 1, 2017https://github.com/nodejs/node/pull/15050#issuecomment-326494595
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 2, 2017https://github.com/nodejs/node/pull/15050#issuecomment-326725955
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 2, 2017 https://github.com/nodejs/node/pull/15050#pullrequestreview-60270134
View reviewed changes https://github.com/nodejs/node/pull/15050/files
test/addons-napi/test_conversions/test.jshttps://github.com/nodejs/node/pull/15050/files#diff-e543e4bfca7d666b0c8d25626b9ea621e6524708292e8226b09387b682e3339c
mcollinahttps://github.com/mcollina
Sep 2, 2017https://github.com/nodejs/node/pull/15050#discussion_r136690648
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
BridgeARhttps://github.com/BridgeAR
Sep 2, 2017https://github.com/nodejs/node/pull/15050#discussion_r136690837
Please reload this pagehttps://github.com/nodejs/node/pull/15050
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15036https://github.com/nodejs/node/pull/15036
Please reload this pagehttps://github.com/nodejs/node/pull/15050
mcollinahttps://github.com/mcollina
Sep 4, 2017https://github.com/nodejs/node/pull/15050#discussion_r136793161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15036https://github.com/nodejs/node/pull/15036
Please reload this pagehttps://github.com/nodejs/node/pull/15050
BridgeARhttps://github.com/BridgeAR
Sep 4, 2017https://github.com/nodejs/node/pull/15050#discussion_r136813833
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15036https://github.com/nodejs/node/pull/15036
Please reload this pagehttps://github.com/nodejs/node/pull/15050
joyeecheunghttps://github.com/joyeecheung
Sep 10, 2017https://github.com/nodejs/node/pull/15050#discussion_r137940490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
BridgeARhttps://github.com/BridgeAR
Sep 11, 2017https://github.com/nodejs/node/pull/15050#discussion_r137978402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/nodejs
nodejshttps://github.com/nodejs
Sep 2, 2017https://github.com/nodejs/node/pull/15050#event-1232259246
https://github.com/nodejs
nodejshttps://github.com/nodejs
Sep 2, 2017https://github.com/nodejs/node/pull/15050#event-1232259257
https://github.com/nodejs
nodejshttps://github.com/nodejs
Sep 2, 2017https://github.com/nodejs/node/pull/15050#event-1232259265
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 3, 2017 https://github.com/nodejs/node/pull/15050#pullrequestreview-60289277
View reviewed changes https://github.com/nodejs/node/pull/15050/files
lib/assert.jshttps://github.com/nodejs/node/pull/15050/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
joyeecheunghttps://github.com/joyeecheung
Sep 3, 2017https://github.com/nodejs/node/pull/15050#discussion_r136709473
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
BridgeARhttps://github.com/BridgeAR
Sep 3, 2017https://github.com/nodejs/node/pull/15050#discussion_r136724015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
BridgeARhttps://github.com/BridgeAR
Sep 4, 2017https://github.com/nodejs/node/pull/15050#discussion_r136737740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Trotthttps://github.com/Trott
September 4, 2017 12:41https://github.com/nodejs/node/pull/15050#event-1233481574
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 5, 2017 https://github.com/nodejs/node/pull/15050#pullrequestreview-60497432
View reviewed changes https://github.com/nodejs/node/pull/15050/files
doc/api/assert.mdhttps://github.com/nodejs/node/pull/15050/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
Trotthttps://github.com/Trott
Sep 5, 2017https://github.com/nodejs/node/pull/15050#discussion_r136897092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
Trotthttps://github.com/Trott
Sep 5, 2017https://github.com/nodejs/node/pull/15050#discussion_r136897532
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
BridgeARhttps://github.com/BridgeAR
Sep 5, 2017https://github.com/nodejs/node/pull/15050#discussion_r136960178
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
doc/api/assert.mdhttps://github.com/nodejs/node/pull/15050/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
Trotthttps://github.com/Trott
Sep 5, 2017https://github.com/nodejs/node/pull/15050#discussion_r136897114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
BridgeARhttps://github.com/BridgeAR
Sep 5, 2017https://github.com/nodejs/node/pull/15050#discussion_r136959988
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/320cfaed56730543fef9c1969f35afd951905104..af780c95a2271453407d0be3bea2010d80387136
320cfaehttps://github.com/nodejs/node/commit/320cfaed56730543fef9c1969f35afd951905104
af780c9https://github.com/nodejs/node/commit/af780c95a2271453407d0be3bea2010d80387136
Compare https://github.com/nodejs/node/compare/320cfaed56730543fef9c1969f35afd951905104..af780c95a2271453407d0be3bea2010d80387136
September 5, 2017 11:25https://github.com/nodejs/node/pull/15050#event-1234682524
https://github.com/BridgeAR
assert: fix boxed primitives in deep*Equalhttps://github.com/nodejs/node/pull/15050/commits/66432d859b3868053147fcb8db2ad160766bd9d2
66432d8https://github.com/nodejs/node/pull/15050/commits/66432d859b3868053147fcb8db2ad160766bd9d2
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/af780c95a2271453407d0be3bea2010d80387136..66432d859b3868053147fcb8db2ad160766bd9d2
af780c9https://github.com/nodejs/node/commit/af780c95a2271453407d0be3bea2010d80387136
66432d8https://github.com/nodejs/node/commit/66432d859b3868053147fcb8db2ad160766bd9d2
Compare https://github.com/nodejs/node/compare/af780c95a2271453407d0be3bea2010d80387136..66432d859b3868053147fcb8db2ad160766bd9d2
September 5, 2017 11:26https://github.com/nodejs/node/pull/15050#event-1234683993
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 5, 2017https://github.com/nodejs/node/pull/15050#issuecomment-327148163
Please reload this pagehttps://github.com/nodejs/node/pull/15050
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Trotthttps://github.com/Trott
joyeecheunghttps://github.com/joyeecheung
September 9, 2017 02:40https://github.com/nodejs/node/pull/15050#event-1241725560
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 9, 2017 https://github.com/nodejs/node/pull/15050#pullrequestreview-61670884
View reviewed changes https://github.com/nodejs/node/pull/15050/files/66432d859b3868053147fcb8db2ad160766bd9d2
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/15050#pullrequestreview-61670884
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 10, 2017 https://github.com/nodejs/node/pull/15050#pullrequestreview-61675819
View reviewed changes https://github.com/nodejs/node/pull/15050/files/66432d859b3868053147fcb8db2ad160766bd9d2
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 10, 2017https://github.com/nodejs/node/pull/15050#issuecomment-328318219
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
[squash] add testcase back inhttps://github.com/nodejs/node/pull/15050/commits/7dfd780584519369077dd32ea95f5ecef07751ce
7dfd780https://github.com/nodejs/node/pull/15050/commits/7dfd780584519369077dd32ea95f5ecef07751ce
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 12, 2017https://github.com/nodejs/node/pull/15050#issuecomment-328975730
Please reload this pagehttps://github.com/nodejs/node/pull/15050
22ae8c0https://github.com/nodejs/node/commit/22ae8c02480444b5d09fabeadbac65f54809c206
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 12, 2017https://github.com/nodejs/node/pull/15050#event-1246046437
BridgeARhttps://github.com/BridgeAR
Sep 12, 2017 https://github.com/nodejs/node/pull/15050#ref-commit-22ae8c0
https://github.com/BridgeAR
assert: fix boxed primitives in deepStrictEqualhttps://github.com/nodejs/node/commit/22ae8c02480444b5d09fabeadbac65f54809c206
22ae8c0https://github.com/nodejs/node/commit/22ae8c02480444b5d09fabeadbac65f54809c206
#15050https://github.com/nodejs/node/pull/15050
addaleaxhttps://github.com/addaleax
Sep 13, 2017 https://github.com/nodejs/node/pull/15050#ref-commit-225bc1f
https://github.com/BridgeAR
https://github.com/addaleax
assert: fix boxed primitives in deepStrictEqualhttps://github.com/addaleax/node/commit/225bc1fe4b44dd84f5d19c81bc7b4bd32026b6f5
225bc1fhttps://github.com/addaleax/node/commit/225bc1fe4b44dd84f5d19c81bc7b4bd32026b6f5
nodejs#15050https://github.com/nodejs/node/pull/15050
https://github.com/jasnell
jasnellhttps://github.com/jasnell
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Sep 20, 2017https://github.com/nodejs/node/pull/15050#event-1257711741
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 20, 2017https://github.com/nodejs/node/pull/15050#issuecomment-330893852
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 20, 2017 https://github.com/nodejs/node/pull/15050#ref-pullrequest-259336261
[v8.x backport] assert: fix boxed primitives in deepStrictEqual #15514 https://github.com/nodejs/node/pull/15514
BridgeARhttps://github.com/BridgeAR
Sep 21, 2017 https://github.com/nodejs/node/pull/15050#ref-commit-d1b3b16
https://github.com/BridgeAR
assert: fix boxed primitives in deepStrictEqualhttps://github.com/BridgeAR/node/commit/d1b3b160e3bf4e96868b86c69ae93bb695c31011
d1b3b16https://github.com/BridgeAR/node/commit/d1b3b160e3bf4e96868b86c69ae93bb695c31011
nodejs#15050https://github.com/nodejs/node/pull/15050
jasnellhttps://github.com/jasnell
Sep 21, 2017 https://github.com/nodejs/node/pull/15050#ref-commit-f6c65e6
https://github.com/BridgeAR
https://github.com/jasnell
assert: fix boxed primitives in deepStrictEqualhttps://github.com/nodejs/node/commit/f6c65e6e19fb8af58bb3a5b4f9bbaa4398046649
f6c65e6https://github.com/nodejs/node/commit/f6c65e6e19fb8af58bb3a5b4f9bbaa4398046649
#15050https://github.com/nodejs/node/pull/15050
https://github.com/jasnell
jasnellhttps://github.com/jasnell
backported-to-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v8.x
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Sep 21, 2017https://github.com/nodejs/node/pull/15050#event-1259561241
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Oct 17, 2017https://github.com/nodejs/node/pull/15050#event-1297478189
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
April 1, 2019 23:37https://github.com/nodejs/node/pull/15050#event-2244906414
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15050
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/15050/files/fd96e2669ed43fc958276a286976094770091bbb
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/15050/files/66432d859b3868053147fcb8db2ad160766bd9d2
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/15050/files/66432d859b3868053147fcb8db2ad160766bd9d2
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/15050/files/b2887a7a98f969363a820bc49313da912c7a0c6c
https://github.com/kunalspathak
kunalspathak https://github.com/kunalspathak
https://github.com/nodejs/node/pull/15050/files/73f7077cdc9ea5b74a973e41153720ed692086a7
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Please reload this pagehttps://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/joyeecheung
https://github.com/mcollina
https://github.com/Trott
https://github.com/kunalspathak
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.