René's URL Explorer Experiment


Title: assert: use same value equal for deepStrictEqual NaN by BridgeAR · Pull Request #15036 · nodejs/node · GitHub

Open Graph Title: assert: use same value equal for deepStrictEqual NaN by BridgeAR · Pull Request #15036 · nodejs/node

X Title: assert: use same value equal for deepStrictEqual NaN by BridgeAR · Pull Request #15036 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: I think it makes sense to further improve assert a bit and to accept NaN as well. I also fixed the documentation a bit by adding missing changelogs to the assert docs. Checklist make -j4 test (U...

X Description: I think it makes sense to further improve assert a bit and to accept NaN as well. I also fixed the documentation a bit by adding missing changelogs to the assert docs. Checklist make -j4 test (U...

Opengraph URL: https://github.com/nodejs/node/pull/15036

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d3da88cb-c9a3-15cd-130a-6d807959d1b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8E0:5EA33:956A7B:CC5984:6A4DDC10
html-safe-noncea5906fd275d6ac7252fb105e154e4d12a032f8ab82093099d0c0aa7c537d8475
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEUwOjVFQTMzOjk1NkE3QjpDQzU5ODQ6NkE0RERDMTAiLCJ2aXNpdG9yX2lkIjoiNDE3NzE1MTA0MDU2OTU5Njk0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac570ebe0fa4558f78da72891c1ca539c02cdd58be37f6becf4489108bb5c54c2c
hovercard-subject-tagpull_request:137767684
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/15036/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d0218b310afcb059eeb29f572607033b3c895d2c33a52fa74e10e149b81a12cc/nodejs/node/pull/15036
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d0218b310afcb059eeb29f572607033b3c895d2c33a52fa74e10e149b81a12cc/nodejs/node/pull/15036
og:image:altI think it makes sense to further improve assert a bit and to accept NaN as well. I also fixed the documentation a bit by adding missing changelogs to the assert docs. Checklist make -j4 test (U...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/15036#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15036
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15036
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/15036
Reloadhttps://github.com/nodejs/node/pull/15036
Reloadhttps://github.com/nodejs/node/pull/15036
Please reload this pagehttps://github.com/nodejs/node/pull/15036
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/15036
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:assert-nanhttps://github.com/BridgeAR/node/tree/assert-nan
Conversationhttps://github.com/nodejs/node/pull/15036
Commits2 (2)https://github.com/nodejs/node/pull/15036/commits
Checkshttps://github.com/nodejs/node/pull/15036/checks
Files changedhttps://github.com/nodejs/node/pull/15036/files
assert: use same value equal for deepStrictEqual NaNhttps://github.com/nodejs/node/pull/15036#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:assert-nanhttps://github.com/BridgeAR/node/tree/assert-nan
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 25, 2017https://github.com/nodejs/node/pull/15036#issue-253031920
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Aug 25, 2017https://github.com/nodejs/node/pull/15036#event-1222233307
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Aug 25, 2017https://github.com/nodejs/node/pull/15036#event-1222233418
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58776802
View reviewed changes https://github.com/nodejs/node/pull/15036/files
doc/api/assert.mdhttps://github.com/nodejs/node/pull/15036/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
Trotthttps://github.com/Trott
Aug 25, 2017https://github.com/nodejs/node/pull/15036#discussion_r135364954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 25, 2017https://github.com/nodejs/node/pull/15036#discussion_r135365468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 25, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325049972
this linehttps://github.com/BridgeAR/node/blame/06003949a77c240b3390764b11f1276a96a67f24/doc/api/assert.md#L164
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Aug 25, 2017https://github.com/nodejs/node/pull/15036#event-1222248281
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 25, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325050447
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58779598
View reviewed changes https://github.com/nodejs/node/pull/15036/files
test/parallel/test-assert-deep.jshttps://github.com/nodejs/node/pull/15036/files#diff-65ce4d754f96bb8e7561644f04140af1f2ecca063ae5579712a976d7d1e8967b
Trotthttps://github.com/Trott
Aug 25, 2017https://github.com/nodejs/node/pull/15036#discussion_r135367545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58779703
View reviewed changes https://github.com/nodejs/node/pull/15036/files
test/parallel/test-assert-deep.jshttps://github.com/nodejs/node/pull/15036/files#diff-65ce4d754f96bb8e7561644f04140af1f2ecca063ae5579712a976d7d1e8967b
Trotthttps://github.com/Trott
Aug 25, 2017https://github.com/nodejs/node/pull/15036#discussion_r135367644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58779725
View reviewed changes https://github.com/nodejs/node/pull/15036/files
Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/nodejs/node/pull/15036#pullrequestreview-58779725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 25, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58779871
View reviewed changes https://github.com/nodejs/node/pull/15036/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 25, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325051579
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 25, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58780453
View reviewed changes https://github.com/nodejs/node/pull/15036/files
doc/api/assert.mdhttps://github.com/nodejs/node/pull/15036/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 25, 2017https://github.com/nodejs/node/pull/15036#discussion_r135368361
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 25, 2017https://github.com/nodejs/node/pull/15036#discussion_r135368479
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/refack
refackhttps://github.com/refack
Aug 26, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58792531
View reviewed changes https://github.com/nodejs/node/pull/15036/files
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/15036#pullrequestreview-58792531
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
test/parallel/test-assert-deep.jshttps://github.com/nodejs/node/pull/15036/files#diff-65ce4d754f96bb8e7561644f04140af1f2ecca063ae5579712a976d7d1e8967b
refackhttps://github.com/refack
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135379971
Please reload this pagehttps://github.com/nodejs/node/pull/15036
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/96947/29738113-c66fbb3a-89e8-11e7-9402-c2e91e282abe.png
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135380168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
refackhttps://github.com/refack
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135392747
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135393997
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness
Please reload this pagehttps://github.com/nodejs/node/pull/15036
refackhttps://github.com/refack
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135394466
Please reload this pagehttps://github.com/nodejs/node/pull/15036
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135394897
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 26, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58804811
View reviewed changes https://github.com/nodejs/node/pull/15036/files
lib/assert.jshttps://github.com/nodejs/node/pull/15036/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
lpincahttps://github.com/lpinca
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135392602
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135394079
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
lpincahttps://github.com/lpinca
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135394151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 26, 2017https://github.com/nodejs/node/pull/15036#discussion_r135394619
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/refack
refackhttps://github.com/refack
stale reviewhttps://github.com/nodejs/node/pull/15036#pullrequestreview-58792531
August 26, 2017 19:15https://github.com/nodejs/node/pull/15036#event-1222593193
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017 https://github.com/nodejs/node/pull/15036#ref-pullrequest-253138753
assert: fix boxed primitives in deep*Equal #15050 https://github.com/nodejs/node/pull/15050
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325175176
Please reload this pagehttps://github.com/nodejs/node/pull/15036
#15050https://github.com/nodejs/node/pull/15050
@jasnellhttps://github.com/jasnell
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 27, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325199260
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/refack
refackhttps://github.com/refack
Aug 27, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58824758
View reviewed changes https://github.com/nodejs/node/pull/15036/files
refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/nodejs/node/pull/15036#pullrequestreview-58824758
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/refack
refackhttps://github.com/refack
Aug 27, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325204042
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/daxlab
daxlabhttps://github.com/daxlab
Aug 28, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58851222
View reviewed changes https://github.com/nodejs/node/pull/15036/files
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 28, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325309624
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 28, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-58897273
View reviewed changes https://github.com/nodejs/node/pull/15036/files
doc/api/assert.mdhttps://github.com/nodejs/node/pull/15036/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
tniessenhttps://github.com/tniessen
Aug 28, 2017https://github.com/nodejs/node/pull/15036#discussion_r135482595
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Aug 29, 2017https://github.com/nodejs/node/pull/15036#discussion_r135685940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/refack
refackhttps://github.com/refack
Aug 28, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325349523
@refackhttps://github.com/refack
@BridgeARhttps://github.com/BridgeAR
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 29, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325536472
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/a2aab62041451016d435888167d8fad7b49514e5..f8d78a6d6a861c381bb81d6a2f2507f494386ec4
a2aab62https://github.com/nodejs/node/commit/a2aab62041451016d435888167d8fad7b49514e5
f8d78a6https://github.com/nodejs/node/commit/f8d78a6d6a861c381bb81d6a2f2507f494386ec4
Compare https://github.com/nodejs/node/compare/a2aab62041451016d435888167d8fad7b49514e5..f8d78a6d6a861c381bb81d6a2f2507f494386ec4
August 29, 2017 03:24https://github.com/nodejs/node/pull/15036#event-1224865443
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 29, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325544408
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 29, 2017https://github.com/nodejs/node/pull/15036#issuecomment-325547141
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/960/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/960/
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 31, 2017https://github.com/nodejs/node/pull/15036#issuecomment-326203628
Please reload this pagehttps://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
September 1, 2017 02:43https://github.com/nodejs/node/pull/15036#commits-pushed-0bf1af3
https://github.com/BridgeAR
doc: add missing changelogs to assert docshttps://github.com/nodejs/node/pull/15036/commits/0bf1af305ae30b1052779489ea537ebb4b904975
0bf1af3https://github.com/nodejs/node/pull/15036/commits/0bf1af305ae30b1052779489ea537ebb4b904975
https://github.com/BridgeAR
assert: use Same-value eql. for deepStrictEqual NaNhttps://github.com/nodejs/node/pull/15036/commits/07e36df483bac14f847a36c3e804fb2baa2eea61
07e36dfhttps://github.com/nodejs/node/pull/15036/commits/07e36df483bac14f847a36c3e804fb2baa2eea61
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/f8d78a6d6a861c381bb81d6a2f2507f494386ec4..07e36df483bac14f847a36c3e804fb2baa2eea61
f8d78a6https://github.com/nodejs/node/commit/f8d78a6d6a861c381bb81d6a2f2507f494386ec4
07e36dfhttps://github.com/nodejs/node/commit/07e36df483bac14f847a36c3e804fb2baa2eea61
Compare https://github.com/nodejs/node/compare/f8d78a6d6a861c381bb81d6a2f2507f494386ec4..07e36df483bac14f847a36c3e804fb2baa2eea61
September 1, 2017 05:44https://github.com/nodejs/node/pull/15036#event-1230781399
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 1, 2017https://github.com/nodejs/node/pull/15036#issuecomment-326494372
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 2, 2017https://github.com/nodejs/node/pull/15036#issuecomment-326769449
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 4, 2017 https://github.com/nodejs/node/pull/15036#pullrequestreview-60380128
View reviewed changes https://github.com/nodejs/node/pull/15036/files/07e36df483bac14f847a36c3e804fb2baa2eea61
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/15036#pullrequestreview-60380128
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 5, 2017https://github.com/nodejs/node/pull/15036#issuecomment-327146810
1789dcfhttps://github.com/nodejs/node/commit/1789dcfc873eea0b993a1fa20f2e30819a57b9c9
ea2e636https://github.com/nodejs/node/commit/ea2e6363f221c1c6ca5b04b295bd6d17ecca355b
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 5, 2017https://github.com/nodejs/node/pull/15036#event-1234676491
BridgeARhttps://github.com/BridgeAR
Sep 5, 2017 https://github.com/nodejs/node/pull/15036#ref-commit-1789dcf
https://github.com/BridgeAR
doc: add missing changelogs to assert docshttps://github.com/nodejs/node/commit/1789dcfc873eea0b993a1fa20f2e30819a57b9c9
1789dcfhttps://github.com/nodejs/node/commit/1789dcfc873eea0b993a1fa20f2e30819a57b9c9
#15036https://github.com/nodejs/node/pull/15036
BridgeARhttps://github.com/BridgeAR
Sep 5, 2017 https://github.com/nodejs/node/pull/15036#ref-commit-ea2e636
https://github.com/BridgeAR
assert: use SameValueZero in deepStrictEqualhttps://github.com/nodejs/node/commit/ea2e6363f221c1c6ca5b04b295bd6d17ecca355b
ea2e636https://github.com/nodejs/node/commit/ea2e6363f221c1c6ca5b04b295bd6d17ecca355b
#15036https://github.com/nodejs/node/pull/15036
addaleaxhttps://github.com/addaleax
Sep 5, 2017 https://github.com/nodejs/node/pull/15036#ref-commit-6fc6e4b
https://github.com/BridgeAR
https://github.com/addaleax
doc: add missing changelogs to assert docshttps://github.com/addaleax/ayo/commit/6fc6e4b3d54521336eb77c2380b3776aca2a90c2
6fc6e4bhttps://github.com/addaleax/ayo/commit/6fc6e4b3d54521336eb77c2380b3776aca2a90c2
nodejs/node#15036https://github.com/nodejs/node/pull/15036
addaleaxhttps://github.com/addaleax
Sep 5, 2017 https://github.com/nodejs/node/pull/15036#ref-commit-005ba59
https://github.com/BridgeAR
https://github.com/addaleax
assert: use SameValueZero in deepStrictEqualhttps://github.com/addaleax/ayo/commit/005ba59b509977914ff5f7b8474311849981cb8e
005ba59https://github.com/addaleax/ayo/commit/005ba59b509977914ff5f7b8474311849981cb8e
nodejs/node#15036https://github.com/nodejs/node/pull/15036
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/15036#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
https://github.com/bradennapier
bradennapierhttps://github.com/bradennapier
Nov 3, 2017 https://github.com/nodejs/node/pull/15036#ref-issue-270938179
[REQUEST]: Document Breaking Changes in 9.0 #16713 https://github.com/nodejs/node/issues/16713
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
April 1, 2019 23:37https://github.com/nodejs/node/pull/15036#event-2244906358
https://github.com/adamlaska
adamlaskahttps://github.com/adamlaska
May 13, 2022 https://github.com/nodejs/node/pull/15036#ref-pullrequest-1235695566
[Snyk] Fix for 1 vulnerabilities adamlaska/node#67 https://github.com/adamlaska/node/pull/67
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 27, 2023 https://github.com/nodejs/node/pull/15036#ref-pullrequest-1685924609
[Snyk] Fix for 20 vulnerabilities aliscco/alisco-node#253 https://github.com/aliscco/alisco-node/pull/253
[Snyk] Fix for 16 vulnerabilities aliscco/alisco-node#304 https://github.com/aliscco/alisco-node/pull/304
[Snyk] Fix for 18 vulnerabilities aliscco/alisco-node#310 https://github.com/aliscco/alisco-node/pull/310
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 28, 2023 https://github.com/nodejs/node/pull/15036#ref-pullrequest-1687855700
[Snyk] Fix for 20 vulnerabilities aliscco/alisco-node#314 https://github.com/aliscco/alisco-node/pull/314
[Snyk] Fix for 9 vulnerabilities aliscco/alisco-node#330 https://github.com/aliscco/alisco-node/pull/330
[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#334 https://github.com/aliscco/alisco-node/pull/334
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 28, 2023 https://github.com/nodejs/node/pull/15036#ref-pullrequest-1689046654
[Snyk] Fix for 114 vulnerabilities aliscco/alisco-node#338 https://github.com/aliscco/alisco-node/pull/338
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 28, 2023 https://github.com/nodejs/node/pull/15036#ref-pullrequest-1689126461
[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#342 https://github.com/aliscco/alisco-node/pull/342
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F15036
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/15036/files/a2aab62041451016d435888167d8fad7b49514e5
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/15036/files/a2aab62041451016d435888167d8fad7b49514e5
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/15036/files/07e36df483bac14f847a36c3e804fb2baa2eea61
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/15036/files/2cb4a618ce1c814498d1ba7a96fc741cc64267d9
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/15036/files/9f39cd4004426b5803812167098bef3077fabbf0
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/15036/files/2cb4a618ce1c814498d1ba7a96fc741cc64267d9
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/15036/files/a2aab62041451016d435888167d8fad7b49514e5
https://github.com/daxlab
daxlab https://github.com/daxlab
https://github.com/nodejs/node/pull/15036/files/a2aab62041451016d435888167d8fad7b49514e5
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/15036
https://github.com/BridgeAR
https://github.com/vsemozhetbyt
https://github.com/Trott
https://github.com/refack
https://github.com/tniessen
https://github.com/mcollina
https://github.com/jasnell
https://github.com/lpinca
https://github.com/daxlab
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.