René's URL Explorer Experiment


Title: tls_wrap: use localhost if options.host is empty by sitegui · Pull Request #1493 · nodejs/node · GitHub

Open Graph Title: tls_wrap: use localhost if options.host is empty by sitegui · Pull Request #1493 · nodejs/node

X Title: tls_wrap: use localhost if options.host is empty by sitegui · Pull Request #1493 · nodejs/node

Description: That's my PR for #1489. Thanks @Fishrock123 for the actual fix idea cc: @silverwind @Fishrock123 tls.connect(options) with no options.host should accept a certificate with CN: 'localhost'. Fix Erro...

Open Graph Description: That's my PR for #1489. Thanks @Fishrock123 for the actual fix idea cc: @silverwind @Fishrock123 tls.connect(options) with no options.host should accept a certificate with CN: 'localhost...

X Description: That's my PR for #1489. Thanks @Fishrock123 for the actual fix idea cc: @silverwind @Fishrock123 tls.connect(options) with no options.host should accept a certificate with CN: 'loca...

Opengraph URL: https://github.com/nodejs/node/pull/1493

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2dd42277-c731-2b23-3946-cf306ab23c36
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B0A:247E0C:25F3CE3:3394F3D:696AD80E
html-safe-noncef3615a5740f3c62574247a0d4feda5f7fe87d366c7fcb91866a06ecee82f26af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjBBOjI0N0UwQzoyNUYzQ0UzOjMzOTRGM0Q6Njk2QUQ4MEUiLCJ2aXNpdG9yX2lkIjoiMTA3MDgyNjYzMjYzMzkzODA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9219ca10adfefc5f414f266a0298495794d6e82091db02feeabbdd1a19b80dc1
hovercard-subject-tagpull_request:33806271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1493/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ee037f0a473f22115d6c4c356e48b36270ba21dace50baa7bba7e320ea6eab53/nodejs/node/pull/1493
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee037f0a473f22115d6c4c356e48b36270ba21dace50baa7bba7e320ea6eab53/nodejs/node/pull/1493
og:image:altThat's my PR for #1489. Thanks @Fishrock123 for the actual fix idea cc: @silverwind @Fishrock123 tls.connect(options) with no options.host should accept a certificate with CN: 'localhost...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesitegui
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1493#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1493
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1493
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1493
Reloadhttps://github.com/nodejs/node/pull/1493
Reloadhttps://github.com/nodejs/node/pull/1493
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1493
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/1493
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/1493#issue-comment-box
siteguihttps://github.com/sitegui
nodejs:masterhttps://github.com/nodejs/node/tree/master
tls_wrap: use localhost if options.host is empty https://github.com/nodejs/node/pull/1493#top
siteguihttps://github.com/sitegui
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversation 17 https://github.com/nodejs/node/pull/1493
Commits 5 https://github.com/nodejs/node/pull/1493/commits
Checks 0 https://github.com/nodejs/node/pull/1493/checks
Files changed https://github.com/nodejs/node/pull/1493/files
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/sitegui
siteguihttps://github.com/sitegui
Apr 21, 2015https://github.com/nodejs/node/pull/1493#issue-69959139
#1489https://github.com/nodejs/node/issues/1489
@Fishrock123https://github.com/Fishrock123
@silverwindhttps://github.com/silverwind
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/sitegui
tls_wrap: use localhost if options.host is emptyhttps://github.com/nodejs/node/pull/1493/commits/5b225cd99a5833781a7a61d68b65e0dcd927c5bb
5b225cdhttps://github.com/nodejs/node/pull/1493/commits/5b225cd99a5833781a7a61d68b65e0dcd927c5bb
#1489https://github.com/nodejs/node/issues/1489
Fishrock123https://github.com/Fishrock123
Apr 21, 2015 https://github.com/nodejs/node/pull/1493#discussion-diff-28825284
View reviewed changes https://github.com/nodejs/node/pull/1493/files/5b225cd99a5833781a7a61d68b65e0dcd927c5bb#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/1493/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
Fishrock123https://github.com/Fishrock123
Apr 21, 2015https://github.com/nodejs/node/pull/1493#discussion_r28825284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1493
siteguihttps://github.com/sitegui
Apr 21, 2015https://github.com/nodejs/node/pull/1493#discussion_r28825659
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1493
kkoopahttps://github.com/kkoopa
Apr 21, 2015https://github.com/nodejs/node/pull/1493#discussion_r28825686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedencehttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedence
Please reload this pagehttps://github.com/nodejs/node/pull/1493
siteguihttps://github.com/sitegui
Apr 22, 2015https://github.com/nodejs/node/pull/1493#discussion_r28843815
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@kkoopahttps://github.com/kkoopa
Please reload this pagehttps://github.com/nodejs/node/pull/1493
silverwindhttps://github.com/silverwind
Apr 22, 2015https://github.com/nodejs/node/pull/1493#discussion_r28892001
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Apr 21, 2015https://github.com/nodejs/node/pull/1493#event-286662663
Fishrock123https://github.com/Fishrock123
Apr 21, 2015 https://github.com/nodejs/node/pull/1493#discussion-diff-28825357
View reviewed changes https://github.com/nodejs/node/pull/1493/files/5b225cd99a5833781a7a61d68b65e0dcd927c5bb#diff-cb6283b458d2316236e8ee1cae96d58cba397c0e697d9a246e3d37ad54ff8eb1
test/parallel/test-tls-connect-no-host.jshttps://github.com/nodejs/node/pull/1493/files#diff-cb6283b458d2316236e8ee1cae96d58cba397c0e697d9a246e3d37ad54ff8eb1
Fishrock123https://github.com/Fishrock123
Apr 21, 2015https://github.com/nodejs/node/pull/1493#discussion_r28825357
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1493
siteguihttps://github.com/sitegui
April 21, 2015 18:41https://github.com/nodejs/node/pull/1493#commits-pushed-51f90e8
https://github.com/sitegui
Silly fix for PR1493https://github.com/nodejs/node/pull/1493/commits/51f90e82eec0a107490c0ad64be44ebd77be8c3b
51f90e8https://github.com/nodejs/node/pull/1493/commits/51f90e82eec0a107490c0ad64be44ebd77be8c3b
https://github.com/sitegui
Wrap at 80 columnshttps://github.com/nodejs/node/pull/1493/commits/c3c8d6ea4eed07f9d553b101bcc065cff16f0da6
c3c8d6ehttps://github.com/nodejs/node/pull/1493/commits/c3c8d6ea4eed07f9d553b101bcc065cff16f0da6
brendanashworthhttps://github.com/brendanashworth
Apr 22, 2015 https://github.com/nodejs/node/pull/1493#discussion-diff-28838124
View reviewed changes https://github.com/nodejs/node/pull/1493/files/c3c8d6ea4eed07f9d553b101bcc065cff16f0da6#diff-cb6283b458d2316236e8ee1cae96d58cba397c0e697d9a246e3d37ad54ff8eb1
test/parallel/test-tls-connect-no-host.jshttps://github.com/nodejs/node/pull/1493/files#diff-cb6283b458d2316236e8ee1cae96d58cba397c0e697d9a246e3d37ad54ff8eb1
brendanashworthhttps://github.com/brendanashworth
Apr 22, 2015https://github.com/nodejs/node/pull/1493#discussion_r28838124
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/sitegui
Style fixhttps://github.com/nodejs/node/pull/1493/commits/e5c93eba61a0e9ff943b43ca85b1318d30d2703a
e5c93ebhttps://github.com/nodejs/node/pull/1493/commits/e5c93eba61a0e9ff943b43ca85b1318d30d2703a
https://github.com/sitegui
siteguihttps://github.com/sitegui
Apr 22, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95006139
Please reload this pagehttps://github.com/nodejs/node/pull/1493
chrisdickinsonhttps://github.com/chrisdickinson
Apr 22, 2015 https://github.com/nodejs/node/pull/1493#discussion-diff-28843166
View reviewed changes https://github.com/nodejs/node/pull/1493/files/e5c93eba61a0e9ff943b43ca85b1318d30d2703a#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/1493/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
chrisdickinsonhttps://github.com/chrisdickinson
Apr 22, 2015https://github.com/nodejs/node/pull/1493#discussion_r28843166
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Apr 22, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95261785
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Apr 22, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95262059
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/sitegui
Make test quiethttps://github.com/nodejs/node/pull/1493/commits/2d7f52ce4c5d9988b9702018851bc24f8dc844e0
2d7f52chttps://github.com/nodejs/node/pull/1493/commits/2d7f52ce4c5d9988b9702018851bc24f8dc844e0
https://github.com/sitegui
siteguihttps://github.com/sitegui
Apr 23, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95372392
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Apr 23, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95377132
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Apr 23, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95426707
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Apr 23, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95433488
Please reload this pagehttps://github.com/nodejs/node/pull/1493
silverwindhttps://github.com/silverwind
Apr 23, 2015 https://github.com/nodejs/node/pull/1493#ref-commit-a7d7463
https://github.com/sitegui
https://github.com/silverwind
tls_wrap: use localhost if options.host is emptyhttps://github.com/nodejs/node/commit/a7d74633f20e285395f5e2860bdac56381603476
a7d7463https://github.com/nodejs/node/commit/a7d74633f20e285395f5e2860bdac56381603476
#1493https://github.com/nodejs/node/pull/1493
#1489https://github.com/nodejs/node/issues/1489
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Apr 23, 2015https://github.com/nodejs/node/pull/1493#issuecomment-95612239
a7d7463https://github.com/nodejs/node/commit/a7d74633f20e285395f5e2860bdac56381603476
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Apr 23, 2015https://github.com/nodejs/node/pull/1493#event-288394895
https://github.com/rvagg
rvagghttps://github.com/rvagg
Apr 27, 2015 https://github.com/nodejs/node/pull/1493#ref-pullrequest-71146613
Release proposal: v2.0.0 #1532 https://github.com/nodejs/node/pull/1532
Fishrock123https://github.com/Fishrock123
Apr 29, 2015 https://github.com/nodejs/node/pull/1493#ref-commit-5eea0de
https://github.com/sitegui
https://github.com/Fishrock123
tls_wrap: use localhost if options.host is emptyhttps://github.com/Fishrock123/node/commit/5eea0dec88246e626850ce292beb6885c38a95da
5eea0dehttps://github.com/Fishrock123/node/commit/5eea0dec88246e626850ce292beb6885c38a95da
nodejs#1493https://github.com/nodejs/node/pull/1493
nodejs#1489https://github.com/nodejs/node/issues/1489
https://github.com/rvagg
rvagghttps://github.com/rvagg
May 2, 2015 https://github.com/nodejs/node/pull/1493#ref-pullrequest-72591122
doc: update AUTHORS list #1586 https://github.com/nodejs/node/pull/1586
Fishrock123https://github.com/Fishrock123
May 14, 2015 https://github.com/nodejs/node/pull/1493#ref-commit-71274b0
https://github.com/sitegui
https://github.com/Fishrock123
tls_wrap: use localhost if options.host is emptyhttps://github.com/Fishrock123/node/commit/71274b0263083942e2affed0f959fe98a7366781
71274b0https://github.com/Fishrock123/node/commit/71274b0263083942e2affed0f959fe98a7366781
nodejs#1493https://github.com/nodejs/node/pull/1493
nodejs#1560https://github.com/nodejs/node/pull/1560
a7d7463https://github.com/Fishrock123/node/commit/a7d74633f20e285395f5e2860bdac56381603476
nodejs#1489https://github.com/nodejs/node/issues/1489
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 14, 2015 https://github.com/nodejs/node/pull/1493#ref-issue-76409605
Release proposal: v1.8.2 #1703 https://github.com/nodejs/node/issues/1703
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1493
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/1493
https://github.com/sitegui
https://github.com/silverwind
https://github.com/brendanashworth
https://github.com/chrisdickinson
https://github.com/Fishrock123
https://github.com/kkoopa
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.