Title: Openssl clientcertengine support2 by Trott · Pull Request #14903 · nodejs/node · GitHub
Open Graph Title: Openssl clientcertengine support2 by Trott · Pull Request #14903 · nodejs/node
X Title: Openssl clientcertengine support2 by Trott · Pull Request #14903 · nodejs/node
Description: This is an attempt to finish #6569 which stalled. First commit is a squashed commit mostly of work done by @joelostrowski with their authorship preserved. Original PR description: Added an option 'clientCertEngine' to tls.createSecureContext which gets wired up to OpenSSL function SSL_CTX_set_client_cert_engine. The option is passed through from https.request as well. This allows using a custom OpenSSL engine to provide the client certificate. PTAL @bnoordhuis @indutny PTAL @sam-github at the doc changes and anything else you want @danbev If you have time to look to make sure there aren't any "NOOOOO, this will fail if compiled without OpenSSL!!!!" problems that are super-obvious, that would be great. The stuff in test/addons/openssl-client-cert-engine seems like it needs a common.hasCrypto() check, no? Anything else anywhere in the code that looks like it might be problematic? Marking as in progress because I can't get the test addon to compile on MacOS. Can someone help me make sense of this output from make test-addons? Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines Affected core subsystem(s) tls http crypto
Open Graph Description: This is an attempt to finish #6569 which stalled. First commit is a squashed commit mostly of work done by @joelostrowski with their authorship preserved. Original PR description: Added an option ...
X Description: This is an attempt to finish #6569 which stalled. First commit is a squashed commit mostly of work done by @joelostrowski with their authorship preserved. Original PR description: Added an option ...
Opengraph URL: https://github.com/nodejs/node/pull/14903
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:4273701e-8312-3dc6-50e8-ad3d645e317f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB14:1A446D:707352E:9A02F42:69964A0B |
| html-safe-nonce | 436b6432331d0ac4781f9c61b1b003ffd3bbb3a856213fe5a3664ce5efcfebf0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjE0OjFBNDQ2RDo3MDczNTJFOjlBMDJGNDI6Njk5NjRBMEIiLCJ2aXNpdG9yX2lkIjoiODgyNTg1NzI5MjEzMjg2OTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1bd2446bb0c8ea8fec9d1a697ddcd2ee1f4985bc3403a62f63e22beaaab7005d |
| hovercard-subject-tag | pull_request:136366791 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/14903/commits/085a84775a86179f4f0eac58c72a7bf8412b5ec6 |
| twitter:image | https://avatars.githubusercontent.com/u/718899?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/718899?s=400&v=4 |
| og:image:alt | This is an attempt to finish #6569 which stalled. First commit is a squashed commit mostly of work done by @joelostrowski with their authorship preserved. Original PR description: Added an option ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | bb5fc598983958d677e5179b50e71c2bfa2a8ac1568110d429775cd645bbe799 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 171966ace3e7ca5785ca7770e7adff7c50821654 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width