| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6cba2196-bcee-bc90-3ba1-57db846852f3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE72:242A4:5A7B99:70EABC:69913757 |
| html-safe-nonce | 31a7300e07359aac964da2468315cc46cd5ec682060db478f9822f1e6fc184d8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTcyOjI0MkE0OjVBN0I5OTo3MEVBQkM6Njk5MTM3NTciLCJ2aXNpdG9yX2lkIjoiNjc4ODU4ODA0MjM5NzQ5NzE3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bbd9cc1717d889649a72a952d2fff6043e894f1ca82359153013df1357f82ec8 |
| hovercard-subject-tag | pull_request:136366791 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14903/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e6197d27a68a337a3447e2cac9061536d36f73d039524f1ef837f947876f5090/nodejs/node/pull/14903 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e6197d27a68a337a3447e2cac9061536d36f73d039524f1ef837f947876f5090/nodejs/node/pull/14903 |
| og:image:alt | This is an attempt to finish #6569 which stalled. First commit is a squashed commit mostly of work done by @joelostrowski with their authorship preserved.
Original PR description:
Added an option ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/14903#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14903 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14903 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/14903 |
| Reload | https://github.com/nodejs/node/pull/14903 |
| Reload | https://github.com/nodejs/node/pull/14903 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
710
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:openssl-clientcertengine-support2 | https://github.com/Trott/io.js/tree/openssl-clientcertengine-support2 |
| Conversation | https://github.com/nodejs/node/pull/14903 |
| Commits5 (5) | https://github.com/nodejs/node/pull/14903/commits |
| Checks | https://github.com/nodejs/node/pull/14903/checks |
| Files changed | https://github.com/nodejs/node/pull/14903/files |
| Openssl clientcertengine support2 | https://github.com/nodejs/node/pull/14903#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:openssl-clientcertengine-support2 | https://github.com/Trott/io.js/tree/openssl-clientcertengine-support2 |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14903#issue-251089718 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| #6569 | https://github.com/nodejs/node/pull/6569 |
| @joelostrowski | https://github.com/joelostrowski |
| @bnoordhuis | https://github.com/bnoordhuis |
| @indutny | https://github.com/indutny |
| @sam-github | https://github.com/sam-github |
| @danbev | https://github.com/danbev |
| this output | https://gist.github.com/Trott/aebd17a0682c6ec517a1412a63dfa8cc |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14903#event-1211006024 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14903#event-1211006092 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 17, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-57072993 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| test/addons/openssl-client-cert-engine/binding.gyp | https://github.com/nodejs/node/pull/14903/files#diff-3af1c9a792e063894ec58cba0384dcc4122fe4f32c6b72bd092e789830c2114c |
| addaleax | https://github.com/addaleax |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r133844699 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| Aug 19, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r134097655 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| lib/_tls_common.js | https://github.com/nodejs/node/pull/14903/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848 |
| addaleax | https://github.com/addaleax |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r133844918 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r137700763 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
| Aug 18, 2017 | https://github.com/nodejs/node/pull/14903#event-1211103853 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/0b3a4a83bbe12791ee5435411d0bc6536002720a..4b829ff3763e9869b0c7f0e9727bc6c7dca8add9 |
| 0b3a4a8 | https://github.com/nodejs/node/commit/0b3a4a83bbe12791ee5435411d0bc6536002720a |
| 4b829ff | https://github.com/nodejs/node/commit/4b829ff3763e9869b0c7f0e9727bc6c7dca8add9 |
|
Compare
| https://github.com/nodejs/node/compare/0b3a4a83bbe12791ee5435411d0bc6536002720a..4b829ff3763e9869b0c7f0e9727bc6c7dca8add9 |
| August 20, 2017 23:01 | https://github.com/nodejs/node/pull/14903#event-1213336780 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 21, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-323649088 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://ci.nodejs.org/job/node-test-commit-osx/11890/nodes=osx1010/console | https://ci.nodejs.org/job/node-test-commit-osx/11890/nodes=osx1010/console |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Aug 21, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-57405877 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| test/addons/openssl-client-cert-engine/test.js | https://github.com/nodejs/node/pull/14903/files#diff-d2e3d675a30c96fcd42fb6f25c5649def06f5ed9c7299791feda7483ce46d310 |
| danbev | https://github.com/danbev |
| Aug 21, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r134148477 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r137700935 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Aug 21, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-57406335 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| test/addons/openssl-client-cert-engine/binding.gyp | https://github.com/nodejs/node/pull/14903/files#diff-3af1c9a792e063894ec58cba0384dcc4122fe4f32c6b72bd092e789830c2114c |
| danbev | https://github.com/danbev |
| Aug 21, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r134148956 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r137701258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Aug 21, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-57417832 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| test/addons/openssl-client-cert-engine/test.js | https://github.com/nodejs/node/pull/14903/files#diff-d2e3d675a30c96fcd42fb6f25c5649def06f5ed9c7299791feda7483ce46d310 |
| danbev | https://github.com/danbev |
| Aug 21, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r134159340 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r137701391 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
|
Aug 21, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-57418674 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| indutny | https://github.com/indutny |
| https://github.com/nodejs/node/pull/14903#pullrequestreview-57418674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Aug 21, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-323673638 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/4b829ff3763e9869b0c7f0e9727bc6c7dca8add9..bf5ef60a07c126b4f3b571a240d29131d112038f |
| 4b829ff | https://github.com/nodejs/node/commit/4b829ff3763e9869b0c7f0e9727bc6c7dca8add9 |
| bf5ef60 | https://github.com/nodejs/node/commit/bf5ef60a07c126b4f3b571a240d29131d112038f |
|
Compare
| https://github.com/nodejs/node/compare/4b829ff3763e9869b0c7f0e9727bc6c7dca8add9..bf5ef60a07c126b4f3b571a240d29131d112038f |
| September 8, 2017 02:54 | https://github.com/nodejs/node/pull/14903#event-1240071907 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-328003335 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/3eeb9782c844a7f5200a820e454e674a9a06448d..d6fee40f9fcc0e9c9723c2ece13b3a482a4525cb |
| 3eeb978 | https://github.com/nodejs/node/commit/3eeb9782c844a7f5200a820e454e674a9a06448d |
| d6fee40 | https://github.com/nodejs/node/commit/d6fee40f9fcc0e9c9723c2ece13b3a482a4525cb |
|
Compare
| https://github.com/nodejs/node/compare/3eeb9782c844a7f5200a820e454e674a9a06448d..d6fee40f9fcc0e9c9723c2ece13b3a482a4525cb |
| September 8, 2017 11:37 | https://github.com/nodejs/node/pull/14903#event-1240631468 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 8, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-61485828 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/14903#pullrequestreview-61485828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Sep 8, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-61486309 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-328182697 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#event-1241501771 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Sep 8, 2017 | https://github.com/nodejs/node/pull/14903#event-1241501992 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 11, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-328430463 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Sep 11, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-328525020 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Sep 11, 2017
| https://github.com/nodejs/node/pull/14903#pullrequestreview-61892102 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14903/files |
| doc/api/tls.md | https://github.com/nodejs/node/pull/14903/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| sam-github | https://github.com/sam-github |
| Sep 11, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r138135223 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| Sep 13, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r138758479 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| lib/_tls_common.js | https://github.com/nodejs/node/pull/14903/files#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848 |
| sam-github | https://github.com/sam-github |
| Sep 11, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r138135481 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| Sep 13, 2017 | https://github.com/nodejs/node/pull/14903#discussion_r138763190 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 11, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-328603937 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/f55f5a8552296c1d1d85d2c49c67052897fcad3d..5c1c0e47acf6e219044255d8ef19aa35795ee118 |
| f55f5a8 | https://github.com/nodejs/node/commit/f55f5a8552296c1d1d85d2c49c67052897fcad3d |
| 5c1c0e4 | https://github.com/nodejs/node/commit/5c1c0e47acf6e219044255d8ef19aa35795ee118 |
|
Compare
| https://github.com/nodejs/node/compare/f55f5a8552296c1d1d85d2c49c67052897fcad3d..5c1c0e47acf6e219044255d8ef19aa35795ee118 |
| September 12, 2017 06:48 | https://github.com/nodejs/node/pull/14903#event-1244650811 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 12, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-328757797 |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| Trott | https://github.com/Trott |
| November 8, 2017 13:48 | https://github.com/nodejs/node/pull/14903#commits-pushed-1501e2c |
|
| https://github.com/Trott |
| squash: nits | https://github.com/nodejs/node/pull/14903/commits/1501e2c35a79377f42269471d5fd829831d73417 |
| 1501e2c | https://github.com/nodejs/node/pull/14903/commits/1501e2c35a79377f42269471d5fd829831d73417 |
|
| https://github.com/Trott |
| squash: typo | https://github.com/nodejs/node/pull/14903/commits/085a84775a86179f4f0eac58c72a7bf8412b5ec6 |
| 085a847 | https://github.com/nodejs/node/pull/14903/commits/085a84775a86179f4f0eac58c72a7bf8412b5ec6 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 8, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-342822656 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://ci.nodejs.org/job/node-test-pull-request/11306/ | https://ci.nodejs.org/job/node-test-pull-request/11306/ |
| https://ci.nodejs.org/job/node-test-pull-request/11307/ | https://ci.nodejs.org/job/node-test-pull-request/11307/ |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/474fb50d655792ed488c6a48af230fd504dc5de3..085a84775a86179f4f0eac58c72a7bf8412b5ec6 |
| 474fb50 | https://github.com/nodejs/node/commit/474fb50d655792ed488c6a48af230fd504dc5de3 |
| 085a847 | https://github.com/nodejs/node/commit/085a84775a86179f4f0eac58c72a7bf8412b5ec6 |
|
Compare
| https://github.com/nodejs/node/compare/474fb50d655792ed488c6a48af230fd504dc5de3..085a84775a86179f4f0eac58c72a7bf8412b5ec6 |
| November 8, 2017 13:50 | https://github.com/nodejs/node/pull/14903#event-1331875250 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-343696160 |
| 6ee985f | https://github.com/nodejs/node/commit/6ee985f311de14621c440377f76d0391b6b23320 |
| de917f8 | https://github.com/nodejs/node/commit/de917f8e81bbf4a590abd85e8dbb3ef9887fb6b2 |
| 829d8f1 | https://github.com/nodejs/node/commit/829d8f1cd0351d9fc3ee0ff9ce63c6f6c34da373 |
| @joelostrowski | https://github.com/joelostrowski |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 11, 2017 | https://github.com/nodejs/node/pull/14903#event-1337373655 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 12, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-343742071 |
| #16964 | https://github.com/nodejs/node/pull/16964 |
| #16965 | https://github.com/nodejs/node/pull/16965 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/joelostrowski |
| joelostrowski | https://github.com/joelostrowski |
| Nov 13, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-343849505 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 12, 2017 | https://github.com/nodejs/node/pull/14903#issuecomment-350991499 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/14903#ref-pullrequest-281310293 |
|
docs: fix link for https api change
#17630
| https://github.com/nodejs/node/pull/17630 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/14903#ref-commit-2627f85 |
|
| https://github.com/MylesBorins |
| docs: fix link for https api change | https://github.com/MylesBorins/node/commit/2627f85842a05368db749be42191f8da203d4ec1 |
| 2627f85 | https://github.com/MylesBorins/node/commit/2627f85842a05368db749be42191f8da203d4ec1 |
| nodejs#14903 | https://github.com/nodejs/node/pull/14903 |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 12, 2017
| https://github.com/nodejs/node/pull/14903#ref-commit-dc92540 |
|
| https://github.com/MylesBorins |
|
| https://github.com/BridgeAR |
| doc: fix link for https api change | https://github.com/BridgeAR/node/commit/dc925400d78a01216ae017f4e336eb114c41bca9 |
| dc92540 | https://github.com/BridgeAR/node/commit/dc925400d78a01216ae017f4e336eb114c41bca9 |
| nodejs#17630 | https://github.com/nodejs/node/pull/17630 |
| nodejs#14903 | https://github.com/nodejs/node/pull/14903 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/14903#ref-commit-33c1e8b |
|
| https://github.com/joelostrowski |
|
| https://github.com/MylesBorins |
| tls: implement clientCertEngine option | https://github.com/nodejs/node/commit/33c1e8b3d56fc4546a45489e05817725a95b53b9 |
|
| https://github.com/nodejs/node/commit/33c1e8b3d56fc4546a45489e05817725a95b53b9#comments |
| 33c1e8b | https://github.com/nodejs/node/commit/33c1e8b3d56fc4546a45489e05817725a95b53b9 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/14903#ref-commit-7d49bd0 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: add clientCertEngine to docs | https://github.com/nodejs/node/commit/7d49bd0045969fa504731009ef5ddcb6d4c4e130 |
|
| https://github.com/nodejs/node/commit/7d49bd0045969fa504731009ef5ddcb6d4c4e130#comments |
| 7d49bd0 | https://github.com/nodejs/node/commit/7d49bd0045969fa504731009ef5ddcb6d4c4e130 |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/14903#ref-commit-121245f |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: add tls clientcertengine tests | https://github.com/nodejs/node/commit/121245f25f7ddd0a400d042f7d410d65ddb2cf57 |
|
| https://github.com/nodejs/node/commit/121245f25f7ddd0a400d042f7d410d65ddb2cf57#comments |
| 121245f | https://github.com/nodejs/node/commit/121245f25f7ddd0a400d042f7d410d65ddb2cf57 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2017
| https://github.com/nodejs/node/pull/14903#ref-pullrequest-273233952 |
|
src: fix SetClientCertEngine() nullptr dereference
#16965
| https://github.com/nodejs/node/pull/16965 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 10, 2018
| https://github.com/nodejs/node/pull/14903#ref-commit-f71feb1 |
|
| https://github.com/MylesBorins |
| doc: fix link for https api change | https://github.com/nodejs/node/commit/f71feb1fc754c8dd75a0aab673eba8f98f42a513 |
| f71feb1 | https://github.com/nodejs/node/commit/f71feb1fc754c8dd75a0aab673eba8f98f42a513 |
| #17630 | https://github.com/nodejs/node/pull/17630 |
| #14903 | https://github.com/nodejs/node/pull/14903 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 10, 2018
| https://github.com/nodejs/node/pull/14903#ref-commit-0ad783a |
|
| https://github.com/MylesBorins |
| doc: fix link for https api change | https://github.com/nodejs/node/commit/0ad783afaf42ab3cfe50f138e824b3741f53d9f7 |
| 0ad783a | https://github.com/nodejs/node/commit/0ad783afaf42ab3cfe50f138e824b3741f53d9f7 |
| #17630 | https://github.com/nodejs/node/pull/17630 |
| #14903 | https://github.com/nodejs/node/pull/14903 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Feb 27, 2018 | https://github.com/nodejs/node/pull/14903#event-1493461574 |
| https://github.com/JackOfMostTrades |
| JackOfMostTrades | https://github.com/JackOfMostTrades |
|
Mar 5, 2018
| https://github.com/nodejs/node/pull/14903#ref-issue-300793145 |
|
EC_POINT_cmp returns error when using a dynamic ENGINE and statically linked openssl
openssl/openssl#5475
| https://github.com/openssl/openssl/issues/5475 |
| targos | https://github.com/targos |
|
Apr 6, 2018
| https://github.com/nodejs/node/pull/14903#ref-commit-6ee985f |
|
| https://github.com/joelostrowski |
|
| https://github.com/Trott |
| tls: implement clientCertEngine option | https://github.com/nodejs/node/commit/6ee985f311de14621c440377f76d0391b6b23320 |
|
| https://github.com/nodejs/node/commit/6ee985f311de14621c440377f76d0391b6b23320#comments |
| 6ee985f | https://github.com/nodejs/node/commit/6ee985f311de14621c440377f76d0391b6b23320 |
| targos | https://github.com/targos |
|
Apr 6, 2018
| https://github.com/nodejs/node/pull/14903#ref-commit-de917f8 |
|
| https://github.com/Trott |
| doc: add clientCertEngine to docs | https://github.com/nodejs/node/commit/de917f8e81bbf4a590abd85e8dbb3ef9887fb6b2 |
|
| https://github.com/nodejs/node/commit/de917f8e81bbf4a590abd85e8dbb3ef9887fb6b2#comments |
| de917f8 | https://github.com/nodejs/node/commit/de917f8e81bbf4a590abd85e8dbb3ef9887fb6b2 |
| targos | https://github.com/targos |
|
Apr 6, 2018
| https://github.com/nodejs/node/pull/14903#ref-commit-829d8f1 |
|
| https://github.com/Trott |
| test: add tls clientcertengine tests | https://github.com/nodejs/node/commit/829d8f1cd0351d9fc3ee0ff9ce63c6f6c34da373 |
|
| https://github.com/nodejs/node/commit/829d8f1cd0351d9fc3ee0ff9ce63c6f6c34da373#comments |
| 829d8f1 | https://github.com/nodejs/node/commit/829d8f1cd0351d9fc3ee0ff9ce63c6f6c34da373 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| May 22, 2018 | https://github.com/nodejs/node/pull/14903#issuecomment-391022148 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 22, 2018 | https://github.com/nodejs/node/pull/14903#issuecomment-391150074 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/14903#issuecomment-413980294 |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:47 | https://github.com/nodejs/node/pull/14903#event-5890955928 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14903 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/14903/files/e33220f905af9d23a247aa8c54cd6a01edbe4622 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/14903/files/db08d3daa2459471e3b5eab9ba29054ef031ed28 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/14903/files/d6fee40f9fcc0e9c9723c2ece13b3a482a4525cb |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/14903/files/d6fee40f9fcc0e9c9723c2ece13b3a482a4525cb |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/14903/files/ad8cdb5ef50371e532aca4556b2d3eedd272cc32 |
|
| https://github.com/indutny |
|
indutny
| https://github.com/indutny |
|
| https://github.com/nodejs/node/pull/14903/files/4b829ff3763e9869b0c7f0e9727bc6c7dca8add9 |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/14903/files/d6fee40f9fcc0e9c9723c2ece13b3a482a4525cb |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/14903 |
|
| https://github.com/Trott |
|
| https://github.com/danbev |
|
| https://github.com/mhdawson |
|
| https://github.com/sam-github |
|
| https://github.com/BridgeAR |
|
| https://github.com/refack |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
|
| https://github.com/bnoordhuis |
|
| https://github.com/joelostrowski |
|
| https://github.com/MylesBorins |
|
| https://github.com/indutny |
|
| https://github.com/addaleax |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |