| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bc18c480-035b-610d-a878-7c65a05541df |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB1E:3BD5F7:330400:43F4B0:6A51405A |
| html-safe-nonce | c2778edea178e8f5cfd199e363320d3ac8902f39641f109e8ab6d34cf78ec406 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjFFOjNCRDVGNzozMzA0MDA6NDNGNEIwOjZBNTE0MDVBIiwidmlzaXRvcl9pZCI6IjY0OTA2MTc2Mjk2MTg4MTUwNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 802dd21515308b4ffcc4e6af5866810274f90a9afb7b1e1ab5fe17cd6821bce6 |
| hovercard-subject-tag | pull_request:136359939 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14902/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3173e7c365758b89ea481e9d59a9b551b51a90b0438f455fc3ae280eab198b75/nodejs/node/pull/14902 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3173e7c365758b89ea481e9d59a9b551b51a90b0438f455fc3ae280eab198b75/nodejs/node/pull/14902 |
| og:image:alt | Remove the command line flag that was needed for N-API module loading.
Re: nodejs/vm#9
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | e840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e876f00c5723f6080b9d294e4958fd4d506e6faf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/14902#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14902 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14902 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/14902 |
| Reload | https://github.com/nodejs/node/pull/14902 |
| Reload | https://github.com/nodejs/node/pull/14902 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
978
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:remove-flag | https://github.com/gabrielschulhof/node/tree/remove-flag |
| Conversation | https://github.com/nodejs/node/pull/14902 |
| Commits1 (1) | https://github.com/nodejs/node/pull/14902/commits |
| Checks | https://github.com/nodejs/node/pull/14902/checks |
| Files changed | https://github.com/nodejs/node/pull/14902/files |
| n-api: remove n-api module loading flag | https://github.com/nodejs/node/pull/14902#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:remove-flag | https://github.com/gabrielschulhof/node/tree/remove-flag |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#issue-251080587 |
| nodejs/vm#9 | https://github.com/nodejs/vm/issues/9 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#event-1210953467 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Aug 17, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57064225 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| refack | https://github.com/refack |
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57064225 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-323202797 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 17, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57070771 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57070771 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| test/addons-napi/testcfg.py | https://github.com/nodejs/node/pull/14902/files#diff-d821ca2a390172ffbbb7da84febaae8a99b93ce8c61fa8f78329774e10fe674d |
| cjihrig | https://github.com/cjihrig |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133842800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| src/node_api.cc | https://github.com/nodejs/node/pull/14902/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc |
| cjihrig | https://github.com/cjihrig |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133843379 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| src/node.cc | https://github.com/nodejs/node/pull/14902/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| cjihrig | https://github.com/cjihrig |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133843484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 17, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57073882 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| src/node.cc | https://github.com/nodejs/node/pull/14902/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| addaleax | https://github.com/addaleax |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133845522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| mhdawson | https://github.com/mhdawson |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133848258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| jasnell | https://github.com/jasnell |
| Aug 18, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133893735 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 17, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-323215816 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
|
Aug 18, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57096288 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| src/node.cc | https://github.com/nodejs/node/pull/14902/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| digitalinfinity | https://github.com/digitalinfinity |
| Aug 18, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133865802 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| jasnell | https://github.com/jasnell |
| Aug 18, 2017 | https://github.com/nodejs/node/pull/14902#discussion_r133893842 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Aug 18, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57127024 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57127024 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this list | https://github.com/nodejs/abi-stable-node/issues/271 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/513fe34cbaa1a756686e420318f5c65c13422b84..e6ad4b5b90f4f25f1fabb0a35123560f94e540af |
| 513fe34 | https://github.com/nodejs/node/commit/513fe34cbaa1a756686e420318f5c65c13422b84 |
| e6ad4b5 | https://github.com/nodejs/node/commit/e6ad4b5b90f4f25f1fabb0a35123560f94e540af |
|
Compare
| https://github.com/nodejs/node/compare/513fe34cbaa1a756686e420318f5c65c13422b84..e6ad4b5b90f4f25f1fabb0a35123560f94e540af |
| August 18, 2017 10:49 | https://github.com/nodejs/node/pull/14902#event-1211681907 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Aug 18, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-323323111 |
| @mhdawson | https://github.com/mhdawson |
| @digitalinfinity | https://github.com/digitalinfinity |
| @addaleax | https://github.com/addaleax |
| @mcollina | https://github.com/mcollina |
| @cjihrig | https://github.com/cjihrig |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/e6ad4b5b90f4f25f1fabb0a35123560f94e540af..9b783633a0fe12410f8e94c96a7f7fd51e264b6e |
| e6ad4b5 | https://github.com/nodejs/node/commit/e6ad4b5b90f4f25f1fabb0a35123560f94e540af |
| 9b78363 | https://github.com/nodejs/node/commit/9b783633a0fe12410f8e94c96a7f7fd51e264b6e |
|
Compare
| https://github.com/nodejs/node/compare/e6ad4b5b90f4f25f1fabb0a35123560f94e540af..9b783633a0fe12410f8e94c96a7f7fd51e264b6e |
| August 18, 2017 10:53 | https://github.com/nodejs/node/pull/14902#event-1211686421 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 18, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57203222 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/nodejs/node/pull/14902#pullrequestreview-57203222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @mcollina | https://github.com/mcollina |
| @aruneshchandra | https://github.com/aruneshchandra |
| @jasongin | https://github.com/jasongin |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/14902#ref-issue-253127142 |
|
Node.js Foundation Core Technical Committee (CTC) Meeting 2017-08-30
nodejs/CTC#171
| https://github.com/nodejs/CTC/issues/171 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-326037041 |
| @mhdawson | https://github.com/mhdawson |
| @RReverser | https://github.com/RReverser |
| @bmeck | https://github.com/bmeck |
| nodejs/abi-stable-node#256 (comment) | https://github.com/nodejs/abi-stable-node/issues/256#issuecomment-325138872 |
| @BoingBoing | https://github.com/BoingBoing |
| #15088 | https://github.com/nodejs/node/pull/15088 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 30, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-326052441 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/14902#ref-issue-247017140 |
|
drop --napi-modules earlier than dropping the "experimental" status
nodejs/vm#9
| https://github.com/nodejs/vm/issues/9 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 30, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-59669973 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 13, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-329267369 |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 13, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-329269927 |
| @BridgeAR | https://github.com/BridgeAR |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-329517676 |
| https://ci.nodejs.org/job/node-test-pull-request/10081/ | https://ci.nodejs.org/job/node-test-pull-request/10081/ |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 14, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-329600940 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| #15108 | https://github.com/nodejs/node/issues/15108 |
| @sampsongao | https://github.com/sampsongao |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Sep 18, 2017
| https://github.com/nodejs/node/pull/14902#pullrequestreview-63500783 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14902/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/14902#pullrequestreview-63500783 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 18, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-330375585 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| n-api: remove n-api module loading flag | https://github.com/nodejs/node/pull/14902/commits/ca5d54f7d82f54e13e1f78287fa302c25627732b |
| ca5d54f | https://github.com/nodejs/node/pull/14902/commits/ca5d54f7d82f54e13e1f78287fa302c25627732b |
| nodejs/vm#9 | https://github.com/nodejs/vm/issues/9 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/9b783633a0fe12410f8e94c96a7f7fd51e264b6e..ca5d54f7d82f54e13e1f78287fa302c25627732b |
| 9b78363 | https://github.com/nodejs/node/commit/9b783633a0fe12410f8e94c96a7f7fd51e264b6e |
| ca5d54f | https://github.com/nodejs/node/commit/ca5d54f7d82f54e13e1f78287fa302c25627732b |
|
Compare
| https://github.com/nodejs/node/compare/9b783633a0fe12410f8e94c96a7f7fd51e264b6e..ca5d54f7d82f54e13e1f78287fa302c25627732b |
| September 19, 2017 20:32 | https://github.com/nodejs/node/pull/14902#event-1256246472 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-330665996 |
| https://ci.nodejs.org/job/node-test-pull-request/10141/ | https://ci.nodejs.org/job/node-test-pull-request/10141/ |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-330669473 |
| https://ci.nodejs.org/job/node-test-pull-request/10142/ | https://ci.nodejs.org/job/node-test-pull-request/10142/ |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-330671112 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/14902#issuecomment-330671250 |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
| Qard | https://github.com/Qard |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/14902#ref-commit-6e03392 |
| n-api: remove n-api module loading flag | https://github.com/Qard/ayo/commit/6e03392d3d9894f7dabb4fa3e97ea1c77ea11e0f |
| 6e03392 | https://github.com/Qard/ayo/commit/6e03392d3d9894f7dabb4fa3e97ea1c77ea11e0f |
| nodejs/vm#9 | https://github.com/nodejs/vm/issues/9 |
| nodejs/node#14902 | https://github.com/nodejs/node/pull/14902 |
| Qard | https://github.com/Qard |
|
Sep 21, 2017
| https://github.com/nodejs/node/pull/14902#ref-commit-c859a10 |
| n-api: remove n-api module loading flag | https://github.com/Qard/ayo/commit/c859a10dd7ce3a9227752dffb140529d5636e129 |
| c859a10 | https://github.com/Qard/ayo/commit/c859a10dd7ce3a9227752dffb140529d5636e129 |
| nodejs/vm#9 | https://github.com/nodejs/vm/issues/9 |
| nodejs/node#14902 | https://github.com/nodejs/node/pull/14902 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| September 25, 2017 09:20 | https://github.com/nodejs/node/pull/14902#event-1263308256 |
| jasnell | https://github.com/jasnell |
|
Sep 25, 2017
| https://github.com/nodejs/node/pull/14902#ref-commit-883cd78 |
|
| https://github.com/jasnell |
| 2017-09-26, Node.js Version 8.6.0 (Current) | https://github.com/nodejs/node/commit/883cd785d30d4e60e179805d79a8f73ac5068f38 |
| 883cd78 | https://github.com/nodejs/node/commit/883cd785d30d4e60e179805d79a8f73ac5068f38 |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| @sebdeckers | https://github.com/sebdeckers |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| jasnell | https://github.com/jasnell |
|
Sep 26, 2017
| https://github.com/nodejs/node/pull/14902#ref-commit-b48ff2a |
|
| https://github.com/jasnell |
| 2017-09-26, Node.js Version 8.6.0 (Current) | https://github.com/nodejs/node/commit/b48ff2aa1e57e761fa0825e3dc78105a0d016e16 |
| b48ff2a | https://github.com/nodejs/node/commit/b48ff2aa1e57e761fa0825e3dc78105a0d016e16 |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #14560 | https://github.com/nodejs/node/pull/14560 |
| #14560 | https://github.com/nodejs/node/pull/14560 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| @sebdeckers | https://github.com/sebdeckers |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| jasnell | https://github.com/jasnell |
|
Sep 26, 2017
| https://github.com/nodejs/node/pull/14902#ref-commit-05e4c1d |
|
| https://github.com/jasnell |
| 2017-09-26, Node.js Version 8.6.0 (Current) | https://github.com/nodejs/node/commit/05e4c1d6bcc6499c23d47b57f97038117341a5eb |
| 05e4c1d | https://github.com/nodejs/node/commit/05e4c1d6bcc6499c23d47b57f97038117341a5eb |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #14560 | https://github.com/nodejs/node/pull/14560 |
| #14560 | https://github.com/nodejs/node/pull/14560 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| @sebdeckers | https://github.com/sebdeckers |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 29, 2017
| https://github.com/nodejs/node/pull/14902#ref-commit-8f07f00 |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
| 2017-09-26, Node.js Version 8.6.0 (Current) | https://github.com/nodejs/node/commit/8f07f00df0fed592c1902b66b524bb898db29fad |
| 8f07f00 | https://github.com/nodejs/node/commit/8f07f00df0fed592c1902b66b524bb898db29fad |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #15206 | https://github.com/nodejs/node/pull/15206 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #7855 | https://github.com/nodejs/node/pull/7855 |
| #14560 | https://github.com/nodejs/node/pull/14560 |
| #14560 | https://github.com/nodejs/node/pull/14560 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| #14245 | https://github.com/nodejs/node/pull/14245 |
| @sebdeckers | https://github.com/sebdeckers |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| #15354 | https://github.com/nodejs/node/pull/15354 |
| addaleax | https://github.com/addaleax |
|
Sep 30, 2017
| https://github.com/nodejs/node/pull/14902#ref-commit-b7374d9 |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
| 2017-09-26, Node.js Version 8.6.0 (Current) | https://github.com/addaleax/ayo/commit/b7374d9c36d562c47b90b490dab5bfc7e0a74e9f |
| b7374d9 | https://github.com/addaleax/ayo/commit/b7374d9c36d562c47b90b490dab5bfc7e0a74e9f |
| nodejs/node#15206 | https://github.com/nodejs/node/pull/15206 |
| nodejs/node#7855 | https://github.com/nodejs/node/pull/7855 |
| nodejs/node#14560 | https://github.com/nodejs/node/pull/14560 |
| nodejs/node#14902 | https://github.com/nodejs/node/pull/14902 |
| nodejs/node#14245 | https://github.com/nodejs/node/pull/14245 |
| @sebdeckers | https://github.com/sebdeckers |
| nodejs/node#15354 | https://github.com/nodejs/node/pull/15354 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Oct 17, 2017 | https://github.com/nodejs/node/pull/14902#event-1296126012 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/14902#ref-commit-a61dd4b |
| n-api: remove n-api module loading flag | https://github.com/gabrielschulhof/node/commit/a61dd4b6300ff2a3c2d964d2d3388731789f0fb4 |
| a61dd4b | https://github.com/gabrielschulhof/node/commit/a61dd4b6300ff2a3c2d964d2d3388731789f0fb4 |
| nodejs/vm#9 | https://github.com/nodejs/vm/issues/9 |
| nodejs#14902 | https://github.com/nodejs/node/pull/14902 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/14902#ref-issue-314760864 |
|
documentation of --napi-modules
#20082
| https://github.com/nodejs/node/issues/20082 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/14902#ref-commit-5e29823 |
|
| https://github.com/MylesBorins |
| n-api: remove n-api module loading flag | https://github.com/nodejs/node/commit/5e29823d1d392218050bebfba9f68f569c9e5128 |
| 5e29823 | https://github.com/nodejs/node/commit/5e29823d1d392218050bebfba9f68f569c9e5128 |
| nodejs/vm#9 | https://github.com/nodejs/vm/issues/9 |
| #19447 | https://github.com/nodejs/node/pull/19447 |
| #14902 | https://github.com/nodejs/node/pull/14902 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/14902#ref-pullrequest-313968187 |
|
v6.14.2 proposal
#19996
| https://github.com/nodejs/node/pull/19996 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 18, 2018
| https://github.com/nodejs/node/pull/14902#ref-pullrequest-315207132 |
|
src: kickstart addon by calling its constructor
#20114
| https://github.com/nodejs/node/pull/20114 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 25, 2018
| https://github.com/nodejs/node/pull/14902#ref-pullrequest-317730700 |
|
n-api: update cli documentation
#20301
| https://github.com/nodejs/node/pull/20301 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14902 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/14902/files/513fe34cbaa1a756686e420318f5c65c13422b84 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/14902/files/9b783633a0fe12410f8e94c96a7f7fd51e264b6e |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/14902/files/513fe34cbaa1a756686e420318f5c65c13422b84 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/14902/files/513fe34cbaa1a756686e420318f5c65c13422b84 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/14902/files/513fe34cbaa1a756686e420318f5c65c13422b84 |
|
| https://github.com/digitalinfinity |
|
digitalinfinity
| https://github.com/digitalinfinity |
|
| https://github.com/nodejs/node/pull/14902/files/513fe34cbaa1a756686e420318f5c65c13422b84 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/14902/files/9b783633a0fe12410f8e94c96a7f7fd51e264b6e |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/14902 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/refack |
|
| https://github.com/mhdawson |
|
| https://github.com/digitalinfinity |
|
| https://github.com/BridgeAR |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |