René's URL Explorer Experiment


Title: https: disallow boolean types for `key` and `cert` options by jimmycann · Pull Request #14807 · nodejs/node · GitHub

Open Graph Title: https: disallow boolean types for `key` and `cert` options by jimmycann · Pull Request #14807 · nodejs/node

X Title: https: disallow boolean types for `key` and `cert` options by jimmycann · Pull Request #14807 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is my first PR on the Node repository, your feedback is greatly appreciated. When using https.createServer, passing boolean values for key and cert properties in the options object parameter d...

X Description: This is my first PR on the Node repository, your feedback is greatly appreciated. When using https.createServer, passing boolean values for key and cert properties in the options object parameter d...

Opengraph URL: https://github.com/nodejs/node/pull/14807

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9993a03f-c50e-1d29-b030-c80150fd2c52
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8FE:50919:4E1D5AF:6C8ED79:6A4F6943
html-safe-nonce580922a6bd386c82396fb71eb9ca4d387c6d980c3494bb2137251179ea3158ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEZFOjUwOTE5OjRFMUQ1QUY6NkM4RUQ3OTo2QTRGNjk0MyIsInZpc2l0b3JfaWQiOiI4MTI0MDAzMTU4Mzk1NDE0ODUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb645e74ea64e8a198ec1ac059179a87d6dcd8804183eb30bd95ef336dcc3d33
hovercard-subject-tagpull_request:135495969
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14807/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/10a5a20f143110a16cafec6700c784946aba0863c913adf947a966169dc1856d/nodejs/node/pull/14807
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/10a5a20f143110a16cafec6700c784946aba0863c913adf947a966169dc1856d/nodejs/node/pull/14807
og:image:altThis is my first PR on the Node repository, your feedback is greatly appreciated. When using https.createServer, passing boolean values for key and cert properties in the options object parameter d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejimmycann
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/14807#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14807
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14807
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/14807
Reloadhttps://github.com/nodejs/node/pull/14807
Reloadhttps://github.com/nodejs/node/pull/14807
Please reload this pagehttps://github.com/nodejs/node/pull/14807
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/14807
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jimmycannhttps://github.com/jimmycann
nodejs:masterhttps://github.com/nodejs/node/tree/master
jimmycann:issue/12802https://github.com/jimmycann/node/tree/issue/12802
Conversationhttps://github.com/nodejs/node/pull/14807
Commits4 (4)https://github.com/nodejs/node/pull/14807/commits
Checkshttps://github.com/nodejs/node/pull/14807/checks
Files changedhttps://github.com/nodejs/node/pull/14807/files
https: disallow boolean types for key and cert optionshttps://github.com/nodejs/node/pull/14807#top
jimmycannhttps://github.com/jimmycann
nodejs:masterhttps://github.com/nodejs/node/tree/master
jimmycann:issue/12802https://github.com/jimmycann/node/tree/issue/12802
https://github.com/jimmycann
jimmycannhttps://github.com/jimmycann
Aug 13, 2017https://github.com/nodejs/node/pull/14807#issue-249877175
#12802https://github.com/nodejs/node/issues/12802
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/jimmycann
https: disallow boolean types for key and cert optionshttps://github.com/nodejs/node/pull/14807/commits/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
262d4b2https://github.com/nodejs/node/pull/14807/commits/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
nodejs#12802https://github.com/nodejs/node/issues/12802
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
https https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps
Aug 13, 2017https://github.com/nodejs/node/pull/14807#event-1203905377
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 13, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-55967730
View reviewed changes https://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
lib/https.jshttps://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944
addaleaxhttps://github.com/addaleax
Aug 13, 2017https://github.com/nodejs/node/pull/14807#discussion_r132843877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
new error systemhttps://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md
Please reload this pagehttps://github.com/nodejs/node/pull/14807
test/parallel/test-https-options-boolean-check.jshttps://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f#diff-db68b2f6d9616ff181037ddff7d85b358c233bcc498777e815d95b3a931240bb
addaleaxhttps://github.com/addaleax
Aug 13, 2017https://github.com/nodejs/node/pull/14807#discussion_r132843882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/refack
refackhttps://github.com/refack
Aug 13, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322046830
Please reload this pagehttps://github.com/nodejs/node/pull/14807
@yjimkhttps://github.com/yjimk
documentationhttps://nodejs.org/api/tls.html#tls_tls_createsecurecontext_options
node/lib/_tls_common.jshttps://github.com/nodejs/node/blob/262d4b29cba3650ac6d826149e1a7e5e2a2a087f/lib/_tls_common.js#L84-L107
262d4b2https://github.com/nodejs/node/commit/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
node/lib/path.jshttps://github.com/nodejs/node/blob/262d4b29cba3650ac6d826149e1a7e5e2a2a087f/lib/path.js#L28
262d4b2https://github.com/nodejs/node/commit/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
https://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.mdhttps://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-55969654
View reviewed changes https://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/14807#pullrequestreview-55969654
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@yjimkhttps://github.com/yjimk
Please reload this pagehttps://github.com/nodejs/node/pull/14807
lib/https.jshttps://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944
Trotthttps://github.com/Trott
Aug 13, 2017https://github.com/nodejs/node/pull/14807#discussion_r132845984
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
Trotthttps://github.com/Trott
Aug 13, 2017https://github.com/nodejs/node/pull/14807#discussion_r132846014
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
test/parallel/test-https-options-boolean-check.jshttps://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f#diff-db68b2f6d9616ff181037ddff7d85b358c233bcc498777e815d95b3a931240bb
Trotthttps://github.com/Trott
Aug 13, 2017https://github.com/nodejs/node/pull/14807#discussion_r132846078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
lib/https.jshttps://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f#diff-494d2deee304c672124ecd82d090283595fd3d8c5a80a1825d972a2d229e4944
Trotthttps://github.com/Trott
Aug 13, 2017https://github.com/nodejs/node/pull/14807#discussion_r132846086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 13, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-55971147
View reviewed changes https://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
cjihrighttps://github.com/cjihrig
https://github.com/nodejs/node/pull/14807#pullrequestreview-55971147
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
test/parallel/test-https-options-boolean-check.jshttps://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f#diff-db68b2f6d9616ff181037ddff7d85b358c233bcc498777e815d95b3a931240bb
cjihrighttps://github.com/cjihrig
Aug 13, 2017https://github.com/nodejs/node/pull/14807#discussion_r132847686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 13, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322061737
Please reload this pagehttps://github.com/nodejs/node/pull/14807
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/jimmycann
jimmycannhttps://github.com/jimmycann
Aug 13, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322067103
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/jimmycann
tls: disallow boolean types for key, cert and ca optionshttps://github.com/nodejs/node/pull/14807/commits/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde
e92e64ahttps://github.com/nodejs/node/pull/14807/commits/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde
nodejs#12802https://github.com/nodejs/node/issues/12802
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/14807#pullrequestreview-55969654
August 14, 2017 21:20https://github.com/nodejs/node/pull/14807#event-1205552150
https://github.com/jimmycann
jimmycannhttps://github.com/jimmycann
Aug 15, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322347544
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 15, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56241641
View reviewed changes https://github.com/nodejs/node/pull/14807/files/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde
lib/_tls_common.jshttps://github.com/nodejs/node/pull/14807/files/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
addaleaxhttps://github.com/addaleax
Aug 15, 2017https://github.com/nodejs/node/pull/14807#discussion_r133097150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
jimmycannhttps://github.com/jimmycann
Aug 15, 2017https://github.com/nodejs/node/pull/14807#discussion_r133098863
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
addaleaxhttps://github.com/addaleax
Aug 15, 2017https://github.com/nodejs/node/pull/14807#discussion_r133165075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/lib/zlib.jshttps://github.com/nodejs/node/blob/cde272a066923a1b93a10a8121b0ce572308d13c/lib/zlib.js#L231
cde272ahttps://github.com/nodejs/node/commit/cde272a066923a1b93a10a8121b0ce572308d13c
Please reload this pagehttps://github.com/nodejs/node/pull/14807
jimmycannhttps://github.com/jimmycann
Aug 15, 2017https://github.com/nodejs/node/pull/14807#discussion_r133304655
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
stale reviewhttps://github.com/nodejs/node/pull/14807#pullrequestreview-55967730
August 15, 2017 00:52https://github.com/nodejs/node/pull/14807#event-1205762225
https://github.com/jasnell
jasnellhttps://github.com/jasnell
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Aug 16, 2017https://github.com/nodejs/node/pull/14807#event-1207664807
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 16, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56537885
View reviewed changes https://github.com/nodejs/node/pull/14807/files/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde
test/parallel/test-https-options-boolean-check.jshttps://github.com/nodejs/node/pull/14807/files/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde#diff-db68b2f6d9616ff181037ddff7d85b358c233bcc498777e815d95b3a931240bb
jasnellhttps://github.com/jasnell
Aug 16, 2017https://github.com/nodejs/node/pull/14807#discussion_r133366720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
jimmycannhttps://github.com/jimmycann
Aug 16, 2017https://github.com/nodejs/node/pull/14807#discussion_r133410798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/fl0w
fl0whttps://github.com/fl0w
Aug 16, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322720139
#12802https://github.com/nodejs/node/issues/12802
e92e64ahttps://github.com/nodejs/node/commit/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/jimmycann
jimmycannhttps://github.com/jimmycann
Aug 16, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322728002
@fl0whttps://github.com/fl0w
https://twitter.com/_ericelliott/status/710571765844615168https://twitter.com/_ericelliott/status/710571765844615168
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/jimmycann
tls: type checking for key, cert and ca optionshttps://github.com/nodejs/node/pull/14807/commits/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
b132c96https://github.com/nodejs/node/pull/14807/commits/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
nodejs#12802https://github.com/nodejs/node/issues/12802
https://github.com/jimmycann
jimmycannhttps://github.com/jimmycann
Aug 16, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322742302
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 16, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56674700
View reviewed changes https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
lib/_tls_common.jshttps://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
silverwindhttps://github.com/silverwind
Aug 16, 2017https://github.com/nodejs/node/pull/14807#discussion_r133488004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 16, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56675024
View reviewed changes https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
lib/_tls_common.jshttps://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
silverwindhttps://github.com/silverwind
Aug 16, 2017https://github.com/nodejs/node/pull/14807#discussion_r133488291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 16, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56675399
View reviewed changes https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
lib/_tls_common.jshttps://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a#diff-e16679ca1a0c18eb3e587384f11d0710a78e379e50a102b9cffd53551fc37848
silverwindhttps://github.com/silverwind
Aug 16, 2017https://github.com/nodejs/node/pull/14807#discussion_r133488609
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 16, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56676389
View reviewed changes https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
silverwindhttps://github.com/silverwind
https://github.com/nodejs/node/pull/14807#pullrequestreview-56676389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 16, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56676604
View reviewed changes https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Aug 16, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322816668
@fl0whttps://github.com/fl0w
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 16, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-56743713
View reviewed changes https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
https://github.com/jimmycann
jimmycannhttps://github.com/jimmycann
Aug 16, 2017https://github.com/nodejs/node/pull/14807#issuecomment-322901779
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/jimmycann
tls: type checking for key, cert and ca optionshttps://github.com/nodejs/node/pull/14807/commits/c46fdd41dd02bd14ee84d313db6c0b71402c1354
c46fdd4https://github.com/nodejs/node/pull/14807/commits/c46fdd41dd02bd14ee84d313db6c0b71402c1354
nodejs#12802https://github.com/nodejs/node/issues/12802
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 23, 2017https://github.com/nodejs/node/pull/14807#issuecomment-324422613
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017 https://github.com/nodejs/node/pull/14807#pullrequestreview-58823089
View reviewed changes https://github.com/nodejs/node/pull/14807/files/c46fdd41dd02bd14ee84d313db6c0b71402c1354
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017https://github.com/nodejs/node/pull/14807#issuecomment-325199823
a7dccd0https://github.com/nodejs/node/commit/a7dccd040d72ce7de61d9160ec031420c52a49d4
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017https://github.com/nodejs/node/pull/14807#event-1222799189
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017 https://github.com/nodejs/node/pull/14807#ref-commit-a7dccd0
https://github.com/jimmycann
https://github.com/BridgeAR
tls: type checking for key, cert and ca optionshttps://github.com/nodejs/node/commit/a7dccd040d72ce7de61d9160ec031420c52a49d4
https://github.com/nodejs/node/commit/a7dccd040d72ce7de61d9160ec031420c52a49d4#comments
a7dccd0https://github.com/nodejs/node/commit/a7dccd040d72ce7de61d9160ec031420c52a49d4
#14807https://github.com/nodejs/node/pull/14807
#12802https://github.com/nodejs/node/issues/12802
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 27, 2017 https://github.com/nodejs/node/pull/14807#ref-pullrequest-253170723
tls: replace forEach with for #15053 https://github.com/nodejs/node/pull/15053
Aug 30, 2017 https://github.com/nodejs/node/pull/14807#ref-commit-ce34c06
https://github.com/jimmycann
tls: type checking for key, cert and ca optionshttps://github.com/ayojs/ayo/commit/ce34c06347584499adc5c77a7b745e36f8fdf79b
ce34c06https://github.com/ayojs/ayo/commit/ce34c06347584499adc5c77a7b745e36f8fdf79b
nodejs/node#14807https://github.com/nodejs/node/pull/14807
nodejs/node#12802https://github.com/nodejs/node/issues/12802
Aug 30, 2017 https://github.com/nodejs/node/pull/14807#ref-commit-5ecd08c
https://github.com/jimmycann
tls: type checking for key, cert and ca optionshttps://github.com/ayojs/ayo/commit/5ecd08cc80a8185a12b28ed1fc4b9015dc7eaa21
5ecd08chttps://github.com/ayojs/ayo/commit/5ecd08cc80a8185a12b28ed1fc4b9015dc7eaa21
nodejs/node#14807https://github.com/nodejs/node/pull/14807
nodejs/node#12802https://github.com/nodejs/node/issues/12802
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/14807#ref-commit-6891ac2
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
6891ac2https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14807#ref-commit-7165af5
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
7165af5https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14807#ref-commit-a618552
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
a618552https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14807#ref-commit-8d28704
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
8d28704https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/14807#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14807
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/14807/files/e92e64ade76c21a7d1cc1b96a68cfbda283c8fde
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/14807/files/c46fdd41dd02bd14ee84d313db6c0b71402c1354
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/14807/files/262d4b29cba3650ac6d826149e1a7e5e2a2a087f
https://github.com/silverwind
silverwind https://github.com/silverwind
https://github.com/nodejs/node/pull/14807/files/b132c96673b37f6b3e3baf4c8a6c7eeb49106f9a
https https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/14807
https://github.com/jimmycann
https://github.com/refack
https://github.com/silverwind
https://github.com/fl0w
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com/Trott
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.