René's URL Explorer Experiment


Title: url: drop auth in `url.resolve()` if host changes by rlidwka · Pull Request #1480 · nodejs/node · GitHub

Open Graph Title: url: drop auth in `url.resolve()` if host changes by rlidwka · Pull Request #1480 · nodejs/node

X Title: url: drop auth in `url.resolve()` if host changes by rlidwka · Pull Request #1480 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: #1435 Not sure how to handle this though.

X Description: #1435 Not sure how to handle this though.

Opengraph URL: https://github.com/nodejs/node/pull/1480

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6a7c32bf-542d-079c-e73b-eefc0e04eeb8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAACC:278EE8:2AE2E:39784:6A527DD2
html-safe-nonceb4cda926e6317c86105c921346894fb780aa2425b78bd24bfe4e1a85c59410b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUNDOjI3OEVFODoyQUUyRTozOTc4NDo2QTUyN0REMiIsInZpc2l0b3JfaWQiOiIxMzUyNTQwMjQzMzAwMDg5Mjk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4a7fd5120a60f6913362db4c450910def0d1ba5fe51f5c564f4e89b1d1b5adeb
hovercard-subject-tagpull_request:33708177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1480/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/99976dc9e77c74ee44241abeb7e866f849ef5123f7bd5395b5caf59e505d06de/nodejs/node/pull/1480
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99976dc9e77c74ee44241abeb7e866f849ef5123f7bd5395b5caf59e505d06de/nodejs/node/pull/1480
og:image:alt#1435 Not sure how to handle this though.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerlidwka
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1480#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1480
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1480
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1480
Reloadhttps://github.com/nodejs/node/pull/1480
Reloadhttps://github.com/nodejs/node/pull/1480
Please reload this pagehttps://github.com/nodejs/node/pull/1480
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1480
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 986 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
rlidwkahttps://github.com/rlidwka
nodejs:masterhttps://github.com/nodejs/node/tree/master
rlidwka:authhttps://github.com/rlidwka/io.js/tree/auth
Conversationhttps://github.com/nodejs/node/pull/1480
Commits1 (1)https://github.com/nodejs/node/pull/1480/commits
Checkshttps://github.com/nodejs/node/pull/1480/checks
Files changedhttps://github.com/nodejs/node/pull/1480/files
url: drop auth in url.resolve() if host changeshttps://github.com/nodejs/node/pull/1480#top
rlidwkahttps://github.com/rlidwka
nodejs:masterhttps://github.com/nodejs/node/tree/master
rlidwka:authhttps://github.com/rlidwka/io.js/tree/auth
https://github.com/rlidwka
rlidwkahttps://github.com/rlidwka
Apr 20, 2015https://github.com/nodejs/node/pull/1480#issue-69685660
#1435https://github.com/nodejs/node/issues/1435
thishttps://github.com/iojs/io.js/issues/1435#issuecomment-94554166
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/rlidwka
url: drop auth in url.resolve() if host changeshttps://github.com/nodejs/node/pull/1480/commits/837b7defa3f279b30a2615301e48bc6068220591
837b7dehttps://github.com/nodejs/node/pull/1480/commits/837b7defa3f279b30a2615301e48bc6068220591
nodejs#1435https://github.com/nodejs/node/issues/1435
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Apr 20, 2015https://github.com/nodejs/node/pull/1480#event-285630012
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
May 6, 2015https://github.com/nodejs/node/pull/1480#issuecomment-99271080
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581
311c3e4https://github.com/nodejs/node/commit/311c3e4371ee520a977a7e895c280f326cb85732
b926718https://github.com/nodejs/node/commit/b9267189a58e48e587faec78a5e83b6bbfc72581
Compare https://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581
June 2, 2015 17:25https://github.com/nodejs/node/pull/1480#event-320249123
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7..628a3ab0930c8500483aa72a340e503cda41cf0b
9d21135https://github.com/nodejs/node/commit/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7
628a3abhttps://github.com/nodejs/node/commit/628a3ab0930c8500483aa72a340e503cda41cf0b
Compare https://github.com/nodejs/node/compare/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7..628a3ab0930c8500483aa72a340e503cda41cf0b
June 25, 2015 09:18https://github.com/nodejs/node/pull/1480#event-339839112
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jul 21, 2015https://github.com/nodejs/node/pull/1480#issuecomment-123176737
@domenichttps://github.com/domenic
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/domenic
domenichttps://github.com/domenic
Jul 21, 2015https://github.com/nodejs/node/pull/1480#issuecomment-123177136
https://github.com/jsdom/whatwg-urlhttps://github.com/jsdom/whatwg-url
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jul 22, 2015https://github.com/nodejs/node/pull/1480#issuecomment-123815981
@domenichttps://github.com/domenic
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/indutny
indutnyhttps://github.com/indutny
force-pushedhttps://github.com/nodejs/node/compare/bffb20424cf236dd5291f8d627e80968e492b1ba..eb35968de7a040d737f3280e9fed0b6edf566b2b
bffb204https://github.com/nodejs/node/commit/bffb20424cf236dd5291f8d627e80968e492b1ba
eb35968https://github.com/nodejs/node/commit/eb35968de7a040d737f3280e9fed0b6edf566b2b
Compare https://github.com/nodejs/node/compare/bffb20424cf236dd5291f8d627e80968e492b1ba..eb35968de7a040d737f3280e9fed0b6edf566b2b
July 22, 2015 21:21https://github.com/nodejs/node/pull/1480#event-362764363
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db
11c25c2https://github.com/nodejs/node/commit/11c25c28e266dd89ce6744ed7a23f2576c1bb103
ba02bd0https://github.com/nodejs/node/commit/ba02bd02e91773be161e03a9ed67745fba8f22db
Compare https://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db
September 6, 2015 11:55https://github.com/nodejs/node/pull/1480#event-402153115
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 22, 2015https://github.com/nodejs/node/pull/1480#issuecomment-150085789
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 16, 2015https://github.com/nodejs/node/pull/1480#issuecomment-156909166
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/dougwilson
dougwilsonhttps://github.com/dougwilson
Nov 16, 2015https://github.com/nodejs/node/pull/1480#issuecomment-156927073
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 18, 2015 https://github.com/nodejs/node/pull/1480#ref-pullrequest-117492542
url: don't keep auth information when changing host #3893 https://github.com/nodejs/node/pull/3893
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/1e896a69fae430b3221610cc50294a6563ad198d..082cc8d6d8f5c7c797e58cefeb475b783c730635
1e896a6https://github.com/nodejs/node/commit/1e896a69fae430b3221610cc50294a6563ad198d
082cc8dhttps://github.com/nodejs/node/commit/082cc8d6d8f5c7c797e58cefeb475b783c730635
Compare https://github.com/nodejs/node/compare/1e896a69fae430b3221610cc50294a6563ad198d..082cc8d6d8f5c7c797e58cefeb475b783c730635
December 27, 2015 02:00https://github.com/nodejs/node/pull/1480#event-500827983
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 22, 2016https://github.com/nodejs/node/pull/1480#issuecomment-213629317
https://ci.nodejs.org/job/node-test-pull-request/2370/https://ci.nodejs.org/job/node-test-pull-request/2370/
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/jasnell
jasnellhttps://github.com/jasnell
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Apr 22, 2016https://github.com/nodejs/node/pull/1480#event-638378018
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 22, 2016https://github.com/nodejs/node/pull/1480#issuecomment-213629590
Please reload this pagehttps://github.com/nodejs/node/pull/1480
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/jasnell
jasnellhttps://github.com/jasnell
6.0.0https://github.com/nodejs/node/milestone/13
Apr 22, 2016https://github.com/nodejs/node/pull/1480#event-638379390
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 23, 2016https://github.com/nodejs/node/pull/1480#issuecomment-213633916
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 25, 2016https://github.com/nodejs/node/pull/1480#issuecomment-214441283
@mscdexhttps://github.com/mscdex
@cjihrighttps://github.com/cjihrig
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/1480
mscdexhttps://github.com/mscdex
Apr 25, 2016 https://github.com/nodejs/node/pull/1480#discussion-diff-60952437
View reviewed changes https://github.com/nodejs/node/pull/1480/files/837b7defa3f279b30a2615301e48bc6068220591#diff-b150f5a605b5fc69c2d99ece78558afd3d3e1ae81924adab8c8aad8accdd5361
test/parallel/test-url.jshttps://github.com/nodejs/node/pull/1480/files#diff-b150f5a605b5fc69c2d99ece78558afd3d3e1ae81924adab8c8aad8accdd5361
mscdexhttps://github.com/mscdex
Apr 25, 2016https://github.com/nodejs/node/pull/1480#discussion_r60952437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1480
jasnellhttps://github.com/jasnell
Apr 25, 2016https://github.com/nodejs/node/pull/1480#discussion_r60953147
Please reload this pagehttps://github.com/nodejs/node/pull/1480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 25, 2016https://github.com/nodejs/node/pull/1480#issuecomment-214452691
Please reload this pagehttps://github.com/nodejs/node/pull/1480
jasnellhttps://github.com/jasnell
Apr 25, 2016 https://github.com/nodejs/node/pull/1480#ref-commit-eb4201f
https://github.com/rlidwka
https://github.com/jasnell
url: drop auth in url.resolve() if host changeshttps://github.com/nodejs/node/commit/eb4201f07a1b1f430ddf4efad4f276f3088def97
eb4201fhttps://github.com/nodejs/node/commit/eb4201f07a1b1f430ddf4efad4f276f3088def97
#1435https://github.com/nodejs/node/issues/1435
#1480https://github.com/nodejs/node/pull/1480
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 25, 2016https://github.com/nodejs/node/pull/1480#issuecomment-214455030
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 25, 2016https://github.com/nodejs/node/pull/1480#event-640366524
jasnellhttps://github.com/jasnell
Apr 26, 2016 https://github.com/nodejs/node/pull/1480#ref-commit-1b50b80
https://github.com/rlidwka
https://github.com/jasnell
url: drop auth in url.resolve() if host changeshttps://github.com/nodejs/node/commit/1b50b80e06db48ad51f7038dc0faedea94d96054
1b50b80https://github.com/nodejs/node/commit/1b50b80e06db48ad51f7038dc0faedea94d96054
#1435https://github.com/nodejs/node/issues/1435
#1480https://github.com/nodejs/node/pull/1480
https://github.com/msakrejda
msakrejdahttps://github.com/msakrejda
Aug 18, 2016 https://github.com/nodejs/node/pull/1480#ref-issue-171977963
url.resolve auth behavior if host does *not* change #8165 https://github.com/nodejs/node/issues/8165
https://github.com/imyller
imyllerhttps://github.com/imyller
Aug 21, 2016 https://github.com/nodejs/node/pull/1480#ref-pullrequest-172340708
url: keep auth in url.resolve() if host matches #8215 https://github.com/nodejs/node/pull/8215
https://github.com/msakrejda
msakrejdahttps://github.com/msakrejda
Aug 31, 2016 https://github.com/nodejs/node/pull/1480#ref-issue-171797418
Auth lost on redirect to same host in node 6.3.1 follow-redirects/follow-redirects#42 https://github.com/follow-redirects/follow-redirects/issues/42
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1480
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
6.0.0 https://github.com/nodejs/node/milestone/13
Please reload this pagehttps://github.com/nodejs/node/pull/1480
https://github.com/rlidwka
https://github.com/brendanashworth
https://github.com/domenic
https://github.com/trevnorris
https://github.com/jasnell
https://github.com/dougwilson
https://github.com/mscdex
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.