René's URL Explorer Experiment


Title: timers: Migrate to use internal/errors by starkwang · Pull Request #14659 · nodejs/node · GitHub

Open Graph Title: timers: Migrate to use internal/errors by starkwang · Pull Request #14659 · nodejs/node

X Title: timers: Migrate to use internal/errors by starkwang · Pull Request #14659 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: ref: #11273 Migrate the timers module to use internal/errors. And some tests are added for timers.enroll(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchm...

X Description: ref: #11273 Migrate the timers module to use internal/errors. And some tests are added for timers.enroll(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchm...

Opengraph URL: https://github.com/nodejs/node/pull/14659

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bf44212d-04df-bcdf-d4e3-870afc19e631
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABC8:18EF1B:49FFEC8:66FB32B:6A4F7D15
html-safe-nonce4c5ae2d79627f691eccde1913cea263cab8f56f31ea21d22e60894af1e51a1f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkM4OjE4RUYxQjo0OUZGRUM4OjY2RkIzMkI6NkE0RjdEMTUiLCJ2aXNpdG9yX2lkIjoiMjE1MjI3NDYzNDI2MjY3NDcwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace015a550215e3dcf84291c20d34a0d310fb855edf2377db1f321db148c4fd616
hovercard-subject-tagpull_request:134374438
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14659/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a9b86c86566117102214134095197c3cdc917a5b1488e8438faedc28c73e855d/nodejs/node/pull/14659
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a9b86c86566117102214134095197c3cdc917a5b1488e8438faedc28c73e855d/nodejs/node/pull/14659
og:image:altref: #11273 Migrate the timers module to use internal/errors. And some tests are added for timers.enroll(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestarkwang
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/14659#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14659
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14659
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/14659
Reloadhttps://github.com/nodejs/node/pull/14659
Reloadhttps://github.com/nodejs/node/pull/14659
Please reload this pagehttps://github.com/nodejs/node/pull/14659
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/14659
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
starkwanghttps://github.com/starkwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
starkwang:timers-internal-errorshttps://github.com/starkwang/node/tree/timers-internal-errors
Conversationhttps://github.com/nodejs/node/pull/14659
Commits1 (1)https://github.com/nodejs/node/pull/14659/commits
Checkshttps://github.com/nodejs/node/pull/14659/checks
Files changedhttps://github.com/nodejs/node/pull/14659/files
timers: Migrate to use internal/errorshttps://github.com/nodejs/node/pull/14659#top
starkwanghttps://github.com/starkwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
starkwang:timers-internal-errorshttps://github.com/starkwang/node/tree/timers-internal-errors
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Aug 7, 2017https://github.com/nodejs/node/pull/14659#issue-248325004
Please reload this pagehttps://github.com/nodejs/node/pull/14659
#11273https://github.com/nodejs/node/issues/11273
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Aug 7, 2017https://github.com/nodejs/node/pull/14659#event-1194884754
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 7, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-54608707
View reviewed changes https://github.com/nodejs/node/pull/14659/files
lib/timers.jshttps://github.com/nodejs/node/pull/14659/files#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
tniessenhttps://github.com/tniessen
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131612983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
refackhttps://github.com/refack
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131638878
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
starkwanghttps://github.com/starkwang
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131643585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/lib/buffer.js#L244https://github.com/nodejs/node/blob/master/lib/buffer.js#L244
Please reload this pagehttps://github.com/nodejs/node/pull/14659
refackhttps://github.com/refack
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131643984
Please reload this pagehttps://github.com/nodejs/node/pull/14659
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
test/parallel/test-timers-enroll-invalid-msecs.jshttps://github.com/nodejs/node/pull/14659/files#diff-111b62f4996c207122b2a9d8d1ddf48869fd903ccc3563049a333e97cf88b1cd
tniessenhttps://github.com/tniessen
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131613057
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/tniessen
tniessenhttps://github.com/tniessen
stale reviewhttps://github.com/nodejs/node/pull/14659#pullrequestreview-54608707
August 7, 2017 09:48https://github.com/nodejs/node/pull/14659#event-1195103997
https://github.com/refack
refackhttps://github.com/refack
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Aug 7, 2017https://github.com/nodejs/node/pull/14659#event-1195290418
https://github.com/refack
refackhttps://github.com/refack
Aug 7, 2017https://github.com/nodejs/node/pull/14659#event-1195290475
https://github.com/starkwang
starkwanghttps://github.com/starkwang
force-pushedhttps://github.com/nodejs/node/compare/46172ab8ec6f364bbf2b4d348eab3568cb165bae..65cd92aa0624a5709941d696058df6d8bf89639a
46172abhttps://github.com/nodejs/node/commit/46172ab8ec6f364bbf2b4d348eab3568cb165bae
65cd92ahttps://github.com/nodejs/node/commit/65cd92aa0624a5709941d696058df6d8bf89639a
Compare https://github.com/nodejs/node/compare/46172ab8ec6f364bbf2b4d348eab3568cb165bae..65cd92aa0624a5709941d696058df6d8bf89639a
August 7, 2017 15:33https://github.com/nodejs/node/pull/14659#event-1195630250
https://github.com/refack
refackhttps://github.com/refack
Aug 7, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-54697500
View reviewed changes https://github.com/nodejs/node/pull/14659/files
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/14659#pullrequestreview-54697500
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/refack
refackhttps://github.com/refack
Aug 7, 2017https://github.com/nodejs/node/pull/14659#issuecomment-320704124
https://ci.nodejs.org/job/node-test-pull-request/9519/https://ci.nodejs.org/job/node-test-pull-request/9519/
@jasnellhttps://github.com/jasnell
@fhinkelhttps://github.com/fhinkel
@Trotthttps://github.com/Trott
@mhdawsonhttps://github.com/mhdawson
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 7, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-54723188
View reviewed changes https://github.com/nodejs/node/pull/14659/files
lib/internal/errors.jshttps://github.com/nodejs/node/pull/14659/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
tniessenhttps://github.com/tniessen
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131716888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
test/parallel/test-internal-errors.jshttps://github.com/nodejs/node/pull/14659/files#diff-dee890a54d8682024c7107ca5fd0f8c219e16a2bf63a5be96a92bfaf851fc25c
tniessenhttps://github.com/tniessen
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131717359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/refack
refackhttps://github.com/refack
Aug 7, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-54724928
View reviewed changes https://github.com/nodejs/node/pull/14659/files
lib/internal/errors.jshttps://github.com/nodejs/node/pull/14659/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
refackhttps://github.com/refack
Aug 7, 2017https://github.com/nodejs/node/pull/14659#discussion_r131718482
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/starkwang
starkwanghttps://github.com/starkwang
force-pushedhttps://github.com/nodejs/node/compare/7727304dfb95b68cd2445bde06830e619ab52d7e..cd2e3ef56a230be4b3431a5f36658628c70c3415
7727304https://github.com/nodejs/node/commit/7727304dfb95b68cd2445bde06830e619ab52d7e
cd2e3efhttps://github.com/nodejs/node/commit/cd2e3ef56a230be4b3431a5f36658628c70c3415
Compare https://github.com/nodejs/node/compare/7727304dfb95b68cd2445bde06830e619ab52d7e..cd2e3ef56a230be4b3431a5f36658628c70c3415
August 8, 2017 00:08https://github.com/nodejs/node/pull/14659#event-1196336688
https://github.com/starkwang
starkwanghttps://github.com/starkwang
Aug 8, 2017https://github.com/nodejs/node/pull/14659#issuecomment-320813776
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 8, 2017 https://github.com/nodejs/node/pull/14659#ref-issue-206642170
Tracking Issue: Migrate errors to internal/errors.js #11273 https://github.com/nodejs/node/issues/11273
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 8, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-54834746
View reviewed changes https://github.com/nodejs/node/pull/14659/files
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/14659#pullrequestreview-54834746
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
lib/internal/errors.jshttps://github.com/nodejs/node/pull/14659/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
BridgeARhttps://github.com/BridgeAR
Aug 8, 2017https://github.com/nodejs/node/pull/14659#discussion_r131820759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/starkwang
starkwanghttps://github.com/starkwang
force-pushedhttps://github.com/nodejs/node/compare/cd2e3ef56a230be4b3431a5f36658628c70c3415..fc7e71d948911e8ee0388a22e3287f943110a1fb
cd2e3efhttps://github.com/nodejs/node/commit/cd2e3ef56a230be4b3431a5f36658628c70c3415
fc7e71dhttps://github.com/nodejs/node/commit/fc7e71d948911e8ee0388a22e3287f943110a1fb
Compare https://github.com/nodejs/node/compare/cd2e3ef56a230be4b3431a5f36658628c70c3415..fc7e71d948911e8ee0388a22e3287f943110a1fb
August 8, 2017 06:14https://github.com/nodejs/node/pull/14659#event-1196600459
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 14, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-56121150
View reviewed changes https://github.com/nodejs/node/pull/14659/files
Fishrock123https://github.com/Fishrock123
https://github.com/nodejs/node/pull/14659#pullrequestreview-56121150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.nodejs.org/job/node-test-pull-request/9652/https://ci.nodejs.org/job/node-test-pull-request/9652/
Please reload this pagehttps://github.com/nodejs/node/pull/14659
tniessenhttps://github.com/tniessen
Aug 16, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-620ba41
https://github.com/fengmk2
https://github.com/tniessen
http: don't double-fire the req error eventhttps://github.com/nodejs/node/commit/620ba416940299fbad3e40258bb8fd99279ec8c5
https://github.com/nodejs/node/commit/620ba416940299fbad3e40258bb8fd99279ec8c5#comments
620ba41https://github.com/nodejs/node/commit/620ba416940299fbad3e40258bb8fd99279ec8c5
#14659https://github.com/nodejs/node/pull/14659
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 16, 2017https://github.com/nodejs/node/pull/14659#issuecomment-322804496
620ba41https://github.com/nodejs/node/commit/620ba416940299fbad3e40258bb8fd99279ec8c5
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 16, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-56693015
View reviewed changes https://github.com/nodejs/node/pull/14659/files
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 16, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-56695727
View reviewed changes https://github.com/nodejs/node/pull/14659/files
doc/api/errors.mdhttps://github.com/nodejs/node/pull/14659/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
thefourtheyehttps://github.com/thefourtheye
Aug 16, 2017https://github.com/nodejs/node/pull/14659#discussion_r133506725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
test/parallel/test-timers-enroll-invalid-msecs.jshttps://github.com/nodejs/node/pull/14659/files#diff-111b62f4996c207122b2a9d8d1ddf48869fd903ccc3563049a333e97cf88b1cd
thefourtheyehttps://github.com/thefourtheye
Aug 16, 2017https://github.com/nodejs/node/pull/14659#discussion_r133507018
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
starkwanghttps://github.com/starkwang
Aug 18, 2017https://github.com/nodejs/node/pull/14659#discussion_r133867574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/starkwang
starkwanghttps://github.com/starkwang
force-pushedhttps://github.com/nodejs/node/compare/fc7e71d948911e8ee0388a22e3287f943110a1fb..b042d1921c583a52fb946b729d313dfc28790e15
fc7e71dhttps://github.com/nodejs/node/commit/fc7e71d948911e8ee0388a22e3287f943110a1fb
b042d19https://github.com/nodejs/node/commit/b042d1921c583a52fb946b729d313dfc28790e15
Compare https://github.com/nodejs/node/compare/fc7e71d948911e8ee0388a22e3287f943110a1fb..b042d1921c583a52fb946b729d313dfc28790e15
August 18, 2017 02:04https://github.com/nodejs/node/pull/14659#event-1211177087
MSLaguanahttps://github.com/MSLaguana
Aug 21, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-51af17b
https://github.com/fengmk2
https://github.com/MSLaguana
http: don't double-fire the req error eventhttps://github.com/nodejs/node-chakracore/commit/51af17bd18c91586d74972883240b9eaf2a7cc96
51af17bhttps://github.com/nodejs/node-chakracore/commit/51af17bd18c91586d74972883240b9eaf2a7cc96
nodejs/node#14659https://github.com/nodejs/node/pull/14659
https://github.com/starkwang
timers: Migrate to use internal/errorshttps://github.com/nodejs/node/pull/14659/commits/7a090800beae7b5b87f5531813f732f2dffb8bfe
7a09080https://github.com/nodejs/node/pull/14659/commits/7a090800beae7b5b87f5531813f732f2dffb8bfe
nodejs#11273https://github.com/nodejs/node/issues/11273
https://github.com/starkwang
starkwanghttps://github.com/starkwang
force-pushedhttps://github.com/nodejs/node/compare/b042d1921c583a52fb946b729d313dfc28790e15..7a090800beae7b5b87f5531813f732f2dffb8bfe
b042d19https://github.com/nodejs/node/commit/b042d1921c583a52fb946b729d313dfc28790e15
7a09080https://github.com/nodejs/node/commit/7a090800beae7b5b87f5531813f732f2dffb8bfe
Compare https://github.com/nodejs/node/compare/b042d1921c583a52fb946b729d313dfc28790e15..7a090800beae7b5b87f5531813f732f2dffb8bfe
August 24, 2017 05:21https://github.com/nodejs/node/pull/14659#event-1219077863
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017 https://github.com/nodejs/node/pull/14659#pullrequestreview-58822514
View reviewed changes https://github.com/nodejs/node/pull/14659/files/7a090800beae7b5b87f5531813f732f2dffb8bfe
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/14659#pullrequestreview-58822514
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017https://github.com/nodejs/node/pull/14659#issuecomment-325201184
4d893e0https://github.com/nodejs/node/commit/4d893e093a539518a201e4a4f40adc26b8bbf74e
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017https://github.com/nodejs/node/pull/14659#event-1222805515
BridgeARhttps://github.com/BridgeAR
Aug 27, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-4d893e0
https://github.com/starkwang
https://github.com/BridgeAR
timers: Migrate to use internal/errorshttps://github.com/nodejs/node/commit/4d893e093a539518a201e4a4f40adc26b8bbf74e
4d893e0https://github.com/nodejs/node/commit/4d893e093a539518a201e4a4f40adc26b8bbf74e
#14659https://github.com/nodejs/node/pull/14659
Aug 30, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-2ce9572
https://github.com/starkwang
timers: Migrate to use internal/errorshttps://github.com/ayojs/ayo/commit/2ce9572347a9cb57663802773c8ab340a33e174e
2ce9572https://github.com/ayojs/ayo/commit/2ce9572347a9cb57663802773c8ab340a33e174e
nodejs/node#14659https://github.com/nodejs/node/pull/14659
Aug 30, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-1946279
https://github.com/starkwang
timers: Migrate to use internal/errorshttps://github.com/ayojs/ayo/commit/19462795bd01388f1a513ec8b52542c013196cc2
1946279https://github.com/ayojs/ayo/commit/19462795bd01388f1a513ec8b52542c013196cc2
nodejs/node#14659https://github.com/nodejs/node/pull/14659
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-6891ac2
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
6891ac2https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-7165af5
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
7165af5https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-a618552
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
a618552https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14659#ref-commit-8d28704
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
8d28704https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/14659#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/14659#event-1916393638
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14659
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/14659/files/65cd92aa0624a5709941d696058df6d8bf89639a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/14659/files/fc7e71d948911e8ee0388a22e3287f943110a1fb
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/14659/files/7a090800beae7b5b87f5531813f732f2dffb8bfe
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/14659/files/65cd92aa0624a5709941d696058df6d8bf89639a
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/14659/files/fc7e71d948911e8ee0388a22e3287f943110a1fb
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/14659/files/fc7e71d948911e8ee0388a22e3287f943110a1fb
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Please reload this pagehttps://github.com/nodejs/node/pull/14659
https://github.com/starkwang
https://github.com/refack
https://github.com/tniessen
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/Fishrock123
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.