| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d9b40877-1e24-c44a-4e1d-79c3d371c13f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB54:34D244:4C13C60:6B83C75:6A4FD211 |
| html-safe-nonce | 60fbd5dcfa38f715b0f20d9e89c84b83c2c34511956696457ad2d9f4e5df429e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjU0OjM0RDI0NDo0QzEzQzYwOjZCODNDNzU6NkE0RkQyMTEiLCJ2aXNpdG9yX2lkIjoiMzg1MDE2Mzc4NTc3NzAwOTE2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 34950ff24fd232b09c833a081e4f62758791b0a525d8beec74ab6bcba40b7426 |
| hovercard-subject-tag | pull_request:134312249 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14645/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5fbc414743ab4e04119d9b9a0bab3f61fcb368fa2d9c944702e06ac45a4873b3/nodejs/node/pull/14645 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5fbc414743ab4e04119d9b9a0bab3f61fcb368fa2d9c944702e06ac45a4873b3/nodejs/node/pull/14645 |
| og:image:alt | This change normalizes a few situations where a callback might be invoked with this set to undefined in one case, but null in a very similar case.
First commit:
test: refactor test-fs-stat
* add `... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/14645#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14645 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14645 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/14645 |
| Reload | https://github.com/nodejs/node/pull/14645 |
| Reload | https://github.com/nodejs/node/pull/14645 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:strictify | https://github.com/Trott/io.js/tree/strictify |
| Conversation | https://github.com/nodejs/node/pull/14645 |
| Commits5 (5) | https://github.com/nodejs/node/pull/14645/commits |
| Checks | https://github.com/nodejs/node/pull/14645/checks |
| Files changed | https://github.com/nodejs/node/pull/14645/files |
| lib: consistent this in callbacks | https://github.com/nodejs/node/pull/14645#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:strictify | https://github.com/Trott/io.js/tree/strictify |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 6, 2017 | https://github.com/nodejs/node/pull/14645#issue-248221880 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 6, 2017 | https://github.com/nodejs/node/pull/14645#event-1194362834 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
| Aug 6, 2017 | https://github.com/nodejs/node/pull/14645#event-1194362847 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 6, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-320482201 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Aug 6, 2017
| https://github.com/nodejs/node/pull/14645#pullrequestreview-54526653 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14645/files |
| lib/fs.js | https://github.com/nodejs/node/pull/14645/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| mscdex | https://github.com/mscdex |
| Aug 6, 2017 | https://github.com/nodejs/node/pull/14645#discussion_r131533766 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| Trott | https://github.com/Trott |
| Aug 6, 2017 | https://github.com/nodejs/node/pull/14645#discussion_r131534404 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| refack | https://github.com/refack |
| Aug 8, 2017 | https://github.com/nodejs/node/pull/14645#discussion_r131893947 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| Trott | https://github.com/Trott |
| Aug 9, 2017 | https://github.com/nodejs/node/pull/14645#discussion_r132330538 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 6, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-320486238 |
| @mscdex | https://github.com/mscdex |
| e15b625 | https://github.com/nodejs/node/commit/e15b625a841f294b75620f8692cdde657e9e36a4 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 6, 2017
| https://github.com/nodejs/node/pull/14645#pullrequestreview-54528936 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14645/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 7, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-320794168 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
ctc-review
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-review |
| Aug 7, 2017 | https://github.com/nodejs/node/pull/14645#event-1196223046 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 7, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-320794329 |
| https://ci.nodejs.org/job/node-test-pull-request/9525/ | https://ci.nodejs.org/job/node-test-pull-request/9525/ |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Aug 7, 2017
| https://github.com/nodejs/node/pull/14645#pullrequestreview-54792325 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14645/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/14645#pullrequestreview-54792325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/e15b625c030591bae8e676a4403821ce0cd1e904..9d038418510b06c0eb6de3fa31b3a59bb7fa5d20 |
| e15b625 | https://github.com/nodejs/node/commit/e15b625c030591bae8e676a4403821ce0cd1e904 |
| 9d03841 | https://github.com/nodejs/node/commit/9d038418510b06c0eb6de3fa31b3a59bb7fa5d20 |
|
Compare
| https://github.com/nodejs/node/compare/e15b625c030591bae8e676a4403821ce0cd1e904..9d038418510b06c0eb6de3fa31b3a59bb7fa5d20 |
| August 7, 2017 23:00 | https://github.com/nodejs/node/pull/14645#event-1196276781 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 8, 2017
| https://github.com/nodejs/node/pull/14645#pullrequestreview-54809378 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14645/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
ctc-review
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-review |
| Aug 8, 2017 | https://github.com/nodejs/node/pull/14645#event-1196354045 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 8, 2017
| https://github.com/nodejs/node/pull/14645#pullrequestreview-54835203 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14645/files |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Aug 8, 2017
| https://github.com/nodejs/node/pull/14645#pullrequestreview-54915854 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14645/files |
| lib/fs.js | https://github.com/nodejs/node/pull/14645/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| refack | https://github.com/refack |
| Aug 8, 2017 | https://github.com/nodejs/node/pull/14645#discussion_r131893947 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321308989 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321309013 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
|
| https://github.com/Trott |
| test: refactor test-fs-stat | https://github.com/nodejs/node/pull/14645/commits/b3166e30f7f18aa4b3a057287edb9cde55954319 |
| b3166e3 | https://github.com/nodejs/node/pull/14645/commits/b3166e30f7f18aa4b3a057287edb9cde55954319 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/9d038418510b06c0eb6de3fa31b3a59bb7fa5d20..87ec89c2a3c05c309be695c35b48c9e7ab3476cb |
| 9d03841 | https://github.com/nodejs/node/commit/9d038418510b06c0eb6de3fa31b3a59bb7fa5d20 |
| 87ec89c | https://github.com/nodejs/node/commit/87ec89c2a3c05c309be695c35b48c9e7ab3476cb |
|
Compare
| https://github.com/nodejs/node/compare/9d038418510b06c0eb6de3fa31b3a59bb7fa5d20..87ec89c2a3c05c309be695c35b48c9e7ab3476cb |
| August 9, 2017 16:30 | https://github.com/nodejs/node/pull/14645#event-1199431776 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321401776 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/87ec89c2a3c05c309be695c35b48c9e7ab3476cb..255f8cd34167b271c807be5316465a4f4a8f4e48 |
| 87ec89c | https://github.com/nodejs/node/commit/87ec89c2a3c05c309be695c35b48c9e7ab3476cb |
| 255f8cd | https://github.com/nodejs/node/commit/255f8cd34167b271c807be5316465a4f4a8f4e48 |
|
Compare
| https://github.com/nodejs/node/compare/87ec89c2a3c05c309be695c35b48c9e7ab3476cb..255f8cd34167b271c807be5316465a4f4a8f4e48 |
| August 9, 2017 23:14 | https://github.com/nodejs/node/pull/14645#event-1200027774 |
| Trott | https://github.com/Trott |
| August 9, 2017 16:15 | https://github.com/nodejs/node/pull/14645#commits-pushed-9d6365a |
|
| https://github.com/Trott |
| fs: invoke callbacks with undefined context | https://github.com/nodejs/node/pull/14645/commits/9d6365a6e1642edb7353329e438238ddc0f8bd80 |
| 9d6365a | https://github.com/nodejs/node/pull/14645/commits/9d6365a6e1642edb7353329e438238ddc0f8bd80 |
|
| https://github.com/Trott |
| test: check this value for nextTick() | https://github.com/nodejs/node/pull/14645/commits/23918c4cd4e5a5ff0e1f9bf0a46465a33a8936d9 |
| 23918c4 | https://github.com/nodejs/node/pull/14645/commits/23918c4cd4e5a5ff0e1f9bf0a46465a33a8936d9 |
|
| https://github.com/Trott |
| process: make this value consistent | https://github.com/nodejs/node/pull/14645/commits/aa07e873401a8251d62800eed315a9a4fc0b2071 |
| aa07e87 | https://github.com/nodejs/node/pull/14645/commits/aa07e873401a8251d62800eed315a9a4fc0b2071 |
|
| https://github.com/Trott |
| benchmark: cover more nextTick() code | https://github.com/nodejs/node/pull/14645/commits/64e1f005cd9287894ce16a4c644d158c272b7714 |
| 64e1f00 | https://github.com/nodejs/node/pull/14645/commits/64e1f005cd9287894ce16a4c644d158c272b7714 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/255f8cd34167b271c807be5316465a4f4a8f4e48..64e1f005cd9287894ce16a4c644d158c272b7714 |
| 255f8cd | https://github.com/nodejs/node/commit/255f8cd34167b271c807be5316465a4f4a8f4e48 |
| 64e1f00 | https://github.com/nodejs/node/commit/64e1f005cd9287894ce16a4c644d158c272b7714 |
|
Compare
| https://github.com/nodejs/node/compare/255f8cd34167b271c807be5316465a4f4a8f4e48..64e1f005cd9287894ce16a4c644d158c272b7714 |
| August 9, 2017 23:15 | https://github.com/nodejs/node/pull/14645#event-1200029123 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321407078 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321426973 |
| https://ci.nodejs.org/job/node-test-pull-request/9580/ | https://ci.nodejs.org/job/node-test-pull-request/9580/ |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321441103 |
| 9d6365a | https://github.com/nodejs/node/commit/9d6365a6e1642edb7353329e438238ddc0f8bd80 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Aug 10, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321471389 |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| Trott | https://github.com/Trott |
|
Aug 10, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-c6126b1 |
|
| https://github.com/Trott |
| test: refactor test-fs-stat | https://github.com/Trott/io.js/commit/c6126b1308d5f7a8a06a36a3c1b523268edfd3fe |
| c6126b1 | https://github.com/Trott/io.js/commit/c6126b1308d5f7a8a06a36a3c1b523268edfd3fe |
| nodejs#14645 | https://github.com/nodejs/node/pull/14645 |
| Trott | https://github.com/Trott |
|
Aug 10, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-2249234 |
|
| https://github.com/Trott |
| fs: invoke callbacks with undefined context | https://github.com/Trott/io.js/commit/2249234fee2b4f0ce204859728135b9767538383 |
| 2249234 | https://github.com/Trott/io.js/commit/2249234fee2b4f0ce204859728135b9767538383 |
| nodejs#14645 | https://github.com/nodejs/node/pull/14645 |
| Trott | https://github.com/Trott |
|
Aug 10, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-0d3ef5b |
|
| https://github.com/Trott |
| test: check this value for nextTick() | https://github.com/Trott/io.js/commit/0d3ef5b0f863a1caa538673c08747d62d23f3d31 |
| 0d3ef5b | https://github.com/Trott/io.js/commit/0d3ef5b0f863a1caa538673c08747d62d23f3d31 |
| nodejs#14645 | https://github.com/nodejs/node/pull/14645 |
| Trott | https://github.com/Trott |
|
Aug 10, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-a253704 |
|
| https://github.com/Trott |
| process: make this value consistent | https://github.com/Trott/io.js/commit/a2537044463ffa200d781e15b4768be4bf9dbf8d |
| a253704 | https://github.com/Trott/io.js/commit/a2537044463ffa200d781e15b4768be4bf9dbf8d |
| nodejs#14645 | https://github.com/nodejs/node/pull/14645 |
| Trott | https://github.com/Trott |
|
Aug 10, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-97c4394 |
|
| https://github.com/Trott |
| benchmark: cover more nextTick() code | https://github.com/Trott/io.js/commit/97c43940c81a835c21650a3323c5005a5b620e7c |
| 97c4394 | https://github.com/Trott/io.js/commit/97c43940c81a835c21650a3323c5005a5b620e7c |
| nodejs#14645 | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2017 | https://github.com/nodejs/node/pull/14645#issuecomment-321599696 |
| c6126b1 | https://github.com/nodejs/node/commit/c6126b1308d5f7a8a06a36a3c1b523268edfd3fe |
| 2249234 | https://github.com/nodejs/node/commit/2249234fee2b4f0ce204859728135b9767538383 |
| 0d3ef5b | https://github.com/nodejs/node/commit/0d3ef5b0f863a1caa538673c08747d62d23f3d31 |
| a253704 | https://github.com/nodejs/node/commit/a2537044463ffa200d781e15b4768be4bf9dbf8d |
| 97c4394 | https://github.com/nodejs/node/commit/97c43940c81a835c21650a3323c5005a5b620e7c |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2017 | https://github.com/nodejs/node/pull/14645#event-1201254566 |
| jasnell | https://github.com/jasnell |
|
Oct 17, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-6891ac2 |
|
| https://github.com/jasnell |
| 2017-10-31, Version 9.0.0 (Current) | https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd |
| 6891ac2 | https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd |
| d731369b1d | https://github.com/nodejs/node/commit/d731369b1d |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| 602fd36d95 | https://github.com/nodejs/node/commit/602fd36d95 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| e5c290bed9 | https://github.com/nodejs/node/commit/e5c290bed9 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| 2249234fee | https://github.com/nodejs/node/commit/2249234fee |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| 10be20a0e8 | https://github.com/nodejs/node/commit/10be20a0e8 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| 620ba41694 | https://github.com/nodejs/node/commit/620ba41694 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| 156549d8ff | https://github.com/nodejs/node/commit/156549d8ff |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| f55ee6e24a | https://github.com/nodejs/node/commit/f55ee6e24a |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| 668ad44922 | https://github.com/nodejs/node/commit/668ad44922 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| f6caeb9526 | https://github.com/nodejs/node/commit/f6caeb9526 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| 5f22375922 | https://github.com/nodejs/node/commit/5f22375922 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| ce3586da31 | https://github.com/nodejs/node/commit/ce3586da31 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| 468110b327 | https://github.com/nodejs/node/commit/468110b327 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| a7dccd040d | https://github.com/nodejs/node/commit/a7dccd040d |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| jasnell | https://github.com/jasnell |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-7165af5 |
|
| https://github.com/jasnell |
| 2017-10-31, Version 9.0.0 (Current) | https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3 |
| 7165af5 | https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3 |
| d731369b1d | https://github.com/nodejs/node/commit/d731369b1d |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| 602fd36d95 | https://github.com/nodejs/node/commit/602fd36d95 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| e5c290bed9 | https://github.com/nodejs/node/commit/e5c290bed9 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| 2249234fee | https://github.com/nodejs/node/commit/2249234fee |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| 10be20a0e8 | https://github.com/nodejs/node/commit/10be20a0e8 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| 620ba41694 | https://github.com/nodejs/node/commit/620ba41694 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| 156549d8ff | https://github.com/nodejs/node/commit/156549d8ff |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| f55ee6e24a | https://github.com/nodejs/node/commit/f55ee6e24a |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| 668ad44922 | https://github.com/nodejs/node/commit/668ad44922 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| f6caeb9526 | https://github.com/nodejs/node/commit/f6caeb9526 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| 5f22375922 | https://github.com/nodejs/node/commit/5f22375922 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| ce3586da31 | https://github.com/nodejs/node/commit/ce3586da31 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| 468110b327 | https://github.com/nodejs/node/commit/468110b327 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| a7dccd040d | https://github.com/nodejs/node/commit/a7dccd040d |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| jasnell | https://github.com/jasnell |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-a618552 |
|
| https://github.com/jasnell |
| 2017-10-31, Version 9.0.0 (Current) | https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6 |
| a618552 | https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6 |
| d731369b1d | https://github.com/nodejs/node/commit/d731369b1d |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| 602fd36d95 | https://github.com/nodejs/node/commit/602fd36d95 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| e5c290bed9 | https://github.com/nodejs/node/commit/e5c290bed9 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| 2249234fee | https://github.com/nodejs/node/commit/2249234fee |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| 10be20a0e8 | https://github.com/nodejs/node/commit/10be20a0e8 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| 620ba41694 | https://github.com/nodejs/node/commit/620ba41694 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| 156549d8ff | https://github.com/nodejs/node/commit/156549d8ff |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| f55ee6e24a | https://github.com/nodejs/node/commit/f55ee6e24a |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| 668ad44922 | https://github.com/nodejs/node/commit/668ad44922 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| f6caeb9526 | https://github.com/nodejs/node/commit/f6caeb9526 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| 5f22375922 | https://github.com/nodejs/node/commit/5f22375922 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| ce3586da31 | https://github.com/nodejs/node/commit/ce3586da31 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| 468110b327 | https://github.com/nodejs/node/commit/468110b327 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| a7dccd040d | https://github.com/nodejs/node/commit/a7dccd040d |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| jasnell | https://github.com/jasnell |
|
Oct 29, 2017
| https://github.com/nodejs/node/pull/14645#ref-commit-8d28704 |
|
| https://github.com/jasnell |
| 2017-10-31, Version 9.0.0 (Current) | https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878 |
| 8d28704 | https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878 |
| d731369b1d | https://github.com/nodejs/node/commit/d731369b1d |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| #14414 | https://github.com/nodejs/node/pull/14414 |
| 602fd36d95 | https://github.com/nodejs/node/commit/602fd36d95 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| #15412 | https://github.com/nodejs/node/pull/15412 |
| e5c290bed9 | https://github.com/nodejs/node/commit/e5c290bed9 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| #15407 | https://github.com/nodejs/node/pull/15407 |
| 2249234fee | https://github.com/nodejs/node/commit/2249234fee |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| #14645 | https://github.com/nodejs/node/pull/14645 |
| 10be20a0e8 | https://github.com/nodejs/node/commit/10be20a0e8 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| #8895 | https://github.com/nodejs/node/pull/8895 |
| 620ba41694 | https://github.com/nodejs/node/commit/620ba41694 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| #14659 | https://github.com/nodejs/node/pull/14659 |
| 156549d8ff | https://github.com/nodejs/node/commit/156549d8ff |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| #14358 | https://github.com/nodejs/node/pull/14358 |
| f55ee6e24a | https://github.com/nodejs/node/commit/f55ee6e24a |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| #15535 | https://github.com/nodejs/node/pull/15535 |
| 668ad44922 | https://github.com/nodejs/node/commit/668ad44922 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| #15238 | https://github.com/nodejs/node/pull/15238 |
| f6caeb9526 | https://github.com/nodejs/node/commit/f6caeb9526 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| #14622 | https://github.com/nodejs/node/pull/14622 |
| 5f22375922 | https://github.com/nodejs/node/commit/5f22375922 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| #12794 | https://github.com/nodejs/node/pull/12794 |
| ce3586da31 | https://github.com/nodejs/node/commit/ce3586da31 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| #15627 | https://github.com/nodejs/node/pull/15627 |
| 468110b327 | https://github.com/nodejs/node/commit/468110b327 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| #14249 | https://github.com/nodejs/node/pull/14249 |
| a7dccd040d | https://github.com/nodejs/node/commit/a7dccd040d |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| #14807 | https://github.com/nodejs/node/pull/14807 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 30, 2017
| https://github.com/nodejs/node/pull/14645#ref-pullrequest-254697213 |
|
Proposal: 2017-10-31, Version 9.0.0 (Current)
#15135
| https://github.com/nodejs/node/pull/15135 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| July 31, 2018 15:37 | https://github.com/nodejs/node/pull/14645#event-1763061385 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14645 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/14645/files/e15b625c030591bae8e676a4403821ce0cd1e904 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/14645/files/9d038418510b06c0eb6de3fa31b3a59bb7fa5d20 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/14645/files/e15b625c030591bae8e676a4403821ce0cd1e904 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/14645/files/9d038418510b06c0eb6de3fa31b3a59bb7fa5d20 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/14645/files/8c6438f1d55ff2d6aecb9b442a254438a8ffcdd0 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/14645/files/9d038418510b06c0eb6de3fa31b3a59bb7fa5d20 |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/14645 |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/mcollina |
|
| https://github.com/mscdex |
|
| https://github.com/refack |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |