René's URL Explorer Experiment


Title: src: properly manage timer in cares ChannelWrap by addaleax · Pull Request #14634 · nodejs/node · GitHub

Open Graph Title: src: properly manage timer in cares ChannelWrap by addaleax · Pull Request #14634 · nodejs/node

X Title: src: properly manage timer in cares ChannelWrap by addaleax · Pull Request #14634 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes a bug introduced in 727b291 where code managing the uv_timer_t for a ChannelWrap instance was left unchanged, when it should have changed the lifetime of the handle to being tied to the ...

X Description: This fixes a bug introduced in 727b291 where code managing the uv_timer_t for a ChannelWrap instance was left unchanged, when it should have changed the lifetime of the handle to being tied to the ...

Opengraph URL: https://github.com/nodejs/node/pull/14634

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:36eb6829-28f2-1327-14f6-6a4fd8b2579b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D94:1D13EE:D75350:11A8DA2:6991FEE8
html-safe-nonce3f5d2719fe0e3e4aa49e08aea9836b3c40c5b685f077b470c25bd48c1bf0dccb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDk0OjFEMTNFRTpENzUzNTA6MTFBOERBMjo2OTkxRkVFOCIsInZpc2l0b3JfaWQiOiI2MTg5MzYzOTE2MTgwNjg0NTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac15551d0c615a17df7570fdd76eded000ef4cd2aacadb3c77e837f4e2200531c9
hovercard-subject-tagpull_request:134230974
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14634/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cb3ee1ab45b0ad1f38a0ce8bff52735129c6677693b5def0ef1b35f30e36ef0f/nodejs/node/pull/14634
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cb3ee1ab45b0ad1f38a0ce8bff52735129c6677693b5def0ef1b35f30e36ef0f/nodejs/node/pull/14634
og:image:altThis fixes a bug introduced in 727b291 where code managing the uv_timer_t for a ChannelWrap instance was left unchanged, when it should have changed the lifetime of the handle to being tied to the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/14634#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14634
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14634
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/14634
Reloadhttps://github.com/nodejs/node/pull/14634
Reloadhttps://github.com/nodejs/node/pull/14634
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/14634
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 715 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:cares-fix-timerhttps://github.com/addaleax/node/tree/cares-fix-timer
Conversationhttps://github.com/nodejs/node/pull/14634
Commits5 (5)https://github.com/nodejs/node/pull/14634/commits
Checkshttps://github.com/nodejs/node/pull/14634/checks
Files changedhttps://github.com/nodejs/node/pull/14634/files
src: properly manage timer in cares ChannelWraphttps://github.com/nodejs/node/pull/14634#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:cares-fix-timerhttps://github.com/addaleax/node/tree/cares-fix-timer
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 4, 2017https://github.com/nodejs/node/pull/14634#issue-248090565
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#14599https://github.com/nodejs/node/issues/14599
#14518https://github.com/nodejs/node/pull/14518
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/addaleax
src: properly manage timer in cares ChannelWraphttps://github.com/nodejs/node/pull/14634/commits/3baafef544de624eecb88e992e518b7b82f2c5fa
3baafefhttps://github.com/nodejs/node/pull/14634/commits/3baafef544de624eecb88e992e518b7b82f2c5fa
727b291https://github.com/addaleax/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
nodejs#14599https://github.com/nodejs/node/issues/14599
nodejs#14518https://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
XadillaXhttps://github.com/XadillaX
August 4, 2017 19:01https://github.com/nodejs/node/pull/14634#event-1193654153
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
Aug 4, 2017https://github.com/nodejs/node/pull/14634#event-1193654240
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 4, 2017 https://github.com/nodejs/node/pull/14634#ref-issue-247449964
test/parallel/test-async-wrap-getasyncid.js crashing #14599 https://github.com/nodejs/node/issues/14599
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 4, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320329690
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://ci.nodejs.org/job/node-test-commit/11555/https://ci.nodejs.org/job/node-test-commit/11555/
https://ci.nodejs.org/job/node-stress-single-test/1358/https://ci.nodejs.org/job/node-stress-single-test/1358/
https://ci.nodejs.org/job/node-stress-single-test/1359/https://ci.nodejs.org/job/node-stress-single-test/1359/
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Aug 4, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320334498
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/mscdex
mscdexhttps://github.com/mscdex
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Aug 4, 2017https://github.com/nodejs/node/pull/14634#event-1193694010
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 4, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320335391
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 5, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320447357
@bnoordhuishttps://github.com/bnoordhuis
@trevnorrishttps://github.com/trevnorris
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/refack
refackhttps://github.com/refack
Aug 5, 2017 https://github.com/nodejs/node/pull/14634#pullrequestreview-54517818
View reviewed changes https://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa
https://github.com/refack
refackhttps://github.com/refack
Aug 5, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320451414
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 5, 2017 https://github.com/nodejs/node/pull/14634#pullrequestreview-54519516
View reviewed changes https://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 5, 2017 https://github.com/nodejs/node/pull/14634#pullrequestreview-54519556
View reviewed changes https://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa
https://github.com/indutny
indutnyhttps://github.com/indutny
Aug 5, 2017 https://github.com/nodejs/node/pull/14634#pullrequestreview-54519599
View reviewed changes https://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa
indutnyhttps://github.com/indutny
https://github.com/nodejs/node/pull/14634#pullrequestreview-54519599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
indutnyhttps://github.com/indutny
Aug 5, 2017https://github.com/nodejs/node/pull/14634#discussion_r131526516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
indutnyhttps://github.com/indutny
Aug 5, 2017https://github.com/nodejs/node/pull/14634#discussion_r131526523
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
addressing indutny commentshttps://github.com/nodejs/node/pull/14634/commits/e764842840c8708c7fb338cb5755be64fdbe43b2
e764842https://github.com/nodejs/node/pull/14634/commits/e764842840c8708c7fb338cb5755be64fdbe43b2
https://github.com/refack
refackhttps://github.com/refack
Aug 5, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320460144
https://ci.nodejs.org/job/node-test-commit/11568/https://ci.nodejs.org/job/node-test-commit/11568/
https://ci.nodejs.org/job/node-stress-single-test/1360/https://ci.nodejs.org/job/node-stress-single-test/1360/
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/indutny
indutnyhttps://github.com/indutny
Aug 5, 2017 https://github.com/nodejs/node/pull/14634#pullrequestreview-54519752
View reviewed changes https://github.com/nodejs/node/pull/14634/files/e764842840c8708c7fb338cb5755be64fdbe43b2
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14634/files/e764842840c8708c7fb338cb5755be64fdbe43b2#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
indutnyhttps://github.com/indutny
Aug 5, 2017https://github.com/nodejs/node/pull/14634#discussion_r131526708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
refackhttps://github.com/refack
Aug 5, 2017https://github.com/nodejs/node/pull/14634#discussion_r131526715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
nullptrhttps://github.com/nodejs/node/pull/14634/commits/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8
1fdf0achttps://github.com/nodejs/node/pull/14634/commits/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8
https://github.com/refack
refackhttps://github.com/refack
Aug 5, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320460373
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://ci.nodejs.org/job/node-stress-single-test/1361/https://ci.nodejs.org/job/node-stress-single-test/1361/
https://ci.nodejs.org/job/node-stress-single-test/1362/nodes=aix61-ppc64/https://ci.nodejs.org/job/node-stress-single-test/1362/nodes=aix61-ppc64/
https://ci.nodejs.org/job/node-test-commit/11569/https://ci.nodejs.org/job/node-test-commit/11569/
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/refack
refackhttps://github.com/refack
Aug 5, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320465351
ARM failhttps://ci.nodejs.org/job/node-test-commit-arm/11317/nodes=armv7-wheezy/console
#14206https://github.com/nodejs/node/issues/14206
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 6, 2017 https://github.com/nodejs/node/pull/14634#pullrequestreview-54528312
View reviewed changes https://github.com/nodejs/node/pull/14634/files/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8
XadillaXhttps://github.com/XadillaX
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/nodejs/node/pull/14634#pullrequestreview-54528312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c-ares/c-ares#135 (comment)https://github.com/c-ares/c-ares/issues/135#issuecomment-318323032
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 7, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320547804
@XadillaXhttps://github.com/XadillaX
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 7, 2017 https://github.com/nodejs/node/pull/14634#pullrequestreview-54618484
View reviewed changes https://github.com/nodejs/node/pull/14634/files/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/14634#pullrequestreview-54618484
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14634/files/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
bnoordhuishttps://github.com/bnoordhuis
Aug 7, 2017https://github.com/nodejs/node/pull/14634#discussion_r131621972
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14634/files/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
bnoordhuishttps://github.com/bnoordhuis
Aug 7, 2017https://github.com/nodejs/node/pull/14634#discussion_r131622440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14634
addaleaxhttps://github.com/addaleax
Aug 7, 2017https://github.com/nodejs/node/pull/14634#discussion_r131624271
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@indutnyhttps://github.com/indutny
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/14634
addaleaxhttps://github.com/addaleax
August 7, 2017 12:42https://github.com/nodejs/node/pull/14634#commits-pushed-75885f3
https://github.com/addaleax
[squash] undo pointless changehttps://github.com/nodejs/node/pull/14634/commits/75885f37f2c32d8d5a38fa479e9fcbbaa33b1204
75885f3https://github.com/nodejs/node/pull/14634/commits/75885f37f2c32d8d5a38fa479e9fcbbaa33b1204
https://github.com/addaleax
[squash] style nithttps://github.com/nodejs/node/pull/14634/commits/8a19e57d577c1b9124ad6c3fde041e9316f94e6e
8a19e57https://github.com/nodejs/node/pull/14634/commits/8a19e57d577c1b9124ad6c3fde041e9316f94e6e
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 7, 2017 https://github.com/nodejs/node/pull/14634#ref-pullrequest-247351530
v8.3.0 proposal #14594 https://github.com/nodejs/node/pull/14594
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 7, 2017https://github.com/nodejs/node/pull/14634#issuecomment-320644536
41a0dfchttps://github.com/nodejs/node/commit/41a0dfcd97ade7b14625986df6c96876c5ec9071
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 7, 2017https://github.com/nodejs/node/pull/14634#event-1195268595
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
August 7, 2017 11:59https://github.com/nodejs/node/pull/14634#event-1195268927
addaleaxhttps://github.com/addaleax
Aug 7, 2017 https://github.com/nodejs/node/pull/14634#ref-commit-41a0dfc
https://github.com/addaleax
src: properly manage timer in cares ChannelWraphttps://github.com/nodejs/node/commit/41a0dfcd97ade7b14625986df6c96876c5ec9071
41a0dfchttps://github.com/nodejs/node/commit/41a0dfcd97ade7b14625986df6c96876c5ec9071
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#14599https://github.com/nodejs/node/issues/14599
#14518https://github.com/nodejs/node/pull/14518
#14634https://github.com/nodejs/node/pull/14634
addaleaxhttps://github.com/addaleax
Aug 7, 2017 https://github.com/nodejs/node/pull/14634#ref-commit-3c6b5e5
https://github.com/addaleax
src: properly manage timer in cares ChannelWraphttps://github.com/nodejs/node/commit/3c6b5e5fac47dda28a28c8b91b92251a535f4860
3c6b5e5https://github.com/nodejs/node/commit/3c6b5e5fac47dda28a28c8b91b92251a535f4860
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#14599https://github.com/nodejs/node/issues/14599
#14518https://github.com/nodejs/node/pull/14518
#14634https://github.com/nodejs/node/pull/14634
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Aug 16, 2017https://github.com/nodejs/node/pull/14634#event-1207836419
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Aug 17, 2018https://github.com/nodejs/node/pull/14634#event-1795364463
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14634
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/14634/files/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/14634/files/3baafef544de624eecb88e992e518b7b82f2c5fa
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/14634/files/e764842840c8708c7fb338cb5755be64fdbe43b2
https://github.com/indutny
indutny https://github.com/indutny
https://github.com/nodejs/node/pull/14634/files/e764842840c8708c7fb338cb5755be64fdbe43b2
https://github.com/XadillaX
XadillaX https://github.com/XadillaX
https://github.com/nodejs/node/pull/14634/files/1fdf0ac9cdbb3beaee32234e76ce0ed390001cb8
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
test/parallel/test-async-wrap-getasyncid.js crashing https://github.com/nodejs/node/issues/14599
Please reload this pagehttps://github.com/nodejs/node/pull/14634
https://github.com/addaleax
https://github.com/mscdex
https://github.com/Trott
https://github.com/refack
https://github.com/indutny
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/XadillaX
https://github.com/tniessen
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.