René's URL Explorer Experiment


Title: os: make EOL configurable and readonly by XadillaX · Pull Request #14622 · nodejs/node · GitHub

Open Graph Title: os: make EOL configurable and readonly by XadillaX · Pull Request #14622 · nodejs/node

X Title: os: make EOL configurable and readonly by XadillaX · Pull Request #14622 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: #14619 Checklist make -j4 test (UNIX) tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) os

X Description: Refs: #14619 Checklist make -j4 test (UNIX) tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) os

Opengraph URL: https://github.com/nodejs/node/pull/14622

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5bd31cc0-5fe4-b6b8-c285-8e82f4565e14
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id930C:14011B:3324053:47DEE00:6A4F7C0A
html-safe-nonce20c83c583d2990b10158c39800d2ae64c189bcf71b3f65ed0111c73d8851bc71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzBDOjE0MDExQjozMzI0MDUzOjQ3REVFMDA6NkE0RjdDMEEiLCJ2aXNpdG9yX2lkIjoiNDU2OTE1NTI4Njk1MDk2ODMzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac458102b096dd31ed5a92e6f84d20b709c3dccef8eb9fd930054d0d70de006185
hovercard-subject-tagpull_request:134098692
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14622/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/32f81f919ceec0a32aa999ec5ccd13f6348747d912630ca9b27943fdcaee39e8/nodejs/node/pull/14622
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/32f81f919ceec0a32aa999ec5ccd13f6348747d912630ca9b27943fdcaee39e8/nodejs/node/pull/14622
og:image:altRefs: #14619 Checklist make -j4 test (UNIX) tests and/or benchmarks are included commit message follows commit guidelines Affected core subsystem(s) os
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameXadillaX
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/14622#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14622
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14622
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/14622
Reloadhttps://github.com/nodejs/node/pull/14622
Reloadhttps://github.com/nodejs/node/pull/14622
Please reload this pagehttps://github.com/nodejs/node/pull/14622
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/14622
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
XadillaXhttps://github.com/XadillaX
nodejs:masterhttps://github.com/nodejs/node/tree/master
XadillaX:feature/os-eolhttps://github.com/XadillaX/node/tree/feature/os-eol
Conversationhttps://github.com/nodejs/node/pull/14622
Commits1 (1)https://github.com/nodejs/node/pull/14622/commits
Checkshttps://github.com/nodejs/node/pull/14622/checks
Files changedhttps://github.com/nodejs/node/pull/14622/files
os: make EOL configurable and readonlyhttps://github.com/nodejs/node/pull/14622#top
XadillaXhttps://github.com/XadillaX
nodejs:masterhttps://github.com/nodejs/node/tree/master
XadillaX:feature/os-eolhttps://github.com/XadillaX/node/tree/feature/os-eol
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 4, 2017https://github.com/nodejs/node/pull/14622#issue-247914315
Please reload this pagehttps://github.com/nodejs/node/pull/14622
#14619https://github.com/nodejs/node/issues/14619
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
os https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos
Aug 4, 2017https://github.com/nodejs/node/pull/14622#event-1192615583
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Aug 4, 2017https://github.com/nodejs/node/pull/14622#event-1192616437
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54308487
View reviewed changes https://github.com/nodejs/node/pull/14622/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54317774
View reviewed changes https://github.com/nodejs/node/pull/14622/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54329388
View reviewed changes https://github.com/nodejs/node/pull/14622/files
test/parallel/test-os-eol.jshttps://github.com/nodejs/node/pull/14622/files#diff-7037fd36208786832f67a74715bb3714710884a7d44acc10ac6b69748d6a54a4
richardlauhttps://github.com/richardlau
Aug 4, 2017https://github.com/nodejs/node/pull/14622#discussion_r131356744
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54343539
View reviewed changes https://github.com/nodejs/node/pull/14622/files
tniessenhttps://github.com/tniessen
https://github.com/nodejs/node/pull/14622#pullrequestreview-54343539
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/14622
test/parallel/test-os-eol.jshttps://github.com/nodejs/node/pull/14622/files#diff-7037fd36208786832f67a74715bb3714710884a7d44acc10ac6b69748d6a54a4
tniessenhttps://github.com/tniessen
Aug 4, 2017https://github.com/nodejs/node/pull/14622#discussion_r131368986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
XadillaXhttps://github.com/XadillaX
Aug 4, 2017https://github.com/nodejs/node/pull/14622#discussion_r131392404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#14496 (comment)https://github.com/nodejs/node/issues/14496#issuecomment-318011509
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54354534
View reviewed changes https://github.com/nodejs/node/pull/14622/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54378610
View reviewed changes https://github.com/nodejs/node/pull/14622/files
https://github.com/refack
refackhttps://github.com/refack
Aug 4, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320271062
Please reload this pagehttps://github.com/nodejs/node/pull/14622
@XadillaXhttps://github.com/XadillaX
node_contants.chttps://github.com/nodejs/node/blob/master/src/node_constants.cc#L1284
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 4, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320271904
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 4, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320284286
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54405835
View reviewed changes https://github.com/nodejs/node/pull/14622/files
lib/os.jshttps://github.com/nodejs/node/pull/14622/files#diff-169b839d55312a439ec3709adaa8422a38a872d610dc33bb8151e3ffacc9265f
TimothyGuhttps://github.com/TimothyGu
Aug 4, 2017https://github.com/nodejs/node/pull/14622#discussion_r131423360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
XadillaXhttps://github.com/XadillaX
Aug 6, 2017https://github.com/nodejs/node/pull/14622#discussion_r131534685
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 4, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54406882
View reviewed changes https://github.com/nodejs/node/pull/14622/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/14622#pullrequestreview-54406882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Aug 4, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320299083
#14619https://github.com/nodejs/node/issues/14619
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 4, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320301887
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 6, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54527675
View reviewed changes https://github.com/nodejs/node/pull/14622/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/14622#pullrequestreview-54527675
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Aug 6, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-54541279
View reviewed changes https://github.com/nodejs/node/pull/14622/files
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 7, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320558566
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
stale reviewhttps://github.com/nodejs/node/pull/14622#pullrequestreview-54406882
August 7, 2017 13:05https://github.com/nodejs/node/pull/14622#event-1195363834
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 7, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320658397
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/refack
refackhttps://github.com/refack
Aug 7, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320795934
@jasnellhttps://github.com/jasnell
@XadillaXhttps://github.com/XadillaX
3e31ac4https://github.com/nodejs/node/commit/3e31ac4388292b0c7ba0d42f64017ef21321dedf
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/refack
refackhttps://github.com/refack
Aug 7, 2017https://github.com/nodejs/node/pull/14622#issuecomment-320796120
https://ci.nodejs.org/job/node-test-pull-request/9526/https://ci.nodejs.org/job/node-test-pull-request/9526/
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/jasnell
jasnellhttps://github.com/jasnell
ctc-review https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-review
Aug 8, 2017https://github.com/nodejs/node/pull/14622#event-1198156580
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 8, 2017https://github.com/nodejs/node/pull/14622#issuecomment-321104785
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 10, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-55503681
View reviewed changes https://github.com/nodejs/node/pull/14622/files
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 11, 2017https://github.com/nodejs/node/pull/14622#issuecomment-321720398
@jasnellhttps://github.com/jasnell
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 11, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-55709068
View reviewed changes https://github.com/nodejs/node/pull/14622/files
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/14622#pullrequestreview-55709068
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 13, 2017 https://github.com/nodejs/node/pull/14622#ref-issue-249901338
Node.js Foundation Core Technical Committee (CTC) Meeting 2017-08-16 nodejs/CTC#162 https://github.com/nodejs/CTC/issues/162
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 14, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-56001065
View reviewed changes https://github.com/nodejs/node/pull/14622/files
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 14, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-56126986
View reviewed changes https://github.com/nodejs/node/pull/14622/files
Fishrock123https://github.com/Fishrock123
https://github.com/nodejs/node/pull/14622#pullrequestreview-56126986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/not-an-aardvark
not-an-aardvarkhttps://github.com/not-an-aardvark
Aug 14, 2017https://github.com/nodejs/node/pull/14622#issuecomment-322264753
Please reload this pagehttps://github.com/nodejs/node/pull/14622
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/refack
refackhttps://github.com/refack
Aug 14, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-56157062
View reviewed changes https://github.com/nodejs/node/pull/14622/files
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/14622#pullrequestreview-56157062
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/refack
refackhttps://github.com/refack
Aug 14, 2017https://github.com/nodejs/node/pull/14622#issuecomment-322266171
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/951/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/951/
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Aug 15, 2017https://github.com/nodejs/node/pull/14622#event-1205882298
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 16, 2017https://github.com/nodejs/node/pull/14622#issuecomment-322720082
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 16, 2017 https://github.com/nodejs/node/pull/14622#pullrequestreview-56579407
View reviewed changes https://github.com/nodejs/node/pull/14622/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/14622#pullrequestreview-56579407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
force-pushedhttps://github.com/nodejs/node/compare/3e31ac4388292b0c7ba0d42f64017ef21321dedf..042c2598dbc29b8566ec52d44c2e70e789f52864
3e31ac4https://github.com/nodejs/node/commit/3e31ac4388292b0c7ba0d42f64017ef21321dedf
042c259https://github.com/nodejs/node/commit/042c2598dbc29b8566ec52d44c2e70e789f52864
Compare https://github.com/nodejs/node/compare/3e31ac4388292b0c7ba0d42f64017ef21321dedf..042c2598dbc29b8566ec52d44c2e70e789f52864
August 17, 2017 03:53https://github.com/nodejs/node/pull/14622#event-1209433436
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 17, 2017https://github.com/nodejs/node/pull/14622#issuecomment-322962280
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 17, 2017https://github.com/nodejs/node/pull/14622#issuecomment-322992614
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/957/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/957/
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/not-an-aardvark
not-an-aardvarkhttps://github.com/not-an-aardvark
Aug 17, 2017https://github.com/nodejs/node/pull/14622#issuecomment-322994419
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 17, 2017https://github.com/nodejs/node/pull/14622#event-1209809382
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 17, 2017https://github.com/nodejs/node/pull/14622#event-1209810003
https://github.com/XadillaX
os: make EOL configurable and readonlyhttps://github.com/nodejs/node/pull/14622/commits/6f5087de7c9d4be3497f680e7cfe8715b5f47fdd
6f5087dhttps://github.com/nodejs/node/pull/14622/commits/6f5087de7c9d4be3497f680e7cfe8715b5f47fdd
nodejs#14619https://github.com/nodejs/node/issues/14619
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
force-pushedhttps://github.com/nodejs/node/compare/042c2598dbc29b8566ec52d44c2e70e789f52864..6f5087de7c9d4be3497f680e7cfe8715b5f47fdd
042c259https://github.com/nodejs/node/commit/042c2598dbc29b8566ec52d44c2e70e789f52864
6f5087dhttps://github.com/nodejs/node/commit/6f5087de7c9d4be3497f680e7cfe8715b5f47fdd
Compare https://github.com/nodejs/node/compare/042c2598dbc29b8566ec52d44c2e70e789f52864..6f5087de7c9d4be3497f680e7cfe8715b5f47fdd
August 17, 2017 09:49https://github.com/nodejs/node/pull/14622#event-1209811831
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 17, 2017https://github.com/nodejs/node/pull/14622#issuecomment-323022707
@not-an-aardvarkhttps://github.com/not-an-aardvark
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 17, 2017https://github.com/nodejs/node/pull/14622#issuecomment-323032650
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/aqrln
aqrlnhttps://github.com/aqrln
Aug 17, 2017https://github.com/nodejs/node/pull/14622#issuecomment-323064981
@XadillaXhttps://github.com/XadillaX
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 21, 2017https://github.com/nodejs/node/pull/14622#issuecomment-323634754
@aqrlnhttps://github.com/aqrln
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/refack
refackhttps://github.com/refack
Aug 21, 2017https://github.com/nodejs/node/pull/14622#issuecomment-323637009
https://ci.nodejs.org/job/node-test-commit/11929/https://ci.nodejs.org/job/node-test-commit/11929/
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/refack
refackhttps://github.com/refack
Aug 21, 2017https://github.com/nodejs/node/pull/14622#issuecomment-323643455
f6caeb9https://github.com/nodejs/node/commit/f6caeb952605ffa9968ccd88eb330829f980a536
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/refack
refackhttps://github.com/refack
Aug 21, 2017https://github.com/nodejs/node/pull/14622#event-1213482933
refackhttps://github.com/refack
Aug 21, 2017 https://github.com/nodejs/node/pull/14622#ref-commit-f6caeb9
https://github.com/XadillaX
https://github.com/refack
os: make EOL configurable and read onlyhttps://github.com/nodejs/node/commit/f6caeb952605ffa9968ccd88eb330829f980a536
f6caeb9https://github.com/nodejs/node/commit/f6caeb952605ffa9968ccd88eb330829f980a536
#14622https://github.com/nodejs/node/pull/14622
#14619https://github.com/nodejs/node/issues/14619
https://github.com/Trott
Trotthttps://github.com/Trott
ctc-review https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-review
Aug 21, 2017https://github.com/nodejs/node/pull/14622#event-1213511095
jasnellhttps://github.com/jasnell
Oct 17, 2017 https://github.com/nodejs/node/pull/14622#ref-commit-6891ac2
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
6891ac2https://github.com/nodejs/node/commit/6891ac20de495702ca39725166d61685a274b7dd
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14622#ref-commit-7165af5
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
7165af5https://github.com/nodejs/node/commit/7165af50106b4f16269b6be6c51ee460e0ac0ee3
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14622#ref-commit-a618552
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
a618552https://github.com/nodejs/node/commit/a6185529bc9960e81b735c6397da3be084feb7e6
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
jasnellhttps://github.com/jasnell
Oct 29, 2017 https://github.com/nodejs/node/pull/14622#ref-commit-8d28704
https://github.com/jasnell
2017-10-31, Version 9.0.0 (Current)https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
8d28704https://github.com/nodejs/node/commit/8d2870449dd87bd7d89e93f2ddf2490a19cc3878
d731369b1dhttps://github.com/nodejs/node/commit/d731369b1d
#14414https://github.com/nodejs/node/pull/14414
#14414https://github.com/nodejs/node/pull/14414
602fd36d95https://github.com/nodejs/node/commit/602fd36d95
#15412https://github.com/nodejs/node/pull/15412
#15412https://github.com/nodejs/node/pull/15412
e5c290bed9https://github.com/nodejs/node/commit/e5c290bed9
#15407https://github.com/nodejs/node/pull/15407
#15407https://github.com/nodejs/node/pull/15407
2249234feehttps://github.com/nodejs/node/commit/2249234fee
#14645https://github.com/nodejs/node/pull/14645
#14645https://github.com/nodejs/node/pull/14645
10be20a0e8https://github.com/nodejs/node/commit/10be20a0e8
#8895https://github.com/nodejs/node/pull/8895
#8895https://github.com/nodejs/node/pull/8895
620ba41694https://github.com/nodejs/node/commit/620ba41694
#14659https://github.com/nodejs/node/pull/14659
#14659https://github.com/nodejs/node/pull/14659
156549d8ffhttps://github.com/nodejs/node/commit/156549d8ff
#14358https://github.com/nodejs/node/pull/14358
#14358https://github.com/nodejs/node/pull/14358
f55ee6e24ahttps://github.com/nodejs/node/commit/f55ee6e24a
#15535https://github.com/nodejs/node/pull/15535
#15535https://github.com/nodejs/node/pull/15535
668ad44922https://github.com/nodejs/node/commit/668ad44922
#15238https://github.com/nodejs/node/pull/15238
#15238https://github.com/nodejs/node/pull/15238
f6caeb9526https://github.com/nodejs/node/commit/f6caeb9526
#14622https://github.com/nodejs/node/pull/14622
#14622https://github.com/nodejs/node/pull/14622
5f22375922https://github.com/nodejs/node/commit/5f22375922
#12794https://github.com/nodejs/node/pull/12794
#12794https://github.com/nodejs/node/pull/12794
ce3586da31https://github.com/nodejs/node/commit/ce3586da31
#15627https://github.com/nodejs/node/pull/15627
#15627https://github.com/nodejs/node/pull/15627
468110b327https://github.com/nodejs/node/commit/468110b327
#14249https://github.com/nodejs/node/pull/14249
#14249https://github.com/nodejs/node/pull/14249
a7dccd040dhttps://github.com/nodejs/node/commit/a7dccd040d
#14807https://github.com/nodejs/node/pull/14807
#14807https://github.com/nodejs/node/pull/14807
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 30, 2017 https://github.com/nodejs/node/pull/14622#ref-pullrequest-254697213
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135 https://github.com/nodejs/node/pull/15135
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14622
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/14622/files/f71fdb17d42862ae143c2a7f6d35788c09232429
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/14622/files/0caac4e7160062c6bf76076f0a8d42f9f9111e18
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/14622/files/3e31ac4388292b0c7ba0d42f64017ef21321dedf
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/14622/files/3e31ac4388292b0c7ba0d42f64017ef21321dedf
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/14622/files/f71fdb17d42862ae143c2a7f6d35788c09232429
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/14622/files/f71fdb17d42862ae143c2a7f6d35788c09232429
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/14622/files/3e31ac4388292b0c7ba0d42f64017ef21321dedf
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/14622/files/0caac4e7160062c6bf76076f0a8d42f9f9111e18
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/14622/files/3e31ac4388292b0c7ba0d42f64017ef21321dedf
https://github.com/rvagg
rvagg https://github.com/rvagg
https://github.com/nodejs/node/pull/14622/files/3e31ac4388292b0c7ba0d42f64017ef21321dedf
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/14622/files/12b84d76ecd34dbdc831c5f3147919c32cc394e9
https://github.com/aqrln
aqrln https://github.com/aqrln
https://github.com/nodejs/node/pull/14622/files/12b84d76ecd34dbdc831c5f3147919c32cc394e9
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/14622/files/3e31ac4388292b0c7ba0d42f64017ef21321dedf
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/14622/files/f71fdb17d42862ae143c2a7f6d35788c09232429
os https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/14622
https://github.com/XadillaX
https://github.com/refack
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/richardlau
https://github.com/tniessen
https://github.com/addaleax
https://github.com/not-an-aardvark
https://github.com/mcollina
https://github.com/aqrln
https://github.com/rvagg
https://github.com/Fishrock123
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/joyeecheung
https://github.com/vsemozhetbyt
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.