René's URL Explorer Experiment


Title: crypto: change segmentation faults to CHECKs by tniessen · Pull Request #14548 · nodejs/node · GitHub

Open Graph Title: crypto: change segmentation faults to CHECKs by tniessen · Pull Request #14548 · nodejs/node

X Title: crypto: change segmentation faults to CHECKs by tniessen · Pull Request #14548 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #14519 I intentionally did not fix this in cares_wrap.cc as @addaleax already did that in #14518 (assuming it gets merged). Checklist make -j4 test (UNIX), or vcbuild test (Windows) pass...

X Description: Fixes: #14519 I intentionally did not fix this in cares_wrap.cc as @addaleax already did that in #14518 (assuming it gets merged). Checklist make -j4 test (UNIX), or vcbuild test (Windows) pass...

Opengraph URL: https://github.com/nodejs/node/pull/14548

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1aa6a15a-e5d1-612f-d3c3-84bef76a0fd4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2A4:E58C0:24118E2:2DEF004:6991B466
html-safe-nonce1859fd3f9d00b0170bfb07da336b7519e24d60f9b069d296f8f65422bc80fc29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkE0OkU1OEMwOjI0MTE4RTI6MkRFRjAwNDo2OTkxQjQ2NiIsInZpc2l0b3JfaWQiOiIxNjY1ODA5MTU3Nzg4MzgyMzEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac83acbda79a747570ad60cc6854bdb7cde3b915894fd4412f0d30e68e3d86ef5c
hovercard-subject-tagpull_request:133146559
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14548/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0544d9a215c415b0824c778a5e855310acb9dd48cb8633194d2280ad11d4ca48/nodejs/node/pull/14548
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0544d9a215c415b0824c778a5e855310acb9dd48cb8633194d2280ad11d4ca48/nodejs/node/pull/14548
og:image:altFixes: #14519 I intentionally did not fix this in cares_wrap.cc as @addaleax already did that in #14518 (assuming it gets merged). Checklist make -j4 test (UNIX), or vcbuild test (Windows) pass...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/14548#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14548
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14548
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/14548
Reloadhttps://github.com/nodejs/node/pull/14548
Reloadhttps://github.com/nodejs/node/pull/14548
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/14548
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:fix-domain-array-segfaulthttps://github.com/tniessen/node/tree/fix-domain-array-segfault
Conversationhttps://github.com/nodejs/node/pull/14548
Commits3 (3)https://github.com/nodejs/node/pull/14548/commits
Checkshttps://github.com/nodejs/node/pull/14548/checks
Files changedhttps://github.com/nodejs/node/pull/14548/files
crypto: change segmentation faults to CHECKshttps://github.com/nodejs/node/pull/14548#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:fix-domain-array-segfaulthttps://github.com/tniessen/node/tree/fix-domain-array-segfault
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 30, 2017https://github.com/nodejs/node/pull/14548#issue-246614870
#14519https://github.com/nodejs/node/issues/14519
@addaleaxhttps://github.com/addaleax
#14518https://github.com/nodejs/node/pull/14518
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/tniessen
crypto: change segmentation faults to CHECKshttps://github.com/nodejs/node/pull/14548/commits/dbf5198d17bc8a3e8ba81049db8373b839e05649
dbf5198https://github.com/nodejs/node/pull/14548/commits/dbf5198d17bc8a3e8ba81049db8373b839e05649
nodejs#14519https://github.com/nodejs/node/issues/14519
https://github.com/tniessen
tniessenhttps://github.com/tniessen
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jul 30, 2017https://github.com/nodejs/node/pull/14548#event-1184936329
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jul 30, 2017https://github.com/nodejs/node/pull/14548#event-1184936342
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 30, 2017https://github.com/nodejs/node/pull/14548#issuecomment-318936096
https://ci.nodejs.org/job/node-test-pull-request/9411/https://ci.nodejs.org/job/node-test-pull-request/9411/
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 30, 2017https://github.com/nodejs/node/pull/14548#event-1184936506
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 30, 2017 https://github.com/nodejs/node/pull/14548#pullrequestreview-53108461
View reviewed changes https://github.com/nodejs/node/pull/14548/files/dbf5198d17bc8a3e8ba81049db8373b839e05649
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 30, 2017 https://github.com/nodejs/node/pull/14548#pullrequestreview-53108472
View reviewed changes https://github.com/nodejs/node/pull/14548/files/dbf5198d17bc8a3e8ba81049db8373b839e05649
src/node_crypto.cchttps://github.com/nodejs/node/pull/14548/files/dbf5198d17bc8a3e8ba81049db8373b839e05649#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
addaleaxhttps://github.com/addaleax
Jul 30, 2017https://github.com/nodejs/node/pull/14548#discussion_r130255218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14548
tniessenhttps://github.com/tniessen
Jul 30, 2017https://github.com/nodejs/node/pull/14548#discussion_r130255415
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/tniessen
Fix nithttps://github.com/nodejs/node/pull/14548/commits/5199aa544c0cce24d506e8d34c36ca46c419fd0b
5199aa5https://github.com/nodejs/node/pull/14548/commits/5199aa544c0cce24d506e8d34c36ca46c419fd0b
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 31, 2017 https://github.com/nodejs/node/pull/14548#pullrequestreview-53110147
View reviewed changes https://github.com/nodejs/node/pull/14548/files/5199aa544c0cce24d506e8d34c36ca46c419fd0b
src/node_crypto.cchttps://github.com/nodejs/node/pull/14548/files/5199aa544c0cce24d506e8d34c36ca46c419fd0b#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
TimothyGuhttps://github.com/TimothyGu
Jul 31, 2017https://github.com/nodejs/node/pull/14548#discussion_r130256885
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14548
tniessenhttps://github.com/tniessen
Jul 31, 2017https://github.com/nodejs/node/pull/14548#discussion_r130320057
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/tniessen
Crash if Set() failshttps://github.com/nodejs/node/pull/14548/commits/96017272316a879919ef93aa51ad869eb4838bd9
9601727https://github.com/nodejs/node/pull/14548/commits/96017272316a879919ef93aa51ad869eb4838bd9
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 31, 2017https://github.com/nodejs/node/pull/14548#issuecomment-319030861
https://ci.nodejs.org/job/node-test-pull-request/9418/https://ci.nodejs.org/job/node-test-pull-request/9418/
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 31, 2017 https://github.com/nodejs/node/pull/14548#pullrequestreview-53184171
View reviewed changes https://github.com/nodejs/node/pull/14548/files/96017272316a879919ef93aa51ad869eb4838bd9
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 31, 2017 https://github.com/nodejs/node/pull/14548#pullrequestreview-53202364
View reviewed changes https://github.com/nodejs/node/pull/14548/files/96017272316a879919ef93aa51ad869eb4838bd9
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 31, 2017https://github.com/nodejs/node/pull/14548#issuecomment-319178089
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 31, 2017 https://github.com/nodejs/node/pull/14548#pullrequestreview-53321977
View reviewed changes https://github.com/nodejs/node/pull/14548/files/96017272316a879919ef93aa51ad869eb4838bd9
tniessenhttps://github.com/tniessen
Aug 2, 2017 https://github.com/nodejs/node/pull/14548#ref-commit-1c36243
https://github.com/tniessen
crypto: change segmentation faults to CHECKshttps://github.com/nodejs/node/commit/1c362436b750c714f8d83f4d47fe7e25d252c96b
1c36243https://github.com/nodejs/node/commit/1c362436b750c714f8d83f4d47fe7e25d252c96b
#14548https://github.com/nodejs/node/pull/14548
#14519https://github.com/nodejs/node/issues/14519
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 2, 2017https://github.com/nodejs/node/pull/14548#issuecomment-319627755
1c36243https://github.com/nodejs/node/commit/1c362436b750c714f8d83f4d47fe7e25d252c96b
@jasnellhttps://github.com/jasnell
https://ci.nodejs.org/job/node-test-commit-linuxone/7699/https://ci.nodejs.org/job/node-test-commit-linuxone/7699/
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 2, 2017https://github.com/nodejs/node/pull/14548#event-1189239617
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/14548#ref-commit-51c1afa
https://github.com/tniessen
https://github.com/addaleax
crypto: change segmentation faults to CHECKshttps://github.com/nodejs/node/commit/51c1afafa665f8e88dde61794596a8e24b06cb63
51c1afahttps://github.com/nodejs/node/commit/51c1afafa665f8e88dde61794596a8e24b06cb63
#14548https://github.com/nodejs/node/pull/14548
#14519https://github.com/nodejs/node/issues/14519
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/14548#ref-pullrequest-247351530
v8.3.0 proposal #14594 https://github.com/nodejs/node/pull/14594
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Aug 16, 2017https://github.com/nodejs/node/pull/14548#issuecomment-322703134
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Aug 16, 2017https://github.com/nodejs/node/pull/14548#event-1207829243
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14548
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/14548/files/dbf5198d17bc8a3e8ba81049db8373b839e05649
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/14548/files/96017272316a879919ef93aa51ad869eb4838bd9
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/14548/files/96017272316a879919ef93aa51ad869eb4838bd9
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/14548/files/96017272316a879919ef93aa51ad869eb4838bd9
https://github.com/tniessen
tniessen https://github.com/tniessen
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Internal domain function can be used to cause segfaults https://github.com/nodejs/node/issues/14519
Please reload this pagehttps://github.com/nodejs/node/pull/14548
https://github.com/tniessen
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/addaleax
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.