René's URL Explorer Experiment


Title: build: fix shared library flags logic by Fishrock123 · Pull Request #1454 · nodejs/node · GitHub

Open Graph Title: build: fix shared library flags logic by Fishrock123 · Pull Request #1454 · nodejs/node

X Title: build: fix shared library flags logic by Fishrock123 · Pull Request #1454 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: An even smaller fix than #1450 See: #1436 (comment)

X Description: An even smaller fix than #1450 See: #1436 (comment)

Opengraph URL: https://github.com/nodejs/node/pull/1454

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:730a049d-1dc8-835a-2eac-31bfb113357a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9C8:2C3014:5A5768:7525EB:6AED288E
html-safe-noncedd597c8207aad5c4452a0d3fe6ff72823fd4a4d7fd0a185b6778348d823a14a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUM4OjJDMzAxNDo1QTU3Njg6NzUyNUVCOjZBRUQyODhFIiwidmlzaXRvcl9pZCI6IjI4Njk0MjcwNDMzMzU3NDM2MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace969cab4f2a5cfc2eaa603de1d10064d43c6c03e68d3db66635a72ae4dee30b7
hovercard-subject-tagpull_request:33572863
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1454/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/768893c3e9eeb6ac0fb86a7b9f766ee7c3fc8dccf26a030424fabb583a14034e/nodejs/node/pull/1454
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/768893c3e9eeb6ac0fb86a7b9f766ee7c3fc8dccf26a030424fabb583a14034e/nodejs/node/pull/1454
og:image:altAn even smaller fix than #1450 See: #1436 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFishrock123
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1454#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1454
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1454
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1454
Reloadhttps://github.com/nodejs/node/pull/1454
Reloadhttps://github.com/nodejs/node/pull/1454
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
Fishrock123https://github.com/Fishrock123
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Fishrock123:fix-shared-lib-configurehttps://github.com/Fishrock123/node/tree/fix-shared-lib-configure
Conversationhttps://github.com/nodejs/node/pull/1454
Commits0 (0)https://github.com/nodejs/node/pull/1454/commits
Checkshttps://github.com/nodejs/node/pull/1454/checks
Files changedhttps://github.com/nodejs/node/pull/1454/files
build: fix shared library flags logichttps://github.com/nodejs/node/pull/1454#top
Fishrock123https://github.com/Fishrock123
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Fishrock123:fix-shared-lib-configurehttps://github.com/Fishrock123/node/tree/fix-shared-lib-configure
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 17, 2015https://github.com/nodejs/node/pull/1454#issue-69198059
#1450https://github.com/nodejs/node/pull/1450
#1436 (comment)https://github.com/nodejs/node/issues/1436#issuecomment-94053167
Please reload this pagehttps://github.com/nodejs/node/pull/1454
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
1.8.0https://github.com/nodejs/node/milestone/6
Apr 17, 2015https://github.com/nodejs/node/pull/1454#event-284167926
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
force-pushedhttps://github.com/nodejs/node/compare/5d36f3d25db0ea26c776d2b27e8fcd37932d9cbc..5b844e140b01bff010747e303c0d9e0f3a0f5514
5d36f3dhttps://github.com/nodejs/node/commit/5d36f3d25db0ea26c776d2b27e8fcd37932d9cbc
5b844e1https://github.com/nodejs/node/commit/5b844e140b01bff010747e303c0d9e0f3a0f5514
Compare https://github.com/nodejs/node/compare/5d36f3d25db0ea26c776d2b27e8fcd37932d9cbc..5b844e140b01bff010747e303c0d9e0f3a0f5514
April 17, 2015 19:46https://github.com/nodejs/node/pull/1454#event-284194187
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Apr 17, 2015https://github.com/nodejs/node/pull/1454#event-284217811
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Apr 17, 2015https://github.com/nodejs/node/pull/1454#issuecomment-94069638
Please reload this pagehttps://github.com/nodejs/node/pull/1454
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Apr 17, 2015https://github.com/nodejs/node/pull/1454#issuecomment-94070393
Please reload this pagehttps://github.com/nodejs/node/pull/1454
Fishrock123https://github.com/Fishrock123
Apr 17, 2015 https://github.com/nodejs/node/pull/1454#ref-commit-1b22bad
https://github.com/Fishrock123
build: fix logic for shared library flagshttps://github.com/Fishrock123/node/commit/1b22bad35fa461d59a1640fc429952181300aa35
1b22badhttps://github.com/Fishrock123/node/commit/1b22bad35fa461d59a1640fc429952181300aa35
fd90b33https://github.com/Fishrock123/node/commit/fd90b33b94e6ce64fde193deca2e2aa6c774f558
nodejs#1454https://github.com/nodejs/node/pull/1454
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 17, 2015https://github.com/nodejs/node/pull/1454#event-284229682
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/236c072b1056818356b29d4c87f6b6d89f804d9e..1b22bad35fa461d59a1640fc429952181300aa35
236c072https://github.com/nodejs/node/commit/236c072b1056818356b29d4c87f6b6d89f804d9e
1b22badhttps://github.com/nodejs/node/commit/1b22bad35fa461d59a1640fc429952181300aa35
Compare https://github.com/nodejs/node/compare/236c072b1056818356b29d4c87f6b6d89f804d9e..1b22bad35fa461d59a1640fc429952181300aa35
April 17, 2015 20:41https://github.com/nodejs/node/pull/1454#event-284229684
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 17, 2015https://github.com/nodejs/node/pull/1454#issuecomment-94070697
@jbergstroemhttps://github.com/jbergstroem
1b22badhttps://github.com/nodejs/node/commit/1b22bad35fa461d59a1640fc429952181300aa35
Please reload this pagehttps://github.com/nodejs/node/pull/1454
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Apr 17, 2015 https://github.com/nodejs/node/pull/1454#ref-pullrequest-69128785
build: improve shared library flags logic #1450 https://github.com/nodejs/node/pull/1450
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 12, 2015 15:38https://github.com/nodejs/node/pull/1454#event-302933986
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jul 14, 2021 https://github.com/nodejs/node/pull/1454#ref-pullrequest-944077199
[Snyk] Upgrade protobufjs from 6.8.8 to 6.11.2 Zintexiss/node-22#27 https://github.com/Zintexiss/node-22/pull/27
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Feb 12, 2022 https://github.com/nodejs/node/pull/1454#ref-pullrequest-1133569213
[Snyk] Upgrade protobufjs from 6.8.8 to 6.11.2 Iceymann18777/node#9 https://github.com/Iceymann18777/node/pull/9
https://github.com/MaxMood96
MaxMood96https://github.com/MaxMood96
May 23, 2022 https://github.com/nodejs/node/pull/1454#ref-pullrequest-1245724863
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 MaxMood96/node#22 https://github.com/MaxMood96/node/pull/22
https://github.com/ryan-ally
ryan-allyhttps://github.com/ryan-ally
May 23, 2022 https://github.com/nodejs/node/pull/1454#ref-pullrequest-1245781989
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 ryan-ally/node#62 https://github.com/ryan-ally/node/pull/62
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 baby636/node#55 https://github.com/baby636/node/pull/55
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 Mement-Mori/node#20 https://github.com/Mement-Mori/node/pull/20
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 adamlaska/node#68 https://github.com/adamlaska/node/pull/68
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 turkdevops/node#371 https://github.com/turkdevops/node/pull/371
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Aug 19, 2022 https://github.com/nodejs/node/pull/1454#ref-pullrequest-1344190981
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 MarcelRaschke/node#1 https://github.com/MarcelRaschke/node/pull/1
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 25, 2023 https://github.com/nodejs/node/pull/1454#ref-pullrequest-1683896684
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 aliscco/alisco-node#181 https://github.com/aliscco/alisco-node/pull/181
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Jul 8, 2023 https://github.com/nodejs/node/pull/1454#ref-pullrequest-1794741041
[Snyk] Security upgrade protobufjs from 6.8.8 to 6.11.3 leonardoadame/node#106 https://github.com/leonardoadame/node/pull/106
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1454
Please reload this pagehttps://github.com/nodejs/node/pull/1454
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
1.8.0 https://github.com/nodejs/node/milestone/6
Please reload this pagehttps://github.com/nodejs/node/pull/1454
https://github.com/Fishrock123
https://github.com/chrisdickinson
https://github.com/jbergstroem
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.