René's URL Explorer Experiment


Title: dns: enable managing independent channels in JS by addaleax · Pull Request #14518 · nodejs/node · GitHub

Open Graph Title: dns: enable managing independent channels in JS by addaleax · Pull Request #14518 · nodejs/node

X Title: dns: enable managing independent channels in JS by addaleax · Pull Request #14518 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #7231 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes (bonus: make test-internet also passes) tests and/or benchmarks are included documentation is changed or added com...

X Description: Fixes: #7231 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes (bonus: make test-internet also passes) tests and/or benchmarks are included documentation is changed or added com...

Opengraph URL: https://github.com/nodejs/node/pull/14518

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:17f95805-9d45-ef0c-3ee0-04bd1b24e694
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id906A:120B97:1F6F017:2814F67:69919272
html-safe-nonce60499b5e7e88f2d1d3c920ca37adf4043b039f5f3f909d37aef4cc1f21163fbb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDZBOjEyMEI5NzoxRjZGMDE3OjI4MTRGNjc6Njk5MTkyNzIiLCJ2aXNpdG9yX2lkIjoiMjU4MjMwMjM1MDY1NzAzMjgxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbd851412c879cbea01c306b08221e751bbd53fb45bdd7e7f98cc17a186c5a046
hovercard-subject-tagpull_request:132805227
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14518/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9294cd815b2371aeef3d75b56ed389e8f8c16c9b329e4c006fbdbf37c72afb78/nodejs/node/pull/14518
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9294cd815b2371aeef3d75b56ed389e8f8c16c9b329e4c006fbdbf37c72afb78/nodejs/node/pull/14518
og:image:altFixes: #7231 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes (bonus: make test-internet also passes) tests and/or benchmarks are included documentation is changed or added com...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/14518#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14518
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14518
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/14518
Reloadhttps://github.com/nodejs/node/pull/14518
Reloadhttps://github.com/nodejs/node/pull/14518
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/14518
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:channellinghttps://github.com/addaleax/node/tree/channelling
Conversationhttps://github.com/nodejs/node/pull/14518
Commits4 (4)https://github.com/nodejs/node/pull/14518/commits
Checkshttps://github.com/nodejs/node/pull/14518/checks
Files changedhttps://github.com/nodejs/node/pull/14518/files
dns: enable managing independent channels in JShttps://github.com/nodejs/node/pull/14518#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:channellinghttps://github.com/addaleax/node/tree/channelling
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 27, 2017https://github.com/nodejs/node/pull/14518#issue-246115806
Please reload this pagehttps://github.com/nodejs/node/pull/14518
#7231https://github.com/nodejs/node/issues/7231
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
https://ci.nodejs.org/job/node-test-commit/11400/https://ci.nodejs.org/job/node-test-commit/11400/
https://ci.nodejs.org/job/node-test-commit/11402/https://ci.nodejs.org/job/node-test-commit/11402/
https://ci.nodejs.org/job/node-test-commit/11404/https://ci.nodejs.org/job/node-test-commit/11404/
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jul 27, 2017https://github.com/nodejs/node/pull/14518#event-1182211908
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
XadillaXhttps://github.com/XadillaX
bnoordhuishttps://github.com/bnoordhuis
July 27, 2017 17:38https://github.com/nodejs/node/pull/14518#event-1182211911
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jul 27, 2017https://github.com/nodejs/node/pull/14518#event-1182211984
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 27, 2017 https://github.com/nodejs/node/pull/14518#ref-issue-159253659
How to add max timeout on DNS query? #7231 https://github.com/nodejs/node/issues/7231
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/1ff2fe35197cb4b936a8b56243c816a94e2d28ba..5ce798292e781a14987a00c2bfae92790f918b18
1ff2fe3https://github.com/nodejs/node/commit/1ff2fe35197cb4b936a8b56243c816a94e2d28ba
5ce7982https://github.com/nodejs/node/commit/5ce798292e781a14987a00c2bfae92790f918b18
Compare https://github.com/nodejs/node/compare/1ff2fe35197cb4b936a8b56243c816a94e2d28ba..5ce798292e781a14987a00c2bfae92790f918b18
July 27, 2017 17:48https://github.com/nodejs/node/pull/14518#event-1182228347
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 27, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-52736437
View reviewed changes https://github.com/nodejs/node/pull/14518/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/14518/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
addaleaxhttps://github.com/addaleax
Jul 27, 2017https://github.com/nodejs/node/pull/14518#discussion_r129913890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
XadillaXhttps://github.com/XadillaX
Jul 27, 2017https://github.com/nodejs/node/pull/14518#discussion_r129985327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
jasnellhttps://github.com/jasnell
Jul 31, 2017https://github.com/nodejs/node/pull/14518#discussion_r130444045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Jul 31, 2017https://github.com/nodejs/node/pull/14518#discussion_r130455614
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@XadillaXhttps://github.com/XadillaX
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/5ce798292e781a14987a00c2bfae92790f918b18..2eff98a1a510c47116dbacde63929229071efe5b
5ce7982https://github.com/nodejs/node/commit/5ce798292e781a14987a00c2bfae92790f918b18
2eff98ahttps://github.com/nodejs/node/commit/2eff98a1a510c47116dbacde63929229071efe5b
Compare https://github.com/nodejs/node/compare/5ce798292e781a14987a00c2bfae92790f918b18..2eff98a1a510c47116dbacde63929229071efe5b
July 27, 2017 18:01https://github.com/nodejs/node/pull/14518#event-1182249065
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 27, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-52761788
View reviewed changes https://github.com/nodejs/node/pull/14518/files
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14518/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
tniessenhttps://github.com/tniessen
Jul 27, 2017https://github.com/nodejs/node/pull/14518#discussion_r129937678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#14519https://github.com/nodejs/node/issues/14519
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Jul 27, 2017https://github.com/nodejs/node/pull/14518#discussion_r129940861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14518/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
tniessenhttps://github.com/tniessen
Jul 27, 2017https://github.com/nodejs/node/pull/14518#discussion_r129938068
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Jul 27, 2017https://github.com/nodejs/node/pull/14518#discussion_r129941032
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/2eff98a1a510c47116dbacde63929229071efe5b..bc5721661c17419f1b38b60dabaf01a0e765cee2
2eff98ahttps://github.com/nodejs/node/commit/2eff98a1a510c47116dbacde63929229071efe5b
bc57216https://github.com/nodejs/node/commit/bc5721661c17419f1b38b60dabaf01a0e765cee2
Compare https://github.com/nodejs/node/compare/2eff98a1a510c47116dbacde63929229071efe5b..bc5721661c17419f1b38b60dabaf01a0e765cee2
July 27, 2017 19:46https://github.com/nodejs/node/pull/14518#event-1182412142
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Jul 28, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-52834919
View reviewed changes https://github.com/nodejs/node/pull/14518/files
src/cares_wrap.cchttps://github.com/nodejs/node/pull/14518/files#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
XadillaXhttps://github.com/XadillaX
Jul 28, 2017https://github.com/nodejs/node/pull/14518#discussion_r130004118
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
XadillaXhttps://github.com/XadillaX
Jul 28, 2017https://github.com/nodejs/node/pull/14518#discussion_r130004146
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c-ares/c-ares#135https://github.com/c-ares/c-ares/issues/135
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 30, 2017 https://github.com/nodejs/node/pull/14518#ref-pullrequest-246614870
crypto: change segmentation faults to CHECKs #14548 https://github.com/nodejs/node/pull/14548
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 31, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-53219779
View reviewed changes https://github.com/nodejs/node/pull/14518/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 31, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-53321209
View reviewed changes https://github.com/nodejs/node/pull/14518/files
lib/dns.jshttps://github.com/nodejs/node/pull/14518/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
jasnellhttps://github.com/jasnell
Jul 31, 2017https://github.com/nodejs/node/pull/14518#discussion_r130444527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Jul 31, 2017https://github.com/nodejs/node/pull/14518#discussion_r130455544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 31, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-53321700
View reviewed changes https://github.com/nodejs/node/pull/14518/files
lib/dns.jshttps://github.com/nodejs/node/pull/14518/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
jasnellhttps://github.com/jasnell
Jul 31, 2017https://github.com/nodejs/node/pull/14518#discussion_r130444984
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Jul 31, 2017https://github.com/nodejs/node/pull/14518#discussion_r130456002
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@XadillaXhttps://github.com/XadillaX
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/bc5721661c17419f1b38b60dabaf01a0e765cee2..4f11e4a89d9e8c4aa2bc7b97a2fb404266907841
bc57216https://github.com/nodejs/node/commit/bc5721661c17419f1b38b60dabaf01a0e765cee2
4f11e4ahttps://github.com/nodejs/node/commit/4f11e4a89d9e8c4aa2bc7b97a2fb404266907841
Compare https://github.com/nodejs/node/compare/bc5721661c17419f1b38b60dabaf01a0e765cee2..4f11e4a89d9e8c4aa2bc7b97a2fb404266907841
July 31, 2017 20:30https://github.com/nodejs/node/pull/14518#event-1186484331
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 31, 2017https://github.com/nodejs/node/pull/14518#issuecomment-319190578
https://ci.nodejs.org/job/node-test-commit/11468/https://ci.nodejs.org/job/node-test-commit/11468/
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/XadillaX
XadillaXhttps://github.com/XadillaX
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-53412660
View reviewed changes https://github.com/nodejs/node/pull/14518/files
doc/api/dns.mdhttps://github.com/nodejs/node/pull/14518/files#diff-939eb24980866afa932ab1e5907808ad39380c1ad38da4d0b7393efd186dcf15
XadillaXhttps://github.com/XadillaX
Aug 1, 2017https://github.com/nodejs/node/pull/14518#discussion_r130529309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017https://github.com/nodejs/node/pull/14518#discussion_r130563433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@XadillaXhttps://github.com/XadillaX
Please reload this pagehttps://github.com/nodejs/node/pull/14518
lib/dns.jshttps://github.com/nodejs/node/pull/14518/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
XadillaXhttps://github.com/XadillaX
Aug 1, 2017https://github.com/nodejs/node/pull/14518#discussion_r130529403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017https://github.com/nodejs/node/pull/14518#discussion_r130563379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
August 1, 2017 11:42https://github.com/nodejs/node/pull/14518#commits-pushed-23245d4
https://github.com/addaleax
src,dns: refactor cares_wrap to avoid global statehttps://github.com/nodejs/node/pull/14518/commits/23245d49e272e84f7faceff5ba215f59783d0b7e
23245d4https://github.com/nodejs/node/pull/14518/commits/23245d49e272e84f7faceff5ba215f59783d0b7e
https://github.com/addaleax
dns: enable usage of independent cares resolvershttps://github.com/nodejs/node/pull/14518/commits/ca4e5c95bb9fcba96e00a55d28253f4674989d50
ca4e5c9https://github.com/nodejs/node/pull/14518/commits/ca4e5c95bb9fcba96e00a55d28253f4674989d50
nodejs#7231https://github.com/nodejs/node/issues/7231
https://github.com/addaleax
dns: add channel.cancel()https://github.com/nodejs/node/pull/14518/commits/2fb2a88cf95311c122b506cd7a802b29547a0f86
2fb2a88https://github.com/nodejs/node/pull/14518/commits/2fb2a88cf95311c122b506cd7a802b29547a0f86
nodejs#7231https://github.com/nodejs/node/issues/7231
https://github.com/addaleax
dns: name generated functionshttps://github.com/nodejs/node/pull/14518/commits/b4e426f652f7e8cf286bbd2f873e4f1bf9f762af
b4e426fhttps://github.com/nodejs/node/pull/14518/commits/b4e426f652f7e8cf286bbd2f873e4f1bf9f762af
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/4f11e4a89d9e8c4aa2bc7b97a2fb404266907841..b4e426f652f7e8cf286bbd2f873e4f1bf9f762af
4f11e4ahttps://github.com/nodejs/node/commit/4f11e4a89d9e8c4aa2bc7b97a2fb404266907841
b4e426fhttps://github.com/nodejs/node/commit/b4e426f652f7e8cf286bbd2f873e4f1bf9f762af
Compare https://github.com/nodejs/node/compare/4f11e4a89d9e8c4aa2bc7b97a2fb404266907841..b4e426f652f7e8cf286bbd2f873e4f1bf9f762af
August 1, 2017 09:42https://github.com/nodejs/node/pull/14518#event-1187302305
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#pullrequestreview-53523815
View reviewed changes https://github.com/nodejs/node/pull/14518/files/b4e426f652f7e8cf286bbd2f873e4f1bf9f762af
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 1, 2017https://github.com/nodejs/node/pull/14518#issuecomment-319425541
https://ci.nodejs.org/job/node-test-commit/11484/https://ci.nodejs.org/job/node-test-commit/11484/
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 1, 2017https://github.com/nodejs/node/pull/14518#issuecomment-319450782
cee8d6d...0f5dabehttps://github.com/nodejs/node/compare/cee8d6d65e650baafb19986513c1971a5a556cb2...0f5dabe4ede908ec552ad3e4942bc27c298fcbb4
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 1, 2017https://github.com/nodejs/node/pull/14518#event-1188158950
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-727b291
https://github.com/addaleax
src,dns: refactor cares_wrap to avoid global statehttps://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#14518https://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-6e05970
https://github.com/addaleax
dns: enable usage of independent cares resolvershttps://github.com/nodejs/node/commit/6e05970494de273a934448a85c48006a2c0610b6
6e05970https://github.com/nodejs/node/commit/6e05970494de273a934448a85c48006a2c0610b6
#7231https://github.com/nodejs/node/issues/7231
#14518https://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-732658e
https://github.com/addaleax
dns: add channel.cancel()https://github.com/nodejs/node/commit/732658e4cf0ab676040cdbad92f39b93fbacaa80
732658ehttps://github.com/nodejs/node/commit/732658e4cf0ab676040cdbad92f39b93fbacaa80
#7231https://github.com/nodejs/node/issues/7231
#14518https://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-0f5dabe
https://github.com/addaleax
dns: name generated functionshttps://github.com/nodejs/node/commit/0f5dabe4ede908ec552ad3e4942bc27c298fcbb4
0f5dabehttps://github.com/nodejs/node/commit/0f5dabe4ede908ec552ad3e4942bc27c298fcbb4
#14518https://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-106a23b
https://github.com/addaleax
src,dns: refactor cares_wrap to avoid global statehttps://github.com/nodejs/node/commit/106a23bd27683b220b9e91454c39bf554079008b
106a23bhttps://github.com/nodejs/node/commit/106a23bd27683b220b9e91454c39bf554079008b
#14518https://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-69e41dc
https://github.com/addaleax
dns: enable usage of independent cares resolvershttps://github.com/nodejs/node/commit/69e41dc5dac2fa23f1fde9ba289c9e4605b6f029
69e41dchttps://github.com/nodejs/node/commit/69e41dc5dac2fa23f1fde9ba289c9e4605b6f029
#7231https://github.com/nodejs/node/issues/7231
#14518https://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-0982810
https://github.com/addaleax
dns: add channel.cancel()https://github.com/nodejs/node/commit/09828102086c303a4132104f666853f64d5c6df5
0982810https://github.com/nodejs/node/commit/09828102086c303a4132104f666853f64d5c6df5
#7231https://github.com/nodejs/node/issues/7231
#14518https://github.com/nodejs/node/pull/14518
addaleaxhttps://github.com/addaleax
Aug 1, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-32b30d5
https://github.com/addaleax
dns: name generated functionshttps://github.com/nodejs/node/commit/32b30d519ef0168eeb9e0981bc11c6dc7d4148aa
32b30d5https://github.com/nodejs/node/commit/32b30d519ef0168eeb9e0981bc11c6dc7d4148aa
#14518https://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
Aug 2, 2017https://github.com/nodejs/node/pull/14518#event-1189305438
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-d665127
https://github.com/addaleax
2017-08-??, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/d665127835c214f91f38f92f68426461a5b433da
d665127https://github.com/nodejs/node/commit/d665127835c214f91f38f92f68426461a5b433da
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/14518#ref-pullrequest-247351530
v8.3.0 proposal #14594 https://github.com/nodejs/node/pull/14594
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 2, 2017 https://github.com/nodejs/node/pull/14518#ref-issue-247449964
test/parallel/test-async-wrap-getasyncid.js crashing #14599 https://github.com/nodejs/node/issues/14599
addaleaxhttps://github.com/addaleax
Aug 3, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-178e9dc
https://github.com/addaleax
2017-08-??, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/178e9dc2388b7b527aa91f38d9d0aa4ee7538e1a
178e9dchttps://github.com/nodejs/node/commit/178e9dc2388b7b527aa91f38d9d0aa4ee7538e1a
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
addaleaxhttps://github.com/addaleax
Aug 4, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-3baafef
https://github.com/addaleax
src: properly manage timer in cares ChannelWraphttps://github.com/addaleax/node/commit/3baafef544de624eecb88e992e518b7b82f2c5fa
3baafefhttps://github.com/addaleax/node/commit/3baafef544de624eecb88e992e518b7b82f2c5fa
727b291https://github.com/addaleax/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
nodejs#14599https://github.com/nodejs/node/issues/14599
nodejs#14518https://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 4, 2017 https://github.com/nodejs/node/pull/14518#ref-pullrequest-248090565
src: properly manage timer in cares ChannelWrap #14634 https://github.com/nodejs/node/pull/14634
addaleaxhttps://github.com/addaleax
Aug 7, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-41a0dfc
https://github.com/addaleax
src: properly manage timer in cares ChannelWraphttps://github.com/nodejs/node/commit/41a0dfcd97ade7b14625986df6c96876c5ec9071
41a0dfchttps://github.com/nodejs/node/commit/41a0dfcd97ade7b14625986df6c96876c5ec9071
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#14599https://github.com/nodejs/node/issues/14599
#14518https://github.com/nodejs/node/pull/14518
#14634https://github.com/nodejs/node/pull/14634
addaleaxhttps://github.com/addaleax
Aug 7, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-3c6b5e5
https://github.com/addaleax
src: properly manage timer in cares ChannelWraphttps://github.com/nodejs/node/commit/3c6b5e5fac47dda28a28c8b91b92251a535f4860
3c6b5e5https://github.com/nodejs/node/commit/3c6b5e5fac47dda28a28c8b91b92251a535f4860
727b291https://github.com/nodejs/node/commit/727b2911eca9f00cb7fa6a5f4ee8a73c7e9c94f0
#14599https://github.com/nodejs/node/issues/14599
#14518https://github.com/nodejs/node/pull/14518
#14634https://github.com/nodejs/node/pull/14634
addaleaxhttps://github.com/addaleax
Aug 7, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-9f2863f
https://github.com/addaleax
2017-08-??, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/9f2863f1f7bda1917386d242924dd1640a77beba
9f2863fhttps://github.com/nodejs/node/commit/9f2863f1f7bda1917386d242924dd1640a77beba
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
cjihrighttps://github.com/cjihrig
Aug 8, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-54cb14c
https://github.com/addaleax
https://github.com/cjihrig
2017-08-08, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/54cb14c4ddbb83d3586894bcbef87549f197510d
54cb14chttps://github.com/nodejs/node/commit/54cb14c4ddbb83d3586894bcbef87549f197510d
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
addaleaxhttps://github.com/addaleax
Aug 9, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-fb88fa1
https://github.com/addaleax
2017-08-09, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/fb88fa19f1268d9627035eea0a402d3802a2d26a
fb88fa1https://github.com/nodejs/node/commit/fb88fa19f1268d9627035eea0a402d3802a2d26a
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
https://github.com/gabrielschulhofhttps://github.com/gabrielschulhof
cjihrighttps://github.com/cjihrig
Aug 10, 2017 https://github.com/nodejs/node/pull/14518#ref-commit-b72e702
https://github.com/addaleax
https://github.com/cjihrig
2017-08-09, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/b72e702247a4dcbbb9d678253dad2b9b223459f4
b72e702https://github.com/nodejs/node/commit/b72e702247a4dcbbb9d678253dad2b9b223459f4
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
https://github.com/gabrielschulhofhttps://github.com/gabrielschulhof
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 13, 2017https://github.com/nodejs/node/pull/14518#issuecomment-351415941
#17014https://github.com/nodejs/node/pull/17014
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Dec 13, 2017 https://github.com/nodejs/node/pull/14518#ref-pullrequest-273725843
src: fix bad sizeof expression #17014 https://github.com/nodejs/node/pull/17014
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 15, 2018https://github.com/nodejs/node/pull/14518#event-1425117700
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 15, 2018https://github.com/nodejs/node/pull/14518#issuecomment-357799582
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019 https://github.com/nodejs/node/pull/14518#ref-pullrequest-400832404
doc: clarify what dns.setResolvers() affects #25570 https://github.com/nodejs/node/pull/25570
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14518
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/14518/files/b4e426f652f7e8cf286bbd2f873e4f1bf9f762af
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/14518/files/bc5721661c17419f1b38b60dabaf01a0e765cee2
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/14518/files/2eff98a1a510c47116dbacde63929229071efe5b
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/XadillaX
XadillaX https://github.com/XadillaX
https://github.com/nodejs/node/pull/14518/files/4f11e4a89d9e8c4aa2bc7b97a2fb404266907841
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/14518
https://github.com/addaleax
https://github.com/gibfahn
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/XadillaX
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.