René's URL Explorer Experiment


Title: build: improve shared library flags logic by jbergstroem · Pull Request #1450 · nodejs/node · GitHub

Open Graph Title: build: improve shared library flags logic by jbergstroem · Pull Request #1450 · nodejs/node

X Title: build: improve shared library flags logic by jbergstroem · Pull Request #1450 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is one of the commit from #1429 which fixes a bug with shared library flags. The other pull request doesn't necessarily have any issues but could benefit from a bit more review. This shoul...

X Description: This is one of the commit from #1429 which fixes a bug with shared library flags. The other pull request doesn't necessarily have any issues but could benefit from a bit more review. This s...

Opengraph URL: https://github.com/nodejs/node/pull/1450

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7ad708af-ffbd-1768-6a47-5ce2b7099112
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB88E:2684EB:682D72:8E081F:6AED26E3
html-safe-nonce5fe3a81125a6ca39c61008ad3ecc397b50a79a884117b729437e15dfc3e80478
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODhFOjI2ODRFQjo2ODJENzI6OEUwODFGOjZBRUQyNkUzIiwidmlzaXRvcl9pZCI6IjU3MTA2NDYzODAzNTQ5Mzg1OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac932dfea8532fc65c407986398dceaa4d1fbefa706a0961a21cfecfee2d00203f
hovercard-subject-tagpull_request:33539149
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1450/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e135373eee17a2b73df1b49cf3a5de665c5f2f3c409c4f64f8c2fb19e5356820/nodejs/node/pull/1450
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e135373eee17a2b73df1b49cf3a5de665c5f2f3c409c4f64f8c2fb19e5356820/nodejs/node/pull/1450
og:image:altThis is one of the commit from #1429 which fixes a bug with shared library flags. The other pull request doesn't necessarily have any issues but could benefit from a bit more review. This shoul...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejbergstroem
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1450#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1450
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1450
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1450
Reloadhttps://github.com/nodejs/node/pull/1450
Reloadhttps://github.com/nodejs/node/pull/1450
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
jbergstroemhttps://github.com/jbergstroem
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
jbergstroem:fix/shared_library_togglehttps://github.com/jbergstroem/node/tree/fix/shared_library_toggle
Conversationhttps://github.com/nodejs/node/pull/1450
Commits1 (1)https://github.com/nodejs/node/pull/1450/commits
Checkshttps://github.com/nodejs/node/pull/1450/checks
Files changedhttps://github.com/nodejs/node/pull/1450/files
build: improve shared library flags logichttps://github.com/nodejs/node/pull/1450#top
jbergstroemhttps://github.com/jbergstroem
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
jbergstroem:fix/shared_library_togglehttps://github.com/jbergstroem/node/tree/fix/shared_library_toggle
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Apr 17, 2015https://github.com/nodejs/node/pull/1450#issue-69128785
#1429https://github.com/nodejs/node/pull/1429
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/1450
https://github.com/jbergstroem
build: improve shared library flags logichttps://github.com/nodejs/node/pull/1450/commits/437e21bb1fb8151d532144b24b5a5f31debfe07f
437e21bhttps://github.com/nodejs/node/pull/1450/commits/437e21bb1fb8151d532144b24b5a5f31debfe07f
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Apr 17, 2015 https://github.com/nodejs/node/pull/1450#ref-issue-68841345
Release proposal: 1.8.0 #1436 https://github.com/nodejs/node/issues/1436
https://github.com/Nibbler999
Nibbler999https://github.com/Nibbler999
Apr 17, 2015https://github.com/nodejs/node/pull/1450#issuecomment-93976964
#1434https://github.com/nodejs/node/issues/1434
Please reload this pagehttps://github.com/nodejs/node/pull/1450
https://github.com/mscdex
mscdexhttps://github.com/mscdex
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Apr 17, 2015https://github.com/nodejs/node/pull/1450#event-283956970
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 17, 2015https://github.com/nodejs/node/pull/1450#issuecomment-94000228
Please reload this pagehttps://github.com/nodejs/node/pull/1450
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
1.8.0https://github.com/nodejs/node/milestone/6
Apr 17, 2015https://github.com/nodejs/node/pull/1450#event-284046576
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 17, 2015 https://github.com/nodejs/node/pull/1450#ref-pullrequest-69198059
build: fix shared library flags logic #1454 https://github.com/nodejs/node/pull/1454
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Apr 17, 2015https://github.com/nodejs/node/pull/1450#issuecomment-94065669
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1450
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Apr 17, 2015https://github.com/nodejs/node/pull/1450#issuecomment-94070737
#1454https://github.com/nodejs/node/pull/1454
Please reload this pagehttps://github.com/nodejs/node/pull/1450
https://github.com/jbergstroem
jbergstroemhttps://github.com/jbergstroem
Apr 17, 2015https://github.com/nodejs/node/pull/1450#event-284230230
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1450
Please reload this pagehttps://github.com/nodejs/node/pull/1450
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
1.8.0 https://github.com/nodejs/node/milestone/6
Please reload this pagehttps://github.com/nodejs/node/pull/1450
https://github.com/jbergstroem
https://github.com/Nibbler999
https://github.com/bnoordhuis
https://github.com/mscdex
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.