| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3af5917c-6464-f0c5-8811-f8c9c94c2062 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F74:31BD8E:2479B9:33822A:696A0763 |
| html-safe-nonce | e20478bc9d41d40f208f525ca20f315a94884c0604d30ceb0cd48c9a1074340f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Rjc0OjMxQkQ4RToyNDc5Qjk6MzM4MjJBOjY5NkEwNzYzIiwidmlzaXRvcl9pZCI6Ijc4MDcwOTMwNTIyMTAyODQzODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 61382fc5596227d4db77989a3e987024873ab2a694b99885d526188b8ae18672 |
| hovercard-subject-tag | pull_request:131236801 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/14360/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4b254c8f5108255e0480053debaae419f3f743f6c16e4e7ef704e5b236382780/nodejs/node/pull/14360 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4b254c8f5108255e0480053debaae419f3f743f6c16e4e7ef704e5b236382780/nodejs/node/pull/14360 |
| og:image:alt | Backport of #13758 with one required commit from #10561 added. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/14360#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14360 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14360 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/14360 |
| Reload | https://github.com/nodejs/node/pull/14360 |
| Reload | https://github.com/nodejs/node/pull/14360 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/14360 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/14360 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/14360#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| Trott:backport-13758 | https://github.com/Trott/io.js/tree/backport-13758 |
|
[v6.x backport] tools: apply stricter indentation rules to tools
| https://github.com/nodejs/node/pull/14360#top |
| Trott | https://github.com/Trott |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| Trott:backport-13758 | https://github.com/Trott/io.js/tree/backport-13758 |
|
Conversation
1
| https://github.com/nodejs/node/pull/14360 |
|
Commits
4
| https://github.com/nodejs/node/pull/14360/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/14360/checks |
|
Files changed
| https://github.com/nodejs/node/pull/14360/files |
| Please reload this page | https://github.com/nodejs/node/pull/14360 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 19, 2017 | https://github.com/nodejs/node/pull/14360#issue-243922081 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| #10561 | https://github.com/nodejs/node/pull/10561 |
| Please reload this page | https://github.com/nodejs/node/pull/14360 |
| Trott | https://github.com/Trott |
| July 18, 2017 21:47 | https://github.com/nodejs/node/pull/14360#commits-pushed-13308b2 |
|
| https://github.com/Trott |
| tools: remove no-useless-regex-char-class-escape | https://github.com/nodejs/node/pull/14360/commits/13308b2bee96cd78c1b02c529bca114f790ae55f |
| 13308b2 | https://github.com/nodejs/node/pull/14360/commits/13308b2bee96cd78c1b02c529bca114f790ae55f |
| nodejs#10561 | https://github.com/nodejs/node/pull/10561 |
|
| https://github.com/Trott |
| tools: fix indentation in required-modules.js | https://github.com/nodejs/node/pull/14360/commits/8ab455e727a88ae8493b317693e47e17b29a9f6f |
| 8ab455e | https://github.com/nodejs/node/pull/14360/commits/8ab455e727a88ae8493b317693e47e17b29a9f6f |
| nodejs#13758 | https://github.com/nodejs/node/pull/13758 |
|
| https://github.com/Trott |
| tools: apply stricter indentation rules to tools | https://github.com/nodejs/node/pull/14360/commits/1ebad50509ac051bdb7debb6ee5478d70a6f7ff1 |
| 1ebad50 | https://github.com/nodejs/node/pull/14360/commits/1ebad50509ac051bdb7debb6ee5478d70a6f7ff1 |
| nodejs#13758 | https://github.com/nodejs/node/pull/13758 |
|
| https://github.com/Trott |
| tools: fix error in custom ESLint rule | https://github.com/nodejs/node/pull/14360/commits/1088e81fc6b50333d8bc27411307c607b8e473e5 |
| 1088e81 | https://github.com/nodejs/node/pull/14360/commits/1088e81fc6b50333d8bc27411307c607b8e473e5 |
| nodejs#13758 (comment) | https://github.com/nodejs/node/pull/13758#discussion_r122582786 |
| nodejs#13758 | https://github.com/nodejs/node/pull/13758 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| MylesBorins | https://github.com/MylesBorins |
| Jul 19, 2017 | https://github.com/nodejs/node/pull/14360#event-1169552480 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x |
| Jul 19, 2017 | https://github.com/nodejs/node/pull/14360#event-1169552517 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 19, 2017
| https://github.com/nodejs/node/pull/14360#ref-pullrequest-236702086 |
|
tools: apply stricter indentation rules to tools
#13758
| https://github.com/nodejs/node/pull/13758 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 19, 2017
| https://github.com/nodejs/node/pull/14360#pullrequestreview-51041571 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/14360/files/1088e81fc6b50333d8bc27411307c607b8e473e5 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-05b95fa |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: remove no-useless-regex-char-class-escape | https://github.com/nodejs/node/commit/05b95fa98f59fa65e0642245e4caadf216a018e8 |
| 05b95fa | https://github.com/nodejs/node/commit/05b95fa98f59fa65e0642245e4caadf216a018e8 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #10561 | https://github.com/nodejs/node/pull/10561 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-c52f60f |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: fix indentation in required-modules.js | https://github.com/nodejs/node/commit/c52f60f1f37358b070a31b47a9d96768a30dcc62 |
| c52f60f | https://github.com/nodejs/node/commit/c52f60f1f37358b070a31b47a9d96768a30dcc62 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-4d91ff4 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: apply stricter indentation rules to tools | https://github.com/nodejs/node/commit/4d91ff42fe6d1e9f489770106bc5424f1ed2b216 |
| 4d91ff4 | https://github.com/nodejs/node/commit/4d91ff42fe6d1e9f489770106bc5424f1ed2b216 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-ecc50e9 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: fix error in custom ESLint rule | https://github.com/nodejs/node/commit/ecc50e9d912573eec108e143b561df219b46e183 |
| ecc50e9 | https://github.com/nodejs/node/commit/ecc50e9d912573eec108e143b561df219b46e183 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 (comment) | https://github.com/nodejs/node/pull/13758#discussion_r122582786 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 21, 2017 | https://github.com/nodejs/node/pull/14360#issuecomment-317071994 |
| ce4718f...ecc50e9 | https://github.com/nodejs/node/compare/ce4718f0f406565c474790ccf8533e18ef631e13...ecc50e9d912573eec108e143b561df219b46e183 |
| Please reload this page | https://github.com/nodejs/node/pull/14360 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 21, 2017 | https://github.com/nodejs/node/pull/14360#event-1174314713 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-0d60a34 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: remove no-useless-regex-char-class-escape | https://github.com/nodejs/node/commit/0d60a34298ad43c44fee9447a4adbf4a5fbb50f2 |
| 0d60a34 | https://github.com/nodejs/node/commit/0d60a34298ad43c44fee9447a4adbf4a5fbb50f2 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #10561 | https://github.com/nodejs/node/pull/10561 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-81c2763 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: fix indentation in required-modules.js | https://github.com/nodejs/node/commit/81c276342f4179a2ebd98803bc5ae6abceffd476 |
| 81c2763 | https://github.com/nodejs/node/commit/81c276342f4179a2ebd98803bc5ae6abceffd476 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-446b04a |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: apply stricter indentation rules to tools | https://github.com/nodejs/node/commit/446b04a47e85f804d8e0ff42c046dcf5994d0814 |
| 446b04a | https://github.com/nodejs/node/commit/446b04a47e85f804d8e0ff42c046dcf5994d0814 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 21, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-8648032 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: fix error in custom ESLint rule | https://github.com/nodejs/node/commit/8648032359628c91514ed2207b03096914b76d15 |
| 8648032 | https://github.com/nodejs/node/commit/8648032359628c91514ed2207b03096914b76d15 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 (comment) | https://github.com/nodejs/node/pull/13758#discussion_r122582786 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 31, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-5505777 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: remove no-useless-regex-char-class-escape | https://github.com/nodejs/node/commit/550577749f89e1f2bc3ff47181732fecbadfc81b |
| 5505777 | https://github.com/nodejs/node/commit/550577749f89e1f2bc3ff47181732fecbadfc81b |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #10561 | https://github.com/nodejs/node/pull/10561 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 31, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-04934b0 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: fix indentation in required-modules.js | https://github.com/nodejs/node/commit/04934b04c3b43b74654e10c3891559b856041e96 |
| 04934b0 | https://github.com/nodejs/node/commit/04934b04c3b43b74654e10c3891559b856041e96 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 31, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-bb74da3 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: apply stricter indentation rules to tools | https://github.com/nodejs/node/commit/bb74da309c57be80c10336bbf859fb4131dcb7dc |
| bb74da3 | https://github.com/nodejs/node/commit/bb74da309c57be80c10336bbf859fb4131dcb7dc |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 31, 2017
| https://github.com/nodejs/node/pull/14360#ref-commit-910fa50 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: fix error in custom ESLint rule | https://github.com/nodejs/node/commit/910fa50e0ebade03fc0f0c5809c2b5a275679df5 |
| 910fa50 | https://github.com/nodejs/node/commit/910fa50e0ebade03fc0f0c5809c2b5a275679df5 |
| #14360 | https://github.com/nodejs/node/pull/14360 |
| #13758 (comment) | https://github.com/nodejs/node/pull/13758#discussion_r122582786 |
| #13758 | https://github.com/nodejs/node/pull/13758 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:46 | https://github.com/nodejs/node/pull/14360#event-5890949934 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14360 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/14360/files/1088e81fc6b50333d8bc27411307c607b8e473e5 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/14360 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |