René's URL Explorer Experiment


Title: http: OutgoingMessage change writable after end by Kasher · Pull Request #14024 · nodejs/node · GitHub

Open Graph Title: http: OutgoingMessage change writable after end by Kasher · Pull Request #14024 · nodejs/node

X Title: http: OutgoingMessage change writable after end by Kasher · Pull Request #14024 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When an OutgoingMessage is closed (for example, using the end method), its 'writable' property should be changed to false - since it is not writable anymore. The 'writable' property...

X Description: When an OutgoingMessage is closed (for example, using the end method), its 'writable' property should be changed to false - since it is not writable anymore. The 'writable&a...

Opengraph URL: https://github.com/nodejs/node/pull/14024

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:7a85631f-6919-daa7-3c46-429e0612f396
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB148:1F14:1A50976:23BFB9F:6A504997
html-safe-nonce6026af9abf301a9ff0bc79b0765fda1f381432ae2a29c3ec304a93cdafe64035
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTQ4OjFGMTQ6MUE1MDk3NjoyM0JGQjlGOjZBNTA0OTk3IiwidmlzaXRvcl9pZCI6IjQ3NzQzNDQ4NzEzMjEyOTExNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac767409e042388ce41ed2d1022db490efcb115cfc17639ef82675bfb043577ce0
hovercard-subject-tagpull_request:128485464
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/14024
twitter:imagehttps://opengraph.githubassets.com/6a5f8a926a87821d7d68c30c0a49464973c500e78a6ff1313fbd5402fe0f5fb1/nodejs/node/pull/14024
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a5f8a926a87821d7d68c30c0a49464973c500e78a6ff1313fbd5402fe0f5fb1/nodejs/node/pull/14024
og:image:altWhen an OutgoingMessage is closed (for example, using the end method), its 'writable' property should be changed to false - since it is not writable anymore. The 'writable' property...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKasher
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/14024#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14024
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14024
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/14024
Reloadhttps://github.com/nodejs/node/pull/14024
Reloadhttps://github.com/nodejs/node/pull/14024
Please reload this pagehttps://github.com/nodejs/node/pull/14024
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/14024
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Kasherhttps://github.com/Kasher
nodejs:masterhttps://github.com/nodejs/node/tree/master
Kasher:http_outgoing_mark_as_not_writable_upon_closehttps://github.com/Kasher/node/tree/http_outgoing_mark_as_not_writable_upon_close
Conversationhttps://github.com/nodejs/node/pull/14024
Commits4 (4)https://github.com/nodejs/node/pull/14024/commits
Checkshttps://github.com/nodejs/node/pull/14024/checks
Files changedhttps://github.com/nodejs/node/pull/14024/files
http: OutgoingMessage change writable after endhttps://github.com/nodejs/node/pull/14024#top
Kasherhttps://github.com/Kasher
nodejs:masterhttps://github.com/nodejs/node/tree/master
Kasher:http_outgoing_mark_as_not_writable_upon_closehttps://github.com/Kasher/node/tree/http_outgoing_mark_as_not_writable_upon_close
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 1, 2017https://github.com/nodejs/node/pull/14024#issue-239943418
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
#14023https://github.com/nodejs/node/issues/14023
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jul 1, 2017https://github.com/nodejs/node/pull/14024#event-1146927928
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 1, 2017 https://github.com/nodejs/node/pull/14024#ref-issue-239943395
Write after end when piping a ClientRequest to ServerResponse #14023 https://github.com/nodejs/node/issues/14023
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jul 2, 2017https://github.com/nodejs/node/pull/14024#issuecomment-312499484
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 2, 2017https://github.com/nodejs/node/pull/14024#issuecomment-312502889
@gireeshpunathilhttps://github.com/gireeshpunathil
#14023https://github.com/nodejs/node/issues/14023
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jul 3, 2017https://github.com/nodejs/node/pull/14024#issuecomment-312548631
@Kasherhttps://github.com/Kasher
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
force-pushedhttps://github.com/nodejs/node/compare/641175fe332ff8131e4c8c7380c360170b91a77f..554d98742491f4edf65f4bce23dc0fcf0a8522f1
641175fhttps://github.com/nodejs/node/commit/641175fe332ff8131e4c8c7380c360170b91a77f
554d987https://github.com/nodejs/node/commit/554d98742491f4edf65f4bce23dc0fcf0a8522f1
Compare https://github.com/nodejs/node/compare/641175fe332ff8131e4c8c7380c360170b91a77f..554d98742491f4edf65f4bce23dc0fcf0a8522f1
July 7, 2017 12:38https://github.com/nodejs/node/pull/14024#event-1154399464
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 7, 2017https://github.com/nodejs/node/pull/14024#issuecomment-313670336
@gireeshpunathilhttps://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/14024/files#diff-f48f06a77b4005be724d14b42ab7f87dhttps://github.com/nodejs/node/pull/14024/files#diff-f48f06a77b4005be724d14b42ab7f87d
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
force-pushedhttps://github.com/nodejs/node/compare/554d98742491f4edf65f4bce23dc0fcf0a8522f1..28b4f4d3b41d53cd5d244c3d31852cfcd0be6b7e
554d987https://github.com/nodejs/node/commit/554d98742491f4edf65f4bce23dc0fcf0a8522f1
28b4f4dhttps://github.com/nodejs/node/commit/28b4f4d3b41d53cd5d244c3d31852cfcd0be6b7e
Compare https://github.com/nodejs/node/compare/554d98742491f4edf65f4bce23dc0fcf0a8522f1..28b4f4d3b41d53cd5d244c3d31852cfcd0be6b7e
July 7, 2017 12:53https://github.com/nodejs/node/pull/14024#event-1154418786
https://github.com/Kasher
http: OutgoingMessage change writable after endhttps://github.com/nodejs/node/pull/14024/commits/20b6326928eedab1ea10c947b8261a05ea130ec8
20b6326https://github.com/nodejs/node/pull/14024/commits/20b6326928eedab1ea10c947b8261a05ea130ec8
https://github.com/Kasher
Kasherhttps://github.com/Kasher
force-pushedhttps://github.com/nodejs/node/compare/28b4f4d3b41d53cd5d244c3d31852cfcd0be6b7e..20b6326928eedab1ea10c947b8261a05ea130ec8
28b4f4dhttps://github.com/nodejs/node/commit/28b4f4d3b41d53cd5d244c3d31852cfcd0be6b7e
20b6326https://github.com/nodejs/node/commit/20b6326928eedab1ea10c947b8261a05ea130ec8
Compare https://github.com/nodejs/node/compare/28b4f4d3b41d53cd5d244c3d31852cfcd0be6b7e..20b6326928eedab1ea10c947b8261a05ea130ec8
July 7, 2017 12:59https://github.com/nodejs/node/pull/14024#event-1154428448
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jul 7, 2017https://github.com/nodejs/node/pull/14024#issuecomment-313681761
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jul 7, 2017 https://github.com/nodejs/node/pull/14024#pullrequestreview-48606353
View reviewed changes https://github.com/nodejs/node/pull/14024/files/20b6326928eedab1ea10c947b8261a05ea130ec8
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 8, 2017https://github.com/nodejs/node/pull/14024#issuecomment-313867925
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jul 9, 2017https://github.com/nodejs/node/pull/14024#issuecomment-313892856
@Kasherhttps://github.com/Kasher
https://ci.nodejs.org/job/node-test-pull-request/9049/https://ci.nodejs.org/job/node-test-pull-request/9049/
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 10, 2017 https://github.com/nodejs/node/pull/14024#pullrequestreview-48821475
View reviewed changes https://github.com/nodejs/node/pull/14024/files/20b6326928eedab1ea10c947b8261a05ea130ec8
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/14024#pullrequestreview-48821475
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
test/parallel/test-http-outgoing-finish-writable.jshttps://github.com/nodejs/node/pull/14024/files/20b6326928eedab1ea10c947b8261a05ea130ec8#diff-d87a6135b2f8c71aef507784b92aedf63542544dbeee12dc4d0956588bf57182
mcollinahttps://github.com/mcollina
Jul 10, 2017https://github.com/nodejs/node/pull/14024#discussion_r126347577
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
test/parallel/test-pipe-outgoing-message-data-emitted-after-ended.jshttps://github.com/nodejs/node/pull/14024/files/20b6326928eedab1ea10c947b8261a05ea130ec8#diff-3729244fe57cb9f2893cf9ce6342bd51b44fb3a11e4873a28dc4c4ad5e005dbe
mcollinahttps://github.com/mcollina
Jul 10, 2017https://github.com/nodejs/node/pull/14024#discussion_r126347791
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
Kasherhttps://github.com/Kasher
Jul 10, 2017https://github.com/nodejs/node/pull/14024#discussion_r126397076
Please reload this pagehttps://github.com/nodejs/node/pull/14024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
test/parallel/test-pipe-outgoing-message-data-emitted-after-ended.jshttps://github.com/nodejs/node/pull/14024/files/20b6326928eedab1ea10c947b8261a05ea130ec8#diff-3729244fe57cb9f2893cf9ce6342bd51b44fb3a11e4873a28dc4c4ad5e005dbe
mcollinahttps://github.com/mcollina
Jul 10, 2017https://github.com/nodejs/node/pull/14024#discussion_r126349686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
Kasherhttps://github.com/Kasher
Jul 10, 2017https://github.com/nodejs/node/pull/14024#discussion_r126398064
Please reload this pagehttps://github.com/nodejs/node/pull/14024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/request/request/blob/master/request.js#L1489https://github.com/request/request/blob/master/request.js#L1489
https://github.com/request/request/blob/master/request.js#L1082https://github.com/request/request/blob/master/request.js#L1082
#14024 (comment)https://github.com/nodejs/node/pull/14024#issuecomment-314087874
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314087874
Please reload this pagehttps://github.com/nodejs/node/pull/14024
@mcollinahttps://github.com/mcollina
https://github.com/request/request/blob/master/request.js#L131https://github.com/request/request/blob/master/request.js#L131
https://github.com/request/request/blob/master/request.js#L1489https://github.com/request/request/blob/master/request.js#L1489
https://github.com/request/request/blob/master/request.js#L748https://github.com/request/request/blob/master/request.js#L748
https://github.com/request/request/blob/master/request.js#L772https://github.com/request/request/blob/master/request.js#L772
https://github.com/request/request/blob/master/request.js#L1082https://github.com/request/request/blob/master/request.js#L1082
https://github.com/nodejs/node/blob/master/lib/internal/streams/legacy.js#L15https://github.com/nodejs/node/blob/master/lib/internal/streams/legacy.js#L15
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314099032
@Kasherhttps://github.com/Kasher
https://github.com/request/request/blob/master/request.js#L118https://github.com/request/request/blob/master/request.js#L118
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314129422
@mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/blob/master/lib/_http_server.js#L122https://github.com/nodejs/node/blob/master/lib/_http_server.js#L122
https://github.com/nodejs/node/blob/master/lib/internal/streams/legacy.js#L15https://github.com/nodejs/node/blob/master/lib/internal/streams/legacy.js#L15
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314144698
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314175066
Please reload this pagehttps://github.com/nodejs/node/pull/14024
@mcollinahttps://github.com/mcollina
which calls to Stream.prototype.pipe:https://github.com/request/request/blob/master/request.js#L1489
https://camo.githubusercontent.com/067618774bec14cb9e9946dab961840adece48408a4c7c6f1e275e8a8a85cd18/687474703a2f2f692e696d6775722e636f6d2f58697730746d632e706e67
https://github.com/nodejs/node/blob/master/lib/internal/streams/legacy.js#L15https://github.com/nodejs/node/blob/master/lib/internal/streams/legacy.js#L15
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314177606
@Kasherhttps://github.com/Kasher
https://github.com/nodejs/node/pull/14024/files#diff-f48f06a77b4005be724d14b42ab7f87dR9https://github.com/nodejs/node/pull/14024/files#diff-f48f06a77b4005be724d14b42ab7f87dR9
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314209482
Please reload this pagehttps://github.com/nodejs/node/pull/14024
@mcollinahttps://github.com/mcollina
#14023https://github.com/nodejs/node/issues/14023
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 10, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314212423
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Review fixes.https://github.com/nodejs/node/pull/14024/commits/17365ea11c310f29fad743e73d40a1f15b1f5a32
17365eahttps://github.com/nodejs/node/pull/14024/commits/17365ea11c310f29fad743e73d40a1f15b1f5a32
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 11, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314481626
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 11, 2017 https://github.com/nodejs/node/pull/14024#pullrequestreview-49236208
View reviewed changes https://github.com/nodejs/node/pull/14024/files/17365ea11c310f29fad743e73d40a1f15b1f5a32
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/14024#pullrequestreview-49236208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
test/parallel/test-http-outgoing-finish-writable.jshttps://github.com/nodejs/node/pull/14024/files/17365ea11c310f29fad743e73d40a1f15b1f5a32#diff-d87a6135b2f8c71aef507784b92aedf63542544dbeee12dc4d0956588bf57182
mcollinahttps://github.com/mcollina
Jul 11, 2017https://github.com/nodejs/node/pull/14024#discussion_r126725247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
test/parallel/test-http-outgoing-finish-writable.jshttps://github.com/nodejs/node/pull/14024/files/17365ea11c310f29fad743e73d40a1f15b1f5a32#diff-d87a6135b2f8c71aef507784b92aedf63542544dbeee12dc4d0956588bf57182
mcollinahttps://github.com/mcollina
Jul 11, 2017https://github.com/nodejs/node/pull/14024#discussion_r126725565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
test/parallel/test-pipe-outgoing-message-data-emitted-after-ended.jshttps://github.com/nodejs/node/pull/14024/files/17365ea11c310f29fad743e73d40a1f15b1f5a32#diff-3729244fe57cb9f2893cf9ce6342bd51b44fb3a11e4873a28dc4c4ad5e005dbe
mcollinahttps://github.com/mcollina
Jul 11, 2017https://github.com/nodejs/node/pull/14024#discussion_r126732119
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
test/parallel/test-pipe-outgoing-message-data-emitted-after-ended.jshttps://github.com/nodejs/node/pull/14024/files/17365ea11c310f29fad743e73d40a1f15b1f5a32#diff-3729244fe57cb9f2893cf9ce6342bd51b44fb3a11e4873a28dc4c4ad5e005dbe
mcollinahttps://github.com/mcollina
Jul 11, 2017https://github.com/nodejs/node/pull/14024#discussion_r126732296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Review fixes 2.0.https://github.com/nodejs/node/pull/14024/commits/fd89a7e5707574553af9c75492a6ebb7b91b9293
fd89a7ehttps://github.com/nodejs/node/pull/14024/commits/fd89a7e5707574553af9c75492a6ebb7b91b9293
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 11, 2017https://github.com/nodejs/node/pull/14024#issuecomment-314512221
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 12, 2017 https://github.com/nodejs/node/pull/14024#pullrequestreview-49413433
View reviewed changes https://github.com/nodejs/node/pull/14024/files/fd89a7e5707574553af9c75492a6ebb7b91b9293
test/parallel/test-pipe-outgoing-message-data-emitted-after-ended.jshttps://github.com/nodejs/node/pull/14024/files/fd89a7e5707574553af9c75492a6ebb7b91b9293#diff-3729244fe57cb9f2893cf9ce6342bd51b44fb3a11e4873a28dc4c4ad5e005dbe
mcollinahttps://github.com/mcollina
Jul 12, 2017https://github.com/nodejs/node/pull/14024#discussion_r126886835
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 30, 2017https://github.com/nodejs/node/pull/14024#issuecomment-318894243
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
Kasherhttps://github.com/Kasher
Jul 30, 2017https://github.com/nodejs/node/pull/14024#issuecomment-318896496
@mcollinahttps://github.com/mcollina
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Aug 16, 2017https://github.com/nodejs/node/pull/14024#issuecomment-322688739
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/14024
MylesBorinshttps://github.com/MylesBorins
Aug 16, 2017 https://github.com/nodejs/node/pull/14024#ref-commit-0230a35
https://github.com/Kasher
https://github.com/MylesBorins
http: OutgoingMessage change writable after endhttps://github.com/nodejs/node/commit/0230a35475cee09907787302d3be78a6f89f82f5
0230a35https://github.com/nodejs/node/commit/0230a35475cee09907787302d3be78a6f89f82f5
#14024https://github.com/nodejs/node/pull/14024
#14023https://github.com/nodejs/node/issues/14023
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Aug 16, 2017https://github.com/nodejs/node/pull/14024#event-1207735615
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 16, 2017https://github.com/nodejs/node/pull/14024#issuecomment-322689902
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Aug 16, 2017 https://github.com/nodejs/node/pull/14024#ref-pullrequest-250555136
v6.11.3-proposal #14852 https://github.com/nodejs/node/pull/14852
MylesBorinshttps://github.com/MylesBorins
Aug 16, 2017 https://github.com/nodejs/node/pull/14024#ref-commit-5303db7
https://github.com/Kasher
https://github.com/MylesBorins
http: OutgoingMessage change writable after endhttps://github.com/nodejs/node/commit/5303db79470084bdac196f1d824d721fd05d54b0
5303db7https://github.com/nodejs/node/commit/5303db79470084bdac196f1d824d721fd05d54b0
#14024https://github.com/nodejs/node/pull/14024
#14023https://github.com/nodejs/node/issues/14023
https://github.com/SimenB
SimenBhttps://github.com/SimenB
Aug 25, 2017 https://github.com/nodejs/node/pull/14024#ref-issue-252868575
Possible bug in streams between node 8.1.4 and 8.2.0 #15029 https://github.com/nodejs/node/issues/15029
https://github.com/trygve-lie
trygve-liehttps://github.com/trygve-lie
Aug 30, 2017 https://github.com/nodejs/node/pull/14024#ref-issue-253904883
"premature close" error not thrown in node 8.2.0 or newer mafintosh/end-of-stream#14 https://github.com/mafintosh/end-of-stream/issues/14
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2017 https://github.com/nodejs/node/pull/14024#ref-pullrequest-257651710
http: revert #14024 writable is never set to false #15404 https://github.com/nodejs/node/pull/15404
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 14, 2017https://github.com/nodejs/node/pull/14024#issuecomment-329425892
#15404https://github.com/nodejs/node/pull/15404
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Sep 14, 2017https://github.com/nodejs/node/pull/14024#event-1248828421
mcollinahttps://github.com/mcollina
Sep 20, 2017 https://github.com/nodejs/node/pull/14024#ref-commit-cccf934
https://github.com/mcollina
http: reverthttps://github.com/mcollina/node/commit/cccf9348ab7051f6babe89ee38e3076c84782810
nodejs#14024https://github.com/nodejs/node/pull/14024
writable is never set to falsehttps://github.com/mcollina/node/commit/cccf9348ab7051f6babe89ee38e3076c84782810
cccf934https://github.com/mcollina/node/commit/cccf9348ab7051f6babe89ee38e3076c84782810
nodejs#14024https://github.com/nodejs/node/pull/14024
nodejs#15029https://github.com/nodejs/node/issues/15029
mcollinahttps://github.com/mcollina
Sep 20, 2017 https://github.com/nodejs/node/pull/14024#ref-commit-8589c70
https://github.com/mcollina
http: reverthttps://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696
#14024https://github.com/nodejs/node/pull/14024
writable is never set to falsehttps://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696
8589c70https://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696
#14024https://github.com/nodejs/node/pull/14024
#15029https://github.com/nodejs/node/issues/15029
#15404https://github.com/nodejs/node/pull/15404
jasnellhttps://github.com/jasnell
Sep 20, 2017 https://github.com/nodejs/node/pull/14024#ref-commit-771c2ac
https://github.com/mcollina
https://github.com/jasnell
http: reverthttps://github.com/nodejs/node/commit/771c2ac7c295a773445d86e1dcd6d2722aff2137
#14024https://github.com/nodejs/node/pull/14024
writable is never set to falsehttps://github.com/nodejs/node/commit/771c2ac7c295a773445d86e1dcd6d2722aff2137
771c2achttps://github.com/nodejs/node/commit/771c2ac7c295a773445d86e1dcd6d2722aff2137
#14024https://github.com/nodejs/node/pull/14024
#15029https://github.com/nodejs/node/issues/15029
#15404https://github.com/nodejs/node/pull/15404
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 20, 2017 https://github.com/nodejs/node/pull/14024#ref-pullrequest-259314305
Node.js 8.6.0 Release Proposal #15509 https://github.com/nodejs/node/pull/15509
Qardhttps://github.com/Qard
Sep 21, 2017 https://github.com/nodejs/node/pull/14024#ref-commit-d272433
https://github.com/mcollina
http: revert #14024 writable is never set to falsehttps://github.com/Qard/ayo/commit/d272433f6ad758e1a73b65646bb70526018ddd98
d272433https://github.com/Qard/ayo/commit/d272433f6ad758e1a73b65646bb70526018ddd98
nodejs/node#14024https://github.com/nodejs/node/pull/14024
nodejs/node#15029https://github.com/nodejs/node/issues/15029
nodejs/node#15404https://github.com/nodejs/node/pull/15404
Qardhttps://github.com/Qard
Sep 21, 2017 https://github.com/nodejs/node/pull/14024#ref-commit-4638c68
https://github.com/mcollina
http: revert #14024 writable is never set to falsehttps://github.com/Qard/ayo/commit/4638c6873afea2e21f69c94cab8bcdd65d45e921
4638c68https://github.com/Qard/ayo/commit/4638c6873afea2e21f69c94cab8bcdd65d45e921
nodejs/node#14024https://github.com/nodejs/node/pull/14024
nodejs/node#15029https://github.com/nodejs/node/issues/15029
nodejs/node#15404https://github.com/nodejs/node/pull/15404
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 16, 2017https://github.com/nodejs/node/pull/14024#issuecomment-337055981
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 16, 2017https://github.com/nodejs/node/pull/14024#issuecomment-337057004
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/missbruni
missbrunihttps://github.com/missbruni
Apr 24, 2018https://github.com/nodejs/node/pull/14024#issuecomment-383968824
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 16, 2019 https://github.com/nodejs/node/pull/14024#ref-pullrequest-468473536
http: writable set to false #28715 https://github.com/nodejs/node/pull/28715
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F14024
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/14024/files/fd89a7e5707574553af9c75492a6ebb7b91b9293
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/14024/files/64d17bec19db2dc5c89cf231fdae042f50bacafc
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/14024/files/20b6326928eedab1ea10c947b8261a05ea130ec8
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/14024
https://github.com/Kasher
https://github.com/gireeshpunathil
https://github.com/mcollina
https://github.com/TimothyGu
https://github.com/MylesBorins
https://github.com/missbruni
https://github.com/jasnell
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.